Bug#773713: broadcom-sta: Please support kernel 3.18

2015-04-15 Thread Tony Houghton
Package: broadcom-sta-dkms
Version: 6.30.223.248-4
Followup-For: Bug #773713

Dear Maintainer,

*** Reporter, please consider answering these questions, where appropriate ***

   * What led up to the situation?
   * What exactly did you do (or not do) that was effective (or
 ineffective)?
   * What was the outcome of this action?
   * What outcome did you expect instead?

*** End of the template - remove these template lines ***

Content-Type: text/plain; charset=us-ascii
MIME-Version: 1.0
Content-Transfer-Encoding: 7bit
From: Tony Houghton h...@realh.co.uk
To: Debian Bug Tracking System 773...@bugs.debian.org
Subject: Re: broadcom-sta: Please support kernel 3.18
Bcc: Tony Houghton h...@realh.co.uk
Message-ID: 20150415141153.1889.39110.reportbug@jeanette.centauri
X-Mailer: reportbug 6.6.3
Date: Wed, 15 Apr 2015 15:11:53 +0100

Package: broadcom-sta-dkms
Version: 6.30.223.248-3
Followup-For: Bug #773713

This package seems to work fine with 3.19-trunk from experimental when
pacthed appropriately. I used patches from Ubuntu and Arch:

https://github.com/longsleep/bcmwl-ubuntu/blob/master/debian/patches/0015-add-support-for-Linux-3.18.patch
https://gist.github.com/hobarrera/ac0e6225210ac5bb13f6#file-broadcom-sta-6-30-223-248-linux-3-18-null-pointer-crash-patch

I had to change the paths to add amd64/ before src/, I guess you'll have
to make copies to do the same for i386 in the official package.

-- System Information:
Debian Release: 8.0
  APT prefers testing
  APT policy: (990, 'testing'), (500, 'testing-updates'), (500, 'unstable'), 
(1, 'experimental')
Architecture: amd64 (x86_64)

Kernel: Linux 3.19.0-trunk-amd64 (SMP w/4 CPU cores)
Locale: LANG=en_GB.UTF-8, LC_CTYPE=en_GB.UTF-8 (charmap=UTF-8)
Shell: /bin/sh linked to /bin/dash
Init: systemd (via /run/systemd/system)

Versions of packages broadcom-sta-dkms depends on:
ii  dkms  2.2.0.3-2

Versions of packages broadcom-sta-dkms recommends:
ii  wireless-tools  30~pre9-8

broadcom-sta-dkms suggests no packages.

-- no debconf information

-- System Information:
Debian Release: 8.0
  APT prefers testing
  APT policy: (990, 'testing'), (500, 'testing-updates'), (500, 'unstable'), 
(1, 'experimental')
Architecture: amd64 (x86_64)

Kernel: Linux 3.19.0-trunk-amd64 (SMP w/4 CPU cores)
Locale: LANG=en_GB.UTF-8, LC_CTYPE=en_GB.UTF-8 (charmap=UTF-8)
Shell: /bin/sh linked to /bin/dash
Init: systemd (via /run/systemd/system)

Versions of packages broadcom-sta-dkms depends on:
ii  dkms  2.2.0.3-2

Versions of packages broadcom-sta-dkms recommends:
ii  wireless-tools  30~pre9-8

broadcom-sta-dkms suggests no packages.

-- no debconf information


-- 
To UNSUBSCRIBE, email to debian-bugs-dist-requ...@lists.debian.org
with a subject of unsubscribe. Trouble? Contact listmas...@lists.debian.org



Bug#773713: broadcom-sta: Please support kernel 3.18

2015-02-01 Thread Bruno Bierbaumer
Source: broadcom-sta
Followup-For: Bug #773713

Attach the mentioned patch.

-- System Information:
Debian Release: 8.0
  APT prefers testing-updates
  APT policy: (500, 'testing-updates'), (500, 'testing'), (102, 'experimental')
Architecture: amd64 (x86_64)
Foreign Architectures: i386

Kernel: Linux 3.19.0-rc6 (SMP w/8 CPU cores)
Locale: LANG=en_US.UTF-8, LC_CTYPE=en_US.UTF-8 (charmap=UTF-8)
Shell: /bin/sh linked to /bin/dash
Init: systemd (via /run/systemd/system)
diff -urN a/src/wl/sys/wl_linux.c b/src/wl/sys/wl_linux.c
--- a/src/wl/sys/wl_linux.c	2015-01-06 12:33:42.981659618 +0100
+++ b/src/wl/sys/wl_linux.c	2015-01-06 12:34:05.647395418 +0100
@@ -2157,8 +2157,8 @@
 	wlif = WL_DEV_IF(dev);
 	wl = WL_INFO(dev);
 
+	skb-prev = NULL;
 	if (WL_ALL_PASSIVE_ENAB(wl) || (WL_RTR()  WL_CONFIG_SMP())) {
-		skb-prev = NULL;
 
 		TXQ_LOCK(wl);


Bug#773713: broadcom-sta: Please support kernel 3.18

2015-02-01 Thread Bruno Bierbaumer
Source: broadcom-sta
Followup-For: Bug #773713

Hello Cyril, Hello Eduard
I am also interested in Kernel 3.18+ support for broadcom-sta, but there seems
to be panic/lockup issue with newer Kernel versions.
There are freezes when going to suspend while downloading something or when
disconnecting the WiFi during a a file transfer.

The Gentoo bug tracker (https://bugs.gentoo.org/show_bug.cgi?id=523326#c24)
offers a fix for these freezes which is working for me. See attachment.

Regards,
Bruno


-- 
To UNSUBSCRIBE, email to debian-bugs-dist-requ...@lists.debian.org
with a subject of unsubscribe. Trouble? Contact listmas...@lists.debian.org



Bug#773713: broadcom-sta: Please support kernel 3.18

2014-12-22 Thread Eduard Bloch
Source: broadcom-sta
Version: 6.30.223.248-3
Severity: wishlist
Tags: patch

Hello Cyril,

I added the Gentoo patch for kernel 3.18 and fixed m-a support. I also
added versions to Breaks/Replaces because that didn't make sense IMHO,
the current versions can coexist. See attachment.

Regards,
Eduard.

-- System Information:
Debian Release: 8.0
  APT prefers unstable
  APT policy: (500, 'unstable'), (500, 'testing'), (500, 'stable'), (1, 
'experimental')
Architecture: amd64 (x86_64)
Foreign Architectures: i386

Kernel: Linux 3.18.1+ (SMP w/2 CPU cores; PREEMPT)
Locale: LANG=en_US.UTF-8, LC_CTYPE=en_US.UTF-8 (charmap=UTF-8)
Shell: /bin/sh linked to /bin/dash
Init: sysvinit (via /sbin/init)
diff -Nurd broadcom-sta-6.30.223.248_debian/debian/changelog broadcom-sta-6.30.223.248/debian/changelog
--- broadcom-sta-6.30.223.248_debian/debian/changelog	2014-12-07 15:07:56.0 +0100
+++ broadcom-sta-6.30.223.248/debian/changelog	2014-12-22 15:08:37.914183038 +0100
@@ -1,3 +1,13 @@
+broadcom-sta (6.30.223.248-3.1) experimental; urgency=low
+
+  * Non-maintainer upload.
+  * Added patch for kernel 3.18 support (from Gentoo, with little
+modifications)
+  * Set some variables right for kernel-package/module-assistant usage, 
+to build correctly against headers without instaling the kernel first
+
+ -- Eduard Bloch ed@idefix  Mon, 22 Dec 2014 14:59:25 +0100
+
 broadcom-sta (6.30.223.248-3) unstable; urgency=medium
 
   * Synced supported chipsets list with README.txt file (Closes: #762954).
diff -Nurd broadcom-sta-6.30.223.248_debian/debian/control broadcom-sta-6.30.223.248/debian/control
--- broadcom-sta-6.30.223.248_debian/debian/control	2014-10-28 08:15:47.0 +0100
+++ broadcom-sta-6.30.223.248/debian/control	2014-12-22 15:34:42.480182036 +0100
@@ -22,8 +22,8 @@
 Architecture: all
 Depends: ${misc:Depends}
 Recommends: wireless-tools
-Breaks: broadcom-sta-common, broadcom-sta-modules ( 5.100.82.112-6~), broadcom-sta-source
-Replaces: broadcom-sta-common, broadcom-sta-modules ( 5.100.82.112-6~), broadcom-sta-source
+Breaks: broadcom-sta-common ( 6.30.223.248-1), broadcom-sta-modules ( 5.100.82.112-6~), broadcom-sta-source ( 6.30.223.248-1)
+Replaces: broadcom-sta-common ( 6.30.223.248-1), broadcom-sta-modules ( 5.100.82.112-6~), broadcom-sta-source ( 6.30.223.248-1)
 Provides: broadcom-sta-modules
 Description: dkms source for the Broadcom STA Wireless driver
  Broadcom STA is a binary-only device driver to support the following IEEE
diff -Nurd broadcom-sta-6.30.223.248_debian/debian/patches/10-broadcom-sta-6.30.223.248-linux-3.18.patch broadcom-sta-6.30.223.248/debian/patches/10-broadcom-sta-6.30.223.248-linux-3.18.patch
--- broadcom-sta-6.30.223.248_debian/debian/patches/10-broadcom-sta-6.30.223.248-linux-3.18.patch	1970-01-01 01:00:00.0 +0100
+++ broadcom-sta-6.30.223.248/debian/patches/10-broadcom-sta-6.30.223.248-linux-3.18.patch	2014-12-22 15:06:58.698183381 +0100
@@ -0,0 +1,30 @@
+From 5aae9ccfda6dfc680403b4a5ff9a36dcd5331dfd Mon Sep 17 00:00:00 2001
+From: Michael Marineau m...@marineau.org
+Date: Tue, 11 Nov 2014 15:17:46 -0800
+Subject: [PATCH] linux 3.18
+
+http://git.kernel.org/cgit/linux/kernel/git/torvalds/linux.git/commit/?id=5bc8c1f2b070bab82ed738f98ecfac725e33c57f
+---
+ src/wl/sys/wl_cfg80211_hybrid.c | 6 +-
+ 1 file changed, 5 insertions(+), 1 deletion(-)
+
+diff --git a/src/wl/sys/wl_cfg80211_hybrid.c b/src/wl/sys/wl_cfg80211_hybrid.c
+index 514a892..e3ebef2 100644
+--- a/amd64/src/wl/sys/wl_cfg80211_hybrid.c
 b/amd64/src/wl/sys/wl_cfg80211_hybrid.c
+@@ -2010,7 +2010,11 @@ static s32 wl_inform_single_bss(struct wl_cfg80211_priv *wl, struct wl_bss_info
+ 
+ 	notify_ie = (u8 *)bi + le16_to_cpu(bi-ie_offset);
+ 	notify_ielen = le32_to_cpu(bi-ie_length);
+-	cbss = cfg80211_inform_bss(wiphy, channel, (const u8 *)(bi-BSSID.octet),
++	cbss = cfg80211_inform_bss(wiphy, channel,
++#if LINUX_VERSION_CODE = KERNEL_VERSION(3, 18, 0)
++		CFG80211_BSS_FTYPE_UNKNOWN,
++#endif
++		(const u8 *)(bi-BSSID.octet),
+ 		0, beacon_proberesp-capab_info, beacon_proberesp-beacon_int,
+ 		(const u8 *)notify_ie, notify_ielen, signal, GFP_KERNEL);
+ 
+-- 
+2.0.4
+
diff -Nurd broadcom-sta-6.30.223.248_debian/debian/patches/series broadcom-sta-6.30.223.248/debian/patches/series
--- broadcom-sta-6.30.223.248_debian/debian/patches/series	2014-12-07 14:18:59.0 +0100
+++ broadcom-sta-6.30.223.248/debian/patches/series	2014-12-22 15:00:40.434184690 +0100
@@ -8,3 +8,5 @@
 07-fix_procfs_handling.patch
 08-enable_error_traces.patch
 09-fix_system_hang_when_deleting_monitor.patch
+10-broadcom-sta-6.30.223.248-linux-3.18.patch
+
diff -Nurd broadcom-sta-6.30.223.248_debian/debian/rules.modules broadcom-sta-6.30.223.248/debian/rules.modules
--- broadcom-sta-6.30.223.248_debian/debian/rules.modules	2014-10-20 17:50:25.0 +0200
+++ broadcom-sta-6.30.223.248/debian/rules.modules	2014-12-22 15:16:26.274181417 +0100
@@ -8,7 +8,7 @@
 
 kdist_clean: prep-deb-files
 	dh_clean
-	$(MAKE) clean