Bug#798359: lintian: list of autopkgtest restrictions is not up-to-date

2015-09-08 Thread Jérémy Bobbio
Package: lintian
Version: 2.5.36.1

Hi!

It seems that the list of known restrictions for debian/tests/control is
not up-to-date.

Several packages raise unknown-runtime-tests-restriction [1] despite
using restrictions properly listed in the reference documentation [2].

 [1]: https://lintian.debian.org/tags/unknown-runtime-tests-restriction.html
 [2]: 
https://anonscm.debian.org/gitweb/?p=autopkgtest/autopkgtest.git;a=blob_plain;f=doc/README.package-tests.rst;hb=HEAD

Thanks!
-- 
Lunar.''`. 
lu...@debian.org: :Ⓐ  :  # apt-get install anarchism
`. `'` 
  `-   


signature.asc
Description: Digital signature


Bug#798359: lintian: list of autopkgtest restrictions is not up-to-date

2015-09-08 Thread Jakub Wilk

* Axel Beckert , 2015-09-08, 20:33:

P: cedar-backup2 source: unknown-runtime-tests-restriction allow-stderr, 
paragraph starting at line 18

But allow-stderr is in all Restrictions, not only in the one in line 
18. So it seems the comma after "allow-stderr" which seems to confuse 
lintian (as it also emits the comma in the warning).


Sounds similar to #792418.

--
Jakub Wilk



Bug#798359: lintian: list of autopkgtest restrictions is not up-to-date

2015-09-08 Thread Axel Beckert
Control: unmerge -1
Control: tag -1 + pending

Hi again,

Axel Beckert wrote:
> > >P: cedar-backup2 source: unknown-runtime-tests-restriction allow-stderr, 
> > >paragraph starting at line 18
> > >
> > >But allow-stderr is in all Restrictions, not only in the one in
> > >line 18. So it seems the comma after "allow-stderr" which seems to
> > >confuse lintian (as it also emits the comma in the warning).
> > 
> > Sounds similar to #792418.
> 
> Thanks! It actually is the same issue.

Actually not. They're about the same issue but with different tags.

> And in #792418 the questions I wanted to ask the autopkgtest
> maintainers are already answered. So I can now implement a proper
> solution.

That still stands -- for both bug reports. This one (#798359) is fixed
in git now. I'll now look for a fix for #792418, too.

Regards, Axel
-- 
 ,''`.  |  Axel Beckert , http://people.debian.org/~abe/
: :' :  |  Debian Developer, ftp.ch.debian.org Admin
`. `'   |  4096R: 2517 B724 C5F6 CA99 5329  6E61 2FF9 CD59 6126 16B5
  `-|  1024D: F067 EA27 26B9 C3FC 1486  202E C09E 1D89 9593 0EDE



Bug#798359: lintian: list of autopkgtest restrictions is not up-to-date

2015-09-08 Thread Axel Beckert
Control: retitle -1 lintian: unknown-runtime-tests-restriction reports 
comma-delimited known restrictions

Hi again,

Axel Beckert wrote:
> Jérémy Bobbio wrote:
> > It seems that the list of known restrictions for debian/tests/control is
> > not up-to-date.
> > 
> > Several packages raise unknown-runtime-tests-restriction [1] despite
> > using restrictions properly listed in the reference documentation [2].
> > 
> >  [1]: https://lintian.debian.org/tags/unknown-runtime-tests-restriction.html
> >  [2]: 
> > https://anonscm.debian.org/gitweb/?p=autopkgtest/autopkgtest.git;a=blob_plain;f=doc/README.package-tests.rst;hb=HEAD
> 
> Hrm. I just compared the source code with [2]. The source code is
> uptodate. There is probably a bug somewhere else in the logic.

I've taken the following example:

→ cat -n cedar-backup2-2.26.4/debian/tests/control
 1  # Run the unit tests on the library code
 2  Tests: unittest
 3  Restrictions: allow-stderr
 4
 5  # Run some basic tests on command-line functionality for cback
 6  Tests: cback-version cback-help cback-diagnostics
 7  Restrictions: allow-stderr
 8
 9  # Run some basic tests on command-line functionality for cback-span
10  Tests: cback-span-version cback-span-help cback-span-diagnostics
11  Restrictions: allow-stderr
12
13  # Run some basic tests on command-line functionality for 
cback-amazons3-sync
14  Tests: cback-amazons3-sync-version cback-amazons3-sync-help 
cback-amazons3-sync-diagnostics
15  Restrictions: allow-stderr
16
17  # Run a simple backup and make sure it succeeds
18  Tests: simplebackup
19  Depends: @, awk, diffutils, tar
20  Restrictions: allow-stderr, needs-root
21

Lintian reports:

P: cedar-backup2 source: unknown-runtime-tests-restriction allow-stderr, 
paragraph starting at line 18

But allow-stderr is in all Restrictions, not only in the one in line
18. So it seems the comma after "allow-stderr" which seems to confuse
lintian (as it also emits the comma in the warning).

Will try to find a fix.

Thanks for the report!

Regards, Axel
-- 
 ,''`.  |  Axel Beckert , http://people.debian.org/~abe/
: :' :  |  Debian Developer, ftp.ch.debian.org Admin
`. `'   |  4096R: 2517 B724 C5F6 CA99 5329  6E61 2FF9 CD59 6126 16B5
  `-|  1024D: F067 EA27 26B9 C3FC 1486  202E C09E 1D89 9593 0EDE



Bug#798359: lintian: list of autopkgtest restrictions is not up-to-date

2015-09-08 Thread Axel Beckert
Control: merge -1 792418

Hi Jakub,

Jakub Wilk wrote:
> * Axel Beckert , 2015-09-08, 20:33:
> >P: cedar-backup2 source: unknown-runtime-tests-restriction allow-stderr, 
> >paragraph starting at line 18
> >
> >But allow-stderr is in all Restrictions, not only in the one in
> >line 18. So it seems the comma after "allow-stderr" which seems to
> >confuse lintian (as it also emits the comma in the warning).
> 
> Sounds similar to #792418.

Thanks! It actually is the same issue. And in #792418 the questions I
wanted to ask the autopkgtest maintainers are already answered. So I
can now implement a proper solution.

Regards, Axel
-- 
 ,''`.  |  Axel Beckert , http://people.debian.org/~abe/
: :' :  |  Debian Developer, ftp.ch.debian.org Admin
`. `'   |  4096R: 2517 B724 C5F6 CA99 5329  6E61 2FF9 CD59 6126 16B5
  `-|  1024D: F067 EA27 26B9 C3FC 1486  202E C09E 1D89 9593 0EDE



Bug#798359: lintian: list of autopkgtest restrictions is not up-to-date

2015-09-08 Thread Axel Beckert
Hi Lunar,

Jérémy Bobbio wrote:
> It seems that the list of known restrictions for debian/tests/control is
> not up-to-date.
> 
> Several packages raise unknown-runtime-tests-restriction [1] despite
> using restrictions properly listed in the reference documentation [2].
> 
>  [1]: https://lintian.debian.org/tags/unknown-runtime-tests-restriction.html
>  [2]: 
> https://anonscm.debian.org/gitweb/?p=autopkgtest/autopkgtest.git;a=blob_plain;f=doc/README.package-tests.rst;hb=HEAD

Hrm. I just compared the source code with [2]. The source code is
uptodate. There is probably a bug somewhere else in the logic.

Will have a look.

Regards, Axel
-- 
 ,''`.  |  Axel Beckert , http://people.debian.org/~abe/
: :' :  |  Debian Developer, ftp.ch.debian.org Admin
`. `'   |  4096R: 2517 B724 C5F6 CA99 5329  6E61 2FF9 CD59 6126 16B5
  `-|  1024D: F067 EA27 26B9 C3FC 1486  202E C09E 1D89 9593 0EDE