Bug#804100: RFS: rhythmbox-plugin-alternative-toolbar/0.14.0-1~debian [ITP]

[foss.freedom]

Gianfranco,

  think I have had success with the watch file.  I found that if you store
the signature within a branch (in this case the debian branch) then you can
directly access the .asc file via the watch file.

Also I've removed the unneeded "license removal" patch.  This just leaves
the patch to Makefile.am to ensure the LICENSE file is not added to the
debian binary

The latest revision has been uploaded to mentors.

thanks

David

On 29 December 2015 at 00:36, foss.freedom  wrote:

> ok - scratch that Gianfranco,
>
> I deleted the rhythmbox-plugin-alternative-toolbar_0.15.0.orig.tar.gz file
> and reran uscan --debug --force-download
>
> It came back with the same 404 error
>
> GitHub saves attached downloads to the releases/download/v0.15.0 folder
> not to the archive folder
>
>
> https://github.com/fossfreedom/alternative-toolbar/releases/download/v0.15.0/v0.15.0.tar.gz.asc
>
> As I mentioned - my regex knowledge is very limited so I dont really
> understand how to modify the watch file.  I've read that link you gave me
> and I'm non-the-wiser as to how to change the watch file to find the .asc
> is the releases/download/{version} folder
>
> David
>
> On 29 December 2015 at 00:23, foss.freedom  wrote:
>
>> Hi Gianfranco,
>>
>>   strange that my uscan didnt pick that up.
>>
>> I've renamed the .asc file on the tag to v0.15.0.tar.gz.asc
>>
>> With regards to the license issue.
>>
>> I have to include the LICENSE part of Makefile.am so that those people
>> who compile directly from source correctly has the LICENSE file added to
>> the /usr/lib/rhythmbox/plugins/alternative-toolbar folder
>>
>> So at the very minimum I need at least a patch to remove the LICENSE part
>> of Makefile.am for Debian.
>>
>> As I mentioned in one of my emails above I couldnt get that dh-helper
>> statement working in my rules file - I raised this on unix & linux
>> stackexchange and someone mentioned you can't have cdbs and dh-helper type
>> statements in the same rule file.  I can't say if this is true or not -
>> just that I couldnt get it to work.
>>
>>  -
>> http://unix.stackexchange.com/questions/250683/how-to-remove-a-license-file-when-debian-packaging-using-autotools-automake
>>
>> thanks
>>
>> David
>>
>> On 28 December 2015 at 23:33, Gianfranco Costamagna <
>> costamagnagianfra...@yahoo.it> wrote:
>>
>>> Hi,
>>>
>>>
>>> uscan warning: In directory ., downloading
>>>
>>> https://github.com/fossfreedom/alternative-toolbar/archive/v0.15.0.tar.gz.asc
>>> failed: 404 Not Found
>>>
>>>
>>> seems that you have to rename it (or tweak the regex)
>>>
>>>
>>> BTW remove license . patch seems difficult to maintain, what about
>>> dropping the two patches and do something like that in your rules file?
>>>
>>> override_dh_auto_install:
>>> dh_auto_install
>>> find debian/tmp -name "LICENSE" -delete
>>>
>>> it shoud work (note: I didn't test it)
>>>
>>> cheers,
>>>
>>> G.
>>>
>>> Il Lunedì 28 Dicembre 2015 21:21, foss.freedom 
>>> ha scritto:
>>>
>>>
>>>
>>> Gianfranco,
>>>
>>>   I've uploaded an updated package with your suggested watch file.
>>>
>>> According to the uscan results I got the following - I presume this
>>> means success?
>>>
>>> uscan debug: matching pattern(s) (?:(?:https://github.com
>>> )?\/fossfreedom\/alternative\-toolbar\/tags)?.*/v?(\d\S*)\.tar\.gz
>>> -- Found the following matching hrefs:
>>>  /fossfreedom/alternative-toolbar/archive/v0.15.0.tar.gz (0.15.0)
>>>  /fossfreedom/alternative-toolbar/archive/v0.14.1.tar.gz (0.14.1)
>>>  /fossfreedom/alternative-toolbar/archive/v0.14.0.tar.gz (0.14.0)
>>> Newest version on remote site is 0.15.0, local version is 0.15.0
>>>  => Package is up to date
>>> Newest version on remote site is 0.15.0, local version is 0.15.0
>>>  => rhythmbox-plugin-alternative-toolbar_0.15.0.orig.tar.gz already in
>>> package directory '..'
>>> -- Scan finished
>>>
>>> thanks
>>>
>>> David
>>>
>>>
>>> On 28 December 2015 at 19:21, Gianfranco Costamagna <
>>> costamagnagianfra...@yahoo.it> wrote:
>>>
>>> Hi
>>> >
>>> >
>>> >>I'm trying to get rid of the last pedantic linitian issue which is the
>>> signing of the release.
>>> >>
>>> >>  I think I've figured out how to sign  the .tar.gz on github
>>> >>
>>> >>gpg --default-key 7B0393D9 --armor --detach-sign
>>> alternative-toolbar-0.15.tar.gz
>>> >
>>> >
>>> >wonderful!
>>> >
>>> >>Then I attached the .asc file to the release.
>>> >>https://github.com/fossfreedom/alternative-toolbar/releases/tag/v0.15
>>> >
>>> >
>>> >exactly
>>> >
>>> >>I created a .pgp file in the debian folder with:
>>> >>
>>> >>gpg --export "the public fingerprint for the debian key" >
>>> debian/upstream-signing-key.pgp
>>> >>
>>> >>
>>> >>However I really dont understand regex and thus I dont know how to
>>> change the watch file from this:
>>> >>
>>> >>version=3
>>> >>opts=filenamemangle=s/.+\/v?(\d\S*)\.tar\.gz/alternative-toolbar-$1\.tar\.gz/
>>> \
>>> >>  

Bug#804100: RFS: rhythmbox-plugin-alternative-toolbar/0.14.0-1~debian [ITP]

[foss.freedom]

Gianfranco,

  I've uploaded an updated package with your suggested watch file.

According to the uscan results I got the following - I presume this means
success?

uscan debug: matching pattern(s) (?:(?:https://github.com
)?\/fossfreedom\/alternative\-toolbar\/tags)?.*/v?(\d\S*)\.tar\.gz
-- Found the following matching hrefs:
 /fossfreedom/alternative-toolbar/archive/v0.15.0.tar.gz (0.15.0)
 /fossfreedom/alternative-toolbar/archive/v0.14.1.tar.gz (0.14.1)
 /fossfreedom/alternative-toolbar/archive/v0.14.0.tar.gz (0.14.0)
Newest version on remote site is 0.15.0, local version is 0.15.0
 => Package is up to date
Newest version on remote site is 0.15.0, local version is 0.15.0
 => rhythmbox-plugin-alternative-toolbar_0.15.0.orig.tar.gz already in
package directory '..'
-- Scan finished

thanks

David

On 28 December 2015 at 19:21, Gianfranco Costamagna <
costamagnagianfra...@yahoo.it> wrote:

> Hi
>
>
> >I'm trying to get rid of the last pedantic linitian issue which is the
> signing of the release.
> >
> >  I think I've figured out how to sign  the .tar.gz on github
> >
> >gpg --default-key 7B0393D9 --armor --detach-sign
> alternative-toolbar-0.15.tar.gz
>
>
> wonderful!
>
> >Then I attached the .asc file to the release.
> >https://github.com/fossfreedom/alternative-toolbar/releases/tag/v0.15
>
>
> exactly
>
> >I created a .pgp file in the debian folder with:
> >
> >gpg --export "the public fingerprint for the debian key" >
> debian/upstream-signing-key.pgp
> >
> >
> >However I really dont understand regex and thus I dont know how to change
> the watch file from this:
> >
> >version=3
> >opts=filenamemangle=s/.+\/v?(\d\S*)\.tar\.gz/alternative-toolbar-$1\.tar\.gz/
> \
> >  https://github.com/fossfreedom/alternative-toolbar/tags
> .*/v?(\d\S*)\.tar\.gz
> >
> >to something like this
> >
> >version=3
> >pgpsigurlmangle=s/(what do I do here?)/.asc/ \
> >
> >https://github.com/fossfreedom/alternative-toolbar/archive/v?(dunno what
> here)\.tar.gz
> >
> >Any thoughts?
>
>
>
> not sure, maybe something like this?
> opts=pgpsigurlmangle=s/$/.asc/
>
> so
> version=3
> opts=pgpsigurlmangle=s/$/.asc/,filenamemangle=s/.+\/v?(\d\S*)\.tar\.gz/alternative-toolbar-$1\.tar\.gz/
> \
>  https://github.com/fossfreedom/alternative-toolbar/tags
> .*/v?(\d\S*)\.tar\.gz
>
> this link might help
> https://wiki.debian.org/debian/watch
>
> you can test the fix with uscan --debug --force-download
>
>
> note: I didn't test the above, because there is no upload on mentors with
> the gpg public key inside.
> (you might need to rename the asc file in the github release, please rely
> to the output of uscan --debug,
> to know the correct file naming)
>
> cheers,
>
> G.
>
>
> On 21 December 2015 at 14:33, foss.freedom  wrote:
> Hi Gianfranco
> >
> >
> > I've re-uploaded to mentors.debian.net
> >
> >
> >This corrects the issues mentioned previously.  Note - I've resolved the
> LICENSE issue by two debian/patches
> >
> >
> >Note - This still produces an informational lintian issue with the
> remove-license.diff patch.  This is very odd because this does have a PEP3
> header on the diff file
> >
> >
> >* Package name   : rhythmbox-plugin-alternative-toolbar Version  :
> 0.15.0-1
> >I've uploaded a newer version with a new autotools build
> mechanism+patches here:
> >http://mentors.debian.net/package/rhythmbox-plugin-alternative-toolbar
> Alternatively, one can download the package with dget using this command:
> >dget -x
> http://mentors.debian.net/debian/pool/main/r/rhythmbox-plugin-alternative-toolbar/rhythmbox-plugin-alternative-toolbar_0.15.0-1.dsc
> >
> >
> >
> >
> >thanks
> >
> >
> >David
> >
> >
> >On 21 December 2015 at 11:05, foss.freedom 
> wrote:
> >
> >Many thanks Gianfranco,
> >>
> >>
> >>  to answer your questions
> >>
> >>
> >>1. python3 - yes I should include this as a dependency - you are correct
> rhythmbox does have a dependency - but belt-and-braces
> >>2. When the topic of changing the interface for rhythmbox came up on a
> bugzilla report, the rhythmbox maintainer dismissed very quickly the
> approach of using a python3 plugin.  Thus I havent attempted to upstream
> this
> >>
> >>
> >> - https://bugzilla.gnome.org/show_bug.cgi?id=735648
> >>
> >>
> >>With regards to the lintian report:
> >>
> >>
> >>1.  W: rhythmbox-plugin-alternative-toolbar source:
> build-depends-on-python-dev-with-no-arch-any
> >>
> >>
> >>There is no reason for the package to have a  build-depends on
> python3-dev so I'll remove this.
> >>
> >>
> >>2. P: rhythmbox-plugin-alternative-toolbar source:
> debian-watch-may-check-gpg-signature
> >>
> >>
> >>No idea on this - dont think GitHub provides a means to gpg-signature
> the tar.gz tag file
> >>
> >>
> >>3. P: rhythmbox-plugin-alternative-toolbar: no-upstream-changelog
> >>
> >>
> >>Think this means I need to change my source and thus bump the version.
> If you don't mind I would like to bump this into a future version of the
> plugin.
> 

Bug#804100: RFS: rhythmbox-plugin-alternative-toolbar/0.14.0-1~debian [ITP]

[Gianfranco Costamagna]

Hi


>I'm trying to get rid of the last pedantic linitian issue which is the signing 
>of the release.
>
>  I think I've figured out how to sign  the .tar.gz on github
>
>gpg --default-key 7B0393D9 --armor --detach-sign 
>alternative-toolbar-0.15.tar.gz


wonderful!

>Then I attached the .asc file to the release.
>https://github.com/fossfreedom/alternative-toolbar/releases/tag/v0.15


exactly

>I created a .pgp file in the debian folder with:
>
>gpg --export "the public fingerprint for the debian key" > 
>debian/upstream-signing-key.pgp
>
>
>However I really dont understand regex and thus I dont know how to change the 
>watch file from this:
>
>version=3
>opts=filenamemangle=s/.+\/v?(\d\S*)\.tar\.gz/alternative-toolbar-$1\.tar\.gz/ \
>  https://github.com/fossfreedom/alternative-toolbar/tags .*/v?(\d\S*)\.tar\.gz
>
>to something like this
>
>version=3
>pgpsigurlmangle=s/(what do I do here?)/.asc/ \
>
>https://github.com/fossfreedom/alternative-toolbar/archive/v?(dunno what 
>here)\.tar.gz
>
>Any thoughts?



not sure, maybe something like this?
opts=pgpsigurlmangle=s/$/.asc/

so
version=3
opts=pgpsigurlmangle=s/$/.asc/,filenamemangle=s/.+\/v?(\d\S*)\.tar\.gz/alternative-toolbar-$1\.tar\.gz/
 \
 https://github.com/fossfreedom/alternative-toolbar/tags .*/v?(\d\S*)\.tar\.gz

this link might help
https://wiki.debian.org/debian/watch

you can test the fix with uscan --debug --force-download


note: I didn't test the above, because there is no upload on mentors with the 
gpg public key inside.
(you might need to rename the asc file in the github release, please rely to 
the output of uscan --debug,
to know the correct file naming)

cheers,

G.


On 21 December 2015 at 14:33, foss.freedom  wrote:
Hi Gianfranco
>
>
> I've re-uploaded to mentors.debian.net
>
>
>This corrects the issues mentioned previously.  Note - I've resolved the 
>LICENSE issue by two debian/patches
>
>
>Note - This still produces an informational lintian issue with the 
>remove-license.diff patch.  This is very odd because this does have a PEP3 
>header on the diff file
>
>
>* Package name   : rhythmbox-plugin-alternative-toolbar Version  : 
>0.15.0-1 
>I've uploaded a newer version with a new autotools build mechanism+patches 
>here:
>http://mentors.debian.net/package/rhythmbox-plugin-alternative-toolbar 
>Alternatively, one can download the package with dget using this command: 
>dget -x 
>http://mentors.debian.net/debian/pool/main/r/rhythmbox-plugin-alternative-toolbar/rhythmbox-plugin-alternative-toolbar_0.15.0-1.dsc
>
>
>
>
>thanks
>
>
>David
>
>
>On 21 December 2015 at 11:05, foss.freedom  wrote:
>
>Many thanks Gianfranco,
>>
>>
>>  to answer your questions
>>
>>
>>1. python3 - yes I should include this as a dependency - you are correct 
>>rhythmbox does have a dependency - but belt-and-braces
>>2. When the topic of changing the interface for rhythmbox came up on a 
>>bugzilla report, the rhythmbox maintainer dismissed very quickly the approach 
>>of using a python3 plugin.  Thus I havent attempted to upstream this
>>
>>
>> - https://bugzilla.gnome.org/show_bug.cgi?id=735648
>>
>>
>>With regards to the lintian report:
>>
>>
>>1.  W: rhythmbox-plugin-alternative-toolbar source: 
>>build-depends-on-python-dev-with-no-arch-any
>>
>>
>>There is no reason for the package to have a  build-depends on python3-dev so 
>>I'll remove this.
>>
>>
>>2. P: rhythmbox-plugin-alternative-toolbar source: 
>>debian-watch-may-check-gpg-signature
>>
>>
>>No idea on this - dont think GitHub provides a means to gpg-signature the 
>>tar.gz tag file
>>
>>
>>3. P: rhythmbox-plugin-alternative-toolbar: no-upstream-changelog
>>
>>
>>Think this means I need to change my source and thus bump the version.  If 
>>you don't mind I would like to bump this into a future version of the plugin.
>>
>>
>>4. I: rhythmbox-plugin-alternative-toolbar: 
>>capitalization-error-in-description Gnome GNOME
>>
>>
>>Doh! - yes, quite correct - I'll change all references for Gnome to GNOME in 
>>the description
>>
>>
>>5. W: rhythmbox-plugin-alternative-toolbar: extra-license-file 
>>usr/lib/rhythmbox/plugins/alternative-toolbar/LICENSE
>>
>>
>>I'm not sure how to do this - I thought of using a debian/rules 
>>override_dh_auto_install but this doesnt seem to be working.  If you have any 
>>thoughts on this I would be very grateful - for the moment I've created a 
>>unix-and-linux stackexchange question and I hope someone can answer:
>>
>>
>> - 
>> http://unix.stackexchange.com/questions/250683/how-to-remove-a-license-file-when-debian-packaging-using-autotools-automake#250683
>>
>>
>>thanks
>>
>>
>>David
>>
>>
>> - 
>>
>>
>>On 21 December 2015 at 09:20, Gianfranco Costamagna 
>> wrote:
>>
>>Hi,
>>>
>>>
>>>
>>>the package looks really nice now!
>>>
>>>however there still are some minor issues here

Bug#804100: RFS: rhythmbox-plugin-alternative-toolbar/0.14.0-1~debian [ITP]

[foss.freedom]

ok - scratch that Gianfranco,

I deleted the rhythmbox-plugin-alternative-toolbar_0.15.0.orig.tar.gz file
and reran uscan --debug --force-download

It came back with the same 404 error

GitHub saves attached downloads to the releases/download/v0.15.0 folder not
to the archive folder

https://github.com/fossfreedom/alternative-toolbar/releases/download/v0.15.0/v0.15.0.tar.gz.asc

As I mentioned - my regex knowledge is very limited so I dont really
understand how to modify the watch file.  I've read that link you gave me
and I'm non-the-wiser as to how to change the watch file to find the .asc
is the releases/download/{version} folder

David

On 29 December 2015 at 00:23, foss.freedom  wrote:

> Hi Gianfranco,
>
>   strange that my uscan didnt pick that up.
>
> I've renamed the .asc file on the tag to v0.15.0.tar.gz.asc
>
> With regards to the license issue.
>
> I have to include the LICENSE part of Makefile.am so that those people who
> compile directly from source correctly has the LICENSE file added to the
> /usr/lib/rhythmbox/plugins/alternative-toolbar folder
>
> So at the very minimum I need at least a patch to remove the LICENSE part
> of Makefile.am for Debian.
>
> As I mentioned in one of my emails above I couldnt get that dh-helper
> statement working in my rules file - I raised this on unix & linux
> stackexchange and someone mentioned you can't have cdbs and dh-helper type
> statements in the same rule file.  I can't say if this is true or not -
> just that I couldnt get it to work.
>
>  -
> http://unix.stackexchange.com/questions/250683/how-to-remove-a-license-file-when-debian-packaging-using-autotools-automake
>
> thanks
>
> David
>
> On 28 December 2015 at 23:33, Gianfranco Costamagna <
> costamagnagianfra...@yahoo.it> wrote:
>
>> Hi,
>>
>>
>> uscan warning: In directory ., downloading
>>
>> https://github.com/fossfreedom/alternative-toolbar/archive/v0.15.0.tar.gz.asc
>> failed: 404 Not Found
>>
>>
>> seems that you have to rename it (or tweak the regex)
>>
>>
>> BTW remove license . patch seems difficult to maintain, what about
>> dropping the two patches and do something like that in your rules file?
>>
>> override_dh_auto_install:
>> dh_auto_install
>> find debian/tmp -name "LICENSE" -delete
>>
>> it shoud work (note: I didn't test it)
>>
>> cheers,
>>
>> G.
>>
>> Il Lunedì 28 Dicembre 2015 21:21, foss.freedom 
>> ha scritto:
>>
>>
>>
>> Gianfranco,
>>
>>   I've uploaded an updated package with your suggested watch file.
>>
>> According to the uscan results I got the following - I presume this means
>> success?
>>
>> uscan debug: matching pattern(s) (?:(?:https://github.com
>> )?\/fossfreedom\/alternative\-toolbar\/tags)?.*/v?(\d\S*)\.tar\.gz
>> -- Found the following matching hrefs:
>>  /fossfreedom/alternative-toolbar/archive/v0.15.0.tar.gz (0.15.0)
>>  /fossfreedom/alternative-toolbar/archive/v0.14.1.tar.gz (0.14.1)
>>  /fossfreedom/alternative-toolbar/archive/v0.14.0.tar.gz (0.14.0)
>> Newest version on remote site is 0.15.0, local version is 0.15.0
>>  => Package is up to date
>> Newest version on remote site is 0.15.0, local version is 0.15.0
>>  => rhythmbox-plugin-alternative-toolbar_0.15.0.orig.tar.gz already in
>> package directory '..'
>> -- Scan finished
>>
>> thanks
>>
>> David
>>
>>
>> On 28 December 2015 at 19:21, Gianfranco Costamagna <
>> costamagnagianfra...@yahoo.it> wrote:
>>
>> Hi
>> >
>> >
>> >>I'm trying to get rid of the last pedantic linitian issue which is the
>> signing of the release.
>> >>
>> >>  I think I've figured out how to sign  the .tar.gz on github
>> >>
>> >>gpg --default-key 7B0393D9 --armor --detach-sign
>> alternative-toolbar-0.15.tar.gz
>> >
>> >
>> >wonderful!
>> >
>> >>Then I attached the .asc file to the release.
>> >>https://github.com/fossfreedom/alternative-toolbar/releases/tag/v0.15
>> >
>> >
>> >exactly
>> >
>> >>I created a .pgp file in the debian folder with:
>> >>
>> >>gpg --export "the public fingerprint for the debian key" >
>> debian/upstream-signing-key.pgp
>> >>
>> >>
>> >>However I really dont understand regex and thus I dont know how to
>> change the watch file from this:
>> >>
>> >>version=3
>> >>opts=filenamemangle=s/.+\/v?(\d\S*)\.tar\.gz/alternative-toolbar-$1\.tar\.gz/
>> \
>> >>  https://github.com/fossfreedom/alternative-toolbar/tags
>> .*/v?(\d\S*)\.tar\.gz
>> >>
>> >>to something like this
>> >>
>> >>version=3
>> >>pgpsigurlmangle=s/(what do I do here?)/.asc/ \
>> >>
>> >>https://github.com/fossfreedom/alternative-toolbar/archive/v?(dunno
>> what here)\.tar.gz
>> >>
>> >>Any thoughts?
>> >
>> >
>> >
>> >not sure, maybe something like this?
>> >opts=pgpsigurlmangle=s/$/.asc/
>> >
>> >so
>> >version=3
>> >opts=pgpsigurlmangle=s/$/.asc/,filenamemangle=s/.+\/v?(\d\S*)\.tar\.gz/alternative-toolbar-$1\.tar\.gz/
>> \
>> > https://github.com/fossfreedom/alternative-toolbar/tags
>> .*/v?(\d\S*)\.tar\.gz
>> >
>> >this link might help
>> 

Bug#804100: RFS: rhythmbox-plugin-alternative-toolbar/0.14.0-1~debian [ITP]

[Gianfranco Costamagna]

Hi,


uscan warning: In directory ., downloading
https://github.com/fossfreedom/alternative-toolbar/archive/v0.15.0.tar.gz.asc 
failed: 404 Not Found


seems that you have to rename it (or tweak the regex)


BTW remove license . patch seems difficult to maintain, what about dropping the 
two patches and do something like that in your rules file?

override_dh_auto_install:
dh_auto_install
find debian/tmp -name "LICENSE" -delete

it shoud work (note: I didn't test it)

cheers,

G.

Il Lunedì 28 Dicembre 2015 21:21, foss.freedom  ha 
scritto:



Gianfranco,

  I've uploaded an updated package with your suggested watch file.

According to the uscan results I got the following - I presume this means 
success?

uscan debug: matching pattern(s) 
(?:(?:https://github.com)?\/fossfreedom\/alternative\-toolbar\/tags)?.*/v?(\d\S*)\.tar\.gz
-- Found the following matching hrefs:
 /fossfreedom/alternative-toolbar/archive/v0.15.0.tar.gz (0.15.0)
 /fossfreedom/alternative-toolbar/archive/v0.14.1.tar.gz (0.14.1)
 /fossfreedom/alternative-toolbar/archive/v0.14.0.tar.gz (0.14.0)
Newest version on remote site is 0.15.0, local version is 0.15.0
 => Package is up to date
Newest version on remote site is 0.15.0, local version is 0.15.0
 => rhythmbox-plugin-alternative-toolbar_0.15.0.orig.tar.gz already in package 
directory '..'
-- Scan finished

thanks

David


On 28 December 2015 at 19:21, Gianfranco Costamagna 
 wrote:

Hi
>
>
>>I'm trying to get rid of the last pedantic linitian issue which is the 
>>signing of the release.
>>
>>  I think I've figured out how to sign  the .tar.gz on github
>>
>>gpg --default-key 7B0393D9 --armor --detach-sign 
>>alternative-toolbar-0.15.tar.gz
>
>
>wonderful!
>
>>Then I attached the .asc file to the release.
>>https://github.com/fossfreedom/alternative-toolbar/releases/tag/v0.15
>
>
>exactly
>
>>I created a .pgp file in the debian folder with:
>>
>>gpg --export "the public fingerprint for the debian key" > 
>>debian/upstream-signing-key.pgp
>>
>>
>>However I really dont understand regex and thus I dont know how to change the 
>>watch file from this:
>>
>>version=3
>>opts=filenamemangle=s/.+\/v?(\d\S*)\.tar\.gz/alternative-toolbar-$1\.tar\.gz/ 
>>\
>>  https://github.com/fossfreedom/alternative-toolbar/tags 
>> .*/v?(\d\S*)\.tar\.gz
>>
>>to something like this
>>
>>version=3
>>pgpsigurlmangle=s/(what do I do here?)/.asc/ \
>>
>>https://github.com/fossfreedom/alternative-toolbar/archive/v?(dunno what 
>>here)\.tar.gz
>>
>>Any thoughts?
>
>
>
>not sure, maybe something like this?
>opts=pgpsigurlmangle=s/$/.asc/
>
>so
>version=3
>opts=pgpsigurlmangle=s/$/.asc/,filenamemangle=s/.+\/v?(\d\S*)\.tar\.gz/alternative-toolbar-$1\.tar\.gz/
> \
> https://github.com/fossfreedom/alternative-toolbar/tags .*/v?(\d\S*)\.tar\.gz
>
>this link might help
>https://wiki.debian.org/debian/watch
>
>you can test the fix with uscan --debug --force-download
>
>
>note: I didn't test the above, because there is no upload on mentors with the 
>gpg public key inside.
>(you might need to rename the asc file in the github release, please rely to 
>the output of uscan --debug,
>to know the correct file naming)
>
>cheers,
>
>G.
>
>
>
>On 21 December 2015 at 14:33, foss.freedom  wrote:
>Hi Gianfranco
>>
>>
>> I've re-uploaded to mentors.debian.net
>>
>>
>>This corrects the issues mentioned previously.  Note - I've resolved the 
>>LICENSE issue by two debian/patches
>>
>>
>>Note - This still produces an informational lintian issue with the 
>>remove-license.diff patch.  This is very odd because this does have a PEP3 
>>header on the diff file
>>
>>
>>* Package name   : rhythmbox-plugin-alternative-toolbar Version  : 
>>0.15.0-1
>>I've uploaded a newer version with a new autotools build mechanism+patches 
>>here:
>>http://mentors.debian.net/package/rhythmbox-plugin-alternative-toolbar 
>>Alternatively, one can download the package with dget using this command:
>>dget -x 
>>http://mentors.debian.net/debian/pool/main/r/rhythmbox-plugin-alternative-toolbar/rhythmbox-plugin-alternative-toolbar_0.15.0-1.dsc
>>
>>
>>
>>
>>thanks
>>
>>
>>David
>>
>>
>>On 21 December 2015 at 11:05, foss.freedom  wrote:
>>
>>Many thanks Gianfranco,
>>>
>>>
>>>  to answer your questions
>>>
>>>
>>>1. python3 - yes I should include this as a dependency - you are correct 
>>>rhythmbox does have a dependency - but belt-and-braces
>>>2. When the topic of changing the interface for rhythmbox came up on a 
>>>bugzilla report, the rhythmbox maintainer dismissed very quickly the 
>>>approach of using a python3 plugin.  Thus I havent attempted to upstream this
>>>
>>>
>>> - https://bugzilla.gnome.org/show_bug.cgi?id=735648
>>>
>>>
>>>With regards to the lintian report:
>>>
>>>
>>>1.  W: rhythmbox-plugin-alternative-toolbar source: 
>>>build-depends-on-python-dev-with-no-arch-any
>>>
>>>
>>>There is no reason for the package to have a  

Bug#804100: RFS: rhythmbox-plugin-alternative-toolbar/0.14.0-1~debian [ITP]

[foss.freedom]

Hi Gianfranco,

  strange that my uscan didnt pick that up.

I've renamed the .asc file on the tag to v0.15.0.tar.gz.asc

With regards to the license issue.

I have to include the LICENSE part of Makefile.am so that those people who
compile directly from source correctly has the LICENSE file added to the
/usr/lib/rhythmbox/plugins/alternative-toolbar folder

So at the very minimum I need at least a patch to remove the LICENSE part
of Makefile.am for Debian.

As I mentioned in one of my emails above I couldnt get that dh-helper
statement working in my rules file - I raised this on unix & linux
stackexchange and someone mentioned you can't have cdbs and dh-helper type
statements in the same rule file.  I can't say if this is true or not -
just that I couldnt get it to work.

 -
http://unix.stackexchange.com/questions/250683/how-to-remove-a-license-file-when-debian-packaging-using-autotools-automake

thanks

David

On 28 December 2015 at 23:33, Gianfranco Costamagna <
costamagnagianfra...@yahoo.it> wrote:

> Hi,
>
>
> uscan warning: In directory ., downloading
>
> https://github.com/fossfreedom/alternative-toolbar/archive/v0.15.0.tar.gz.asc
> failed: 404 Not Found
>
>
> seems that you have to rename it (or tweak the regex)
>
>
> BTW remove license . patch seems difficult to maintain, what about
> dropping the two patches and do something like that in your rules file?
>
> override_dh_auto_install:
> dh_auto_install
> find debian/tmp -name "LICENSE" -delete
>
> it shoud work (note: I didn't test it)
>
> cheers,
>
> G.
>
> Il Lunedì 28 Dicembre 2015 21:21, foss.freedom 
> ha scritto:
>
>
>
> Gianfranco,
>
>   I've uploaded an updated package with your suggested watch file.
>
> According to the uscan results I got the following - I presume this means
> success?
>
> uscan debug: matching pattern(s) (?:(?:https://github.com
> )?\/fossfreedom\/alternative\-toolbar\/tags)?.*/v?(\d\S*)\.tar\.gz
> -- Found the following matching hrefs:
>  /fossfreedom/alternative-toolbar/archive/v0.15.0.tar.gz (0.15.0)
>  /fossfreedom/alternative-toolbar/archive/v0.14.1.tar.gz (0.14.1)
>  /fossfreedom/alternative-toolbar/archive/v0.14.0.tar.gz (0.14.0)
> Newest version on remote site is 0.15.0, local version is 0.15.0
>  => Package is up to date
> Newest version on remote site is 0.15.0, local version is 0.15.0
>  => rhythmbox-plugin-alternative-toolbar_0.15.0.orig.tar.gz already in
> package directory '..'
> -- Scan finished
>
> thanks
>
> David
>
>
> On 28 December 2015 at 19:21, Gianfranco Costamagna <
> costamagnagianfra...@yahoo.it> wrote:
>
> Hi
> >
> >
> >>I'm trying to get rid of the last pedantic linitian issue which is the
> signing of the release.
> >>
> >>  I think I've figured out how to sign  the .tar.gz on github
> >>
> >>gpg --default-key 7B0393D9 --armor --detach-sign
> alternative-toolbar-0.15.tar.gz
> >
> >
> >wonderful!
> >
> >>Then I attached the .asc file to the release.
> >>https://github.com/fossfreedom/alternative-toolbar/releases/tag/v0.15
> >
> >
> >exactly
> >
> >>I created a .pgp file in the debian folder with:
> >>
> >>gpg --export "the public fingerprint for the debian key" >
> debian/upstream-signing-key.pgp
> >>
> >>
> >>However I really dont understand regex and thus I dont know how to
> change the watch file from this:
> >>
> >>version=3
> >>opts=filenamemangle=s/.+\/v?(\d\S*)\.tar\.gz/alternative-toolbar-$1\.tar\.gz/
> \
> >>  https://github.com/fossfreedom/alternative-toolbar/tags
> .*/v?(\d\S*)\.tar\.gz
> >>
> >>to something like this
> >>
> >>version=3
> >>pgpsigurlmangle=s/(what do I do here?)/.asc/ \
> >>
> >>https://github.com/fossfreedom/alternative-toolbar/archive/v?(dunno
> what here)\.tar.gz
> >>
> >>Any thoughts?
> >
> >
> >
> >not sure, maybe something like this?
> >opts=pgpsigurlmangle=s/$/.asc/
> >
> >so
> >version=3
> >opts=pgpsigurlmangle=s/$/.asc/,filenamemangle=s/.+\/v?(\d\S*)\.tar\.gz/alternative-toolbar-$1\.tar\.gz/
> \
> > https://github.com/fossfreedom/alternative-toolbar/tags
> .*/v?(\d\S*)\.tar\.gz
> >
> >this link might help
> >https://wiki.debian.org/debian/watch
> >
> >you can test the fix with uscan --debug --force-download
> >
> >
> >note: I didn't test the above, because there is no upload on mentors with
> the gpg public key inside.
> >(you might need to rename the asc file in the github release, please rely
> to the output of uscan --debug,
> >to know the correct file naming)
> >
> >cheers,
> >
> >G.
> >
> >
> >
> >On 21 December 2015 at 14:33, foss.freedom 
> wrote:
> >Hi Gianfranco
> >>
> >>
> >> I've re-uploaded to mentors.debian.net
> >>
> >>
> >>This corrects the issues mentioned previously.  Note - I've resolved the
> LICENSE issue by two debian/patches
> >>
> >>
> >>Note - This still produces an informational lintian issue with the
> remove-license.diff patch.  This is very odd because this does have a PEP3
> header on the diff file
> >>
> >>
> >>* Package name   : 

Bug#804100: RFS: rhythmbox-plugin-alternative-toolbar/0.14.0-1~debian [ITP]

[foss.freedom]

Hi Gianfranco,

I'm trying to get rid of the last pedantic linitian issue which is the
signing of the release.

   I think I've figured out how to sign  the .tar.gz on github

gpg --default-key 7B0393D9 --armor --detach-sign
alternative-toolbar-0.15.tar.gz

Then I attached the .asc file to the release.

https://github.com/fossfreedom/alternative-toolbar/releases/tag/v0.15

I created a .pgp file in the debian folder with:

gpg --export "the public fingerprint for the debian key" >
debian/upstream-signing-key.pgp

However I really dont understand regex and thus I dont know how to change
the watch file from this:

version=3
opts=filenamemangle=s/.+\/v?(\d\S*)\.tar\.gz/alternative-toolbar-$1\.tar\.gz/
\
  https://github.com/fossfreedom/alternative-toolbar/tags
.*/v?(\d\S*)\.tar\.gz

to something like this

version=3
pgpsigurlmangle=s/(what do I do here?)/.asc/ \
https://github.com/fossfreedom/alternative-toolbar/archive/v?(dunno what
here)\.tar.gz

Any thoughts?

thanks in advance

David

On 21 December 2015 at 14:33, foss.freedom  wrote:

> Hi Gianfranco
>
>  I've re-uploaded to mentors.debian.net
>
> This corrects the issues mentioned previously.  Note - I've resolved the
> LICENSE issue by two debian/patches
>
> Note - This still produces an informational lintian issue with the
> remove-license.diff patch.  This is very odd because this does have a PEP3
> header on the diff file
>
> * Package name: rhythmbox-plugin-alternative-toolbar
>Version : 0.15.0-1
> I've uploaded a newer version with a new autotools build mechanism+patches 
> here:
>   http://mentors.debian.net/package/rhythmbox-plugin-alternative-toolbar
>
>   Alternatively, one can download the package with dget using this command:
>
> dget -x 
> http://mentors.debian.net/debian/pool/main/r/rhythmbox-plugin-alternative-toolbar/rhythmbox-plugin-alternative-toolbar_0.15.0-1.dsc
>
>
> thanks
>
> David
>
>
> On 21 December 2015 at 11:05, foss.freedom  wrote:
>
>> Many thanks Gianfranco,
>>
>>   to answer your questions
>>
>> 1. python3 - yes I should include this as a dependency - you are correct
>> rhythmbox does have a dependency - but belt-and-braces
>> 2. When the topic of changing the interface for rhythmbox came up on a
>> bugzilla report, the rhythmbox maintainer dismissed very quickly the
>> approach of using a python3 plugin.  Thus I havent attempted to upstream
>> this
>>
>>  - https://bugzilla.gnome.org/show_bug.cgi?id=735648
>>
>> With regards to the lintian report:
>>
>> 1.  W: rhythmbox-plugin-alternative-toolbar source:
>> build-depends-on-python-dev-with-no-arch-any
>>
>> There is no reason for the package to have a build-depends on python3-dev
>> so I'll remove this.
>>
>> 2. P: rhythmbox-plugin-alternative-toolbar source:
>> debian-watch-may-check-gpg-signature
>>
>> No idea on this - dont think GitHub provides a means to gpg-signature the
>> tar.gz tag file
>>
>> 3. P: rhythmbox-plugin-alternative-toolbar: no-upstream-changelog
>>
>> Think this means I need to change my source and thus bump the version. If
>> you don't mind I would like to bump this into a future version of the
>> plugin.
>>
>> 4. I: rhythmbox-plugin-alternative-toolbar:
>> capitalization-error-in-description Gnome GNOME
>>
>> Doh! - yes, quite correct - I'll change all references for Gnome to GNOME
>> in the description
>>
>> 5. W: rhythmbox-plugin-alternative-toolbar: extra-license-file
>> usr/lib/rhythmbox/plugins/alternative-toolbar/LICENSE
>>
>> I'm not sure how to do this - I thought of using a debian/rules 
>> override_dh_auto_install
>> but this doesnt seem to be working.  If you have any thoughts on this I
>> would be very grateful - for the moment I've created a unix-and-linux
>> stackexchange question and I hope someone can answer:
>>
>>  -
>> http://unix.stackexchange.com/questions/250683/how-to-remove-a-license-file-when-debian-packaging-using-autotools-automake#250683
>>
>> thanks
>>
>> David
>>
>>  -
>>
>> On 21 December 2015 at 09:20, Gianfranco Costamagna <
>> costamagnagianfra...@yahoo.it> wrote:
>>
>>> Hi,
>>>
>>>
>>>
>>> the package looks really nice now!
>>>
>>> however there still are some minor issues here
>>>
>>> http://debomatic-amd64.debian.net/distribution#unstable/rhythmbox-plugin-alternative-toolbar/0.15.0-1/lintian
>>>
>>> can you please address them? the package works in both debian and ubuntu.
>>>
>>> I have a few questions:
>>> 1) isn't python3 a runtime dependency? (not a problem, because seems
>>> that rhythmbox already depends on it)
>>> 2) why didn't you upstream the plugin into the rhythmbox-plugins package?
>>> https://packages.qa.debian.org/r/rhythmbox.html
>>>
>>> thanks,
>>>
>>> Gianfranco
>>>
>>
>>
>

Bug#804100: RFS: rhythmbox-plugin-alternative-toolbar/0.14.0-1~debian [ITP]

[foss.freedom]

Hi Gianfranco

 I've re-uploaded to mentors.debian.net

This corrects the issues mentioned previously.  Note - I've resolved the
LICENSE issue by two debian/patches

Note - This still produces an informational lintian issue with the
remove-license.diff patch.  This is very odd because this does have a PEP3
header on the diff file

* Package name: rhythmbox-plugin-alternative-toolbar
   Version : 0.15.0-1
I've uploaded a newer version with a new autotools build mechanism+patches here:
  http://mentors.debian.net/package/rhythmbox-plugin-alternative-toolbar

  Alternatively, one can download the package with dget using this command:

dget -x 
http://mentors.debian.net/debian/pool/main/r/rhythmbox-plugin-alternative-toolbar/rhythmbox-plugin-alternative-toolbar_0.15.0-1.dsc


thanks

David


On 21 December 2015 at 11:05, foss.freedom  wrote:

> Many thanks Gianfranco,
>
>   to answer your questions
>
> 1. python3 - yes I should include this as a dependency - you are correct
> rhythmbox does have a dependency - but belt-and-braces
> 2. When the topic of changing the interface for rhythmbox came up on a
> bugzilla report, the rhythmbox maintainer dismissed very quickly the
> approach of using a python3 plugin.  Thus I havent attempted to upstream
> this
>
>  - https://bugzilla.gnome.org/show_bug.cgi?id=735648
>
> With regards to the lintian report:
>
> 1.  W: rhythmbox-plugin-alternative-toolbar source:
> build-depends-on-python-dev-with-no-arch-any
>
> There is no reason for the package to have a build-depends on python3-dev
> so I'll remove this.
>
> 2. P: rhythmbox-plugin-alternative-toolbar source:
> debian-watch-may-check-gpg-signature
>
> No idea on this - dont think GitHub provides a means to gpg-signature the
> tar.gz tag file
>
> 3. P: rhythmbox-plugin-alternative-toolbar: no-upstream-changelog
>
> Think this means I need to change my source and thus bump the version. If
> you don't mind I would like to bump this into a future version of the
> plugin.
>
> 4. I: rhythmbox-plugin-alternative-toolbar:
> capitalization-error-in-description Gnome GNOME
>
> Doh! - yes, quite correct - I'll change all references for Gnome to GNOME
> in the description
>
> 5. W: rhythmbox-plugin-alternative-toolbar: extra-license-file
> usr/lib/rhythmbox/plugins/alternative-toolbar/LICENSE
>
> I'm not sure how to do this - I thought of using a debian/rules 
> override_dh_auto_install
> but this doesnt seem to be working.  If you have any thoughts on this I
> would be very grateful - for the moment I've created a unix-and-linux
> stackexchange question and I hope someone can answer:
>
>  -
> http://unix.stackexchange.com/questions/250683/how-to-remove-a-license-file-when-debian-packaging-using-autotools-automake#250683
>
> thanks
>
> David
>
>  -
>
> On 21 December 2015 at 09:20, Gianfranco Costamagna <
> costamagnagianfra...@yahoo.it> wrote:
>
>> Hi,
>>
>>
>>
>> the package looks really nice now!
>>
>> however there still are some minor issues here
>>
>> http://debomatic-amd64.debian.net/distribution#unstable/rhythmbox-plugin-alternative-toolbar/0.15.0-1/lintian
>>
>> can you please address them? the package works in both debian and ubuntu.
>>
>> I have a few questions:
>> 1) isn't python3 a runtime dependency? (not a problem, because seems that
>> rhythmbox already depends on it)
>> 2) why didn't you upstream the plugin into the rhythmbox-plugins package?
>> https://packages.qa.debian.org/r/rhythmbox.html
>>
>> thanks,
>>
>> Gianfranco
>>
>
>

Bug#804100: RFS: rhythmbox-plugin-alternative-toolbar/0.14.0-1~debian [ITP]

[Gianfranco Costamagna]

Hi,



the package looks really nice now!

however there still are some minor issues here
http://debomatic-amd64.debian.net/distribution#unstable/rhythmbox-plugin-alternative-toolbar/0.15.0-1/lintian

can you please address them? the package works in both debian and ubuntu.

I have a few questions:
1) isn't python3 a runtime dependency? (not a problem, because seems that 
rhythmbox already depends on it)
2) why didn't you upstream the plugin into the rhythmbox-plugins package?
https://packages.qa.debian.org/r/rhythmbox.html

thanks,

Gianfranco

Bug#804100: RFS: rhythmbox-plugin-alternative-toolbar/0.14.0-1~debian [ITP]

[foss.freedom]

Many thanks Gianfranco,

  to answer your questions

1. python3 - yes I should include this as a dependency - you are correct
rhythmbox does have a dependency - but belt-and-braces
2. When the topic of changing the interface for rhythmbox came up on a
bugzilla report, the rhythmbox maintainer dismissed very quickly the
approach of using a python3 plugin.  Thus I havent attempted to upstream
this

 - https://bugzilla.gnome.org/show_bug.cgi?id=735648

With regards to the lintian report:

1.  W: rhythmbox-plugin-alternative-toolbar source:
build-depends-on-python-dev-with-no-arch-any

There is no reason for the package to have a build-depends on python3-dev
so I'll remove this.

2. P: rhythmbox-plugin-alternative-toolbar source:
debian-watch-may-check-gpg-signature

No idea on this - dont think GitHub provides a means to gpg-signature the
tar.gz tag file

3. P: rhythmbox-plugin-alternative-toolbar: no-upstream-changelog

Think this means I need to change my source and thus bump the version. If
you don't mind I would like to bump this into a future version of the
plugin.

4. I: rhythmbox-plugin-alternative-toolbar:
capitalization-error-in-description Gnome GNOME

Doh! - yes, quite correct - I'll change all references for Gnome to GNOME
in the description

5. W: rhythmbox-plugin-alternative-toolbar: extra-license-file
usr/lib/rhythmbox/plugins/alternative-toolbar/LICENSE

I'm not sure how to do this - I thought of using a debian/rules
override_dh_auto_install
but this doesnt seem to be working.  If you have any thoughts on this I
would be very grateful - for the moment I've created a unix-and-linux
stackexchange question and I hope someone can answer:

 -
http://unix.stackexchange.com/questions/250683/how-to-remove-a-license-file-when-debian-packaging-using-autotools-automake#250683

thanks

David

 -

On 21 December 2015 at 09:20, Gianfranco Costamagna <
costamagnagianfra...@yahoo.it> wrote:

> Hi,
>
>
>
> the package looks really nice now!
>
> however there still are some minor issues here
>
> http://debomatic-amd64.debian.net/distribution#unstable/rhythmbox-plugin-alternative-toolbar/0.15.0-1/lintian
>
> can you please address them? the package works in both debian and ubuntu.
>
> I have a few questions:
> 1) isn't python3 a runtime dependency? (not a problem, because seems that
> rhythmbox already depends on it)
> 2) why didn't you upstream the plugin into the rhythmbox-plugins package?
> https://packages.qa.debian.org/r/rhythmbox.html
>
> thanks,
>
> Gianfranco
>

Bug#804100: RFS: rhythmbox-plugin-alternative-toolbar/0.14.0-1~debian [ITP]

[foss.freedom]

Gianfranco,

* Package name: rhythmbox-plugin-alternative-toolbar
   Version : 0.15.0-1
I've uploaded a newer version with a new autotools build mechanism here:
  http://mentors.debian.net/package/rhythmbox-plugin-alternative-toolbar

  Alternatively, one can download the package with dget using this command:

dget -x 
http://mentors.debian.net/debian/pool/main/r/rhythmbox-plugin-alternative-toolbar/rhythmbox-plugin-alternative-toolbar_0.15.0-1.dsc

In this version, the build mechanism has been completely reworked - it
now uses autotools rather than the bespoke installer in the previous
version.

I've tested this version via Launchpad for Ubuntu - I've kept all of
your recommended Debian package specifics.

thanks

David


On 22 November 2015 at 11:46, Gianfranco Costamagna <
costamagnagianfra...@yahoo.it> wrote:

> Hi, no, I'm just too busy to look at the package again
>
> the automated mails are just fixing title, and something more, there is no
> action needed from your side :)
>
>
> there are ~30 packages to look at, and I'll be back as soon as I recover
> from many of them :)
>
> cheers,
>
> G.
>
>
>
>
> Il Venerdì 20 Novembre 2015 14:44, foss.freedom 
> ha scritto:
>
>
>
> Hi Gianfranco,
>
>
>  re: RFS: rhythmbox-plugin-alternative-toolbar/0.14.1-1 [ITP]
>
>   sorry to re-ask this, any thoughts/changes etc that I need to do to
> progress this package?
>
> Cheers
>
>
> David
>

Bug#804100: RFS: rhythmbox-plugin-alternative-toolbar/0.14.0-1~debian [ITP]

[Gianfranco Costamagna]

Hi, no, I'm just too busy to look at the package again

the automated mails are just fixing title, and something more, there is no 
action needed from your side :)


there are ~30 packages to look at, and I'll be back as soon as I recover from 
many of them :)

cheers,

G.




Il Venerdì 20 Novembre 2015 14:44, foss.freedom  ha 
scritto:



Hi Gianfranco,
 

 re: RFS: rhythmbox-plugin-alternative-toolbar/0.14.1-1 [ITP]
 
  sorry to re-ask this, any thoughts/changes etc that I need to do to progress 
this package?

Cheers


David

Bug#804100: RFS: rhythmbox-plugin-alternative-toolbar/0.14.0-1~debian [ITP]

[foss.freedom]

Hi Gianfranco,

 re: RFS: rhythmbox-plugin-alternative-toolbar/0.14.1-1 [ITP]

  sorry to re-ask this, any thoughts/changes etc that I need to do to
progress this package?

Cheers

David

Bug#804100: RFS: rhythmbox-plugin-alternative-toolbar/0.14.0-1~debian [ITP]

[foss.freedom]

Hi Gianfranco,

  quick question - I received what looks like some sort of automated emails
- not sure what these mean - do I need to-do anything?

thanks in advance.

"> block 804192 by 804100
Bug #804192 [wnpp] ITP: rhythmbox-plugin-alternative-toolbar -- Replace the
Rhythmbox large toolbar with a Client-Side Decorated or Compact Toolbar
which can be hidden
804192 was not blocked by any bugs.
804192 was not blocking any bugs.
Added blocking bug(s) of 804192: 804100
> stop
Stopping processing here."

and

"Processing commands for cont...@bugs.debian.org:

> retitle 804100 RFS: rhythmbox-plugin-alternative-toolbar/0.14.1-1 [ITP]
Bug #804100 [sponsorship-requests] RFS:
rhythmbox-plugin-alternative-toolbar/0.14.0-1~debian [ITP]
Changed Bug title to 'RFS: rhythmbox-plugin-alternative-toolbar/0.14.1-1
[ITP]' from 'RFS: rhythmbox-plugin-alternative-toolbar/0.14.0-1~debian
[ITP]'
> stop
Stopping processing here.

Please contact me if you need assistance."




On 7 November 2015 at 00:35, foss.freedom  wrote:

> Gianfranco,
>
>   as you have recommended I have revamped the package.  This has been
> uploaded to mentors.debian.net
>
> dget -x 
> http://mentors.debian.net/debian/pool/main/r/rhythmbox-plugin-alternative-toolbar/rhythmbox-plugin-alternative-toolbar_0.14.1-1.dsc
>
>
>  The package now just uses the Github tarball - I no longer build this
> separately.
>
>  The change log has a close statement with the ITP WNPP bug number
>
>  The control description and extended description fields have been
> reworked.
>
>  In terms of the my Githhub repository - again as you have recommended,
> the debian subfolder and gentoo subfolders are now in their own branches.
> This should make maintenance  of the package easier moving forward.
>
> thanks
>
> David (fossfreedom)
>
> On 6 November 2015 at 13:50, Gianfranco Costamagna <
> costamagnagianfra...@yahoo.it> wrote:
>
>> Hi,
>>
>> >"Description: Show or hide the main toolbar for Rhythmbox"
>> >
>> >Maybe something like this is better?
>> >
>> >"Description: a Rhythmbox 3.x plugin that provides an enhanced toolbar
>> capability.
>> >  A compact toolbar with enhanced song seek capabilities.
>> >  A revised graphical interface using the Gnome Headerbar is also
>> available.
>> >
>> >  A new simpler sidebar with refreshed icons is optionally available."
>>
>>
>> yes, the problem is the extended description, that should have something
>> (look at some packages in the archive for references)
>>
>> >The Git tarball as far as I understand it is a snapshot of the
>> particular commit - e.g. v0.14.1
>>
>>
>> yes, the tag
>> >This tarball would include all the sourcetree files including the files
>> you said I shouldnt include in the debian package - the .git folder, the
>> tar.gz file etc.
>>
>>
>> there arent any tar.gz or git files AFAIK (well, one single tar.gz file
>> but we can leave with it).
>>
>> I would suggest you moving gentoo and debian in separate branches, to
>> avoid the need to release a new upstream release when a packaging bug is
>> fixed.
>>
>> I can live with some useless files in the source tarball, as long as no
>> repackage is needed (and it seems to be not the case)
>>
>>
>> >Maybe I'm just building the debian package in the wrong manner.  I'm
>> doing the following at the moment:
>> >
>> >
>> >git clone https://github.com/fossfreedom/alternative-toolbar
>> >
>> >cd alternative-toolbar
>> >
>> >dch -i
>> >
>> >   add the new upstream version and change log
>> >
>> >cd ..
>> >
>> >cd rhythmbox-plugin-alternative-toolbar-0.14.1
>> >
>> >dh_make --createorig
>> >
>> >debuild -S -k0x[gpg key]
>> >
>> >
>> >should I miss out the dh_make --createorig step that creates the package
>> tarball but instead download the GitHub tag tarball (.tar.gz file) and
>> rename it >appropriately?
>>
>>
>> yes.
>>
>> download the tarball (uscan does this for you when you have a watch file)
>>
>>
>> call it something like
>>
>> rhythmbox-plugin-alternative-toolbar_0.14.1.orig.tar.gz
>>
>>
>> extract, copy the debian directory inside (if you start to have a
>> separate branch)
>>
>> debuild -S or dpkg-buildpackage -S  or whatever
>>
>> live happy :)
>>
>> >Then within the folder rhythmbox-plugin-alterative-toolbar-0.14.1 delete
>> the files and folders you have recommended that should not packaged?
>>
>> nope, they are a few kb of files, you can leave them
>>
>> >I thought debuild would then complain because the package contents no
>> longer match the tarball contents - or is there a debuild option here that
>> can help?
>>
>>
>> this is true for modifications, not for deletions.
>>
>> >thanks
>>
>>
>> yw
>>
>> G.
>>
>>
>> On 6 November 2015 at 12:35, Gianfranco Costamagna <
>> costamagnagianfra...@yahoo.it> wrote:
>>
>> Hi,
>> >
>> >
>> >>I've never heard of pyflakes and pyflakes3 - so thanks for introducing
>> me to these tools.  I've run these and they no longer throw errors out.
>> >
>> >
>> >wonderful
>> >>I've run your PEP8 command.  The vast 

Bug#804100: RFS: rhythmbox-plugin-alternative-toolbar/0.14.0-1~debian [ITP]

[foss.freedom]

Gianfranco,

  as you have recommended I have revamped the package.  This has been
uploaded to mentors.debian.net

dget -x 
http://mentors.debian.net/debian/pool/main/r/rhythmbox-plugin-alternative-toolbar/rhythmbox-plugin-alternative-toolbar_0.14.1-1.dsc


 The package now just uses the Github tarball - I no longer build this
separately.

 The change log has a close statement with the ITP WNPP bug number

 The control description and extended description fields have been
reworked.

 In terms of the my Githhub repository - again as you have recommended, the
debian subfolder and gentoo subfolders are now in their own branches.  This
should make maintenance  of the package easier moving forward.

thanks

David (fossfreedom)

On 6 November 2015 at 13:50, Gianfranco Costamagna <
costamagnagianfra...@yahoo.it> wrote:

> Hi,
>
> >"Description: Show or hide the main toolbar for Rhythmbox"
> >
> >Maybe something like this is better?
> >
> >"Description: a Rhythmbox 3.x plugin that provides an enhanced toolbar
> capability.
> >  A compact toolbar with enhanced song seek capabilities.
> >  A revised graphical interface using the Gnome Headerbar is also
> available.
> >
> >  A new simpler sidebar with refreshed icons is optionally available."
>
>
> yes, the problem is the extended description, that should have something
> (look at some packages in the archive for references)
>
> >The Git tarball as far as I understand it is a snapshot of the particular
> commit - e.g. v0.14.1
>
>
> yes, the tag
> >This tarball would include all the sourcetree files including the files
> you said I shouldnt include in the debian package - the .git folder, the
> tar.gz file etc.
>
>
> there arent any tar.gz or git files AFAIK (well, one single tar.gz file
> but we can leave with it).
>
> I would suggest you moving gentoo and debian in separate branches, to
> avoid the need to release a new upstream release when a packaging bug is
> fixed.
>
> I can live with some useless files in the source tarball, as long as no
> repackage is needed (and it seems to be not the case)
>
>
> >Maybe I'm just building the debian package in the wrong manner.  I'm
> doing the following at the moment:
> >
> >
> >git clone https://github.com/fossfreedom/alternative-toolbar
> >
> >cd alternative-toolbar
> >
> >dch -i
> >
> >   add the new upstream version and change log
> >
> >cd ..
> >
> >cd rhythmbox-plugin-alternative-toolbar-0.14.1
> >
> >dh_make --createorig
> >
> >debuild -S -k0x[gpg key]
> >
> >
> >should I miss out the dh_make --createorig step that creates the package
> tarball but instead download the GitHub tag tarball (.tar.gz file) and
> rename it >appropriately?
>
>
> yes.
>
> download the tarball (uscan does this for you when you have a watch file)
>
>
> call it something like
>
> rhythmbox-plugin-alternative-toolbar_0.14.1.orig.tar.gz
>
>
> extract, copy the debian directory inside (if you start to have a separate
> branch)
>
> debuild -S or dpkg-buildpackage -S  or whatever
>
> live happy :)
>
> >Then within the folder rhythmbox-plugin-alterative-toolbar-0.14.1 delete
> the files and folders you have recommended that should not packaged?
>
> nope, they are a few kb of files, you can leave them
>
> >I thought debuild would then complain because the package contents no
> longer match the tarball contents - or is there a debuild option here that
> can help?
>
>
> this is true for modifications, not for deletions.
>
> >thanks
>
>
> yw
>
> G.
>
>
> On 6 November 2015 at 12:35, Gianfranco Costamagna <
> costamagnagianfra...@yahoo.it> wrote:
>
> Hi,
> >
> >
> >>I've never heard of pyflakes and pyflakes3 - so thanks for introducing
> me to these tools.  I've run these and they no longer throw errors out.
> >
> >
> >wonderful
> >>I've run your PEP8 command.  The vast majority of the PEP8 issues have
> now been addressed.  For some reason it is picking out whitespace issues
> with documentation >comments.
> >
> >
> >well, they are many false positive in the above tools :)
> >
> >>There are one-or-two slightly too long PEP8 lines left.  I've left these
> since the readability is important.
> >
> >
> >sure, not a problem at all
> >>The find statement is worrying me.  All the translations have been
> exported directly from launchpad.net where the application is actually
> translated by the >wonderful launchpad translation team.  I dont really
> have any control as to the output from launchpad.
> >
> >
> >fine then :)
> >
> >>Is there a way to "cleanup" these translation po's ?  A quick google
> didnt reveal much.
> >
> >
> >I guess not, maybe poedit fills the files when updating, but I don't know
> about another way, you can leave them
> >>With regards to the source package - I've introduced a cleanup script on
> the git project called "debian_cleanup.sh" - this removes the .git folder,
> .idea folder, >the install.sh and the tar.gz file you asked me to remove.
> >
> >
> >sorry but I fail to understand what is the problem in using the git tag
> 

Bug#804100: RFS: rhythmbox-plugin-alternative-toolbar/0.14.0-1~debian [ITP]

[Gianfranco Costamagna]

Hi,


>I've never heard of pyflakes and pyflakes3 - so thanks for introducing me to 
>these tools.  I've run these and they no longer throw errors out.


wonderful
>I've run your PEP8 command.  The vast majority of the PEP8 issues have now 
>been addressed.  For some reason it is picking out whitespace issues with 
>documentation >comments.


well, they are many false positive in the above tools :)

>There are one-or-two slightly too long PEP8 lines left.  I've left these since 
>the readability is important.


sure, not a problem at all
>The find statement is worrying me.  All the translations have been exported 
>directly from launchpad.net where the application is actually translated by 
>the >wonderful launchpad translation team.  I dont really have any control as 
>to the output from launchpad.


fine then :)

>Is there a way to "cleanup" these translation po's ?  A quick google didnt 
>reveal much.


I guess not, maybe poedit fills the files when updating, but I don't know about 
another way, you can leave them
>With regards to the source package - I've introduced a cleanup script on the 
>git project called "debian_cleanup.sh" - this removes the .git folder, .idea 
>folder, >the install.sh and the tar.gz file you asked me to remove.  


sorry but I fail to understand what is the problem in using the git tag tarball
https://github.com/fossfreedom/alternative-toolbar/releases/tag/v0.14.1

when you tag github automagically creates a tarball for you.

I don't care about saving 10k tarball, I care about you not being forced to 
create a new tarball each release, and letting github do its job
(and watch file getting the correct tarball with "uscan")


maybe you need to repack the source because the github tarball is missing 
something, I don't know, but I would like to see you using it if possible

>I have run this script before running dh_make --createorig and debuild


this is fine, but difficult to maintain, and useless when github does a good 
job in tarball creation

>The other debian package issues have been addressed (I think).


I still see priority: extra instead of optional, and a really really little 
package Description :)



>- https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=804192
>
>I don't see how I can close this bug report as you requested.
>
>Also - I dont really understand what you want me to add to the changelog file 
>- something like this?
>
>* ITP: 804192
>* Initial Debian release



You close bugs by mentioning them in changelog with the "#" char.

e.g.

Initial release. (Closes: #804192)

the Closes: # is for Debian bugs, while
LP: # is for Ubuntu bugs.

(some magic detects the syntax in the changelog and sends a close to the bug 
automagically)


HTH,

G.

On 5 November 2015 at 17:48, Gianfranco Costamagna 
 wrote:

Control: owner -1 !
>Control: tags -1 moreinfo
>
>Hi
>let's review:
>
>
>1) changelog: you need to have only one entry and an ITP bug closed
>https://www.debian.org/devel/wnpp/
>2) changelog: ~debian makes no sense, please remove
>3) compat: 9
>4) control: debhelper (>=9)
>   std-version 3.9.6
>   priority: optional
>
>5) copyright:
>./alttoolbar_rb3compat.py:# Copyright (C) 2012 - Agustin Carrasco
>
>
>missing
>
>years are outdated "2014" is not good, I would say "xxx-2015" where xxx is the 
>first copyright
>
>Also the first line I guess should use this url
>Format: http://www.debian.org/doc/packaging-manuals/copyright-format/1.0/
>(not sure if they are the same)
>
>6) tarball seems to be not the upstream downloadable from github one
>(also it contains the git history)
>
>7) debian/docs: empty?
>please add something or drop it
>(bonus point, use something to translate README.md into a pdf/html page?)
>
>
>8) debian/watch file is missing please add one
>https://wiki.debian.org/debian/watch
>
>check-all-the-things:
>
>$ grep -riE 'fixme|todo|hack|xxx' .
>./alttoolbar_repeat.py:# will be the hacky solution
>./alttoolbar_repeat.py:# This is a hacky old method to 'repeat' the 
>current song as soon as it
>./alttoolbar_repeat.py:# This is a hacky old method to 'repeat' the 
>current song as soon as it
>
>
>$ suspicious-source
>./img/rb-symbolic-icons.tar.gz
>
>
>$ pyflakes .
>(lot of stuff)
>
>
>$ pyflakes3 .
>(lot of stuff)
>
>$ pep8 --ignore W191 .
>
>(lot of stuff)
>
>
>$ find -type f \( -iname '*.po' -o -iname '*.pot' \) -exec msgfmt --check 
>--check-compatibility --check-accelerators --output-file=/dev/null {} \;
>(lot of stuff)
>
>
>
>
>Please note: some of them might be nitpicks/false positive, please check and 
>report back :)
>
>thanks!
>
>(I know it is a lot of work, but the initial review is always the most 
>difficult for both parts)
>
>cheers,
>
>Gianfranco
>

Bug#804100: RFS: rhythmbox-plugin-alternative-toolbar/0.14.0-1~debian [ITP]

[foss.freedom]

Thanks Gianfranco,

  I'll update the changelog as suggested.

The control file has the following description:

"Description: Show or hide the main toolbar for Rhythmbox"

Maybe something like this is better?

"Description: a Rhythmbox 3.x plugin that provides an enhanced toolbar
capability.
  A compact toolbar with enhanced song seek capabilities.
  A revised graphical interface using the Gnome Headerbar is also available.
  A new simpler sidebar with refreshed icons is optionally available."

The Git tarball as far as I understand it is a snapshot of the particular
commit - e.g. v0.14.1

This tarball would include all the sourcetree files including the files you
said I shouldnt include in the debian package - the .git folder, the tar.gz
file etc.


Maybe I'm just building the debian package in the wrong manner.  I'm doing
the following at the moment:

git clone https://github.com/fossfreedom/alternative-toolbar
cd alternative-toolbar
dch -i
   add the new upstream version and change log
cd ..
cd rhythmbox-plugin-alternative-toolbar-0.14.1
dh_make --createorig
debuild -S -k0x[gpg key]

should I miss out the dh_make --createorig step that creates the package
tarball but instead download the GitHub tag tarball (.tar.gz file) and
rename it appropriately?

Then within the folder rhythmbox-plugin-alterative-toolbar-0.14.1 delete
the files and folders you have recommended that should not packaged?

I thought debuild would then complain because the package contents no
longer match the tarball contents - or is there a debuild option here that
can help?

thanks

David

On 6 November 2015 at 12:35, Gianfranco Costamagna <
costamagnagianfra...@yahoo.it> wrote:

> Hi,
>
>
> >I've never heard of pyflakes and pyflakes3 - so thanks for introducing me
> to these tools.  I've run these and they no longer throw errors out.
>
>
> wonderful
> >I've run your PEP8 command.  The vast majority of the PEP8 issues have
> now been addressed.  For some reason it is picking out whitespace issues
> with documentation >comments.
>
>
> well, they are many false positive in the above tools :)
>
> >There are one-or-two slightly too long PEP8 lines left.  I've left these
> since the readability is important.
>
>
> sure, not a problem at all
> >The find statement is worrying me.  All the translations have been
> exported directly from launchpad.net where the application is actually
> translated by the >wonderful launchpad translation team.  I dont really
> have any control as to the output from launchpad.
>
>
> fine then :)
>
> >Is there a way to "cleanup" these translation po's ?  A quick google
> didnt reveal much.
>
>
> I guess not, maybe poedit fills the files when updating, but I don't know
> about another way, you can leave them
> >With regards to the source package - I've introduced a cleanup script on
> the git project called "debian_cleanup.sh" - this removes the .git folder,
> .idea folder, >the install.sh and the tar.gz file you asked me to remove.
>
>
> sorry but I fail to understand what is the problem in using the git tag
> tarball
> https://github.com/fossfreedom/alternative-toolbar/releases/tag/v0.14.1
>
> when you tag github automagically creates a tarball for you.
>
> I don't care about saving 10k tarball, I care about you not being forced
> to create a new tarball each release, and letting github do its job
> (and watch file getting the correct tarball with "uscan")
>
>
> maybe you need to repack the source because the github tarball is missing
> something, I don't know, but I would like to see you using it if possible
>
> >I have run this script before running dh_make --createorig and debuild
>
>
> this is fine, but difficult to maintain, and useless when github does a
> good job in tarball creation
>
> >The other debian package issues have been addressed (I think).
>
>
> I still see priority: extra instead of optional, and a really really
> little package Description :)
>
>
>
> >- https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=804192
> >
> >I don't see how I can close this bug report as you requested.
> >
> >Also - I dont really understand what you want me to add to the changelog
> file - something like this?
> >
> >* ITP: 804192
> >* Initial Debian release
>
>
>
> You close bugs by mentioning them in changelog with the "#" char.
>
> e.g.
>
> Initial release. (Closes: #804192)
>
> the Closes: # is for Debian bugs, while
> LP: # is for Ubuntu bugs.
>
> (some magic detects the syntax in the changelog and sends a close to the
> bug automagically)
>
>
> HTH,
>
> G.
>
> On 5 November 2015 at 17:48, Gianfranco Costamagna <
> costamagnagianfra...@yahoo.it> wrote:
>
> Control: owner -1 !
> >Control: tags -1 moreinfo
> >
> >Hi
> >let's review:
> >
> >
> >1) changelog: you need to have only one entry and an ITP bug closed
> >https://www.debian.org/devel/wnpp/
> >2) changelog: ~debian makes no sense, please remove
> >3) compat: 9
> >4) control: debhelper (>=9)
> >   std-version 3.9.6
> >   priority: optional
> >
> >5) 

Bug#804100: RFS: rhythmbox-plugin-alternative-toolbar/0.14.0-1~debian [ITP]

[Gianfranco Costamagna]

Hi,

>"Description: Show or hide the main toolbar for Rhythmbox"
>
>Maybe something like this is better?
>
>"Description: a Rhythmbox 3.x plugin that provides an enhanced toolbar 
>capability.
>  A compact toolbar with enhanced song seek capabilities.
>  A revised graphical interface using the Gnome Headerbar is also available.
>
>  A new simpler sidebar with refreshed icons is optionally available."


yes, the problem is the extended description, that should have something
(look at some packages in the archive for references)

>The Git tarball as far as I understand it is a snapshot of the particular 
>commit - e.g. v0.14.1


yes, the tag
>This tarball would include all the sourcetree files including the files you 
>said I shouldnt include in the debian package - the .git folder, the tar.gz 
>file etc.


there arent any tar.gz or git files AFAIK (well, one single tar.gz file but we 
can leave with it).

I would suggest you moving gentoo and debian in separate branches, to avoid the 
need to release a new upstream release when a packaging bug is fixed.

I can live with some useless files in the source tarball, as long as no 
repackage is needed (and it seems to be not the case)


>Maybe I'm just building the debian package in the wrong manner.  I'm doing the 
>following at the moment:
>
>
>git clone https://github.com/fossfreedom/alternative-toolbar
>
>cd alternative-toolbar
>
>dch -i 
>
>   add the new upstream version and change log
>
>cd ..
>
>cd rhythmbox-plugin-alternative-toolbar-0.14.1
>
>dh_make --createorig
>
>debuild -S -k0x[gpg key]
>
>
>should I miss out the dh_make --createorig step that creates the package 
>tarball but instead download the GitHub tag tarball (.tar.gz file) and rename 
>it >appropriately?


yes.

download the tarball (uscan does this for you when you have a watch file)


call it something like

rhythmbox-plugin-alternative-toolbar_0.14.1.orig.tar.gz


extract, copy the debian directory inside (if you start to have a separate 
branch)

debuild -S or dpkg-buildpackage -S  or whatever

live happy :)

>Then within the folder rhythmbox-plugin-alterative-toolbar-0.14.1 delete the 
>files and folders you have recommended that should not packaged?

nope, they are a few kb of files, you can leave them

>I thought debuild would then complain because the package contents no longer 
>match the tarball contents - or is there a debuild option here that can help?


this is true for modifications, not for deletions.

>thanks


yw

G.


On 6 November 2015 at 12:35, Gianfranco Costamagna 
 wrote:

Hi,
>
>
>>I've never heard of pyflakes and pyflakes3 - so thanks for introducing me to 
>>these tools.  I've run these and they no longer throw errors out.
>
>
>wonderful
>>I've run your PEP8 command.  The vast majority of the PEP8 issues have now 
>>been addressed.  For some reason it is picking out whitespace issues with 
>>documentation >comments.
>
>
>well, they are many false positive in the above tools :)
>
>>There are one-or-two slightly too long PEP8 lines left.  I've left these 
>>since the readability is important.
>
>
>sure, not a problem at all
>>The find statement is worrying me.  All the translations have been exported 
>>directly from launchpad.net where the application is actually translated by 
>>the >wonderful launchpad translation team.  I dont really have any control as 
>>to the output from launchpad.
>
>
>fine then :)
>
>>Is there a way to "cleanup" these translation po's ?  A quick google didnt 
>>reveal much.
>
>
>I guess not, maybe poedit fills the files when updating, but I don't know 
>about another way, you can leave them
>>With regards to the source package - I've introduced a cleanup script on the 
>>git project called "debian_cleanup.sh" - this removes the .git folder, .idea 
>>folder, >the install.sh and the tar.gz file you asked me to remove.
>
>
>sorry but I fail to understand what is the problem in using the git tag tarball
>https://github.com/fossfreedom/alternative-toolbar/releases/tag/v0.14.1
>
>when you tag github automagically creates a tarball for you.
>
>I don't care about saving 10k tarball, I care about you not being forced to 
>create a new tarball each release, and letting github do its job
>(and watch file getting the correct tarball with "uscan")
>
>
>maybe you need to repack the source because the github tarball is missing 
>something, I don't know, but I would like to see you using it if possible
>
>>I have run this script before running dh_make --createorig and debuild
>
>
>this is fine, but difficult to maintain, and useless when github does a good 
>job in tarball creation
>
>>The other debian package issues have been addressed (I think).
>
>
>I still see priority: extra instead of optional, and a really really little 
>package Description :)
>
>
>
>>- https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=804192
>>
>>I don't see how I can close this bug report as you requested.
>>
>>Also - I dont really understand what 

Bug#804100: RFS: rhythmbox-plugin-alternative-toolbar/0.14.0-1~debian [ITP]

[Gianfranco Costamagna]

Control: owner -1 !
Control: tags -1 moreinfo

Hi
let's review:


1) changelog: you need to have only one entry and an ITP bug closed
https://www.debian.org/devel/wnpp/
2) changelog: ~debian makes no sense, please remove
3) compat: 9
4) control: debhelper (>=9)
   std-version 3.9.6
   priority: optional

5) copyright:
./alttoolbar_rb3compat.py:# Copyright (C) 2012 - Agustin Carrasco


missing

years are outdated "2014" is not good, I would say "xxx-2015" where xxx is the 
first copyright

Also the first line I guess should use this url
Format: http://www.debian.org/doc/packaging-manuals/copyright-format/1.0/
(not sure if they are the same)

6) tarball seems to be not the upstream downloadable from github one
(also it contains the git history)

7) debian/docs: empty?
please add something or drop it
(bonus point, use something to translate README.md into a pdf/html page?)


8) debian/watch file is missing please add one
https://wiki.debian.org/debian/watch

check-all-the-things:

$ grep -riE 'fixme|todo|hack|xxx' .
./alttoolbar_repeat.py:# will be the hacky solution
./alttoolbar_repeat.py:# This is a hacky old method to 'repeat' the current 
song as soon as it
./alttoolbar_repeat.py:# This is a hacky old method to 'repeat' the current 
song as soon as it


$ suspicious-source
./img/rb-symbolic-icons.tar.gz


$ pyflakes .
(lot of stuff)


$ pyflakes3 .
(lot of stuff)

$ pep8 --ignore W191 .

(lot of stuff)


$ find -type f \( -iname '*.po' -o -iname '*.pot' \) -exec msgfmt --check 
--check-compatibility --check-accelerators --output-file=/dev/null {} \;
(lot of stuff)




Please note: some of them might be nitpicks/false positive, please check and 
report back :)

thanks!

(I know it is a lot of work, but the initial review is always the most 
difficult for both parts)

cheers,

Gianfranco

Bug#804100: RFS: rhythmbox-plugin-alternative-toolbar/0.14.0-1~debian [ITP]

[foss.freedom]

Gianfranco,

  many many thanks for spending the time looking at this and giving me some
very valuable feedback.  It has been much appreciated.

* Package name: rhythmbox-plugin-alternative-toolbar
   Version : 0.14.1-1
I've uploaded a newer version with various suggested fixes here:
  http://mentors.debian.net/package/rhythmbox-plugin-alternative-toolbar

  Alternatively, one can download the package with dget using this command:

dget -x 
http://mentors.debian.net/debian/pool/main/r/rhythmbox-plugin-alternative-toolbar/rhythmbox-plugin-alternative-toolbar_0.14.1-1.dsc


I've never heard of pyflakes and pyflakes3 - so thanks for introducing me
to these tools.  I've run these and they no longer throw errors out.

I've run your PEP8 command.  The vast majority of the PEP8 issues have now
been addressed.  For some reason it is picking out whitespace issues with
documentation comments.

There are one-or-two slightly too long PEP8 lines left.  I've left these
since the readability is important.

The find statement is worrying me.  All the translations have been exported
directly from launchpad.net where the application is actually translated by
the wonderful launchpad translation team.  I dont really have any control
as to the output from launchpad.

Is there a way to "cleanup" these translation po's ?  A quick google didnt
reveal much.

With regards to the source package - I've introduced a cleanup script on
the git project called "debian_cleanup.sh" - this removes the .git folder,
.idea folder, the install.sh and the tar.gz file you asked me to remove.

I have run this script before running dh_make --createorig and debuild

The other debian package issues have been addressed (I think).

I've sent an email to the "wnpp" package

 - https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=804192

I don't see how I can close this bug report as you requested.

Also - I dont really understand what you want me to add to the changelog
file - something like this?

 * ITP: 804192
 * Initial Debian release

Thanks

David (fossfreedom)


On 5 November 2015 at 17:48, Gianfranco Costamagna <
costamagnagianfra...@yahoo.it> wrote:

> Control: owner -1 !
> Control: tags -1 moreinfo
>
> Hi
> let's review:
>
>
> 1) changelog: you need to have only one entry and an ITP bug closed
> https://www.debian.org/devel/wnpp/
> 2) changelog: ~debian makes no sense, please remove
> 3) compat: 9
> 4) control: debhelper (>=9)
>std-version 3.9.6
>priority: optional
>
> 5) copyright:
> ./alttoolbar_rb3compat.py:# Copyright (C) 2012 - Agustin Carrasco
>
>
> missing
>
> years are outdated "2014" is not good, I would say "xxx-2015" where xxx is
> the first copyright
>
> Also the first line I guess should use this url
> Format: http://www.debian.org/doc/packaging-manuals/copyright-format/1.0/
> (not sure if they are the same)
>
> 6) tarball seems to be not the upstream downloadable from github one
> (also it contains the git history)
>
> 7) debian/docs: empty?
> please add something or drop it
> (bonus point, use something to translate README.md into a pdf/html page?)
>
>
> 8) debian/watch file is missing please add one
> https://wiki.debian.org/debian/watch
>
> check-all-the-things:
>
> $ grep -riE 'fixme|todo|hack|xxx' .
> ./alttoolbar_repeat.py:# will be the hacky solution
> ./alttoolbar_repeat.py:# This is a hacky old method to 'repeat' the
> current song as soon as it
> ./alttoolbar_repeat.py:# This is a hacky old method to 'repeat' the
> current song as soon as it
>
>
> $ suspicious-source
> ./img/rb-symbolic-icons.tar.gz
>
>
> $ pyflakes .
> (lot of stuff)
>
>
> $ pyflakes3 .
> (lot of stuff)
>
> $ pep8 --ignore W191 .
>
> (lot of stuff)
>
>
> $ find -type f \( -iname '*.po' -o -iname '*.pot' \) -exec msgfmt --check
> --check-compatibility --check-accelerators --output-file=/dev/null {} \;
> (lot of stuff)
>
>
>
>
> Please note: some of them might be nitpicks/false positive, please check
> and report back :)
>
> thanks!
>
> (I know it is a lot of work, but the initial review is always the most
> difficult for both parts)
>
> cheers,
>
> Gianfranco
>

Bug#804100: RFS: rhythmbox-plugin-alternative-toolbar/0.14.0-1~debian [ITP]

[foss.freedom]

Package: sponsorship-requests
Severity: wishlist

Dear Mentors,

I am looking for a sponsor for my package
"rhythmbox-plugin-alternative-toolbar"

* Package name: rhythmbox-plugin-alternative-toolbar
  Version : 0.14.0-1~debian
  Upstream Author : fossfreedom 
* URL : https://github.com/fossfreedom/alternative-toolbar
* License : GPL3+
  Section : gnome

It builds those binary packages:

rhythmbox-plugin-alternative-toolbar - Show or hide the main toolbar
for Rhythmbox

  To access further information about this package, please visit the
following URL:

  http://mentors.debian.net/package/rhythmbox-plugin-alternative-toolbar


  Alternatively, one can download the package with dget using this command:

dget -x
http://mentors.debian.net/debian/pool/main/r/rhythmbox-plugin-alternative-toolbar/rhythmbox-plugin-alternative-toolbar_0.14.0-1~debian.dsc

  More information about rhythmbox-plugin-alternative-toolbar can be
obtained from https://github.com/fossfreedom/alternative-toolbar.
  Additionally I have a blog post about this work here:


https://xpressubuntu.wordpress.com/2015/11/02/rhythmbox-alternative-toolbar-updated/

  Apologies if there are any wrong details here.  A bit about me.  I'm a
python developer mainly dealing with rhythmbox-plugins

  I maintain for Ubuntu a personal package archive of 30+ ubuntu (debian
based) packages:

  https://launchpad.net/~fossfreedom/+archive/ubuntu/rhythmbox-plugins

  This is my first Debian upload.  I note that since I uploaded the package
to mentors.debian.net in "my packages" there was one warning lintian error.

I have fixed this in git - what do i have to do to revise the package on
mentors.debian.net?

Changes since the last upload:

  * initial Debian package

Regards,
David Mohammed (fossfreedom)

-- System Information:
Debian Release: jessie/sid
  APT prefers trusty-updates
  APT policy: (500, 'trusty-updates'), (500, 'trusty-security'), (500,
'trusty'), (100, 'trusty-backports')
Architecture: amd64 (x86_64)
Foreign Architectures: i386

Kernel: Linux 3.13.0-66-generic (SMP w/2 CPU cores)
Locale: LANG=en_GB.UTF-8, LC_CTYPE=en_GB.UTF-8 (charmap=UTF-8)
Shell: /bin/sh linked to /bin/dash