Bug#806198: siscone: FTBFS when built with dpkg-buildpackage -A (dh_testroot in build-indep)

[Santiago Vila]

Greetings.

I have the ok from the Release Managers to consider this issue as RC
for stretch. I'm going to wait at least one week before raising
this to "serious".

There is a patch available for this bug. If you need someone to make
an upload, please ask for a sponsor in debian-mentors.

Thanks.

Bug#806198: siscone: FTBFS when built with dpkg-buildpackage -A (dh_testroot in build-indep)

[Santiago Vila]

tags 806198 + patch
thanks

As explained in the previous message, this is the patch I would apply
if this were my package. Now "dpkg-buildpackage -A" works again.

This is of course a lot better than not working at all, but be careful
because now "dpkg-buildpackage -A" creates a siscone-doc-html package
slightly different than the one it's created without using -A:

Files in first .deb but not in second
-
-rw-r--r--  root/root   
/usr/share/doc/siscone-doc-html/html/devel/config_8h_source.html

This would be a reproducibility issue for which I don't have a fix
and should probably be reported separately.

In either case, please feel free to close this report after
"dpkg-buildpackage -A" works again.

Thanks.--- a/debian/rules
+++ b/debian/rules
@@ -54,14 +54,11 @@ clean:
dh_clean
 
 configure-stamp:
-   dh_testdir
dh_autoreconf
dh_auto_configure -- --libdir=\$${prefix}/lib/$(DEB_HOST_MULTIARCH)
touch $@
 
 doxygen-stamp:
-   dh_testdir
-   dh_testroot
doxygen
touch doxygen-stamp
 

Bug#806198: siscone: FTBFS when built with dpkg-buildpackage -A (dh_testroot in build-indep)

[Santiago Vila]

Package: src:siscone
Version: 2.0.6-1.1
User: sanv...@debian.org
Usertags: binary-indep
Severity: important

Dear maintainer:

I tried to build this package with "dpkg-buildpackage -A"
(i.e. only architecture-independent packages), and it failed:


[...]
 debian/rules build-indep
dh_testdir
dh_testroot
dh_testroot: You must run this as root (or use fakeroot).
debian/rules:63: recipe for target 'doxygen-stamp' failed
make: *** [doxygen-stamp] Error 255
dpkg-buildpackage: error: debian/rules build-indep gave error exit status 2


In this case, debian/rules tries to ensure that you are root in a
target which is not supposed to be executed as root, and it fails.

The way to fix this is up to you, but my own personal preference,
which I would also recommend, is to get rid of each and every
dh_testdir and dh_testroot call.

After all, dpkg-buildpackage already takes care of being root
(or fakeroot) when required, and of course, it does also take care of
being in the right directory. Both things happen by design, so removing
those checks just make debian/rules shorter and easier to understand
without any loss of functionality. It would also make debian/rules
a little bit closer to the minimalistic style that "dh" allows.

Once this issue with dh_testroot is fixed, please ensure that both
"dpkg-buildpackage -A" and "dpkg-buildpackage -B" work. After that,
the package will be suitable to be uploaded in source-only form if you
wish.

Thanks.