Bug#814772: proftpd-basic: includes ~-files in config, incluing a whole directory
tags 814772 + pending stop On 15.02.16 10:51, Harald Witt wrote: > Removing the ~-file "example.conf~" fixed the problem. > But I think it's usual not to include ~-files. > Documented that behavior in config template, so users can care. Tag bug as pending. H. -- sigfault #206401 http://counter.li.org signature.asc Description: OpenPGP digital signature
Bug#814772: proftpd-basic: includes ~-files in config, incluing a whole directory
On 14.12.2016 15:16, Francesco Paolo Lovergine wrote: Hi Francesco, > I would close this bug mainly as an old configuration issue. > > At the time I added Include /etc/proftpd/conf.d > as a way to add a whole set of configuration files. The ~ for backup file is a > convention (e.g. Emacs), so basically any plain file will be included, so the > admin should > ensure to include only valid and not redundant configuration files. > > That said, _now_ I would use something like: > > Include /etc/proftpd/conf.d/*.conf > > which would obsolete this bug. This is _now_ a valid and supported include > clause (not at the time of my first change in the configuration file). > Changing that could add now more headaches for the poor maintainer, with > people complaining about supposed broken configurations and so on. > Meanwhile I agree w/ you that this is not a bug, I'd simply leave a comment in the proftpd.conf that users should care about backup files *~, *.bak etc. Changing the default clause to /etc/proftpd/conf.d/*.conf seems a little bit invasive to me. Hilmar -- #206401 http://counter.li.org
Bug#814772: proftpd-basic: includes ~-files in config, incluing a whole directory
Package: proftpd-basic Followup-For: Bug #814772 I would close this bug mainly as an old configuration issue. At the time I added Include /etc/proftpd/conf.d as a way to add a whole set of configuration files. The ~ for backup file is a convention (e.g. Emacs), so basically any plain file will be included, so the admin should ensure to include only valid and not redundant configuration files. That said, _now_ I would use something like: Include /etc/proftpd/conf.d/*.conf which would obsolete this bug. This is _now_ a valid and supported include clause (not at the time of my first change in the configuration file). Changing that could add now more headaches for the poor maintainer, with people complaining about supposed broken configurations and so on. -- System Information: Debian Release: stretch/sid APT prefers unstable APT policy: (500, 'unstable'), (500, 'testing'), (1, 'experimental') Architecture: amd64 (x86_64) Foreign Architectures: i386 Kernel: Linux 4.8.0-1-amd64 (SMP w/4 CPU cores) Locale: LANG=it_IT.UTF-8, LC_CTYPE=it_IT.UTF-8 (charmap=UTF-8) Shell: /bin/sh linked to /bin/dash Init: systemd (via /run/systemd/system) Versions of packages proftpd-basic depends on: ii adduser3.115 ii debconf1.5.59 ii debianutils4.8.1 ii libacl12.2.52-3 ii libc6 2.24-8 ii libcap21:2.25-1 ii libmemcached11 1.0.18-4.1 ii libmemcachedutil2 1.0.18-4.1 ii libncurses56.0+20161126-1 ii libpam-runtime 1.1.8-3.3 ii libpam0g 1.1.8-3.3 ii libpcre3 2:8.39-2 ii libssl1.0.21.0.2j-4 ii libtinfo5 6.0+20161126-1 ii libwrap0 7.6.q-25 ii lsb-base 9.20161125 ii netbase5.3 ii sed4.2.2-8 ii ucf3.0036 ii zlib1g 1:1.2.8.dfsg-4 proftpd-basic recommends no packages. Versions of packages proftpd-basic suggests: ii openbsd-inetd [inet-superserver] 0.20140418-2 ii openssl 1.1.0c-2 ii proftpd-doc 1.3.5b-1 pn proftpd-mod-geoip pn proftpd-mod-ldap pn proftpd-mod-mysql pn proftpd-mod-odbc pn proftpd-mod-pgsql pn proftpd-mod-sqlite -- debconf information excluded
Bug#814772: proftpd-basic: includes ~-files in config, incluing a whole directory
Package: proftpd-basic Version: 1.3.5-1.1+deb8u1 Severity: normal Dear Maintainer, I included a whole config directory in proftpd.conf: include /etc/proftpd/conf.d/ I created an new config-file example.conf in /etc/proftpd/conf.d/ and edited it multiple times. Restarting proftpt failed. Using "systemctl status proftpd.service" the following error occured: AuthOrder has already been configured on line 8 of '/etc/proftpd/conf.d/example.conf~' Removing the ~-file "example.conf~" fixed the problem. But I think it's usual not to include ~-files. *** Reporter, please consider answering these questions, where appropriate *** * What led up to the situation? * What exactly did you do (or not do) that was effective (or ineffective)? * What was the outcome of this action? * What outcome did you expect instead? *** End of the template - remove these template lines *** -- System Information: Debian Release: 8.3 APT prefers stable APT policy: (500, 'stable') Architecture: amd64 (x86_64) Kernel: Linux 3.16.0-4-amd64 (SMP w/8 CPU cores) Locale: LANG=en_US.UTF-8, LC_CTYPE=en_US.UTF-8 (charmap=UTF-8) Shell: /bin/sh linked to /bin/dash Init: systemd (via /run/systemd/system) Versions of packages proftpd-basic depends on: ii adduser3.113+nmu3 ii debconf1.5.56 ii debianutils4.4+b1 ii libacl12.2.52-2 ii libc6 2.19-18+deb8u2 ii libcap21:2.24-8 ii libmemcached11 1.0.18-4 ii libmemcachedutil2 1.0.18-4 ii libncurses55.9+20140913-1+b1 ii libpam-runtime 1.1.8-3.1+deb8u1 ii libpam0g 1.1.8-3.1+deb8u1 ii libpcre3 2:8.35-3.3+deb8u2 ii libssl1.0.01.0.1k-3+deb8u2 ii libtinfo5 5.9+20140913-1+b1 ii libwrap0 7.6.q-25 ii netbase5.3 ii sed4.2.2-4+b1 ii ucf3.0030 ii zlib1g 1:1.2.8.dfsg-2+b1 proftpd-basic recommends no packages. Versions of packages proftpd-basic suggests: pn openbsd-inetd | inet-superserver ii openssl 1.0.1k-3+deb8u2 pn proftpd-doc pn proftpd-mod-geoip pn proftpd-mod-ldap pn proftpd-mod-mysql pn proftpd-mod-odbc pn proftpd-mod-pgsql pn proftpd-mod-sqlite -- debconf information: * shared/proftpd/inetd_or_standalone: standalone
