Bug#822470: qemu: FTBFS: error: redefinition of 'struct fsxattr'

[James Clarke]

Control: reassign -1 xfsprogs
Control: forcemerge 822369 -1
Control: affects -1 src:qemu

(hopefully I got it right this time…)

> On 27 Apr 2016, at 00:05, James Clarke  wrote:
> 
> Control: package xfsprogs
> Control: forcemerge 822369 -1
> Control: affects -1 src:qemu
> 
> On Wed, 27 Apr 2016 00:02:56 +0200 John Paul Adrian Glaubitz 
>  wrote:
>>> This smells like a bug in the build environment, not in qemu.
>>> There must be ability to include both headers without failing
>>> to build.
>> 
>> Not really. I can reproduce the problem here in my own environment,
>> this used to work before. I assume there were incompatible changes
>> in xfslibs-dev or the kernel.
> 
> This was caused by
> https://github.com/torvalds/linux/commit/2155355fda502e75cd942db101fbb08e1a826ba8

I meant 
https://github.com/torvalds/linux/commit/334e580a6f97e2e84d1c19a8679603956acaa622

> which moved the definition from xfs_fs.h to fs.h.

Regards,
James




signature.asc
Description: Message signed with OpenPGP using GPGMail

Bug#822470: qemu: FTBFS: error: redefinition of 'struct fsxattr'

[James Clarke]

Control: package xfsprogs
Control: forcemerge 822369 -1
Control: affects -1 src:qemu

On Wed, 27 Apr 2016 00:02:56 +0200 John Paul Adrian Glaubitz 
 wrote:
>> This smells like a bug in the build environment, not in qemu.
>> There must be ability to include both headers without failing
>> to build.
> 
> Not really. I can reproduce the problem here in my own environment,
> this used to work before. I assume there were incompatible changes
> in xfslibs-dev or the kernel.

This was caused by
https://github.com/torvalds/linux/commit/2155355fda502e75cd942db101fbb08e1a826ba8
which moved the definition from xfs_fs.h to fs.h.

Regards,
James



signature.asc
Description: Message signed with OpenPGP using GPGMail

Bug#822470: qemu: FTBFS: error: redefinition of 'struct fsxattr'

[John Paul Adrian Glaubitz]

> This smells like a bug in the build environment, not in qemu.
> There must be ability to include both headers without failing
> to build.

Not really. I can reproduce the problem here in my own environment,
this used to work before. I assume there were incompatible changes
in xfslibs-dev or the kernel.

Cheers,

Adrian

-- 
 .''`.  John Paul Adrian Glaubitz
: :' :  Debian Developer - glaub...@debian.org
`. `'   Freie Universitaet Berlin - glaub...@physik.fu-berlin.de
  `-GPG: 62FF 8A75 84E0 2956 9546  0006 7426 3B37 F5B5 F913

Bug#822470: qemu: FTBFS: error: redefinition of 'struct fsxattr'

[Michael Tokarev]

24.04.2016 23:09, Martin Michlmayr wrote:

>> /usr/include/xfs/xfs_fs.h:42:8: error: redefinition of 'struct fsxattr'
>>  struct fsxattr {
>> ^
>> /usr/include/linux/fs.h:155:8: note: originally defined here
>>  struct fsxattr {
>> ^

This smells like a bug in the build environment, not in qemu.
There must be ability to include both headers without failing
to build.

Thanks,

/mjt

Bug#822470: qemu: FTBFS: error: redefinition of 'struct fsxattr'

[Martin Michlmayr]

Package: qemu
Version: 1:2.5+dfsg-5
Severity: serious

This package fails to build in unstable:

> sbuild (Debian sbuild) 0.68.0 (15 Jan 2016) on dl580gen9-02.hlinux
...
> cc -I/<>/qemu-2.5+dfsg/tcg -I/<>/qemu-2.5+dfsg/tcg/i386 
> -I/<>/qemu-2.5+dfsg/linux-headers 
> -I/<>/qemu-2.5+dfsg/qemu-build/linux-headers -I. 
> -I/<>/qemu-2.5+dfsg -I/<>/qemu-2.5+dfsg/include 
> -I/<>/qemu-2.5+dfsg/block -Iblock -I/usr/include/pixman-1  
> -DHAS_LIBSSH2_SFTP_FSYNC -fPIE -DPIE -m64 -D_GNU_SOURCE 
> -D_FILE_OFFSET_BITS=64 -D_LARGEFILE_SOURCE -Wstrict-prototypes 
> -Wredundant-decls -Wall -Wundef -Wwrite-strings -Wmissing-prototypes 
> -fno-strict-aliasing -fno-common  -g -O2 -fstack-protector-strong -Wformat 
> -Werror=format-security -Wdate-time -D_FORTIFY_SOURCE=2 
> -DCONFIG_QEMU_DATAPATH='"/usr/share/qemu:/usr/share/seabios:/usr/lib/ipxe/qemu"'
>  -DVENDOR_DEBIAN -Wendif-labels -Wmissing-include-dirs -Wempty-body 
> -Wnested-externs -Wformat-security -Wformat-y2k -Winit-self 
> -Wignored-qualifiers -Wold-style-declaration -Wold-style-definition 
> -Wtype-limits -fstack-protector-strong  -I/usr/include/p11-kit-1
> -I/usr/incl
> ude/libpng16 -I/usr/include/spice-server -I/usr/include/spice-1 
> -I/usr/include/cacard -I/usr/include/libusb-1.0  
> -I/<>/qemu-2.5+dfsg/tests -MMD -MP -MT block/iscsi.o -MF 
> block/iscsi.d -O2 -U_FORTIFY_SOURCE -D_FORTIFY_SOURCE=2 -pthread 
> -I/usr/include/glib-2.0 -I/usr/lib/x86_64-linux-gnu/glib-2.0/include -pthread 
> -I/usr/include/glib-2.0 -I/usr/lib/x86_64-linux-gnu/glib-2.0/include -g  
> -fPIC -DBUILD_DSO  -c -o block/iscsi.o 
> /<>/qemu-2.5+dfsg/block/iscsi.c
> In file included from /usr/include/xfs/xfs.h:58:0,
>  from /<>/qemu-2.5+dfsg/block/raw-posix.c:97:
> /usr/include/xfs/xfs_fs.h:42:8: error: redefinition of 'struct fsxattr'
>  struct fsxattr {
> ^
> In file included from /<>/qemu-2.5+dfsg/block/raw-posix.c:60:0:
> /usr/include/linux/fs.h:155:8: note: originally defined here
>  struct fsxattr {
> ^
> cc -I/<>/qemu-2.5+dfsg/tcg -I/<>/qemu-2.5+dfsg/tcg/i386 
> -I/<>/qemu-2.5+dfsg/linux-headers 
> -I/<>/qemu-2.5+dfsg/qemu-build/linux-headers -I. 
> -I/<>/qemu-2.5+dfsg -I/<>/qemu-2.5+dfsg/include 
> -I/<>/qemu-2.5+dfsg/block -Iblock -I/usr/include/pixman-1  
> -DHAS_LIBSSH2_SFTP_FSYNC -fPIE -DPIE -m64 -D_GNU_SOURCE 
> -D_FILE_OFFSET_BITS=64 -D_LARGEFILE_SOURCE -Wstrict-prototypes 
> -Wredundant-decls -Wall -Wundef -Wwrite-strings -Wmissing-prototypes 
> -fno-strict-aliasing -fno-common  -g -O2 -fstack-protector-strong -Wformat 
> -Werror=format-security -Wdate-time -D_FORTIFY_SOURCE=2 
> -DCONFIG_QEMU_DATAPATH='"/usr/share/qemu:/usr/share/seabios:/usr/lib/ipxe/qemu"'
>  -DVENDOR_DEBIAN -Wendif-labels -Wmissing-include-dirs -Wempty-body 
> -Wnested-externs -Wformat-security -Wformat-y2k -Winit-self 
> -Wignored-qualifiers -Wold-style-declaration -Wold-style-definition 
> -Wtype-limits -fstack-protector-strong  -I/usr/include/p11-kit-1
> -I/usr/incl
> ude/libpng16 -I/usr/include/spice-server -I/usr/include/spice-1 
> -I/usr/include/cacard -I/usr/include/libusb-1.0  
> -I/<>/qemu-2.5+dfsg/tests -MMD -MP -MT block/curl.o -MF 
> block/curl.d -O2 -U_FORTIFY_SOURCE -D_FORTIFY_SOURCE=2 -pthread 
> -I/usr/include/glib-2.0 -I/usr/lib/x86_64-linux-gnu/glib-2.0/include -pthread 
> -I/usr/include/glib-2.0 -I/usr/lib/x86_64-linux-gnu/glib-2.0/include -g  
> -fPIC -DBUILD_DSO  -c -o block/curl.o /<>/qemu-2.5+dfsg/block/curl.c
> /<>/qemu-2.5+dfsg/rules.mak:57: recipe for target 
> 'block/raw-posix.o' failed
> make[1]: *** [block/raw-posix.o] Error 1

-- 
Martin Michlmayr
Linux for HPE Helion, Hewlett Packard Enterprise