Bug#827923: multipath-tools: lintian errors and warnings

2016-06-23 Thread Ritesh Raj Sarraf
On Wed, 2016-06-22 at 14:32 -0600, Andrew Patterson wrote:
> You are correct, the build was done in jessie. After rebuilding in sid, I get:
> 
> lintian multipath-tools_0.6.1-3_amd64.changes
> W: multipath-tools: package-name-doesnt-match-sonames libmpathcmd0
> libmpathpersist0 libmultipath0
> W: multipath-tools: hardening-no-relro lib/libmpathpersist.so.0
> W: multipath-tools: manpage-has-bad-whatis-entry
> usr/share/man/man3/mpath_persistent_reserve_in.3.gz
> W: multipath-tools: manpage-has-bad-whatis-entry
> usr/share/man/man3/mpath_persistent_reserve_out.3.gz
> W: multipath-tools: manpage-has-errors-from-man
> usr/share/man/man5/multipath.conf.5.gz 239: warning [p 4, 0.0i]: can't break
> line
> W: multipath-tools: manpage-has-bad-whatis-entry
> usr/share/man/man8/mpathpersist.8.gz
> W: multipath-tools: non-dev-pkg-with-shlib-symlink lib/libmpathcmd.so.0
> lib/libmpathcmd.so
> W: multipath-udeb udeb: package-name-doesnt-match-sonames libmultipath0
> N: 5 tags overridden (1 error, 1 warning, 3 info)
> 
> Is it worth it to try and fix these warning? Or at least provide overrides for
> them.

These are good to have fixes. So yes, if you have the time, please do fix them.
But please, no overrides for warnings. They are genuine problems, just wanting
someone's attention and time. The only override we've done is which may have not
applied to the state of multipath-tools.


-- 
Ritesh Raj Sarraf | http://people.debian.org/~rrs
Debian - The Universal Operating System

signature.asc
Description: This is a digitally signed message part


Bug#827923: multipath-tools: lintian errors and warnings

2016-06-22 Thread Andrew Patterson
On Wed, 22 Jun 2016 18:44:49 + Niels Thykier  wrote:
> On Wed, 22 Jun 2016 11:42:54 -0600 Andrew Patterson > 
>  wrote: > > Package: multipath-tools > >
Version: 0.6.1-3 > > > > Hi, > > Please keep me in CC for follow ups on
this if my reply is desired. > > > I get the following errors and
warning when running lintian > > 2.5.44~bpo8+1 on
multipath-tools_0.6.1-3: > > > > [...] > > W: multipath-tools:
maintscript-calls-ldconfig postinst > > E: multipath-tools:
package-must-activate-ldconfig-trigger > > lib/libmultipath.so.0 > > W:
multipath-tools: maintscript-calls-ldconfig postrm > > These 3 can
appear for legitimate reasons if: > > * The build was last done several
months ago, OR > * If done in jessie/jessie-backports (with the jessie
version of > debhelper) > > In the former case, a simple no-change
rebuild will generally fix the > issue (and indeed, the unstable package
does not appear to be affected[1]). > In the latter case, lintian is
simply testing for something that > applies to unstable but not for
jessie. For backports, you can avoid it > by using the debhelper in
jessie-backports; but it is not really necessary. > > Thanks, > ~Niels

You are correct, the build was done in jessie. After rebuilding in sid,
I get:

lintian multipath-tools_0.6.1-3_amd64.changes
W: multipath-tools: package-name-doesnt-match-sonames libmpathcmd0
libmpathpersist0 libmultipath0
W: multipath-tools: hardening-no-relro lib/libmpathpersist.so.0
W: multipath-tools: manpage-has-bad-whatis-entry
usr/share/man/man3/mpath_persistent_reserve_in.3.gz
W: multipath-tools: manpage-has-bad-whatis-entry
usr/share/man/man3/mpath_persistent_reserve_out.3.gz
W: multipath-tools: manpage-has-errors-from-man
usr/share/man/man5/multipath.conf.5.gz 239: warning [p 4, 0.0i]: can't
break line
W: multipath-tools: manpage-has-bad-whatis-entry
usr/share/man/man8/mpathpersist.8.gz
W: multipath-tools: non-dev-pkg-with-shlib-symlink lib/libmpathcmd.so.0
lib/libmpathcmd.so
W: multipath-udeb udeb: package-name-doesnt-match-sonames libmultipath0
N: 5 tags overridden (1 error, 1 warning, 3 info)

Is it worth it to try and fix these warning? Or at least provide
overrides for them.

Andrew

-- 
Andrew Patterson
Hewlett-Packard Enterprise




Bug#827923: multipath-tools: lintian errors and warnings

2016-06-22 Thread Niels Thykier
On Wed, 22 Jun 2016 11:42:54 -0600 Andrew Patterson
 wrote:
> Package: multipath-tools
> Version: 0.6.1-3
> 

Hi,

Please keep me in CC for follow ups on this if my reply is desired.

> I get the following errors and warning when running lintian
> 2.5.44~bpo8+1 on multipath-tools_0.6.1-3:
> 
> [...]
> W: multipath-tools: maintscript-calls-ldconfig postinst
> E: multipath-tools: package-must-activate-ldconfig-trigger
> lib/libmultipath.so.0
> W: multipath-tools: maintscript-calls-ldconfig postrm

These 3 can appear for legitimate reasons if:

 * The build was last done several months ago, OR
 * If done in jessie/jessie-backports (with the jessie version of
   debhelper)

In the former case, a simple no-change rebuild will generally fix the
issue (and indeed, the unstable package does not appear to be affected[1]).
  In the latter case, lintian is simply testing for something that
applies to unstable but not for jessie.  For backports, you can avoid it
by using the debhelper in jessie-backports; but it is not really necessary.

Thanks,
~Niels

[1]
https://lintian.debian.org/maintainer/pkg-lvm-maintain...@lists.alioth.debian.org.html#multipath-tools




signature.asc
Description: OpenPGP digital signature


Bug#827923: multipath-tools: lintian errors and warnings

2016-06-22 Thread Andrew Patterson
Package: multipath-tools
Version: 0.6.1-3

I get the following errors and warning when running lintian
2.5.44~bpo8+1 on multipath-tools_0.6.1-3:

$ lintian multipath-tools_0.6.1-3_amd64.changes
W: multipath-tools: package-name-doesnt-match-sonames libmpathcmd0
libmpathpersist0 libmultipath0
W: multipath-tools: hardening-no-relro lib/libmpathpersist.so.0
W: multipath-tools: manpage-has-bad-whatis-entry
usr/share/man/man3/mpath_persistent_reserve_in.3.gz
W: multipath-tools: manpage-has-bad-whatis-entry
usr/share/man/man3/mpath_persistent_reserve_out.3.gz
W: multipath-tools: manpage-has-errors-from-man
usr/share/man/man5/multipath.conf.5.gz 239: warning [p 4, 0.0i]: can't
break line
W: multipath-tools: manpage-has-bad-whatis-entry
usr/share/man/man8/mpathpersist.8.gz
W: multipath-tools: non-dev-pkg-with-shlib-symlink lib/libmpathcmd.so.0
lib/libmpathcmd.so
W: multipath-tools: maintscript-calls-ldconfig postinst
E: multipath-tools: package-must-activate-ldconfig-trigger
lib/libmultipath.so.0
W: multipath-tools: maintscript-calls-ldconfig postrm
W: multipath-udeb udeb: package-name-doesnt-match-sonames libmultipath0
N: 5 tags overridden (1 error, 1 warning, 3 info)

And here is the output when using --no-overrides:

$ lintian -o multipath-tools_0.6.1-3_amd64.changes
E: multipath-tools-boot: systemd-no-service-for-init-rcS-script
multipath-tools-boot
W: multipath-tools: package-name-doesnt-match-sonames libmpathcmd0
libmpathpersist0 libmultipath0
W: multipath-tools: hardening-no-relro lib/libmpathpersist.so.0
W: multipath-tools: manpage-has-bad-whatis-entry
usr/share/man/man3/mpath_persistent_reserve_in.3.gz
W: multipath-tools: manpage-has-bad-whatis-entry
usr/share/man/man3/mpath_persistent_reserve_out.3.gz
W: multipath-tools: manpage-has-errors-from-man
usr/share/man/man5/multipath.conf.5.gz 239: warning [p 4, 0.0i]: can't
break line
W: multipath-tools: manpage-has-bad-whatis-entry
usr/share/man/man8/mpathpersist.8.gz
W: multipath-tools: non-dev-pkg-with-shlib-symlink
lib/libmpathpersist.so.0 lib/libmpathpersist.so
W: multipath-tools: non-dev-pkg-with-shlib-symlink lib/libmpathcmd.so.0
lib/libmpathcmd.so
W: multipath-tools: maintscript-calls-ldconfig postinst
E: multipath-tools: package-must-activate-ldconfig-trigger
lib/libmultipath.so.0
W: multipath-tools: maintscript-calls-ldconfig postrm
W: multipath-udeb udeb: package-name-doesnt-match-sonames libmultipath0

-- 
Andrew Patterson
Hewlett-Packard Enterprise