Bug#835910: warzone2100: FTBFS when newer automake is installed

2016-09-20 Thread Adrian Bunk
On Wed, Sep 07, 2016 at 01:36:25AM +0200, Santiago Vila wrote:
> reassign 835910 src:warzone2100
> found 835910 3.1.1-3
> forcemerge 835910 824011
> thanks
> 
> On Mon, 29 Aug 2016, Russell Coker wrote:
> 
> > Package: warzone2100
> > Version: 3.1.1-3
> > Severity: serious
> > Tags: upstream patch
> > Justification: fails to build from source (but built successfully in the 
> > past)
> > 
> > The warzone2100 build system insists on automake and aclocal version 1.11.  
> > If
> > you have 1.15 installed it won't build.
> 
> I already reported this as Bug#824011 and suggested using a Build-Conflicts.

Your patch is sufficient, but the patch from Russell is better since it 
doesn't force removal of automake on the build system.

That's not an issue for the kind of builds autobuilders or you are 
doing, but it is annoying when you are forced to temporarily remove 
automake on a normal system.

> You probably didn't see the bug because the maintainer downgraded to "normal".
> 
> Maybe I'm not the only one to think that FTBFS bugs are RC, after all.

I am really surprised anyone disputed that this is RC.

Even more when considering that you already suggested a trivial fix
in the initial bug report.

> Thanks.

cu
Adrian

-- 

   "Is there not promise of rain?" Ling Tan asked suddenly out
of the darkness. There had been need of rain for many days.
   "Only a promise," Lao Er said.
   Pearl S. Buck - Dragon Seed



Bug#835910: warzone2100: FTBFS when newer automake is installed

2016-09-06 Thread Santiago Vila
reassign 835910 src:warzone2100
found 835910 3.1.1-3
forcemerge 835910 824011
thanks

On Mon, 29 Aug 2016, Russell Coker wrote:

> Package: warzone2100
> Version: 3.1.1-3
> Severity: serious
> Tags: upstream patch
> Justification: fails to build from source (but built successfully in the past)
> 
> The warzone2100 build system insists on automake and aclocal version 1.11.  If
> you have 1.15 installed it won't build.

I already reported this as Bug#824011 and suggested using a Build-Conflicts.

You probably didn't see the bug because the maintainer downgraded to "normal".

Maybe I'm not the only one to think that FTBFS bugs are RC, after all.

Thanks.



Bug#835910: warzone2100: FTBFS when newer automake is installed

2016-08-29 Thread Russell Coker
Package: warzone2100
Version: 3.1.1-3
Severity: serious
Tags: upstream patch
Justification: fails to build from source (but built successfully in the past)

The warzone2100 build system insists on automake and aclocal version 1.11.  If
you have 1.15 installed it won't build.

The following patch makes it build when you have a version of automake newer
than 1.11 installed and the links automake and aclocal pointing to the newer
versions (as is the default when multiple versions are installed).

While it is possible to purge newer versions of automake from your system
before starting a build this shouldn't be required and doesn't work well if
your system is used for building packages that depend on newer versions of
automake.

I think this should be included in Unstable to make things easier for everyone
who wants to work on this package.  The same patch is needed for version 3.2.1.

Index: warzone2100-3.1.1/autogen.sh
===
--- warzone2100-3.1.1.orig/autogen.sh
+++ warzone2100-3.1.1/autogen.sh
@@ -148,13 +148,13 @@ not_version ()
 # Chdir to the srcdir, then run auto* tools.
 cd "$SRCDIR"
 
-version_check 0 "automake" "ftp://ftp.gnu.org/pub/gnu/automake/; 1 12 && {
+version_check 0 "automake-1.11" "ftp://ftp.gnu.org/pub/gnu/automake/; 1 12 && {
   echo "Sorry, automake 1.12+ is not supported yet, please use 1.11."
   exit 1
 }
 
 version_check 1 "autoconf" "ftp://ftp.gnu.org/pub/gnu/autoconf/; 2 56 || DIE=1
-version_check 1 "automake" "ftp://ftp.gnu.org/pub/gnu/automake/; 1 11 || DIE=1
+version_check 1 "automake-1.11" "ftp://ftp.gnu.org/pub/gnu/automake/; 1 11 || 
DIE=1
 if [ "$DIE" -eq 1 ]; then
   exit 1
 fi
@@ -164,10 +164,10 @@ fi
   exit 1
 }
 
-echo "+ running aclocal ..."
-aclocal -I m4 || {
+echo "+ running aclocal-1.11 ..."
+aclocal-1.11 -I m4 || {
   echo
-  echo "aclocal failed - check that all needed development files are present 
on system"
+  echo "aclocal-1.11 failed - check that all needed development files are 
present on system"
   exit 1
 }
 echo "+ running autoheader ... "
@@ -182,10 +182,10 @@ autoconf || {
   echo "autoconf failed"
   exit 1
 }
-echo "+ running automake ... "
-automake -a -c --foreign || {
+echo "+ running automake-1.11 ... "
+automake-1.11 -a -c --foreign || {
   echo
-  echo "automake failed"
+  echo "automake-1.11 failed"
   exit 1
 }
 

-- System Information:
Debian Release: stretch/sid
  APT prefers unstable
  APT policy: (500, 'unstable')
Architecture: amd64 (x86_64)

Kernel: Linux 4.6.0-1-amd64 (SMP w/4 CPU cores)
Locale: LANG=en_AU.UTF-8, LC_CTYPE=en_AU.UTF-8 (charmap=UTF-8)
Shell: /bin/sh linked to /bin/bash
Init: systemd (via /run/systemd/system)

Versions of packages warzone2100 depends on:
ii  libc6 2.23-5
ii  libfontconfig12.11.0-6.7
ii  libfreetype6  2.6.3-3+b1
ii  libfribidi0   0.19.7-1
ii  libgcc1   1:6.2.0-1
ii  libgl1-mesa-glx [libgl1]  11.2.2-1
ii  libglc0   0.7.2-5+b3
ii  libglew1.13   1.13.0-2
ii  libglu1-mesa [libglu1]9.0.0-2.1
ii  libminiupnpc101.9.20140610-2.1
ii  libogg0   1.3.2-1
ii  libopenal11:1.17.2-1
ii  libphysfs12.0.3-3
ii  libpng16-16   1.6.24-2
ii  libqt4-network4:4.8.7+dfsg-8
ii  libqt4-script 4:4.8.7+dfsg-8
ii  libqtcore44:4.8.7+dfsg-8
ii  libsdl1.2debian   1.2.15+dfsg1-4
ii  libstdc++66.2.0-1
ii  libtheora01.1.1+dfsg.1-14
ii  libvorbis0a   1.3.5-3
ii  libvorbisfile31.3.5-3
ii  libx11-6  2:1.6.3-1
ii  libxrandr22:1.5.0-1
ii  warzone2100-data  3.1.1-3
ii  zlib1g1:1.2.8.dfsg-2+b1

Versions of packages warzone2100 recommends:
ii  warzone2100-music  3.1.1-3

warzone2100 suggests no packages.

-- no debconf information