Bug#836175: [buildd-tools-devel] Bug#836175: libsbuild-perl: Do not use single quotes in embedded perl script

Hi, Quoting Samuel Thibault (2016-10-16 12:45:45) > Johannes Schauer, on Sun 16 Oct 2016 12:40:39 +0200, wrote: > > $ time schroot -c unstable-amd64-sbuild -n test --begin-session > /dev/null > > schroot -c unstable-amd64-sbuild -n test --begin-session 0.00s user 0.01s > > system 13% cpu 0.086

Bug#836175: [buildd-tools-devel] Bug#836175: libsbuild-perl: Do not use single quotes in embedded perl script

Johannes Schauer, on Sun 16 Oct 2016 12:40:39 +0200, wrote: > Quoting Samuel Thibault (2016-10-16 12:32:41) > > It depends on the packages. For haskell packages, the package removal is > > faster than schroot's unpack/rm. > > really? > > $ time schroot -c unstable-amd64-sbuild -n test

Bug#836175: [buildd-tools-devel] Bug#836175: libsbuild-perl: Do not use single quotes in embedded perl script

Hi, Quoting Samuel Thibault (2016-10-16 12:32:41) > It depends on the packages. For haskell packages, the package removal is > faster than schroot's unpack/rm. really? $ time schroot -c unstable-amd64-sbuild -n test --begin-session > /dev/null schroot -c unstable-amd64-sbuild -n test

Bug#836175: [buildd-tools-devel] Bug#836175: libsbuild-perl: Do not use single quotes in embedded perl script

Johannes Schauer, on Sun 16 Oct 2016 11:38:09 +0200, wrote: > Quoting Samuel Thibault (2016-10-16 11:17:40) > > At least on the buildds we do it. > > I always wondered: what is the advantage of the sudo mode? > - it is several orders of magnitude faster to create and destroy a schroot >than

Bug#836175: [buildd-tools-devel] Bug#836175: libsbuild-perl: Do not use single quotes in embedded perl script

Control: tag -1 + pending Hi Samuel, Quoting Samuel Thibault (2016-10-16 11:17:40) > At least on the buildds we do it. I always wondered: what is the advantage of the sudo mode? There are several advantages of using schroot: - being able to run multiple builds in the same chroot at the same

Bug#836175: [buildd-tools-devel] Bug#836175: libsbuild-perl: Do not use single quotes in embedded perl script

Johannes Schauer, on Sun 16 Oct 2016 03:53:38 +0200, wrote: > Quoting Samuel Thibault (2016-10-15 18:43:36) > > Johannes Schauer, on Wed 12 Oct 2016 15:35:29 +0200, wrote: > > > > > > sudo: no tty present and no askpass program specified > > > E: read_command failed to execute env > > > E: unable

Bug#836175: [buildd-tools-devel] Bug#836175: libsbuild-perl: Do not use single quotes in embedded perl script

Hi, Quoting Samuel Thibault (2016-10-15 18:43:36) > Johannes Schauer, on Wed 12 Oct 2016 15:35:29 +0200, wrote: > > > > sudo: no tty present and no askpass program specified > > E: read_command failed to execute env > > E: unable to open pipe > > Perhaps you are missing adding your user to sudo

Bug#836175: [buildd-tools-devel] Bug#836175: libsbuild-perl: Do not use single quotes in embedded perl script

Hello, Johannes Schauer, on Wed 12 Oct 2016 15:35:29 +0200, wrote: > we can apply a smarter fix by properly escaping the > command string. Here is a patch: It's working fine in my tests. > When I try this out, then many commands seem to be executed correctly. My > build > fails as soon as

Bug#836175: [buildd-tools-devel] Bug#836175: libsbuild-perl: Do not use single quotes in embedded perl script

Hi, On Thu, 1 Sep 2016 01:00:38 +0200 Samuel Thibault wrote: > Johannes Schauer, on Wed 31 Aug 2016 19:29:47 +0200, wrote: > > if your setup deviates from the default, please include in your bugreport > > how > > it does. > > Ok, got to reproduce it easily: > > #

Bug#836175: [buildd-tools-devel] Bug#836175: libsbuild-perl: Do not use single quotes in embedded perl script

Johannes Schauer, on Wed 31 Aug 2016 19:29:47 +0200, wrote: > if your setup deviates from the default, please include in your bugreport how > it does. Ok, got to reproduce it easily: # sbuild-createchroot sid /var/tmp/foo http://ftp2.fr.debian.org/debian # sudo sbuild-adduser samy

Bug#836175: [buildd-tools-devel] Bug#836175: libsbuild-perl: Do not use single quotes in embedded perl script

Johannes Schauer, on Wed 31 Aug 2016 20:04:42 +0200, wrote: > Control: reassign -1 buildd 0.71.0-1 > > Quoting Samuel Thibault (2016-08-31 19:58:15) > > Johannes Schauer, on Wed 31 Aug 2016 19:54:52 +0200, wrote: > > > Where did you find documentation saying so? > > > >

Bug#836175: [buildd-tools-devel] Bug#836175: libsbuild-perl: Do not use single quotes in embedded perl script

Control: reassign -1 buildd 0.71.0-1 Quoting Samuel Thibault (2016-08-31 19:58:15) > Johannes Schauer, on Wed 31 Aug 2016 19:54:52 +0200, wrote: > > Where did you find documentation saying so? > > https://wiki.debian.org/BuilddSetup > > which supersedes the old

Bug#836175: [buildd-tools-devel] Bug#836175: libsbuild-perl: Do not use single quotes in embedded perl script

Johannes Schauer, on Wed 31 Aug 2016 19:54:52 +0200, wrote: > Quoting Samuel Thibault (2016-08-31 19:53:19) > > Johannes Schauer, on Wed 31 Aug 2016 19:49:27 +0200, wrote: > > > Quoting Samuel Thibault (2016-08-31 19:33:27) > > > > Johannes Schauer, on Wed 31 Aug 2016 19:29:47 +0200, wrote: > > >

Bug#836175: [buildd-tools-devel] Bug#836175: libsbuild-perl: Do not use single quotes in embedded perl script

Johannes Schauer, on Wed 31 Aug 2016 19:49:27 +0200, wrote: > Quoting Samuel Thibault (2016-08-31 19:33:27) > > Johannes Schauer, on Wed 31 Aug 2016 19:29:47 +0200, wrote: > > > Did you not create your chroot with sbuild-createchroot? > > > > I use /usr/share/sbuild/create-chroot, which does not

Bug#836175: [buildd-tools-devel] Bug#836175: libsbuild-perl: Do not use single quotes in embedded perl script

Hi, Quoting Samuel Thibault (2016-08-31 19:53:19) > Johannes Schauer, on Wed 31 Aug 2016 19:49:27 +0200, wrote: > > Quoting Samuel Thibault (2016-08-31 19:33:27) > > > Johannes Schauer, on Wed 31 Aug 2016 19:29:47 +0200, wrote: > > > > Did you not create your chroot with sbuild-createchroot? > >

Bug#836175: [buildd-tools-devel] Bug#836175: libsbuild-perl: Do not use single quotes in embedded perl script

Hi, Quoting Samuel Thibault (2016-08-31 19:33:27) > Johannes Schauer, on Wed 31 Aug 2016 19:29:47 +0200, wrote: > > Did you not create your chroot with sbuild-createchroot? > > I use /usr/share/sbuild/create-chroot, which does not seem to use > sbuild-createchroot how did you find that script?

Bug#836175: [buildd-tools-devel] Bug#836175: libsbuild-perl: Do not use single quotes in embedded perl script

Johannes Schauer, on Wed 31 Aug 2016 19:29:47 +0200, wrote: > if your setup deviates from the default, please include in your bugreport how > it does. For example in your case, how does your ~/.sbuildrc look like. Or > even > better: can you figure out which setting in your ~/.sbuildrc that is

Bug#836175: [buildd-tools-devel] Bug#836175: libsbuild-perl: Do not use single quotes in embedded perl script

Hi, Quoting Samuel Thibault (2016-08-31 19:20:54) > Johannes Schauer, on Wed 31 Aug 2016 19:11:38 +0200, wrote: > > Additionally, current sbuild only seem to have this message in > > lib/Sbuild/ChrootPlain.pm and lib/Sbuild/ChrootSudo.pm. Are you not using > > schroot for your chroots? > > I'm

Bug#836175: [buildd-tools-devel] Bug#836175: libsbuild-perl: Do not use single quotes in embedded perl script

Hello, Johannes Schauer, on Wed 31 Aug 2016 19:11:38 +0200, wrote: > > Do you get to see the "Stripped single quote from command for security:" > > message at least? > > nope: Ok. > I also wonder what this single quote stripping is supposed to achieve in the > first place. How does it enhance

Bug#836175: [buildd-tools-devel] Bug#836175: libsbuild-perl: Do not use single quotes in embedded perl script

Hi, Quoting Samuel Thibault (2016-08-31 18:33:12) > The host is jessie with perl and sbuild upgraded to stretch. The chroot is > sid. But I don't see how this could be related. AIUI it's a question of > getting ResolverBase's run_apt_ftparchive called (i.e. AIUI make sure to use > the apt

Bug#836175: [buildd-tools-devel] Bug#836175: libsbuild-perl: Do not use single quotes in embedded perl script

Johannes Schauer, on Wed 31 Aug 2016 18:24:32 +0200, wrote: > Quoting Samuel Thibault (2016-08-31 18:22:57) > > Did you try with a plain chroot or sudo chroot? Here I'm using > > type=directory. > > I also use type=directory chroots. > > Which distribution are you running on and which

Bug#836175: [buildd-tools-devel] Bug#836175: libsbuild-perl: Do not use single quotes in embedded perl script

Hi, Quoting Samuel Thibault (2016-08-31 18:22:57) > Johannes Schauer, on Wed 31 Aug 2016 18:18:40 +0200, wrote: > > > i.e. the perl script gets broken because ChrootPlain's and ChrootSudo's > > > get_command_internal drop single quotes from the command before running > > > it. > > > > > > I just

Bug#836175: [buildd-tools-devel] Bug#836175: libsbuild-perl: Do not use single quotes in embedded perl script

Johannes Schauer, on Wed 31 Aug 2016 18:18:40 +0200, wrote: > > i.e. the perl script gets broken because ChrootPlain's and ChrootSudo's > > get_command_internal drop single quotes from the command before running > > it. > > > > I just replaced all single quotes (') into double quotes (") in the >

Bug#836175: [buildd-tools-devel] Bug#836175: libsbuild-perl: Do not use single quotes in embedded perl script

Hi, Quoting Samuel Thibault (2016-08-31 10:30:39) > I tried to upgrade to the latest version of sbuild, but builds fail with > > “ > W: Stripped single quote from command for security: use strict; > use warnings; > > ... > close $releasefh; > > Scalar found where operator expected at -e line