Bug#836832: libstring-copyright-perl: please parse "copyright (c) 2106..." statement

[Jonas Smedegaard]

Quoting Jonas Smedegaard (2016-09-07 14:46:22)
> Quoting Dominique Dumont (2016-09-07 12:17:34)
> > The problem I have is that the Antonio extracted by licensecheck is 
> > a contributor, not the © owner:
> >
> > $ licensecheck -m --copyright lib/JIRA/Client/Automated.pm 
> > lib/JIRA/Client/Automated.pmUNKNOWN Antonio Perez Testa 
> > 
> >
> > Looks like the following line matches the © detector regexp:
> >
> > =item José Antonio Perez Testa 
> >
> > Note that the firstname "José" is not extracted by licensecheck. 
> >
> > I can only guess that the regexp confuses "é" with "©"...
> >
> > You can find the whole file there:
> > https://anonscm.debian.org/cgit/pkg-perl/packages/libjira-client-automated-perl.git/tree/lib/JIRA/Client/Automated.pm
> 
> Thanks for the added information.
> 
> It is always best to include the _symptoms_ when reporting issues, and 
> only optionally include (suspected) interpretations of their cause.  
> I.e. summarize not as "please parse..." but rather "fails to parse..." 
> and then elaborate on what you did which went wrong (including your 
> theory on how and why it went wrong only as an optional addon) - I 
> suspect that would have helped me understand this issue earlier (wasting 
> less time for both of us).
> 
> I now get the failure too, and will work on narrowing down what is going 
> on (and for the record: your suspicions seem sensible and are - now, as 
> addition - quite helpful to me).

There are multiple things going on here:

 a) Polyvore, Inc. undetected as copyright holder
 b) José misdetected as copyright sign

a) is a bug - as you also filed as such, but took me some time to 
understand how to repeat.

b) is not really bug, but related to licensecheck being "sloppy" by 
default: Use option "-e utf8" and it goes away.

The bug is now fixed upstream.  I will package when it emerges at 
MetaCPAN in about an hour - ...and this mail took an hour to write, so 
just about now :-)


 - Jonas

-- 
 * Jonas Smedegaard - idealist & Internet-arkitekt
 * Tlf.: +45 40843136  Website: http://dr.jones.dk/

 [x] quote me freely  [ ] ask before reusing  [ ] keep private


signature.asc
Description: signature

Bug#836832: libstring-copyright-perl: please parse "copyright (c) 2106..." statement

[Jonas Smedegaard]

Quoting Dominique Dumont (2016-09-07 12:17:34)
> On Wednesday, September 7, 2016 10:15:13 AM CEST you wrote:
>> Did I misinterpret your issue somehow?  Can you try run that exact 
>> same test, or perhaps provide a similarly written test that fails for 
>> you?
>
> Sorry I misinterpreted the result I got from licensecheck (must have been 
> tired yesterday..)
>
> The problem I have is that the Antonio extracted by licensecheck is a 
> contributor,
> not the © owner:
>
> $ licensecheck -m --copyright lib/JIRA/Client/Automated.pm 
> lib/JIRA/Client/Automated.pmUNKNOWN Antonio Perez Testa 
> 
>
> Looks like the following line matches the © detector regexp:
>
> =item José Antonio Perez Testa 
>
> Note that the firstname "José" is not extracted by licensecheck. 
>
> I can only guess that the regexp confuses "é" with "©"...
>
> You can find the whole file there:
> https://anonscm.debian.org/cgit/pkg-perl/packages/libjira-client-automated-perl.git/tree/lib/JIRA/Client/Automated.pm

Thanks for the added information.

It is always best to include the _symptoms_ when reporting issues, and 
only optionally include (suspected) interpretations of their cause.  
I.e. summarize not as "please parse..." but rather "fails to parse..." 
and then elaborate on what you did which went wrong (including your 
theory on how and why it went wrong only as an optional addon) - I 
suspect that would have helped me understand this issue earlier (wasting 
less time for both of us).

I now get the failure too, and will work on narrowing down what is going 
on (and for the record: your suspicions seem sensible and are - now, as 
addition - quite helpful to me).


 - Jonas

-- 
 * Jonas Smedegaard - idealist & Internet-arkitekt
 * Tlf.: +45 40843136  Website: http://dr.jones.dk/

 [x] quote me freely  [ ] ask before reusing  [ ] keep private


signature.asc
Description: signature

Bug#836832: libstring-copyright-perl: please parse "copyright (c) 2106..." statement

[Dominique Dumont]

On Wednesday, September 7, 2016 10:15:13 AM CEST you wrote:
> Did I misinterpret your issue somehow?  Can you try run that exact same 
> test, or perhaps provide a similarly written test that fails for you?

Sorry I misinterpreted the result I got from licensecheck (must have been tired 
yesterday..)

The problem I have is that the Antonio extracted by licensecheck is a 
contributor,
not the © owner:

$ licensecheck -m --copyright lib/JIRA/Client/Automated.pm 
lib/JIRA/Client/Automated.pmUNKNOWN Antonio Perez Testa 

Looks like the following line matches the © detector regexp:

=item José Antonio Perez Testa 

Note that the firstname "José" is not extracted by licensecheck. 

I can only guess that the regexp confuses "é" with "©"...

You can find the whole file there:
https://anonscm.debian.org/cgit/pkg-perl/packages/libjira-client-automated-perl.git/tree/lib/JIRA/Client/Automated.pm

All the best

-- 
 https://github.com/dod38fr/   -o- http://search.cpan.org/~ddumont/
http://ddumont.wordpress.com/  -o-   irc: dod at irc.debian.org

Bug#836832: libstring-copyright-perl: please parse "copyright (c) 2106..." statement

[Jonas Smedegaard]

Quoting Dominique Dumont (2016-09-06 13:45:15)
> String::Copyright fails to extract copyright from the following
> statement (from Jira::Client::Automated):
> 
> 
> This software is copyright (c) 2016 by Polyvore, Inc.
> 
> This is free software; you can redistribute it and/or modify it under
> the same terms as the Perl 5 programming language system itself.
> 
> 
> Note that String::Copyright knows how to parse statements beginning with
> "(c) copyright", but fails when they are reversed (i.e. "copyright (c)")
> 
> Could you tweak String::Copyright to parse this alternative ?

I fail to reproduce this bug.

The following succeeds for me:

use utf8;
use Test::More tests => 2;
use String::Copyright;

is copyright('This software is copyright (c) 2016 by Polyvore, Inc.'),
'© 2016 Polyvore, Inc.', 'sign pseudosign intro';
is copyright('This software is (c) copyright 2016 by Polyvore, Inc.'),
'© 2016 Polyvore, Inc.', 'pseudosign sign intro';


Did I misinterpret your issue somehow?  Can you try run that exact same 
test, or perhaps provide a similarly written test that fails for you?


 - Jonas

-- 
 * Jonas Smedegaard - idealist & Internet-arkitekt
 * Tlf.: +45 40843136  Website: http://dr.jones.dk/

 [x] quote me freely  [ ] ask before reusing  [ ] keep private


signature.asc
Description: signature

Bug#836832: libstring-copyright-perl: please parse "copyright (c) 2106..." statement

[Jonas Smedegaard]

Hi Dominique,

Quoting Dominique Dumont (2016-09-06 13:45:15)
> String::Copyright fails to extract copyright from the following 
> statement (from Jira::Client::Automated):
> 
> 
> This software is copyright (c) 2016 by Polyvore, Inc.
> 
> This is free software; you can redistribute it and/or modify it under
> the same terms as the Perl 5 programming language system itself.
> 
> 
> Note that String::Copyright knows how to parse statements beginning with
> "(c) copyright", but fails when they are reversed (i.e. "copyright (c)")
> 
> Could you tweak String::Copyright to parse this alternative ?

Thanks for the bugreport - much appreciated!

It sure was supposed to catch this pattern - I will look into it...!


 - Jonas

-- 
 * Jonas Smedegaard - idealist & Internet-arkitekt
 * Tlf.: +45 40843136  Website: http://dr.jones.dk/

 [x] quote me freely  [ ] ask before reusing  [ ] keep private


signature.asc
Description: signature

Bug#836832: libstring-copyright-perl: please parse "copyright (c) 2106..." statement

[Dominique Dumont]

Package: libstring-copyright-perl
Version: 0.003001-1
Severity: normal

Dear Maintainer,

String::Copyright fails to extract copyright from the following
statement (from Jira::Client::Automated):


This software is copyright (c) 2016 by Polyvore, Inc.

This is free software; you can redistribute it and/or modify it under
the same terms as the Perl 5 programming language system itself.


Note that String::Copyright knows how to parse statements beginning with
"(c) copyright", but fails when they are reversed (i.e. "copyright (c)")

Could you tweak String::Copyright to parse this alternative ?

All the best

*** Reporter, please consider answering these questions, where appropriate ***

   * What led up to the situation?
   * What exactly did you do (or not do) that was effective (or
 ineffective)?
   * What was the outcome of this action?
   * What outcome did you expect instead?

*** End of the template - remove these template lines ***


-- System Information:
Debian Release: stretch/sid
  APT prefers unstable
  APT policy: (990, 'unstable'), (500, 'testing'), (1, 'experimental')
Architecture: amd64 (x86_64)
Foreign Architectures: i386, armhf

Kernel: Linux 4.7.0-1-amd64 (SMP w/8 CPU cores)
Locale: LANG=en_US.UTF-8, LC_CTYPE=en_US.UTF-8 (charmap=UTF-8)
Shell: /bin/sh linked to /bin/dash
Init: systemd (via /run/systemd/system)

Versions of packages libstring-copyright-perl depends on:
ii  libexporter-tiny-perl  0.042-1
ii  perl   5.22.2-5

libstring-copyright-perl recommends no packages.

libstring-copyright-perl suggests no packages.

-- no debconf information