Bug#837798: RFS: libcgicc/3.2.16-0.1 NMU -- C++ class library for writing CGI applications
On 2016-10-16 10:00, Gianfranco Costamagna wrote: dh_auto_configure already injects some flags such as libdir and multiarch stuff it would be nice to remove them [..] Also, please take the opportunity to fix the changelog as josch pointed out :) Hi Gianfranco and Johannes, the issues you mentioned should be now fixed in the last update on mentors. Thanks, Thomas
Bug#837798: RFS: libcgicc/3.2.16-0.1 NMU -- C++ class library for writing CGI applications
Hi Thomas,
(package removed from deferred queue)
>I have uploaded a new version to mentors with the two changes you
>mentioned in your mails today:
>- Using dh_auto_configure instead of calling ./configure directly.
mm nack :)
dh_auto_configure already injects some flags such as libdir and multiarch stuff
it would be nice to remove them
dh_auto_configure -- --host=x86_64-linux-gnu --build=x86_64-linux-gnu
--prefix=/usr --libdir=\${prefix}/lib/x86_64-linux-gnu
--htmldir=\${prefix}/share/doc/libcgicc-doc/html --disable-demos
./configure --build=x86_64-linux-gnu --prefix=/usr
--includedir=\${prefix}/include --mandir=\${prefix}/share/man
--infodir=\${prefix}/share/info --sysconfdir=/etc --localstatedir=/var
--disable-silent-rules --libdir=\${prefix}/lib/x86_64-linux-gnu
--libexecdir=\${prefix}/lib/x86_64-linux-gnu --disable-maintainer-mode
--disable-dependency-tracking --host=x86_64-linux-gnu --build=x86_64-linux-gnu
--prefix=/usr --libdir=\${prefix}/lib/x86_64-linux-gnu
--htmldir=\${prefix}/share/doc/libcgicc-doc/html --disable-demos
I think some duplication can be avoided :)
>- Removed the Replaces and Conflicts directive for the binary package.
>
>Use this package if you deem those changes worth the hassle of
>re-uploading the package to deferred/15. If not, then I'm happy to keep
>the changes for the next time I need to update the cgicc package.
this change is nice
Also, please take the opportunity to fix the changelog as josch
pointed out :)
thanks a lot!
Gianfranco
Bug#837798: RFS: libcgicc/3.2.16-0.1 NMU --
Hi, Quoting Thomas Pircher (2016-09-14 20:21:14) > Changes since the last upload: > >* Non-maintainer upload. >* New upstream release (closes: #833081, #811988, #798624, #645616). I once made a similar mistake in one of my packages and just listed all the closed bugs without writing down how the new release closes them. You can see for yourself which version you like better in this commit where I fixed the problem for my package: https://anonscm.debian.org/cgit/buildd-tools/sbuild.git/commit/?h=debian/unstable&id=5b06c85f93862f004053f1d85c1d69c9d7716955 Indeed it is not strictly *necessary* to list exactly how each bug was closed, but it is nice for the submitter of the bug to read how it got handled in the email they receive when your upload closes the bug. With just a list, as a bug submitter you don't know how your problem was taken care of without manually diffing the two versions. Here is a nice write-up about why to be more elaborate in d/changelog: https://www.debian.org/doc/manuals/developers-reference/ch06.en.html#bpp-debian-changelog Thanks! cheers, josch signature.asc Description: signature
Bug#837798: RFS: libcgicc/3.2.16-0.1 NMU -- C++ class library for writing CGI applications
On 2016-10-15 12:35, Gianfranco Costamagna wrote: BTW for a next update would be nice to consider using dh_auto_configure instead of directly calling ./configure Hi Gianfranco, I have uploaded a new version to mentors with the two changes you mentioned in your mails today: - Using dh_auto_configure instead of calling ./configure directly. - Removed the Replaces and Conflicts directive for the binary package. Use this package if you deem those changes worth the hassle of re-uploading the package to deferred/15. If not, then I'm happy to keep the changes for the next time I need to update the cgicc package. Thanks, Thomas
Bug#837798: RFS: libcgicc/3.2.16-0.1 NMU -- C++ class library for writing CGI applications
On 2016-10-11 22:22, Gianfranco Costamagna wrote: I see you forgot to probably run dh_clean (I see debian/autoreconf.before and debian/autoreconf.after files) D'oh. They were leftovers from a previous build and are gone now. and I still see a libcgicc3-dev package (instead of libcgicc-dev) Yes, that was my mistake; I misunderstood your suggestion and made libcgicc-dev a virtual package. The last update on mentors now consists of libcgicc3, libcgicc-dev and libcgicc-doc. Thanks, Thomas
Bug#837798: RFS: libcgicc/3.2.16-0.1 NMU -- C++ class library for writing CGI applications
Gianfranco Costamagna: > Hi, > >> I have uploaded a new package to mentors, with the two outstanding > >> issues fixed. > > not sure... > I see you forgot to probably run dh_clean > (I see debian/autoreconf.before and debian/autoreconf.after files) > > [...] > > G. > That needs a "dh_autoreconf_clean" (before the dh_clean). Thanks, ~Niels
Bug#837798: RFS: libcgicc/3.2.16-0.1 NMU -- C++ class library for writing CGI applications
Hi, >I have uploaded a new package to mentors, with the two outstanding >issues fixed. not sure... I see you forgot to probably run dh_clean (I see debian/autoreconf.before and debian/autoreconf.after files) and I still see a libcgicc3-dev package (instead of libcgicc-dev) >Thanks again for your patient and thorough reviews! thanks to you for fixing it :) I'm happy to see you keeping up with my reviews :D G.
Bug#837798: RFS: libcgicc/3.2.16-0.1 NMU -- C++ class library for writing CGI applications
On 2016-10-11 16:18, Gianfranco Costamagna wrote: let me know that last two bits and I'll probably sponsor in deferred/10 (due to the high changes number) (Adding Chris to the loop, in case he as maintainer has a different opinion) Hi Gianfranco, I have uploaded a new package to mentors, with the two outstanding issues fixed. Thanks again for your patient and thorough reviews! Thomas
Bug#837798: RFS: libcgicc/3.2.16-0.1 NMU -- C++ class library for writing CGI applications
Hi, >I missed to add you and 837...@bugs.debian.org in my last mail. In the >upload to mentors from last week I have addressed your feedback (at >least I think I did, that is). The only thing I'm not entirely sure >about is the missing build-dependency on pkg-config as build-dependency, >as described below. if not needed, it is fine to leave it out :) I have some last things to ask: if you bump compat level to 10, you can avoid dh-autoreconf at all Build-Depends: debhelper (>=10) Build-Depends-Indep: doxygen and in rules: "--with autoreconf" can be removed. Last thing: Package: libcgicc3-dev Provides: libcgicc3-dev well, every package provides itself :p I would change it to the unversioned libcgicc-dev because this way you will be able to rebuild reverse dependencies on next soname bump without having to perform sourceful uploads. let me know that last two bits and I'll probably sponsor in deferred/10 (due to the high changes number) (Adding Chris to the loop, in case he as maintainer has a different opinion) thanks! G.
Bug#837798: RFS: libcgicc/3.2.16-0.1 NMU -- C++ class library for writing CGI applications
Hi Gianfranco, I missed to add you and 837...@bugs.debian.org in my last mail. In the upload to mentors from last week I have addressed your feedback (at least I think I did, that is). The only thing I'm not entirely sure about is the missing build-dependency on pkg-config as build-dependency, as described below. Cheers, Thomas On 2016-10-02 18:07, Thomas Pircher wrote: On 2016-09-28 22:37, Gianfranco Costamagna wrote: [..] drop the explicit dependencies since dh-autoreconf already depends on automake and libtool? If this is the customary way then I'll drop the explicit dependencies on automake and libtool. I think so. dh-autoreconf should be enough (with an added pkg-config if needed, IIRC) Hi Gianfranco, automake and libtool are no longer explicit dependencies in my latest upload to mentors [1]. But I haven't added pkg-config. It is not required for building libcgicc and I could not find a mention of pkg-config in the dh-autoreconf documentation. But if I'm missing something than I'll be happy to add the build dependency. I think patching it to be architecture independent might be the best solution Thanks for that. I had not appreciated that packages may contain bit-identical files. That does indeed solve my problem, and I have patched out the --host and --libdir options and re-added the script to the package. Thanks again for your continuing efforts! Thomas [1] https://mentors.debian.net/package/libcgicc
Bug#837798: RFS: libcgicc/3.2.16-0.1 NMU -- C++ class library for writing CGI applications
Hi > They are both used in the build. But if I understand you right, are you > suggesting to drop the explicit dependencies since dh-autoreconf already > depends on automake and libtool? If this is the customary way then I'll > drop the explicit dependencies on automake and libtool. I think so. dh-autoreconf should be enough (with an added pkg-config if needed, IIRC) > This file is made obsolete by the pkg-config file, and it was creating a > problem for multiarch packages: it would install in > /usr/bin/cgicc-config, making it impossible to install two architectures > of this package. this is a problem when the files are not bit-bit identical between architecture, and this seems to be this case ## Host information --host)echo "x86_64-pc-linux-gnu" && exit 0 ;; this changes. You can patch that change out, as example you can grab what we did for libpng1.6[1] or try to print the triplet at runtime, when the user asks for it maybe dpkg-architecture has something interesting for you [1] https://sources.debian.net/src/libpng1.6/1.6.25-1/debian/patches/libpng-config.patch/ > | Using this kind of system to pass compile file is obsolete and will > likely introduce bugs in a multi-arch system. > | Particularly, this kind of script could only belong to a package that > is not Multi-Arch. > > So I took this as excuse to remove the file from the package. > > One possible solution (suggested by lintian) is to move the file out of > the way (to /usr/share/doc, I presume) so it is still shipped, but it >won't be found by build tools, which kind of defeats its purpose. I'm >doubtful there is any benefit in shipping this file. I think patching it to be architecture independent might be the best solution >As far as I can see from the CVS changes, the 'current' value in the >soname was increased in the early 2000's, presumably due to ABI changes. >Then in 2013 the soname was decreased from 5 to 3 in order to match the >library version. This was done as part of these bugs: > >I presume the package should follow the upstream soname. And this would >probably also justify the renamed package, as you were musing in your >mail. If there are no objections, I will rename the packages from >libcgicc5 to libcgicc. libcgicc3 you mean :) >This should be fixed by the renaming from libcgicc5* -> libcgicc*. always a final 3 >Raised as https://savannah.gnu.org/bugs/index.php?49120 >Thinking again, I guess that's not correct. This would require the >packages to be renamed to libcgicc3. oops you got it already >I have uploaded a new build to debian mentors for further review. I'll have a look if you can provide an answer to my above comments :) thanks! Gianfranco signature.asc Description: OpenPGP digital signature
Bug#837798: RFS: libcgicc/3.2.16-0.1 NMU -- C++ class library for writing CGI applications
On 2016-09-18 19:11, Thomas Pircher wrote: Thinking again, I guess that's not correct. This would require the packages to be renamed to libcgicc3. Hi, I have uploaded a new build to debian mentors for further review. https://mentors.debian.net/package/libcgicc This build should address the issues raised on my previous upload, modulo mistakes and misinterpretations on my side. This version does rename the libraries to libcgicc3 (from libcgicc5), replacing and conflicting with the previous name. Thanks, Thomas
Bug#837798: RFS: libcgicc/3.2.16-0.1 NMU -- C++ class library for writing CGI applications
On 2016-09-18 17:39, Thomas Pircher wrote: W: libcgicc5: package-name-doesnt-match-sonames libcgicc3 This should be fixed by the renaming from libcgicc5* -> libcgicc*. Thinking again, I guess that's not correct. This would require the packages to be renamed to libcgicc3. Thomas
Bug#837798: RFS: libcgicc/3.2.16-0.1 NMU -- C++ class library for writing CGI applications
On 2016-09-15 10:49, Gianfranco Costamagna wrote: changes are huge, but being half mia, and on lowNMU threshold... (and too many bugs here, so lets do it) First of all, thanks for the detailed review. I have addressed most issues but not yet uploaded a new version to mentors, pending a couple of questions. 1) have patches been upstreamed? Patch 0001 (pkg-config change) comes from the upstream bug tracker and patch 0002 (empty index.html) has been upstreamed. Patch 0003 (removal of /usr/bin/cgicc-config, see also below, point 7) is not, since I see this as a packaging issue rather than an upstream problem. 2) patch description might be nice 3) d/p/003-no-old-style-config.patch So, in case please patch Makefile.am 4) automake, libtool, doxygen, dh-autoreconf doxygen might be needed only for arch:all builds, so you might want to move it into Build-Depends-Indep Fair points, my next upload to mentors will fix these. 5) automake, libtool, are them useful? They are both used in the build. But if I understand you right, are you suggesting to drop the explicit dependencies since dh-autoreconf already depends on automake and libtool? If this is the customary way then I'll drop the explicit dependencies on automake and libtool. 6) new files diff -Nru libcgicc-3.2.9/debian/libcgicc-dev.dirs diff -Nru libcgicc-3.2.9/debian/libcgicc-dev.install why? Uh, these files are not needed and are leftovers from my experiments with a multi-arch library and will be removed in my next upload. 7) /usr/bin/cgicc-config this was shipped before, why are you removing it? This file is made obsolete by the pkg-config file, and it was creating a problem for multiarch packages: it would install in /usr/bin/cgicc-config, making it impossible to install two architectures of this package. Also, https://lintian.debian.org/tags/old-style-config-script.html says: | Using this kind of system to pass compile file is obsolete and will likely introduce bugs in a multi-arch system. | Particularly, this kind of script could only belong to a package that is not Multi-Arch. So I took this as excuse to remove the file from the package. One possible solution (suggested by lintian) is to move the file out of the way (to /usr/share/doc, I presume) so it is still shipped, but it won't be found by build tools, which kind of defeats its purpose. I'm doubtful there is any benefit in shipping this file. 8) library changed soname? from libcgicc.so.5.0.2 to libcgicc.so.3.2.10 As far as I can see from the CVS changes, the 'current' value in the soname was increased in the early 2000's, presumably due to ABI changes. Then in 2013 the soname was decreased from 5 to 3 in order to match the library version. This was done as part of these bugs: https://savannah.gnu.org/bugs/?func=detailitem&item_id=38053 https://savannah.gnu.org/bugs/?func=detailitem&item_id=38224 I presume the package should follow the upstream soname. And this would probably also justify the renamed package, as you were musing in your mail. If there are no objections, I will rename the packages from libcgicc5 to libcgicc. W: libcgicc5: package-name-doesnt-match-sonames libcgicc3 This should be fixed by the renaming from libcgicc5* -> libcgicc*. X: libcgicc5: shlib-calls-exit usr/lib/x86_64-linux-gnu/libcgicc.so.3.2.10 (^^ this is something for upstream) Raised as https://savannah.gnu.org/bugs/index.php?49120 Thanks, Thomas
Bug#837798: RFS: libcgicc/3.2.16-0.1 NMU --
Forgot lintian 9) I: libcgicc source: binary-control-field-duplicates-source field "section" in package libcgicc5 I: libcgicc source: quilt-patch-missing-description 0002-Non-empty-html-index.patch I: libcgicc source: quilt-patch-missing-description 003-no-old-style-config.patch W: libcgicc5: package-name-doesnt-match-sonames libcgicc3 X: libcgicc5: shlib-calls-exit usr/lib/x86_64-linux-gnu/libcgicc.so.3.2.10 (^^ this is something for upstream) (the invariant lintian complain seems a false positive due upper/lower case) a nice to have might be hardening and the copyright fixes: P: libcgicc5-dev: copyright-refers-to-symlink-license usr/share/common-licenses/GFDL but I don't care too much about them (specially in an NMU case) popcon is low, and there aren't reverse-dependencies in the archive. cheers, G.
Bug#837798: RFS: libcgicc/3.2.16-0.1 NMU --
control: owner -1 ! control: tags -1 moreinfo Hi,> * Non-maintainer upload. changes are huge, but being half mia, and on lowNMU threshold... (and too many bugs here, so lets do it) > * New upstream release (closes: #833081, #811988, #798624, #645616).> * > Updated to Standards-Version 3.9.8 (no changes required). > * Updated to debhelper 9, updated Build-Depends. > * Added Multiarch support. > * Updated debian/*.install and removed the install directory where >source and > destination directories are the same. > * Added patch to generate non-empty index.html in the documentation. > * Removed old-style config file. > * Commented out the broken Vcs URLs in debian/control. review: 1) have patches been upstreamed? 2) patch description might be nice / patches should follow dep3 and please don't remove the original fields (e.g. author) http://dep.debian.net/deps/dep3/ 3) d/p/003-no-old-style-config.patch you are using autoreconf and this patch is patching Makefile.in this means that the patch will touch a file that is autoregenerated. So, in case please patch Makefile.am 4) automake, libtool, doxygen, dh-autoreconf doxygen might be needed only for arch:all builds, so you might want to move it into Build-Depends-Indep (probably it won't work, since you seem to build documentation also in arch:any builds) 5) automake, libtool, are them useful? 6) new files diff -Nru libcgicc-3.2.9/debian/libcgicc-dev.dirs libcgicc-3.2.16/debian/libcgicc-dev.dirs --- libcgicc-3.2.9/debian/libcgicc-dev.dirs 1970-01-01 01:00:00.0 +0100 +++ libcgicc-3.2.16/debian/libcgicc-dev.dirs2016-09-08 20:41:26.0 +0200 @@ -0,0 +1 @@ +usr/include diff -Nru libcgicc-3.2.9/debian/libcgicc-dev.install libcgicc-3.2.16/debian/libcgicc-dev.install --- libcgicc-3.2.9/debian/libcgicc-dev.install 1970-01-01 01:00:00.0 +0100 +++ libcgicc-3.2.16/debian/libcgicc-dev.install 2016-09-08 20:41:26.0 +0200 @@ -0,0 +1,4 @@ +usr/include/* +usr/lib/*/lib*.so +usr/lib/*/pkgconfig/* +usr/share/pkgconfig/* why? I have to say I wouldn't oppose too much a rename of the binary from libcgicc5-dev to libcgicc-dev, but this means going in bin-new queue, and I would take the opportunity on the next SONAME bump. (there aren't reverse-dependencies) 7) /usr/bin/cgicc-config this was shipped before, why are you removing it? 8) library changed soname? from libcgicc.so.5.0.2 to libcgicc.so.3.2.10 not sure what happened, but this seems bad objdump -p ../libcgicc.so.3.2.10 |grep -i SONAME SONAME libcgicc.so.3 soname going backward is somewhat bad. (unless somebody has a better opinion, probably it doesn't mean too much, but for sure the binary needs to follow the SONAME change). Please investigate this with upstream, according to their changelog they did something wrong and tried to recover from it. (changing SONAME for this seems a good reason, and will integrate the Ubuntu patch too, at least in some little way, as well as the -dev package renaming) thanks! G.
Bug#837798: RFS: libcgicc/3.2.16-0.1 NMU --
Package: sponsorship-requests Severity: normal Dear mentors, having been unsuccessful in contacting the maintainer of this package and after having consulted m...@debian.org, I am looking for a sponsor for the package "libcgicc" * Package name: libcgicc Version : 3.2.16-0.1 Upstream Author : Sebastien Diaz * URL : https://www.gnu.org/software/cgicc/ * License : LGPL-3+, GFDL-1.1+ for documentation Section : libs It builds those binary packages: libcgicc-doc - C++ class library for writing CGI applications (documentation) libcgicc5 - C++ class library for writing CGI applications (library) libcgicc5-dev - C++ class library for writing CGI applications (development files To access further information about this package, please visit the following URL: https://mentors.debian.net/package/libcgicc Alternatively, one can download the package with dget using this command: dget -x https://mentors.debian.net/debian/pool/main/libc/libcgicc/libcgicc_3.2.16-0.1.dsc More information about libcgicc can be obtained from https://savannah.gnu.org/p/cgicc Changes since the last upload: * Non-maintainer upload. * New upstream release (closes: #833081, #811988, #798624, #645616). * Updated to Standards-Version 3.9.8 (no changes required). * Updated to debhelper 9, updated Build-Depends. * Added Multiarch support. * Updated debian/*.install and removed the install directory where source and destination directories are the same. * Added patch to generate non-empty index.html in the documentation. * Removed old-style config file. * Commented out the broken Vcs URLs in debian/control. Regards, Thomas Pircher
