Bug#838622: needrestart: systemctl combine, stdio, list mode: do not wrap systemctl restart commands

[Thomas Liske]

Paul Wise  writes:

tags 838622 upstream fixed-upstream
thanks


Hi Paul,

> When using systemctl_combine=1, ui=NeedRestart::UI::stdio and restart=l
> and there are many services to restart, the resulting systemctl restart
> command is wrapped according to the terminal size instead of letting
> the terminal itself wrap the command. The needrestart wrapping prevents
> copy-paste of the whole command-line including the parts after the wrap
> but the terminal wrapping of long lines allows this. It appears that
> the fix would be for the UI modules to grow a 'command' function and
> for the stdio module to *not* use wprint for that function.

I've added a special command print option which does *not* use
Text::Wrap to make long lines working. Thanks for the hint, since I'm
not using list mode at all I was not aware of this issue, yet.


HTH,
Thomas


> -- System Information:
> Debian Release: stretch/sid
>   APT prefers testing-debug
>   APT policy: (900, 'testing-debug'), (900, 'testing'), (800, 
> 'unstable-debug'), (800, 'unstable'), (790, 'buildd-unstable'), (700, 
> 'experimental-debug'), (700, 'experimental'), (690, 'buildd-experimental')
> Architecture: amd64 (x86_64)
>
> Kernel: Linux 4.7.0-1-amd64 (SMP w/4 CPU cores)
> Locale: LANG=en_AU.utf8, LC_CTYPE=en_AU.utf8 (charmap=UTF-8)
> Shell: /bin/sh linked to /bin/dash
> Init: systemd (via /run/systemd/system)
>
> Versions of packages needrestart depends on:
> ii  dpkg   1.18.10
> ii  gettext-base   0.19.8.1-1
> ii  libintl-perl   1.26-2
> ii  libmodule-find-perl0.13-1
> ii  libmodule-scandeps-perl1.21-1
> ii  libproc-processtable-perl  0.53-1+b1
> ii  libsort-naturally-perl 1.03-1
> ii  libterm-readkey-perl   2.33-1+b1
> ii  perl   5.22.2-5
> ii  xz-utils   5.1.1alpha+20120614-2.1
>
> needrestart recommends no packages.
>
> Versions of packages needrestart suggests:
> ii  libnotify-bin0.7.6-2
> ii  needrestart-session  0.3-2
>
> -- no debconf information
>
> -- 
> bye,
> pabs
>
> https://wiki.debian.org/PaulWise

-- 
supp...@ibh.de  Tel. +49 351 477 77 30
www.ibh.de  Fax  +49 351 477 77 39

---
Dipl.-Ing. Thomas Liske
Teamleiter DataCenter Services


IBH IT-Service GmbH  Amtsgericht Dresden
Heilbronner Str. 20  HRB 13626
01189 DresdenGF: Prof. Dr. T. Horn, S. Horn
Germany  VAT DE182302907
---
Ihr Partner für: LAN, WAN IP-Quality, Security, VoIP, SAN, Backup, USV
---
   professioneller IT-Service - kompetent und zuverlässig
---

Bug#838622: needrestart: systemctl combine, stdio, list mode: do not wrap systemctl restart commands

[Paul Wise]

Package: needrestart
Version: 2.9-1
Severity: minor

When using systemctl_combine=1, ui=NeedRestart::UI::stdio and restart=l
and there are many services to restart, the resulting systemctl restart
command is wrapped according to the terminal size instead of letting
the terminal itself wrap the command. The needrestart wrapping prevents
copy-paste of the whole command-line including the parts after the wrap
but the terminal wrapping of long lines allows this. It appears that
the fix would be for the UI modules to grow a 'command' function and
for the stdio module to *not* use wprint for that function.

-- System Information:
Debian Release: stretch/sid
  APT prefers testing-debug
  APT policy: (900, 'testing-debug'), (900, 'testing'), (800, 
'unstable-debug'), (800, 'unstable'), (790, 'buildd-unstable'), (700, 
'experimental-debug'), (700, 'experimental'), (690, 'buildd-experimental')
Architecture: amd64 (x86_64)

Kernel: Linux 4.7.0-1-amd64 (SMP w/4 CPU cores)
Locale: LANG=en_AU.utf8, LC_CTYPE=en_AU.utf8 (charmap=UTF-8)
Shell: /bin/sh linked to /bin/dash
Init: systemd (via /run/systemd/system)

Versions of packages needrestart depends on:
ii  dpkg   1.18.10
ii  gettext-base   0.19.8.1-1
ii  libintl-perl   1.26-2
ii  libmodule-find-perl0.13-1
ii  libmodule-scandeps-perl1.21-1
ii  libproc-processtable-perl  0.53-1+b1
ii  libsort-naturally-perl 1.03-1
ii  libterm-readkey-perl   2.33-1+b1
ii  perl   5.22.2-5
ii  xz-utils   5.1.1alpha+20120614-2.1

needrestart recommends no packages.

Versions of packages needrestart suggests:
ii  libnotify-bin0.7.6-2
ii  needrestart-session  0.3-2

-- no debconf information

-- 
bye,
pabs

https://wiki.debian.org/PaulWise


signature.asc
Description: This is a digitally signed message part