Bug#838735: broadcom-sta-dkms: Please announce supported hardware using AppStream
Here is a patch, using the IDs in debian/broadcom-sta.ids and README.txt. diff --git a/debian/broadcom-sta-dkms.metainfo.xml b/debian/broadcom-sta-dkms.metainfo.xml index 30aeb3d..fd31b87 100644 --- a/debian/broadcom-sta-dkms.metainfo.xml +++ b/debian/broadcom-sta-dkms.metainfo.xml @@ -13,6 +13,24 @@ -pci:v*d*sv*sd*bc02sc80i* +pci:v14E4d4311sv* +pci:v14E4d4312sv* +pci:v14E4d4313sv* +pci:v14E4d4315sv* +pci:v14E4d4328sv* +pci:v14E4d4329sv* +pci:v14E4d432Asv* +pci:v14E4d432Bsv* +pci:v14E4d432Csv* +pci:v14E4d432Dsv* +pci:v14E4d4331sv* +pci:v14E4d4353sv* +pci:v14E4d4357sv* +pci:v14E4d4358sv* +pci:v14E4d4359sv* +pci:v14E4d4365sv* +pci:v14E4d43A0sv* +pci:v14E4d43B1sv* +pci:v14E4d4727sv* -- Happy hacking Petter Reinholdtsen
Bug#838735: broadcom-sta-dkms: Please announce supported hardware using AppStream
[Eduard Bloch 2016-12-20] > I dropped the file installation completely for now because identifying > which hardware is covered by which driver in a better way appears too > troublesome. What is wrong with matching on 'pci:v14E4d*sv*sd*bc02sc80i*', ie all PCI network cards (bus class 2, subclass 80) from Broadcom (vendor 14E4) as matched by /usr/share/misc/pci.ids and https://pci-ids.ucw.cz/read/PD/02 >? It has been announced in isenkram for a few years now. Or matching on specific PCI IDs as my initial proposal, or the IDs listed in debian/broadcom-sta.ids and README.txt in the source? -- Happy hacking Petter Reinholdtsen
Bug#838735: broadcom-sta-dkms: Please announce supported hardware using AppStream
Hallo Peter, * Petter Reinholdtsen [Sat, Dec 17 2016, 07:22:09PM]: > [Petter Reinholdtsen] > > Hi. The current AppStream modalias setting causes the package to show > > up on machines where it isn't supported. Please change the modalias > > matching rule to be more specific to the supported hardware. > > This issue reduces the usability of the isenkram system seriously. The > time is running out to have this fixed in Stretch. Because of this, I > plan to blacklist the appstream information from broadcom-sta-dkms in > isenkram to make sure the bogus package proposal is not listed on all > machines with an ethernet card. > > Please let me know when you decide to adjust the appstream modalias > value in broadcom-sta-dkms, so I can remove the blacklist entry. I dropped the file installation completely for now because identifying which hardware is covered by which driver in a better way appears too troublesome. Could be revisited in future. See the version -5 for now, just uploaded. Regards, Eduard.
Bug#838735: broadcom-sta-dkms: Please announce supported hardware using AppStream
[Petter Reinholdtsen] > Hi. The current AppStream modalias setting causes the package to show > up on machines where it isn't supported. Please change the modalias > matching rule to be more specific to the supported hardware. This issue reduces the usability of the isenkram system seriously. The time is running out to have this fixed in Stretch. Because of this, I plan to blacklist the appstream information from broadcom-sta-dkms in isenkram to make sure the bogus package proposal is not listed on all machines with an ethernet card. Please let me know when you decide to adjust the appstream modalias value in broadcom-sta-dkms, so I can remove the blacklist entry. -- Happy hacking Petter Reinholdtsen
Bug#838735: broadcom-sta-dkms: Please announce supported hardware using AppStream
Control: reopen -1 Control: found -1 6.30.223.271-4 Hi. The current AppStream modalias setting causes the package to show up on machines where it isn't supported. Please change the modalias matching rule to be more specific to the supported hardware. -- Vennlig hilsen Petter Reinholdtsen
Bug#838735: broadcom-sta-dkms: Please announce supported hardware using AppStream
Hi. I was very happy to see you adding AppStream modalias metadata to the broadcom-sta-dkms package. But the modalias matching rule seem to match more than it should. It matches on my Thinkpad X200 and X230, and neither have any broadcom hardware included: % lspci |grep -i broad % isenkram-lookup |grep broadc broadcom-sta-dkms % What was the idea behind the pci:v*d*sv*sd*bc02sc80i* matching rule? Bus class 2, subclass 80 is any network controller according to https://pci-ids.ucw.cz/read/PD/02 >. Perhaps you should limit it to network controllers from broadcom using 'pci:v14e4d*sv*sd*bc02sc80i*'? -- Vennlig hilsen Petter Reinholdtsen
Bug#838735: broadcom-sta-dkms: Please announce supported hardware using AppStream
Package: broadcom-sta-dkms Version: 6.30.223.271-3 Severity: wishlist User: p...@hungry.com Usertags: appstream-modalias Hi. The broadcom-sta-dkms package is one of the packages in the Debian archive that should be proposed for installation when a given hardware dongle is inserted or available. Thanks to the appstream system, this can now be announced in a way other tools can use and act on. I've written the isenkram system to ask the current user if hardware specific packages should be installed when a new dongle is installed or already present on a machine, and isenkram now uses appstream as one source for hardware to package mappings. You can read more about this on my blog, http://people.skolelinux.org/pere/blog/Using_appstream_with_isenkram_to_install_hardware_related_packages_in_Debian.html >. Instructions on how to create the metadata XML file can be found in https://wiki.debian.org/AppStream/Guidelines >. It would be great if you could add an appstream metainfo file to the broadcom-sta-dkms package, with content similar to this: [...] pci:v14e4d4313sv* pci:v14e4d4727sv* pci:v14e4d432asv* pci:v14e4d432bsv* pci:v14e4d432dsv* pci:v14e4d4358sv* pci:v14e4d4359sv* pci:v14e4d4365sv* pci:v14e4d43a0sv* pci:v14e4d43b1sv* If there are other hardware ids or kernel modules also supported by the package, please add those too. :) -- Happy hacking Petter Reinholdtsen
