Bug#844943: python-bleach: FTBFS: Tests failures

[Scott Kitterman]

On Sat, 25 Feb 2017 01:05:29 -0500 Scott Kitterman  
wrote:
> On Tue, 14 Feb 2017 14:52:01 -0500 Scott Kitterman  
> wrote:
> > On Mon, 19 Dec 2016 20:54:02 +0530 Pirate Praveen  
> wrote:
> > ...
> > > Seems python-html5lib was updated without checking reverse dependency
> > > compatibility  https://github.com/mozilla/bleach/issues/212
> > > 
> > 
> > Based on recent discussions in the upstream bugs, it looks like they are 
> > making some progress on this.  If they don't, I think the only option is 
to 
> > embed a copy of the older html5lib in bleach (not ideal, I know).
> 
> Upstream git now passes all tests with the new html5lib.  Pending some 
> additional testing, a new release is planned next week.  I intent to ask the 
> RT for permission to update to the new upstream.  I have a local test 
package 
> of the current git and it passes all tests.
> 
> Scott K

2.0 is released.  I've prepped a package update and requested permission from 
the release team to get it into Stretch.

https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=857400

Scott K

Bug#844943: python-bleach: FTBFS: Tests failures

[Scott Kitterman]

On Tue, 14 Feb 2017 14:52:01 -0500 Scott Kitterman  
wrote:
> On Mon, 19 Dec 2016 20:54:02 +0530 Pirate Praveen  
wrote:
> ...
> > Seems python-html5lib was updated without checking reverse dependency
> > compatibility  https://github.com/mozilla/bleach/issues/212
> > 
> 
> Based on recent discussions in the upstream bugs, it looks like they are 
> making some progress on this.  If they don't, I think the only option is to 
> embed a copy of the older html5lib in bleach (not ideal, I know).

Upstream git now passes all tests with the new html5lib.  Pending some 
additional testing, a new release is planned next week.  I intent to ask the 
RT for permission to update to the new upstream.  I have a local test package 
of the current git and it passes all tests.

Scott K

Bug#844943: python-bleach: FTBFS: Tests failures

[Scott Kitterman]

On Mon, 19 Dec 2016 20:54:02 +0530 Pirate Praveen  wrote:
...
> Seems python-html5lib was updated without checking reverse dependency
> compatibility  https://github.com/mozilla/bleach/issues/212
> 

Based on recent discussions in the upstream bugs, it looks like they are 
making some progress on this.  If they don't, I think the only option is to 
embed a copy of the older html5lib in bleach (not ideal, I know).

Scott K

Bug#844943: python-bleach: FTBFS: Tests failures

[Pirate Praveen]

On Fri, 13 Jan 2017 10:58:28 -0500 Barry Warsaw  wrote:
> Apologies.  Tags pushed.  Let me know when you have a repo or branch for me to
> test and I will do QA on pip and friends.

I have pushed it to https://git.fosscommunity.in/praveen/html5lib

Though two tests are failing because of deprecated usage. Can you try to
fix it? I don't know much of python :(

PYBUILD_TEST_ARGS="py.test" dh_auto_test --buildsystem=pybuild
I: pybuild base:184: py.test
= test session starts
==
platform linux2 -- Python 2.7.13, pytest-3.0.5, py-1.4.32, pluggy-0.4.0
rootdir: /<>, inifile:
plugins: expect-1.1.0
Testing tree builders cElementTree ElementTree lxml DOM
Testing tree walkers PullDOM DOM lxml_native cElementTree genshi ElementTree
collected 25977 items / 2 errors

 ERRORS

__ ERROR collecting html5lib/tests/test_sanitizer.py
___
/usr/lib/python2.7/dist-packages/_pytest/runner.py:163: in __init__
self.result = func()
/usr/lib/python2.7/dist-packages/_pytest/main.py:464: in _memocollect
return self._memoizedcall('_collected', lambda: list(self.collect()))
/usr/lib/python2.7/dist-packages/_pytest/main.py:335: in _memoizedcall
res = function()
/usr/lib/python2.7/dist-packages/_pytest/main.py:464: in 
return self._memoizedcall('_collected', lambda: list(self.collect()))
/usr/lib/python2.7/dist-packages/_pytest/python.py:412: in collect
return super(Module, self).collect()
/usr/lib/python2.7/dist-packages/_pytest/python.py:326: in collect
res = self.makeitem(name, obj)
/usr/lib/python2.7/dist-packages/_pytest/python.py:338: in makeitem
collector=self, name=name, obj=obj)
/usr/lib/python2.7/dist-packages/_pytest/vendored_packages/pluggy.py:745:
in __call__
return self._hookexec(self, self._nonwrappers + self._wrappers, kwargs)
/usr/lib/python2.7/dist-packages/_pytest/vendored_packages/pluggy.py:339:
in _hookexec
return self._inner_hookexec(hook, methods, kwargs)
/usr/lib/python2.7/dist-packages/_pytest/vendored_packages/pluggy.py:334:
in 
_MultiCall(methods, kwargs, hook.spec_opts).execute()
/usr/lib/python2.7/dist-packages/_pytest/vendored_packages/pluggy.py:613:
in execute
return _wrapped_call(hook_impl.function(*args), self.execute)
/usr/lib/python2.7/dist-packages/_pytest/vendored_packages/pluggy.py:250:
in _wrapped_call
wrap_controller.send(call_outcome)
/usr/lib/python2.7/dist-packages/_pytest/python.py:197: in
pytest_pycollect_makeitem
res = list(collector._genfunctions(name, obj))
/usr/lib/python2.7/dist-packages/_pytest/python.py:360: in _genfunctions
Function = self._getcustomclass("Function")
/usr/lib/python2.7/dist-packages/_pytest/main.py:280: in _getcustomclass
cls = getattr(self, name)
/usr/lib/python2.7/dist-packages/_pytest/main.py:197: in fget
PendingDeprecationWarning, stacklevel=2)
E   PendingDeprecationWarning: This usage is deprecated, please use
pytest.Function instead
_ ERROR collecting html5lib/tests/test_treeadapters.py
_
/usr/lib/python2.7/dist-packages/_pytest/runner.py:163: in __init__
self.result = func()
/usr/lib/python2.7/dist-packages/_pytest/main.py:464: in _memocollect
return self._memoizedcall('_collected', lambda: list(self.collect()))
/usr/lib/python2.7/dist-packages/_pytest/main.py:335: in _memoizedcall
res = function()
/usr/lib/python2.7/dist-packages/_pytest/main.py:464: in 
return self._memoizedcall('_collected', lambda: list(self.collect()))
/usr/lib/python2.7/dist-packages/_pytest/python.py:412: in collect
return super(Module, self).collect()
/usr/lib/python2.7/dist-packages/_pytest/python.py:326: in collect
res = self.makeitem(name, obj)
/usr/lib/python2.7/dist-packages/_pytest/python.py:338: in makeitem
collector=self, name=name, obj=obj)
/usr/lib/python2.7/dist-packages/_pytest/vendored_packages/pluggy.py:745:
in __call__
return self._hookexec(self, self._nonwrappers + self._wrappers, kwargs)
/usr/lib/python2.7/dist-packages/_pytest/vendored_packages/pluggy.py:339:
in _hookexec
return self._inner_hookexec(hook, methods, kwargs)
/usr/lib/python2.7/dist-packages/_pytest/vendored_packages/pluggy.py:334:
in 
_MultiCall(methods, kwargs, hook.spec_opts).execute()
/usr/lib/python2.7/dist-packages/_pytest/vendored_packages/pluggy.py:613:
in execute
return _wrapped_call(hook_impl.function(*args), self.execute)
/usr/lib/python2.7/dist-packages/_pytest/vendored_packages/pluggy.py:250:
in _wrapped_call
wrap_controller.send(call_outcome)
/usr/lib/python2.7/dist-packages/_pytest/python.py:197: in
pytest_pycollect_makeitem
res = list(collector._genfunctions(name, obj))
/usr/lib/python2.7/dist-packages/_pytest/python.py:360: in _genfunctions
Function = self._getcustomclass("Function")
/usr/lib/python2.7/dist-packages/_pytest/main.py:280: in _getcustomclass
cls = getattr(self, name)

Bug#844943: python-bleach: FTBFS: Tests failures

[Barry Warsaw]

On Jan 13, 2017, at 09:16 PM, Pirate Praveen wrote:

>I would prefer this approach as I prefer to avoid maintaining two
>versions if possible. I cloned html5lib.git repo, but found recent tags
>missing there. Can you push them?

Apologies.  Tags pushed.  Let me know when you have a repo or branch for me to
test and I will do QA on pip and friends.


pgpBaMg2Bcian.pgp
Description: OpenPGP digital signature

Bug#844943: python-bleach: FTBFS: Tests failures

[Pirate Praveen]

On Tue, 10 Jan 2017 10:39:29 -0500 Barry Warsaw  wrote:
> I had a conversation with the upstream pip maintainer.  In theory it may be
> possible.  In practice it's often a nightmare to go backwards.  I'm willing to
> help try to make that happen if others are also willing to help.

I am interested in a fix and willing to help. I have some experience
uploading older version using new.REALLY.old version scheme.

> >It is not sustainable to expect maintainers to reverse dependencies to fix
> >breakage with out giving them advance notice. Since python-bleach has
> >autopkgtests defined, it would have been easy to find out if an update of
> >python-html5lib would break it or not using a tool like build-and-upload
> >script from pkg-ruby-extras team [1]
> 
> I'm not sure why you think I'd know anything about an obscure Ruby tool.  I
> still contend that Debian ought to have automatic promotion gating on reverse
> dependency building and testing.

I've been trying to promote that tool ever since I started using it. I
wish that tool is more visible, but it needs more work before it can be
packaged. See https://lists.debian.org/debian-ruby/2016/11/msg00011.html

> All that aside, if someone wants to help put together a git branch that
> properly reverts html5lib to seven-9's, I will gladly review and test it with
> pip, and upload it if it looks okay.

I would prefer this approach as I prefer to avoid maintaining two
versions if possible. I cloned html5lib.git repo, but found recent tags
missing there. Can you push them?



signature.asc
Description: OpenPGP digital signature

Bug#844943: python-bleach: FTBFS: Tests failures

[Barry Warsaw]

Here's another thought.

What if we upload a new html5lib source package containing seven-9's?  I know
we're in freeze, but this may make the most sense.  Then, packages which need
the old version like bleach can depend on the seven-9's version and that won't
affect packages which require the newer version like pip.

Eventually bleach will fix their package to work with the newer html5lib, or
even html5lib 1.0 when that gets released.  Then we can remove the seven-9's
package.  It's something of a mini-transition, and I'm not happy about having
to do that, but it seems to be the least painful suggestion for now, with the
least possibility of regressions or breakages.

Cheers,
-Barry



pgpoIISfZz1IH.pgp
Description: OpenPGP digital signature

Bug#844943: python-bleach: FTBFS: Tests failures

[Barry Warsaw]

On Jan 10, 2017, at 09:37 AM, Pirate Praveen wrote:

>bleach and other projects using html5lib seems to have locked the version of
>html5lib to the one with 7 nines. Can we also go back to the older version
>which works?

I had a conversation with the upstream pip maintainer.  In theory it may be
possible.  In practice it's often a nightmare to go backwards.  I'm willing to
help try to make that happen if others are also willing to help.

>It is not sustainable to expect maintainers to reverse dependencies to fix
>breakage with out giving them advance notice. Since python-bleach has
>autopkgtests defined, it would have been easy to find out if an update of
>python-html5lib would break it or not using a tool like build-and-upload
>script from pkg-ruby-extras team [1]

I'm not sure why you think I'd know anything about an obscure Ruby tool.  I
still contend that Debian ought to have automatic promotion gating on reverse
dependency building and testing.

All that aside, if someone wants to help put together a git branch that
properly reverts html5lib to seven-9's, I will gladly review and test it with
pip, and upload it if it looks okay.

Cheers,
-Barry


pgpFj0CJk4Gu5.pgp
Description: OpenPGP digital signature

Bug#844943: python-bleach: FTBFS: Tests failures

[Pirate Praveen]

On Mon, 19 Dec 2016 20:54:02 +0530 Pirate Praveen 
wrote:
> Seems python-html5lib was updated without checking reverse dependency
> compatibility  https://github.com/mozilla/bleach/issues/212
> 

bleach and other projects using html5lib seems to have locked the
version of html5lib to the one with 7 nines. Can we also go back to the
older version which works?

It is not sustainable to expect maintainers to reverse dependencies to
fix breakage with
out giving them advance notice. Since python-bleach has autopkgtests
defined, it
would have been easy to find out if an update of python-html5lib would
break it or not using a tool like build-and-upload script from
pkg-ruby-extras team [1]

This is now blocking progress of pagure too (which we want to use for
git.debian.org).

[1]
https://anonscm.debian.org/cgit/pkg-ruby-extras/pkg-ruby-extras.git/tree/build-and-upload



signature.asc
Description: OpenPGP digital signature

Bug#844943: python-bleach: FTBFS: Tests failures

[Pirate Praveen]

Control: forwarded -1 https://github.com/mozilla/bleach/issues/212

On Sat, 19 Nov 2016 07:57:35 +0100 Lucas Nussbaum  wrote:
> During a rebuild of all packages in sid, your package failed to build on
> amd64.
> 
> Relevant part (hopefully):
> > Traceback (most recent call last):
> >   File "/usr/lib/python2.7/dist-packages/nose/loader.py", line 418, in 
> > loadTestsFromName
> > addr.filename, addr.module)
> >   File "/usr/lib/python2.7/dist-packages/nose/importer.py", line 47, in 
> > importFromPath
> > return self.importFromDir(dir_path, fqname)
> >   File "/usr/lib/python2.7/dist-packages/nose/importer.py", line 94, in 
> > importFromDir
> > mod = load_module(part_fqname, fh, filename, desc)
> >   File "/<>/bleach/__init__.py", line 8, in 
> > from html5lib.sanitizer import HTMLSanitizer
> > ImportError: No module named sanitizer

Seems python-html5lib was updated without checking reverse dependency
compatibility  https://github.com/mozilla/bleach/issues/212



signature.asc
Description: OpenPGP digital signature

Bug#844943: python-bleach: FTBFS: Tests failures

[Lucas Nussbaum]

Source: python-bleach
Version: 1.4.2-1
Severity: serious
Tags: stretch sid
User: debian...@lists.debian.org
Usertags: qa-ftbfs-20161118 qa-ftbfs
Justification: FTBFS on amd64

Hi,

During a rebuild of all packages in sid, your package failed to build on
amd64.

Relevant part (hopefully):
> Traceback (most recent call last):
>   File "/usr/lib/python2.7/dist-packages/nose/loader.py", line 418, in 
> loadTestsFromName
> addr.filename, addr.module)
>   File "/usr/lib/python2.7/dist-packages/nose/importer.py", line 47, in 
> importFromPath
> return self.importFromDir(dir_path, fqname)
>   File "/usr/lib/python2.7/dist-packages/nose/importer.py", line 94, in 
> importFromDir
> mod = load_module(part_fqname, fh, filename, desc)
>   File "/<>/bleach/__init__.py", line 8, in 
> from html5lib.sanitizer import HTMLSanitizer
> ImportError: No module named sanitizer
> 
> --
> Ran 1 test in 0.018s
> 
> FAILED (errors=1)
> debian/rules:13: recipe for target 'override_dh_auto_test' failed

The full build log is available from:
   http://aws-logs.debian.net/2016/11/18/python-bleach_1.4.2-1_unstable.log

A list of current common problems and possible solutions is available at
http://wiki.debian.org/qa.debian.org/FTBFS . You're welcome to contribute!

About the archive rebuild: The rebuild was done on EC2 VM instances from
Amazon Web Services, using a clean, minimal and up-to-date chroot. Every
failed build was retried once to eliminate random failures.