Bug#859867: [buildd-tools-devel] Bug#859867: Bug#859867: Please add a package which automatically configures sbuild for Debian packaging

control: block -1 by 870260 Thanks for the thorough review. It took me quite a bit to address all these comments :). Find the updated patch attached, and answers inline: On Wed, Aug 2, 2017 at 8:11 AM, Johannes Schauer wrote: > Quoting Michael Stapelberg (2017-08-01

Bug#859867: [buildd-tools-devel] Bug#859867: Bug#859867: Please add a package which automatically configures sbuild for Debian packaging

Quoting Michael Stapelberg (2017-08-01 23:15:04) > Alright! Patch attached and provided inline, for your convenience: Cool! > +if (!defined($ENV{SUDO_USER})) { > +die "Please run sudo $0"; > +} Should you not rather check the UID instead? > +system("adduser", "--quiet", "--",

Bug#859867: [buildd-tools-devel] Bug#859867: Bug#859867: Please add a package which automatically configures sbuild for Debian packaging

Alright! Patch attached and provided inline, for your convenience: >From b29b1faf6bafb4b6e51b4e99d0febc81abbb543c Mon Sep 17 00:00:00 2001 From: Michael Stapelberg Date: Tue, 1 Aug 2017 23:13:36 +0200 Subject: [PATCH] add sbuild-debian-developer-setup package ---

Bug#859867: [buildd-tools-devel] Bug#859867: Bug#859867: Please add a package which automatically configures sbuild for Debian packaging

That works for me :). How shall we proceed? Should I prepare a patch against the sbuild package? On Tue, Aug 1, 2017 at 11:00 AM, Johannes Schauer wrote: > Quoting Michael Stapelberg (2017-08-01 10:51:41) > > I think the following suggestion takes care of all the concerns you

Bug#859867: [buildd-tools-devel] Bug#859867: Bug#859867: Please add a package which automatically configures sbuild for Debian packaging

Quoting Michael Stapelberg (2017-08-01 11:04:16) > That works for me :). > > How shall we proceed? Should I prepare a patch against the sbuild package? Yes please! Put the patch into this bug and then we can talk about it. :) signature.asc Description: signature

Bug#859867: [buildd-tools-devel] Bug#859867: Bug#859867: Please add a package which automatically configures sbuild for Debian packaging

Quoting Michael Stapelberg (2017-08-01 10:51:41) > I think the following suggestion takes care of all the concerns you brought > up: Let’s name it sbuild-debian-developer-setup, describe that the goal is to > provide an sbuild setup which can build packages for Debian unstable, > automates

Bug#859867: [buildd-tools-devel] Bug#859867: Bug#859867: Please add a package which automatically configures sbuild for Debian packaging

On Mon, Jul 31, 2017 at 4:24 PM, Johannes Schauer wrote: > Quoting Michael Stapelberg (2017-07-31 14:19:16) > > Unless I’m mistaken, the following is what we’d need to recommend to new > > users: > > > > % sudo apt install sbuild apt-cacher-ng lintian > > Why install lintian? >

Bug#859867: [buildd-tools-devel] Bug#859867: Bug#859867: Please add a package which automatically configures sbuild for Debian packaging

Quoting Michael Stapelberg (2017-07-31 14:19:16) > Unless I’m mistaken, the following is what we’d need to recommend to new > users: > > % sudo apt install sbuild apt-cacher-ng lintian Why install lintian? > % sudo adduser --quiet -- "$USER" sbuild Better: sudo sbuild-adduser $USER > % sudo

Bug#859867: [buildd-tools-devel] Bug#859867: Bug#859867: Please add a package which automatically configures sbuild for Debian packaging

On Sun, Jul 30, 2017 at 7:53 PM, Johannes Schauer wrote: > Hi, > > Quoting Michael Stapelberg (2017-06-02 18:23:02) > > Thanks for the review. Answers inline: > > sorry for the delay. I'm under a pile of work and this wasn't on the top > of my > todo list. But let me not stall

Bug#859867: [buildd-tools-devel] Bug#859867: Bug#859867: Please add a package which automatically configures sbuild for Debian packaging

Hi, Quoting Michael Stapelberg (2017-06-02 18:23:02) > Thanks for the review. Answers inline: sorry for the delay. I'm under a pile of work and this wasn't on the top of my todo list. But let me not stall your work: > > > # Enable eatmydata: occasionally losing a test build is preferable over >

Bug#859867: [buildd-tools-devel] Bug#859867: Bug#859867: Please add a package which automatically configures sbuild for Debian packaging

josch, friendly ping? :) On Fri, Jun 2, 2017 at 6:23 PM, Michael Stapelberg wrote: > Thanks for the review. Answers inline: > > On Wed, May 24, 2017 at 11:03 AM, Johannes Schauer > wrote: > >> Hi, >> >> Quoting Geert Stappers (2017-05-21 08:43:31) >> >

Bug#859867: [buildd-tools-devel] Bug#859867: Bug#859867: Please add a package which automatically configures sbuild for Debian packaging

Thanks for the review. Answers inline: On Wed, May 24, 2017 at 11:03 AM, Johannes Schauer wrote: > Hi, > > Quoting Geert Stappers (2017-05-21 08:43:31) > > the debian/postinst now here inline > > thanks, that allows me to comment easily. > > > # Add to group sbuild all

Bug#859867: [buildd-tools-devel] Bug#859867: Bug#859867: Please add a package which automatically configures sbuild for Debian packaging

Hi, Quoting Geert Stappers (2017-05-21 08:43:31) > the debian/postinst now here inline thanks, that allows me to comment easily. > # Add to group sbuild all “dynamically allocated user accounts”; see > # https://www.debian.org/doc/debian-policy/ch-opersys.html > for user in $(getent passwd

Bug#859867: [buildd-tools-devel] Bug#859867: Bug#859867: Please add a package which automatically configures sbuild for Debian packaging

Hi, Michael Stapelberg writes: > Doing it in a script is one more step. The point of this endavour is to > make the setup as simple as possible. I think creating a chroot in postinst is not good. Mostly because maintainer scripts should never fail, but this is too likely

Bug#859867: [buildd-tools-devel] Bug#859867: Bug#859867: Please add a package which automatically configures sbuild for Debian packaging

Doing it in a script is one more step. The point of this endavour is to make the setup as simple as possible. On that note, the awkward newgrp step afterwards still irks me. On Sun, May 21, 2017 at 8:43 AM, Geert Stappers wrote: > On Sat, May 20, 2017 at 11:34:37PM +0200,

Bug#859867: [buildd-tools-devel] Bug#859867: Bug#859867: Please add a package which automatically configures sbuild for Debian packaging

On Sat, May 20, 2017 at 11:34:37PM +0200, Michael Stapelberg wrote: > > Find attached the first draft of my suggestion. I implemented it as a > separate package purely so that I can build it more quickly, but I assume > we???d want to fold this into src:sbuild eventually. > > The resulting