Bug#865087: [Pkg-freeradius-maintainers] Bug#865087: freeradius-mysql: Obsolete and misleading files in /etc/freeradius/sql/

2017-07-03 Thread Ondrej Zary
Yes, it was an upgrade.
So it's a bug/feature of dpkg. I wonder how many obsolete files do I have 
thanks to this "feature"... The obsolete files even became part of the 
upgraded package:

# dpkg -L freeradius-mysql
/.
/usr
/usr/lib
/usr/lib/freeradius
/usr/lib/freeradius/rlm_sql_mysql.so
/usr/share
/usr/share/doc
/usr/share/doc/freeradius-mysql
/usr/share/doc/freeradius-mysql/changelog.Debian.gz
/usr/share/doc/freeradius-mysql/changelog.gz
/usr/share/doc/freeradius-mysql/copyright
/usr/share/lintian
/usr/share/lintian/overrides
/usr/share/lintian/overrides/freeradius-mysql
/etc/freeradius/sql/mysql/admin.sql
/etc/freeradius/sql/mysql/counter.conf
/etc/freeradius/sql/mysql/cui.conf
/etc/freeradius/sql/mysql/cui.sql
/etc/freeradius/sql/mysql/dialup.conf
/etc/freeradius/sql/mysql/ippool-dhcp.conf
/etc/freeradius/sql/mysql/ippool.conf
/etc/freeradius/sql/mysql/ippool.sql
/etc/freeradius/sql/mysql/nas.sql
/etc/freeradius/sql/mysql/schema.sql
/etc/freeradius/sql/mysql/wimax.conf
/etc/freeradius/sql/mysql/wimax.sql


On Monday 03 July 2017, Michael Stapelberg wrote:
> Actually, the freeradius-mysql package does not contain any files in
> /etc/freeradius/sql, see
> https://packages.debian.org/buster/amd64/freeradius-mysql/filelist.
>
> My guess is that you upgraded from an older version, and dpkg left these
> files in place. I’m not sure if there is something we can do better in the
> packaging to handle this case. Hints/patches welcome.
>
> On Mon, Jun 19, 2017 at 12:47 PM, Ondrej Zary 
>
> wrote:
> > Seems that all files in /etc/freeradius/sql/mysql have a newer version
> > available in /etc/freeradius/3.0/mods-config/sql/ so they probably could
> > be
> > deleted all. Or moved from freeradius-config to freeradius-mysql?
> >
> > This might be true also for other freeradius-*sql packages.
> >
> > admin.sql -> main/mysql/setup.sql
> > counter.conf -> counter/mysql/
> > cui.conf -> cui/mysql/queries.conf
> > cui.sql -> cui/mysql/schema.sql
> > dialup.conf -> main/mysql/queries.conf
> > ippool.conf -> ippool/mysql/queries.conf
> > ippool-dhcp.conf -> ippool-dhcp/mysql/queries.conf
> > ippool.sql -> ippool/mysql/schema.sql
> > nas.sql -> included in main/mysql/schema.sql
> > schema.sql -> main/mysql/schema.sql
> > wimax.conf -> main/mysql/extras/wimax/queries.conf
> > wimax.sql -> main/mysql/extras/wimax/schema.sql
> >
> > On Monday 19 June 2017, Michael Stapelberg wrote:
> > > I don’t use FreeRADIUS with MySQL, so I never noticed. Do you suggest
> > > to just delete the file?
> > >
> > > On Mon, Jun 19, 2017 at 12:39 AM, Ondrej Zary <
> >
> > li...@rainbow-software.org>
> >
> > > wrote:
> > > > Package: freeradius-mysql
> > > > Version: 3.0.12+dfsg-5
> > > > Severity: normal
> > > >
> > > > Dear Maintainer,
> > > > freeradius-mysql package includes obsolete and misleading files in
> > > > /etc/freeradius/sql/mysql/.
> > > > e.g. /etc/freeradius/sql/mysql/schema.sql contains radacct table
> > > > definition which no longer works with freeradius 3
> > > >
> > > > The correct one is in /etc/freeradius/3.0/mods-
> > > > config/sql/main/mysql/schema.sql in freeradius-config package.
> > > >
> > > >
> > > > -- System Information:
> > > > Debian Release: 9.0
> > > >   APT prefers stable
> > > >   APT policy: (500, 'stable')
> > > > Architecture: amd64 (x86_64)
> > > >
> > > > Kernel: Linux 4.9.0-3-amd64 (SMP w/2 CPU cores)
> > > > Locale: LANG=en_US.UTF-8, LC_CTYPE=en_US.UTF-8 (charmap=UTF-8),
> > > > LANGUAGE=en_US.UTF-8 (charmap=UTF-8)
> > > > Shell: /bin/sh linked to /bin/dash
> > > > Init: sysvinit (via /sbin/init)
> > > >
> > > > Versions of packages freeradius-mysql depends on:
> > > > ii  freeradius  3.0.12+dfsg-5
> > > > ii  libc6   2.24-11
> > > > ii  libmariadbclient18  10.1.23-9+deb9u1
> > > > ii  zlib1g  1:1.2.8.dfsg-5
> > > >
> > > > freeradius-mysql recommends no packages.
> > > >
> > > > freeradius-mysql suggests no packages.
> > > >
> > > > -- no debconf information
> > > >
> > > > ___
> > > > Pkg-freeradius-maintainers mailing list
> > > > pkg-freeradius-maintain...@lists.alioth.debian.org
> > > > https://lists.alioth.debian.org/mailman/listinfo/pkg-
> > > > freeradius-maintainers
> >
> > --
> > Ondrej Zary



-- 
Ondrej Zary



Bug#865087: [Pkg-freeradius-maintainers] Bug#865087: freeradius-mysql: Obsolete and misleading files in /etc/freeradius/sql/

2017-07-02 Thread Michael Stapelberg
Actually, the freeradius-mysql package does not contain any files in
/etc/freeradius/sql, see
https://packages.debian.org/buster/amd64/freeradius-mysql/filelist.

My guess is that you upgraded from an older version, and dpkg left these
files in place. I’m not sure if there is something we can do better in the
packaging to handle this case. Hints/patches welcome.

On Mon, Jun 19, 2017 at 12:47 PM, Ondrej Zary 
wrote:

> Seems that all files in /etc/freeradius/sql/mysql have a newer version
> available in /etc/freeradius/3.0/mods-config/sql/ so they probably could
> be
> deleted all. Or moved from freeradius-config to freeradius-mysql?
>
> This might be true also for other freeradius-*sql packages.
>
> admin.sql -> main/mysql/setup.sql
> counter.conf -> counter/mysql/
> cui.conf -> cui/mysql/queries.conf
> cui.sql -> cui/mysql/schema.sql
> dialup.conf -> main/mysql/queries.conf
> ippool.conf -> ippool/mysql/queries.conf
> ippool-dhcp.conf -> ippool-dhcp/mysql/queries.conf
> ippool.sql -> ippool/mysql/schema.sql
> nas.sql -> included in main/mysql/schema.sql
> schema.sql -> main/mysql/schema.sql
> wimax.conf -> main/mysql/extras/wimax/queries.conf
> wimax.sql -> main/mysql/extras/wimax/schema.sql
>
> On Monday 19 June 2017, Michael Stapelberg wrote:
> > I don’t use FreeRADIUS with MySQL, so I never noticed. Do you suggest to
> > just delete the file?
> >
> > On Mon, Jun 19, 2017 at 12:39 AM, Ondrej Zary <
> li...@rainbow-software.org>
> >
> > wrote:
> > > Package: freeradius-mysql
> > > Version: 3.0.12+dfsg-5
> > > Severity: normal
> > >
> > > Dear Maintainer,
> > > freeradius-mysql package includes obsolete and misleading files in
> > > /etc/freeradius/sql/mysql/.
> > > e.g. /etc/freeradius/sql/mysql/schema.sql contains radacct table
> > > definition which no longer works with freeradius 3
> > >
> > > The correct one is in /etc/freeradius/3.0/mods-
> > > config/sql/main/mysql/schema.sql in freeradius-config package.
> > >
> > >
> > > -- System Information:
> > > Debian Release: 9.0
> > >   APT prefers stable
> > >   APT policy: (500, 'stable')
> > > Architecture: amd64 (x86_64)
> > >
> > > Kernel: Linux 4.9.0-3-amd64 (SMP w/2 CPU cores)
> > > Locale: LANG=en_US.UTF-8, LC_CTYPE=en_US.UTF-8 (charmap=UTF-8),
> > > LANGUAGE=en_US.UTF-8 (charmap=UTF-8)
> > > Shell: /bin/sh linked to /bin/dash
> > > Init: sysvinit (via /sbin/init)
> > >
> > > Versions of packages freeradius-mysql depends on:
> > > ii  freeradius  3.0.12+dfsg-5
> > > ii  libc6   2.24-11
> > > ii  libmariadbclient18  10.1.23-9+deb9u1
> > > ii  zlib1g  1:1.2.8.dfsg-5
> > >
> > > freeradius-mysql recommends no packages.
> > >
> > > freeradius-mysql suggests no packages.
> > >
> > > -- no debconf information
> > >
> > > ___
> > > Pkg-freeradius-maintainers mailing list
> > > pkg-freeradius-maintain...@lists.alioth.debian.org
> > > https://lists.alioth.debian.org/mailman/listinfo/pkg-
> > > freeradius-maintainers
>
>
> --
> Ondrej Zary
>



-- 
Best regards,
Michael


Bug#865087: [Pkg-freeradius-maintainers] Bug#865087: freeradius-mysql: Obsolete and misleading files in /etc/freeradius/sql/

2017-06-19 Thread Ondrej Zary
Seems that all files in /etc/freeradius/sql/mysql have a newer version 
available in /etc/freeradius/3.0/mods-config/sql/ so they probably could be 
deleted all. Or moved from freeradius-config to freeradius-mysql?

This might be true also for other freeradius-*sql packages.

admin.sql -> main/mysql/setup.sql
counter.conf -> counter/mysql/
cui.conf -> cui/mysql/queries.conf
cui.sql -> cui/mysql/schema.sql
dialup.conf -> main/mysql/queries.conf
ippool.conf -> ippool/mysql/queries.conf
ippool-dhcp.conf -> ippool-dhcp/mysql/queries.conf
ippool.sql -> ippool/mysql/schema.sql
nas.sql -> included in main/mysql/schema.sql
schema.sql -> main/mysql/schema.sql
wimax.conf -> main/mysql/extras/wimax/queries.conf
wimax.sql -> main/mysql/extras/wimax/schema.sql

On Monday 19 June 2017, Michael Stapelberg wrote:
> I don’t use FreeRADIUS with MySQL, so I never noticed. Do you suggest to
> just delete the file?
>
> On Mon, Jun 19, 2017 at 12:39 AM, Ondrej Zary 
>
> wrote:
> > Package: freeradius-mysql
> > Version: 3.0.12+dfsg-5
> > Severity: normal
> >
> > Dear Maintainer,
> > freeradius-mysql package includes obsolete and misleading files in
> > /etc/freeradius/sql/mysql/.
> > e.g. /etc/freeradius/sql/mysql/schema.sql contains radacct table
> > definition which no longer works with freeradius 3
> >
> > The correct one is in /etc/freeradius/3.0/mods-
> > config/sql/main/mysql/schema.sql in freeradius-config package.
> >
> >
> > -- System Information:
> > Debian Release: 9.0
> >   APT prefers stable
> >   APT policy: (500, 'stable')
> > Architecture: amd64 (x86_64)
> >
> > Kernel: Linux 4.9.0-3-amd64 (SMP w/2 CPU cores)
> > Locale: LANG=en_US.UTF-8, LC_CTYPE=en_US.UTF-8 (charmap=UTF-8),
> > LANGUAGE=en_US.UTF-8 (charmap=UTF-8)
> > Shell: /bin/sh linked to /bin/dash
> > Init: sysvinit (via /sbin/init)
> >
> > Versions of packages freeradius-mysql depends on:
> > ii  freeradius  3.0.12+dfsg-5
> > ii  libc6   2.24-11
> > ii  libmariadbclient18  10.1.23-9+deb9u1
> > ii  zlib1g  1:1.2.8.dfsg-5
> >
> > freeradius-mysql recommends no packages.
> >
> > freeradius-mysql suggests no packages.
> >
> > -- no debconf information
> >
> > ___
> > Pkg-freeradius-maintainers mailing list
> > pkg-freeradius-maintain...@lists.alioth.debian.org
> > https://lists.alioth.debian.org/mailman/listinfo/pkg-
> > freeradius-maintainers


-- 
Ondrej Zary



Bug#865087: [Pkg-freeradius-maintainers] Bug#865087: freeradius-mysql: Obsolete and misleading files in /etc/freeradius/sql/

2017-06-19 Thread Michael Stapelberg
I don’t use FreeRADIUS with MySQL, so I never noticed. Do you suggest to
just delete the file?

On Mon, Jun 19, 2017 at 12:39 AM, Ondrej Zary 
wrote:

> Package: freeradius-mysql
> Version: 3.0.12+dfsg-5
> Severity: normal
>
> Dear Maintainer,
> freeradius-mysql package includes obsolete and misleading files in
> /etc/freeradius/sql/mysql/.
> e.g. /etc/freeradius/sql/mysql/schema.sql contains radacct table
> definition which no longer works with freeradius 3
>
> The correct one is in /etc/freeradius/3.0/mods-
> config/sql/main/mysql/schema.sql in freeradius-config package.
>
>
> -- System Information:
> Debian Release: 9.0
>   APT prefers stable
>   APT policy: (500, 'stable')
> Architecture: amd64 (x86_64)
>
> Kernel: Linux 4.9.0-3-amd64 (SMP w/2 CPU cores)
> Locale: LANG=en_US.UTF-8, LC_CTYPE=en_US.UTF-8 (charmap=UTF-8),
> LANGUAGE=en_US.UTF-8 (charmap=UTF-8)
> Shell: /bin/sh linked to /bin/dash
> Init: sysvinit (via /sbin/init)
>
> Versions of packages freeradius-mysql depends on:
> ii  freeradius  3.0.12+dfsg-5
> ii  libc6   2.24-11
> ii  libmariadbclient18  10.1.23-9+deb9u1
> ii  zlib1g  1:1.2.8.dfsg-5
>
> freeradius-mysql recommends no packages.
>
> freeradius-mysql suggests no packages.
>
> -- no debconf information
>
> ___
> Pkg-freeradius-maintainers mailing list
> pkg-freeradius-maintain...@lists.alioth.debian.org
> https://lists.alioth.debian.org/mailman/listinfo/pkg-
> freeradius-maintainers
>



-- 
Best regards,
Michael


Bug#865087: freeradius-mysql: Obsolete and misleading files in /etc/freeradius/sql/

2017-06-19 Thread Ondrej Zary
Package: freeradius-mysql
Version: 3.0.12+dfsg-5
Severity: normal

Dear Maintainer,
freeradius-mysql package includes obsolete and misleading files in 
/etc/freeradius/sql/mysql/.
e.g. /etc/freeradius/sql/mysql/schema.sql contains radacct table definition 
which no longer works with freeradius 3

The correct one is in /etc/freeradius/3.0/mods-config/sql/main/mysql/schema.sql 
in freeradius-config package.


-- System Information:
Debian Release: 9.0
  APT prefers stable
  APT policy: (500, 'stable')
Architecture: amd64 (x86_64)

Kernel: Linux 4.9.0-3-amd64 (SMP w/2 CPU cores)
Locale: LANG=en_US.UTF-8, LC_CTYPE=en_US.UTF-8 (charmap=UTF-8), 
LANGUAGE=en_US.UTF-8 (charmap=UTF-8)
Shell: /bin/sh linked to /bin/dash
Init: sysvinit (via /sbin/init)

Versions of packages freeradius-mysql depends on:
ii  freeradius  3.0.12+dfsg-5
ii  libc6   2.24-11
ii  libmariadbclient18  10.1.23-9+deb9u1
ii  zlib1g  1:1.2.8.dfsg-5

freeradius-mysql recommends no packages.

freeradius-mysql suggests no packages.

-- no debconf information