Bug#870252: pkg-perl-autopkgtest: skip t/00-compile/*.t
On Sun, 06 Aug 2017 22:40:53 +0300, Niko Tyni wrote: > > So I guess we could upload the package with this change? > > Who wants to do it? > Thanks for the eyeballs, uploaded :) > Have a happy DebConf! Thanks × 2 :) Cheers, gregor -- .''`. https://info.comodo.priv.at/ - Debian Developer https://www.debian.org : :' : OpenPGP fingerprint D1E1 316E 93A7 60A8 104D 85FA BB3A 6801 8649 AA06 `. `' Member of VIBE!AT & SPI, fellow of the Free Software Foundation Europe `- signature.asc Description: Digital Signature
Bug#870252: pkg-perl-autopkgtest: skip t/00-compile/*.t
On Sat, Aug 05, 2017 at 02:37:35PM -0400, gregor herrmann wrote: > On Fri, 04 Aug 2017 17:42:47 -0400, Alex Muntada wrote: > > > gregor herrmann: > > > A quick glance at the commit says: looks good! > > Looks good to me, too. > > So I guess we could upload the package with this change? > Who wants to do it? Thanks for the eyeballs, uploaded :) Have a happy DebConf! -- Niko
Bug#870252: pkg-perl-autopkgtest: skip t/00-compile/*.t
On Fri, 04 Aug 2017 17:42:47 -0400, Alex Muntada wrote: > gregor herrmann: > > A quick glance at the commit says: looks good! > Looks good to me, too. So I guess we could upload the package with this change? Who wants to do it? Cheers, gregor -- .''`. https://info.comodo.priv.at/ - Debian Developer https://www.debian.org : :' : OpenPGP fingerprint D1E1 316E 93A7 60A8 104D 85FA BB3A 6801 8649 AA06 `. `' Member of VIBE!AT & SPI, fellow of the Free Software Foundation Europe `- signature.asc Description: Digital Signature
Bug#870252: pkg-perl-autopkgtest: skip t/00-compile/*.t
gregor herrmann: > A quick glance at the commit says: looks good! Looks good to me, too. Cheers! Alex signature.asc Description: PGP signature
Bug#870252: pkg-perl-autopkgtest: skip t/00-compile/*.t
On Thu, 03 Aug 2017 20:17:02 +0300, Niko Tyni wrote: > > > > These are not going to work with our autopkgtest setup as they look for > > > > modules in the build tree. Also, we run 'perl -wc' in the autopkgtest > > > > syntax check which should be more or less equivalent. > > > > I propose that we add t/00-compile/*.t to the list that the smoke check > > > > skips automatically. > > > Ack. > > > There are also tons of t/*compile*.t tests which are at best useless: > > And there's t/author/*.t in some packages. > I've pushed 75b5cc25c71a896a85c4e92b8eceadb95439b065 that expands > the skip list significantly. Eyeballs / testing would be welcome. Great, thanks. A quick glance at the commit says: looks good! Cheers, gregor -- .''`. https://info.comodo.priv.at/ - Debian Developer https://www.debian.org : :' : OpenPGP fingerprint D1E1 316E 93A7 60A8 104D 85FA BB3A 6801 8649 AA06 `. `' Member of VIBE!AT & SPI, fellow of the Free Software Foundation Europe `- signature.asc Description: Digital Signature
Bug#870252: pkg-perl-autopkgtest: skip t/00-compile/*.t
On Wed, Aug 02, 2017 at 10:45:48AM -0400, gregor herrmann wrote: > On Mon, 31 Jul 2017 22:14:17 -0400, gregor herrmann wrote: > > > > These are not going to work with our autopkgtest setup as they look for > > > modules in the build tree. Also, we run 'perl -wc' in the autopkgtest > > > syntax check which should be more or less equivalent. > > > I propose that we add t/00-compile/*.t to the list that the smoke check > > > skips automatically. > > Ack. > > There are also tons of t/*compile*.t tests which are at best useless: > > And there's t/author/*.t in some packages. I've pushed 75b5cc25c71a896a85c4e92b8eceadb95439b065 that expands the skip list significantly. Eyeballs / testing would be welcome. -- Niko
Bug#870252: pkg-perl-autopkgtest: skip t/00-compile/*.t
On Mon, 31 Jul 2017 22:14:17 -0400, gregor herrmann wrote: > > These are not going to work with our autopkgtest setup as they look for > > modules in the build tree. Also, we run 'perl -wc' in the autopkgtest > > syntax check which should be more or less equivalent. > > I propose that we add t/00-compile/*.t to the list that the smoke check > > skips automatically. > Ack. > There are also tons of t/*compile*.t tests which are at best useless: And there's t/author/*.t in some packages. Cheers, gregor -- .''`. https://info.comodo.priv.at/ - Debian Developer https://www.debian.org : :' : OpenPGP fingerprint D1E1 316E 93A7 60A8 104D 85FA BB3A 6801 8649 AA06 `. `' Member of VIBE!AT & SPI, fellow of the Free Software Foundation Europe `- signature.asc Description: Digital Signature
Bug#870252: pkg-perl-autopkgtest: skip t/00-compile/*.t
On Mon, 31 Jul 2017 13:18:55 +0300, Niko Tyni wrote: > These are not going to work with our autopkgtest setup as they look for > modules in the build tree. Also, we run 'perl -wc' in the autopkgtest > syntax check which should be more or less equivalent. > I propose that we add t/00-compile/*.t to the list that the smoke check > skips automatically. Ack. There are also tons of t/*compile*.t tests which are at best useless: 246 t/00-compile.t 107 t/00_compile.t 68 t/01_compile.t 15 t/compile.t 11 t/00-compile ← the directory 8 t/000-compile-modules.t 6 t/00compile.t 6 t/01-compile.t 5 t/author-00-compile.t 5 t/01compile.t 2 t/20compile.t 2 t/000-compile.t 2 t/001_compile.t 2 t/000_compile.t 2 t/compile-time.t … (and we are patching some of the t/*compile.t files for autopkgtest) pkg-perl-tools' TODO file also has the note (by me): "maybe skip more *pod* tests?" Currently we're removing rm -f $TDIR/t/pod.t rm -f $TDIR/t/pod-coverage.t but there's also (*pod*, with at least 4 hits): 219 t/release-pod-syntax.t 127 t/release-pod-coverage.t 108 t/author-pod-syntax.t 70 t/pod_coverage.t 59 t/author-pod-coverage.t 53 t/02pod.t 47 t/03podcoverage.t 39 t/99pod.t 29 t/99_pod.t 27 t/pod_cvg.t 27 t/98_pod.t 27 t/pod_syn.t 22 t/99-pod.t 21 t/author-pod-spell.t 15 t/release-pod-linkcheck.t 13 t/99_pod_coverage.t 12 t/00-pod.t 11 t/02-pod-coverage.t 10 t/00_pod.t 10 t/99-pod-coverage.t 9 t/91podcover.t 9 t/90podtest.t 8 t/10pod.t 8 t/03-test-pod.t 7 t/02_pod.t 7 t/02-pod.t 6 t/release-pod-no404s.t 6 t/pod_cvg_pp.t 6 t/01-pod.t 6 t/release-pod-spell.t 6 t/00pod.t 5 t/98-pod_coverage.t 5 t/z_pod.t 5 t/podspell.t 5 t/pods.t 5 t/11pod_cover.t 5 t/01_pod.t 5 t/90-pod.t 5 t/03_pod_coverage.t 5 t/podcover.t 5 t/98_pod_coverage.t 4 t/99podcov.t 4 t/98_pod-coverage.t 4 t/91-pod-coverage.t 4 t/01-pod-coverage.t 4 t/98podsyn.t 4 t/pod_cov.t 4 t/98pod-coverage.t 4 t/99_podcoverage.t (*release* and *author* are probably skipped but the rest of the variety is quite interesting.) I also assume that for rm -f $TDIR/t/04critic.t rm -f $TDIR/t/97_meta.t we could fine some nice variations. 15 t/perlcritic.t 8 t/critic.t 5 t/04critic.t 3 t/96-perl-critic.t 3 t/90-release-perlcritic.t 2 t/93-perl-critic.t … 36 t/release-distmeta.t 17 t/97_meta.t 9 t/96metatest.t 9 t/94metatest.t 9 t/meta.t 6 t/metadata.t 6 t/release-meta-json.t 3 t/02metafiles.t 3 t/05metaspec.t 3 t/04metatester.t 3 t/z_meta.t 2 t/006_metaclass_traits.t 2 t/meta-yml.t 2 t/98metatest.t 2 t/03metaversion.t 2 t/meta-json.t 2 t/release-meta-yaml.t 2 t/02_meta.t … Lots of opportunities to clean up a bit :) Cheers, gregor -- .''`. https://info.comodo.priv.at/ - Debian Developer https://www.debian.org : :' : OpenPGP fingerprint D1E1 316E 93A7 60A8 104D 85FA BB3A 6801 8649 AA06 `. `' Member of VIBE!AT & SPI, fellow of the Free Software Foundation Europe `- signature.asc Description: Digital Signature
Bug#870252: pkg-perl-autopkgtest: skip t/00-compile/*.t
Package: pkg-perl-autopkgtest
Version: 0.37
Severity: wishlist
Starting with 0.37, we run the smoke test with 'prove --recurse'.
This has caused a few dozen regressions where packages that
used to pass their autopkgtest checks are now failing due to
tests in subdirectories of t/ that were not run earlier.
One somewhat common failure mode is breakage in t/00-compile/, which I've
encountered in at least libpath-finddev-perl and libmoosex-has-sugar-perl
and which contain autogenerated tests like this:
use strict;
use warnings;
# This test was generated for
# using by Dist::Zilla::Plugin::Test::Compile::PerFile (
@Author::KENTNL/Test::Compile::PerFile ) version 0.002001
# with template 01-basic.t.tpl
use Test::More 0.89 tests => 1;
require_ok("lib/MooseX/Has/Sugar/Minimal.pm");
These are not going to work with our autopkgtest setup as they look for
modules in the build tree. Also, we run 'perl -wc' in the autopkgtest
syntax check which should be more or less equivalent.
I propose that we add t/00-compile/*.t to the list that the smoke check
skips automatically.
--
Niko Tyni nt...@debian.org
