Bug#871831: mono-tools: Depends on libwebkit1.1-cil which is deprecated

2017-09-21 Thread Jeremy Bicha 
On Thu, Sep 21, 2017 at 2:21 PM, Jo Shields  wrote:
> Go ahead and NMU.

Here's 2 git patches to apply on top of the previous one. I'll upload shortly.

There are 2 rdepends for monodoc-browser: monodoc-manual (from
src:mono) and gmime2.6. I'll file the gmime2.6 bug.

Thanks,
Jeremy Bicha
From fbcd6720134f989ccf6926142dc0c9c4997c9bbd Mon Sep 17 00:00:00 2001
From: Jeremy Bicha 
Date: Thu, 21 Sep 2017 14:54:41 -0400
Subject: [PATCH 1/2] Drop monodoc-browser since it won't run without webkit1

---
 debian/control | 24 
 1 file changed, 12 insertions(+), 12 deletions(-)

diff --git a/debian/control b/debian/control
index 2ba1013..0a20b96 100644
--- a/debian/control
+++ b/debian/control
@@ -24,18 +24,18 @@ Standards-Version: 3.9.2
 Vcs-Git: git://git.debian.org/git/pkg-mono/packages/mono-tools.git
 Vcs-Browser: http://git.debian.org/?p=pkg-mono/packages/mono-tools.git
 
-Package: monodoc-browser
-Provides: monodoc-viewer
-Replaces: monodoc-base (<< 2.10.8.1-3)
-Breaks: monodoc-base (<< 2.10.8.1-3)
-Architecture: all
-Depends: ${cli:Depends}, monodoc-manual, ${misc:Depends}
-Description: MonoDoc GTK+ based viewer
- The MonoDoc Project is the documentation framework of the Mono project which
- provides detailed API documentation for all Mono components and the Mono CLI
- implementation.
- .
- This package contains the GTK+ based viewer of the Mono documentation.
+#Package: monodoc-browser
+#Provides: monodoc-viewer
+#Replaces: monodoc-base (<< 2.10.8.1-3)
+#Breaks: monodoc-base (<< 2.10.8.1-3)
+#Architecture: all
+#Depends: ${cli:Depends}, monodoc-manual, ${misc:Depends}
+#Description: MonoDoc GTK+ based viewer
+# The MonoDoc Project is the documentation framework of the Mono project which
+# provides detailed API documentation for all Mono components and the Mono CLI
+# implementation.
+# .
+# This package contains the GTK+ based viewer of the Mono documentation.
 
 Package: mono-tools-gui
 Architecture: all
-- 
2.14.1

From a0012dd5db28de616d1202c0209fc411d7a90c81 Mon Sep 17 00:00:00 2001
From: Jeremy Bicha 
Date: Thu, 21 Sep 2017 14:57:29 -0400
Subject: [PATCH 2/2] Finalize changelog

---
 debian/changelog | 9 +
 1 file changed, 9 insertions(+)

diff --git a/debian/changelog b/debian/changelog
index af1228a..357d7b4 100644
--- a/debian/changelog
+++ b/debian/changelog
@@ -1,3 +1,12 @@
+mono-tools (4.2-2.1) unstable; urgency=medium
+
+  * Non-maintainer upload.
+  * [a4960e8] Don't Build-Depend on libwebkit-cil-dev (Closes: #871831)
+  * [fbcd672] Drop ilcontrast and monodoc-browser since they won't work
+without webkit1
+
+ -- Jeremy Bicha   Thu, 21 Sep 2017 13:32:38 -0400
+
 mono-tools (4.2-2) unstable; urgency=medium
 
   * [9adcc51] Don't depend on gmcs any more
-- 
2.14.1

Bug#871831: mono-tools: Depends on libwebkit1.1-cil which is deprecated

2017-09-21 Thread Jo Shields 
Go ahead and NMU.


The problem with libwebkit2gtk-4.0-37 is it's a wrapper for allowing Gtk2 
plugins in a Gtk3 browser - it's not a way for Gtk2 apps to continue to use 
Webkit


Sent from Outlook


From: Jeremy Bicha 
Sent: 21 September 2017 14:03:17
To: 871...@bugs.debian.org; Jo Shields
Subject: Re: mono-tools: Depends on libwebkit1.1-cil which is deprecated

Just to be clear, monodoc won't run if it's not built against
webkitgtk (or one of a few other dependencies that aren't in Debian
any more) so we should drop the monodoc package too.

Thanks,
Jeremy Bicha

Bug#871831: mono-tools: Depends on libwebkit1.1-cil which is deprecated

2017-09-21 Thread Jeremy Bicha 
Just to be clear, monodoc won't run if it's not built against
webkitgtk (or one of a few other dependencies that aren't in Debian
any more) so we should drop the monodoc package too.

Thanks,
Jeremy Bicha

Bug#871831: mono-tools: Depends on libwebkit1.1-cil which is deprecated

2017-08-11 Thread Jeremy Bicha 
Here's a slightly improved version of the patch.

Thanks,
Jeremy Bicha
From a4960e84a6ded969b2efde222f287d2fdb03e097 Mon Sep 17 00:00:00 2001
From: Jeremy Bicha 
Date: Sat, 12 Aug 2017 00:07:16 -0400
Subject: [PATCH] Don't Build-Depend on libwebkit-cil-dev

Closes: #871831
---
 debian/control | 2 +-
 debian/mono-tools-gui.install  | 8 
 debian/monodoc-browser.install | 2 +-
 3 files changed, 6 insertions(+), 6 deletions(-)

diff --git a/debian/control b/debian/control
index ad0830d..2ba1013 100644
--- a/debian/control
+++ b/debian/control
@@ -15,7 +15,7 @@ Build-Depends-Indep: cli-common-dev (>= 0.8~exp2~),
  libgnome2.0-cil-dev (>= 2.0),
  libnunit-cil-dev,
  libmono-cecil-cil-dev,
- libwebkit-cil-dev,
+# libwebkit-cil-dev,
  monodoc-base (>= 1.1.9),
  dh-xsp,
  libglib2.0-dev,
diff --git a/debian/mono-tools-gui.install b/debian/mono-tools-gui.install
index 46e51e5..f6bc48b 100644
--- a/debian/mono-tools-gui.install
+++ b/debian/mono-tools-gui.install
@@ -1,7 +1,7 @@
-debian/tmp/usr/bin/ilcontrast
-debian/tmp/usr/lib/ilcontrast/
-debian/tmp/usr/share/applications/ilcontrast.desktop
-debian/tmp/usr/share/pixmaps/ilcontrast.png
+#debian/tmp/usr/bin/ilcontrast
+#debian/tmp/usr/lib/ilcontrast/
+#debian/tmp/usr/share/applications/ilcontrast.desktop
+#debian/tmp/usr/share/pixmaps/ilcontrast.png
 debian/tmp/usr/bin/gui-compare
 debian/tmp/usr/lib/gui-compare/
 debian/tmp/usr/bin/mperfmon
diff --git a/debian/monodoc-browser.install b/debian/monodoc-browser.install
index 76ce562..5fbe635 100644
--- a/debian/monodoc-browser.install
+++ b/debian/monodoc-browser.install
@@ -1,6 +1,6 @@
 debian/tmp/usr/bin/monodoc
 debian/tmp/usr/lib/monodoc/browser.exe
-debian/tmp/usr/lib/monodoc/WebKitHtmlRender.dll
+#debian/tmp/usr/lib/monodoc/WebKitHtmlRender.dll
 debian/tmp/usr/share/pixmaps/monodoc.png
 debian/tmp/usr/share/applications/monodoc.desktop
 debian/update-monodoc /usr/bin
-- 
2.11.0

Bug#871831: mono-tools: Depends on libwebkit1.1-cil which is deprecated

2017-08-11 Thread Jeremy Bicha 
Control: reassign -1 source:mono-tools

Since I misfiled this, I'll repeat my original email.

Hi,

mono-tools-gui and monodoc-browser depends on libwebkit1.1-cil, which
is deprecated in favor of libwebkit2gtk-4.0-37 (provided in Debian by
webkit2gtk). These should be ported to the new webkitgtk version so we
can remove the old, unmaintained one.

Please try to do soon as we're going to try to remove the old webkitgtk soon.

I am filing this bug as "serious" since the old webkitgtk will not be
available in the next major stable release of Debian (codenamed
"buster").

I am attaching a patch to drop the dependency. This means that the
ilcontrast tool will not be available, but I think it may be better
than losing the whole package!

If you have any question don't hesitate to ask.

On behalf of the Debian WebKit Maintainers,
Jeremy Bicha
From 3af5cf8a93236e9355f0f3b61020778e11d396da Mon Sep 17 00:00:00 2001
From: Jeremy Bicha 
Date: Sat, 12 Aug 2017 00:07:16 -0400
Subject: [PATCH] Don't Build-Depend on libwebkit-cil-dev

Closes: #871831
---
 debian/control | 5 +++--
 debian/mono-tools-gui.install  | 8 
 debian/monodoc-browser.install | 2 +-
 3 files changed, 8 insertions(+), 7 deletions(-)

diff --git a/debian/control b/debian/control
index ad0830d..99fbdbe 100644
--- a/debian/control
+++ b/debian/control
@@ -1,7 +1,8 @@
 Source: mono-tools
 Section: devel
 Priority: optional
-Maintainer: Debian Mono Group 
+Maintainer: Ubuntu Developers 
+XSBC-Original-Maintainer: Debian Mono Group 
 Uploaders: Mirco Bauer , Sebastian Dröge 
 Build-Depends: debhelper (>= 7.0.50~)
 Build-Depends-Indep: cli-common-dev (>= 0.8~exp2~),
@@ -15,7 +16,7 @@ Build-Depends-Indep: cli-common-dev (>= 0.8~exp2~),
  libgnome2.0-cil-dev (>= 2.0),
  libnunit-cil-dev,
  libmono-cecil-cil-dev,
- libwebkit-cil-dev,
+# libwebkit-cil-dev,
  monodoc-base (>= 1.1.9),
  dh-xsp,
  libglib2.0-dev,
diff --git a/debian/mono-tools-gui.install b/debian/mono-tools-gui.install
index 46e51e5..f6bc48b 100644
--- a/debian/mono-tools-gui.install
+++ b/debian/mono-tools-gui.install
@@ -1,7 +1,7 @@
-debian/tmp/usr/bin/ilcontrast
-debian/tmp/usr/lib/ilcontrast/
-debian/tmp/usr/share/applications/ilcontrast.desktop
-debian/tmp/usr/share/pixmaps/ilcontrast.png
+#debian/tmp/usr/bin/ilcontrast
+#debian/tmp/usr/lib/ilcontrast/
+#debian/tmp/usr/share/applications/ilcontrast.desktop
+#debian/tmp/usr/share/pixmaps/ilcontrast.png
 debian/tmp/usr/bin/gui-compare
 debian/tmp/usr/lib/gui-compare/
 debian/tmp/usr/bin/mperfmon
diff --git a/debian/monodoc-browser.install b/debian/monodoc-browser.install
index 76ce562..5fbe635 100644
--- a/debian/monodoc-browser.install
+++ b/debian/monodoc-browser.install
@@ -1,6 +1,6 @@
 debian/tmp/usr/bin/monodoc
 debian/tmp/usr/lib/monodoc/browser.exe
-debian/tmp/usr/lib/monodoc/WebKitHtmlRender.dll
+#debian/tmp/usr/lib/monodoc/WebKitHtmlRender.dll
 debian/tmp/usr/share/pixmaps/monodoc.png
 debian/tmp/usr/share/applications/monodoc.desktop
 debian/update-monodoc /usr/bin
-- 
2.11.0

Bug#871831: mono-tools: Depends on libwebkit1.1-cil which is deprecated

2017-08-11 Thread Jeremy Bicha 
Source: blam
Severity: serious
Tags: sid buster patch
User: pkg-webkit-maintain...@lists.alioth.debian.org
Usertags: oldlibs libwebkitgtk-1.0-0 webkit1

Hi,

mono-tools-gui and monodoc-browser depends on libwebkit1.1-cil, which
is deprecated in favor of libwebkit2gtk-4.0-37 (provided in Debian by
webkit2gtk). These should be ported to the new webkitgtk version so we
can remove the old, unmaintained one.

Please try to do soon as we're going to try to remove the old webkitgtk soon.

I am filing this bug as "serious" since the old webkitgtk will not be
available in the next major stable release of Debian (codenamed
"buster").

I am attaching a patch in my next email to drop the dependency. This
means that the ilcontrast tool will not be available, but I think it
may be better than losing the whole package!

If you have any question don't hesitate to ask.

On behalf of the Debian WebKit Maintainers,
Jeremy Bicha