Bug#871964: swt-gtk: Build-depends on libwebkitgtk-dev which is deprecated

[Adrian Bunk]

On Tue, Oct 24, 2017 at 05:50:05PM -0400, Jeremy Bicha wrote:
> On Tue, Oct 24, 2017 at 5:34 PM, Adrian Bunk  wrote:
> > Any fix for swt-gtk should also include fixing the other RC bug #879170,
> > and that would keep webkitgtk in buster - removing webkitgtk from buster
> > without also removing libswt-webkit-gtk-3-jni is simply wrong.
> >
> > An actual fix has to include either updating Eclipse or removing
> > Eclipse from buster.
> 
> Yeah, um, I looked into removing Eclipse from Buster and from what I
> saw, it did not appear practical. See my report at comment #130
> https://bugs.debian.org/681726
> 
> Eclipse is the only remaining reverse-depends of #879170 in Testing
> once tuxguitar migrates soon. So if we ignore Eclipse, we're left with
> the RC bug I am fixing in my NMU being the only thing keeping
> webkitgtk from being removed from Buster.
>...

Your "if we ignore Eclipse" is not a valid approach.

If removing Eclipse from buster is not practical, then removing a
(transitive) dependency of Eclipse is not practical.

> Thanks,
> Jeremy Bicha

cu
Adrian

-- 

   "Is there not promise of rain?" Ling Tan asked suddenly out
of the darkness. There had been need of rain for many days.
   "Only a promise," Lao Er said.
   Pearl S. Buck - Dragon Seed

Bug#879170: Bug#871964: swt-gtk: Build-depends on libwebkitgtk-dev which is deprecated

[Jeremy Bicha]

On Tue, Oct 24, 2017 at 5:34 PM, Adrian Bunk  wrote:
> Any fix for swt-gtk should also include fixing the other RC bug #879170,
> and that would keep webkitgtk in buster - removing webkitgtk from buster
> without also removing libswt-webkit-gtk-3-jni is simply wrong.
>
> An actual fix has to include either updating Eclipse or removing
> Eclipse from buster.

Yeah, um, I looked into removing Eclipse from Buster and from what I
saw, it did not appear practical. See my report at comment #130
https://bugs.debian.org/681726

Eclipse is the only remaining reverse-depends of #879170 in Testing
once tuxguitar migrates soon. So if we ignore Eclipse, we're left with
the RC bug I am fixing in my NMU being the only thing keeping
webkitgtk from being removed from Buster.

There's also https://bugs.debian.org/879228 but I'm hoping that will
be solvable and in my opinion it doesn't need to block webkitgtk's
removal. I am mentioning both of these outstanding RC bugs in the RM
bug I plan to file with the Release Team next week so it will be up to
them to decide.

Thanks,
Jeremy Bicha

Bug#871964: swt-gtk: Build-depends on libwebkitgtk-dev which is deprecated

[Adrian Bunk]

On Tue, Oct 24, 2017 at 03:26:06PM -0400, Jeremy Bicha wrote:
> Control: tags -1 pending
> 
> I am uploading a NMU now that is numbered as swt-gtk 3.8.2-4.1 to drop
> the unnecessary build-depends since this is the last thing keeping
> webkitgtk in Buster. I am uploading to DELAYED/2. Please let me know
> if I should delay this fix any further. git patch attached.

I fail to see how this makes sense.

Any fix for swt-gtk should also include fixing the other RC bug #879170, 
and that would keep webkitgtk in buster - removing webkitgtk from buster 
without also removing libswt-webkit-gtk-3-jni is simply wrong.

An actual fix has to include either updating Eclipse or removing 
Eclipse from buster.

> Thanks,
> Jeremy Bicha

cu
Adrian

-- 

   "Is there not promise of rain?" Ling Tan asked suddenly out
of the darkness. There had been need of rain for many days.
   "Only a promise," Lao Er said.
   Pearl S. Buck - Dragon Seed

Bug#871964: swt-gtk: Build-depends on libwebkitgtk-dev which is deprecated

[Jeremy Bicha]

Control: tags -1 pending

I am uploading a NMU now that is numbered as swt-gtk 3.8.2-4.1 to drop
the unnecessary build-depends since this is the last thing keeping
webkitgtk in Buster. I am uploading to DELAYED/2. Please let me know
if I should delay this fix any further. git patch attached.

Thanks,
Jeremy Bicha
From 89a84e10dd70b681cfa523462e5918850efbfde6 Mon Sep 17 00:00:00 2001
From: Jeremy Bicha 
Date: Tue, 24 Oct 2017 15:25:30 -0400
Subject: [PATCH] Drop unnecessary Build-Depends on libwebkitgtk-dev Closes:
 #871964

---
 debian/changelog | 7 +++
 debian/control   | 1 -
 2 files changed, 7 insertions(+), 1 deletion(-)

diff --git a/debian/changelog b/debian/changelog
index b334072..7840165 100644
--- a/debian/changelog
+++ b/debian/changelog
@@ -1,3 +1,10 @@
+swt-gtk (3.8.2-4.1) unstable; urgency=medium
+
+  * Non-maintainer upload.
+  * Drop unnecessary Build-Depends on libwebkitgtk-dev (Closes: #871964)
+
+ -- Jeremy Bicha   Tue, 24 Oct 2017 15:18:42 -0400
+
 swt-gtk (3.8.2-4) unstable; urgency=medium
 
   * Team upload.
diff --git a/debian/control b/debian/control
index 2dbbe38..f6a9f83 100644
--- a/debian/control
+++ b/debian/control
@@ -18,7 +18,6 @@ Build-Depends:
  libglib2.0-dev (>= 2.35),
  libglu1-mesa-dev | libglu-dev,
  libgnomeui-dev,
- libwebkitgtk-dev,
  libxcb-render-util0-dev,
  libxt-dev,
  libxtst-dev,
-- 
2.14.1

Bug#871964: swt-gtk: Build-depends on libwebkitgtk-dev which is deprecated

[Adrian Bunk]

Control: tags 879170 - buster sid
Control: clone 879170 -2
Control: reassign 879170 libswt-webkit-gtk-3-jni
Control: reassign -2 libswt-webkit-gtk-4-jni
Control: retitle -2 libswt-webkit-gtk-4-jni: Missing webkit dependency

On Thu, Oct 19, 2017 at 08:22:26PM -0400, Jeremy Bicha wrote:
>...
> On Tue, Oct 17, 2017 at 5:12 PM, Adrian Bunk  wrote:
> > On Sat, Aug 12, 2017 at 11:43:58PM -0400, Jeremy Bicha wrote:
> >>...
> >> The package does build successfully without the libwebkitgtk-dev
> >> build-dependency.
> >
> > But the resulting library will still dynamically load it.
> >
> >> It feels to me like the libswt-webkit-gtk-3-jni was already broken
> >> since it doesn't have a dependency on any webkitgtk library
> >
> > The missing dependency sounds like a bug.
> >
> >> (I think
> >> the correct one would be libwebkitgtk-3.0-0 but that is still part of
> >> the deprecated libraries which are being removed.)
> >
> > It does use libwebkitgtk-1.0-0:
> > https://sources.debian.net/src/swt-gtk/3.8.2-4/webkitgtk.h/
> >
> > I just tried, and it does work when libwebkitgtk-1.0-0 is installed
> > (and fails without).
> 
> Ok, I am filing a new bug because the missing dependency should be
> fixed in stretch.

Thanks, I'm cloning this for libswt-webkit-gtk-4-jni which has
the same problem of the missing dependency.

> This link says that Eclipse / swt-gtk 4.4 (released in 2014) has
> initial support for gtk3 and webkit2gtk:
> https://www.eclipse.org/swt/R4_4/new_and_noteworthy.html
> 
> Unfortunately, eclipse and swt-gtk are very outdated in Debian:
>...

Current SWT is in src:swt4-gtk.

> Thank you,
> Jeremy Bicha

cu
Adrian

-- 

   "Is there not promise of rain?" Ling Tan asked suddenly out
of the darkness. There had been need of rain for many days.
   "Only a promise," Lao Er said.
   Pearl S. Buck - Dragon Seed

Bug#871964: swt-gtk: Build-depends on libwebkitgtk-dev which is deprecated

[Jeremy Bicha]

Control: clone -1 -2
Control: retitle -2 libswt-webkit-gtk-3-jni: Missing dependency on
libwebkitgtk-1.0-0
Control: reassign -2 libswt-webkit-gtk-3-jni
Control: tags -2 +stretch

On Tue, Oct 17, 2017 at 5:12 PM, Adrian Bunk  wrote:
> On Sat, Aug 12, 2017 at 11:43:58PM -0400, Jeremy Bicha wrote:
>>...
>> The package does build successfully without the libwebkitgtk-dev
>> build-dependency.
>
> But the resulting library will still dynamically load it.
>
>> It feels to me like the libswt-webkit-gtk-3-jni was already broken
>> since it doesn't have a dependency on any webkitgtk library
>
> The missing dependency sounds like a bug.
>
>> (I think
>> the correct one would be libwebkitgtk-3.0-0 but that is still part of
>> the deprecated libraries which are being removed.)
>
> It does use libwebkitgtk-1.0-0:
> https://sources.debian.net/src/swt-gtk/3.8.2-4/webkitgtk.h/
>
> I just tried, and it does work when libwebkitgtk-1.0-0 is installed
> (and fails without).

Ok, I am filing a new bug because the missing dependency should be
fixed in stretch.

This link says that Eclipse / swt-gtk 4.4 (released in 2014) has
initial support for gtk3 and webkit2gtk:
https://www.eclipse.org/swt/R4_4/new_and_noteworthy.html

Unfortunately, eclipse and swt-gtk are very outdated in Debian:
https://bugs.debian.org/681726

$ reverse-depends -r sid libswt-webkit-gtk-3-jni
===
* eclipse-rcp —so outdated it really needs to be removed from Buster
before release if it's not upgraded regardless of this bug
* tuxguitar
* vuze — already removed from testing, see https://bugs.debian.org/870987
* zekr — already removed from testing, see https://bugs.debian.org/866659

Thank you,
Jeremy Bicha

Bug#871964: swt-gtk: Build-depends on libwebkitgtk-dev which is deprecated

[Adrian Bunk]

On Sat, Aug 12, 2017 at 11:43:58PM -0400, Jeremy Bicha wrote:
>...
> The package does build successfully without the libwebkitgtk-dev
> build-dependency.

But the resulting library will still dynamically load it.

> It feels to me like the libswt-webkit-gtk-3-jni was already broken
> since it doesn't have a dependency on any webkitgtk library

The missing dependency sounds like a bug.

> (I think
> the correct one would be libwebkitgtk-3.0-0 but that is still part of
> the deprecated libraries which are being removed.)

It does use libwebkitgtk-1.0-0:
https://sources.debian.net/src/swt-gtk/3.8.2-4/webkitgtk.h/

I just tried, and it does work when libwebkitgtk-1.0-0 is installed  
(and fails without).

>...
> On behalf of the Debian WebKit Maintainers,
> Jeremy Bicha

cu
Adrian

-- 

   "Is there not promise of rain?" Ling Tan asked suddenly out
of the darkness. There had been need of rain for many days.
   "Only a promise," Lao Er said.
   Pearl S. Buck - Dragon Seed

Bug#871964: swt-gtk: Build-depends on libwebkitgtk-dev which is deprecated

[Jeremy Bicha]

Source: swt-gtk
Severity: serious
Tags: sid buster
User: pkg-webkit-maintain...@lists.alioth.debian.org
Usertags: oldlibs libwebkitgtk-1.0-0 webkit1

Hi,

swt-gtk Build-Depends on libwebkitgtk-dev, which is deprecated in favor of
libwebkit2gtk-4.0-dev (provided in Debian by webkit2gtk). Please drop
this Build-Depends so that we can remove the old, unmaintained one.

Please try to do soon as we're going to try to remove the old webkitgtk soon.

I am filing this bug as "serious" since the old webkitgtk will not be
available in the next major stable release of Debian (codenamed
"buster").

The package does build successfully without the libwebkitgtk-dev
build-dependency.

It feels to me like the libswt-webkit-gtk-3-jni was already broken
since it doesn't have a dependency on any webkitgtk library (I think
the correct one would be libwebkitgtk-3.0-0 but that is still part of
the deprecated libraries which are being removed.)

If you have any question don't hesitate to ask.

On behalf of the Debian WebKit Maintainers,
Jeremy Bicha