Bug#882434: stretch-pu: package ust/2.9.0-2+deb9u1

[Adam D. Barratt]

Control: tags -1 + pending

On Sat, 2018-01-13 at 17:29 +0100, Julien Cristau wrote:
> Control: tag -1 confirmed
> 
> On Wed, Nov 22, 2017 at 15:05:52 -0500, Michael Jeanson wrote:
> 
> > The attached diff fixes a bug that makes the python3-lttngust
> > package
> > completely broken unless the corresponding liblttng-ust-dev is also
> > installed.
> > 
> > The original python code load the library using ctypes without
> > specifying a
> > soname. This fix was reported and merged upstream.
> > 
> 
> Anything using ctypes for library bindings should be taken out back
> and
> shot.
> 
> However, this seems like an improvement over the previous
> even-more-buggy state, so go ahead.

Uploaded and flagged for acceptance.

Regards,

Adam

Bug#882434: stretch-pu: package ust/2.9.0-2+deb9u1

[Julien Cristau]

Control: tag -1 confirmed

On Wed, Nov 22, 2017 at 15:05:52 -0500, Michael Jeanson wrote:

> The attached diff fixes a bug that makes the python3-lttngust package
> completely broken unless the corresponding liblttng-ust-dev is also
> installed.
> 
> The original python code load the library using ctypes without specifying a
> soname. This fix was reported and merged upstream.
> 
Anything using ctypes for library bindings should be taken out back and
shot.

However, this seems like an improvement over the previous
even-more-buggy state, so go ahead.

Cheers,
Julien

Bug#882434: stretch-pu: package ust/2.9.0-2+deb9u1

[Michael Jeanson]

Package: release.debian.org
Severity: normal
Tags: stretch
User: release.debian@packages.debian.org
Usertags: pu

Hi,

The attached diff fixes a bug that makes the python3-lttngust package
completely broken unless the corresponding liblttng-ust-dev is also
installed.

The original python code load the library using ctypes without specifying a
soname. This fix was reported and merged upstream.

Fixed in unstable:

https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=882366

Regards,

Michael

-- System Information:
Debian Release: 9.1
  APT prefers stable
  APT policy: (500, 'stable')
Architecture: i386 (i686)

Kernel: Linux 4.9.0-4-686-pae (SMP w/2 CPU cores)
Locale: LANG=en_CA.UTF-8, LC_CTYPE=en_CA.UTF-8 (charmap=UTF-8), 
LANGUAGE=en_CA:en (charmap=UTF-8)
Shell: /bin/sh linked to /bin/dash
Init: systemd (via /run/systemd/system)
diff -Nru ust-2.9.0/debian/changelog ust-2.9.0/debian/changelog
--- ust-2.9.0/debian/changelog  2017-03-08 12:04:25.0 -0500
+++ ust-2.9.0/debian/changelog  2017-11-22 14:45:44.0 -0500
@@ -1,3 +1,10 @@
+ust (2.9.0-2+deb9u1) stable; urgency=medium
+
+  * [5ffa17d] Set gbp branch config
+  * [8e770e4] Fix python3-lttngust load un-versioned library (Closes: #882366)
+
+ -- Michael Jeanson   Wed, 22 Nov 2017 14:45:44 -0500
+
 ust (2.9.0-2) unstable; urgency=medium
 
   * [b8d4e77] Add missing liblttng-ust-fd.so.* (Closes: #857166)
diff -Nru ust-2.9.0/debian/gbp.conf ust-2.9.0/debian/gbp.conf
--- ust-2.9.0/debian/gbp.conf   1969-12-31 19:00:00.0 -0500
+++ ust-2.9.0/debian/gbp.conf   2017-11-22 14:44:31.0 -0500
@@ -0,0 +1,3 @@
+[DEFAULT]
+upstream-branch=upstream/2.9.0
+debian-branch=debian/stretch
diff -Nru 
ust-2.9.0/debian/patches/fix-specify-soname-in-python-lttngust-loadlibrary.patch
 
ust-2.9.0/debian/patches/fix-specify-soname-in-python-lttngust-loadlibrary.patch
--- 
ust-2.9.0/debian/patches/fix-specify-soname-in-python-lttngust-loadlibrary.patch
1969-12-31 19:00:00.0 -0500
+++ 
ust-2.9.0/debian/patches/fix-specify-soname-in-python-lttngust-loadlibrary.patch
2017-11-22 14:45:15.0 -0500
@@ -0,0 +1,30 @@
+From 00ee1adfe1e34d43494227781f6662b0a21b7c4b Mon Sep 17 00:00:00 2001
+From: Michael Jeanson 
+Date: Tue, 21 Nov 2017 11:11:15 -0500
+Subject: [PATCH] Fix: specify SONAME in python-lttngust LoadLibrary
+
+When loading the python agent library with ctypes in the python
+bindings, specify the SONAME. This will make sure we load the proper
+library in the event of a SONAME bump and the bindings will work without
+having to install the "dev" package which in most distros contains the
+non-versionned ".so".
+
+Signed-off-by: Michael Jeanson 
+Signed-off-by: Mathieu Desnoyers 
+---
+ python-lttngust/lttngust/loghandler.py | 2 +-
+ 1 file changed, 1 insertion(+), 1 deletion(-)
+
+diff --git a/python-lttngust/lttngust/loghandler.py 
b/python-lttngust/lttngust/loghandler.py
+index e82cf5c5..6f144cac 100644
+--- a/python-lttngust/lttngust/loghandler.py
 b/python-lttngust/lttngust/loghandler.py
+@@ -22,7 +22,7 @@
+ 
+ 
+ class _Handler(logging.Handler):
+-_LIB_NAME = 'liblttng-ust-python-agent.so'
++_LIB_NAME = 'liblttng-ust-python-agent.so.0'
+ 
+ def __init__(self):
+ super(self.__class__, self).__init__(level=logging.NOTSET)
diff -Nru ust-2.9.0/debian/patches/series ust-2.9.0/debian/patches/series
--- ust-2.9.0/debian/patches/series 2016-11-29 18:21:51.0 -0500
+++ ust-2.9.0/debian/patches/series 2017-11-22 14:45:15.0 -0500
@@ -1,3 +1,4 @@
 fix-incompatible-java-bytecode-format.patch
 use-python3.patch
 javah-doesnt-generate-class-files.patch
+fix-specify-soname-in-python-lttngust-loadlibrary.patch