Bug#885086: Slightly improved version

2018-03-03 Thread Adam D. Barratt 
Control: tags -1 + pending

On Fri, 2018-03-02 at 17:34 +, Adam D. Barratt wrote:
> Control: tags -1 + confirmed
> 
> On Sat, 2018-01-20 at 11:30 -0200, Eduardo M KALINOWSKI wrote:
> > In the previous message I forgot to change the NEWS.Debian file to
> > better describe the change; this version fixes it.
> 
> The NEWS file needs a small change:
> 
> --- kildclient-3.1.0/debian/NEWS.Debian 2016-12-04 20:46:22.0
> -0200
> +++ kildclient-3.1.0/debian/NEWS.Debian 2018-01-20 10:50:25.0
> -0200
> @@ -1,3 +1,11 @@
> +kildclient (3.1.0-1+deb9u1) stretch-security; urgency=high
> 
> The distribution there should be "stretch", not "stretch-security".
> 
> With that change, please go ahead.
> 

Uploaded and flagged for acceptance.

Regards,

Adam

Bug#885086: Slightly improved version

2018-03-02 Thread Adam D. Barratt 
Control: tags -1 + confirmed

On Sat, 2018-01-20 at 11:30 -0200, Eduardo M KALINOWSKI wrote:
> In the previous message I forgot to change the NEWS.Debian file to
> better describe the change; this version fixes it.

The NEWS file needs a small change:

--- kildclient-3.1.0/debian/NEWS.Debian 2016-12-04 20:46:22.0 -0200
+++ kildclient-3.1.0/debian/NEWS.Debian 2018-01-20 10:50:25.0 -0200
@@ -1,3 +1,11 @@
+kildclient (3.1.0-1+deb9u1) stretch-security; urgency=high

The distribution there should be "stretch", not "stretch-security".

With that change, please go ahead.

Regards,

Adam

Bug#885086: Slightly improved version

2018-01-20 Thread Eduardo M KALINOWSKI 
In the previous message I forgot to change the NEWS.Debian file to
better describe the change; this version fixes it.

-- 
"Atomic batteries to power, turbines to speed."
-- Robin, The Boy Wonder

Eduardo M KALINOWSKI
edua...@kalinowski.com.br

diff -Nru kildclient-3.1.0/debian/changelog kildclient-3.1.0/debian/changelog
--- kildclient-3.1.0/debian/changelog	2016-12-04 20:46:22.0 -0200
+++ kildclient-3.1.0/debian/changelog	2018-01-20 10:50:25.0 -0200
@@ -1,3 +1,10 @@
+kildclient (3.1.0-1+deb9u1) stretch; urgency=low
+
+  * Fix for CVE-2017-17511. New dependency 'desktop-file-utils' required
+in order to use GTK+ function for opening URLs. Closes: #885007
+
+ -- Eduardo M Kalinowski   Sat, 20 Jan 2018 10:50:25 -0200
+
 kildclient (3.1.0-1) unstable; urgency=low
 
   * New upstream version: 3.1.0.
diff -Nru kildclient-3.1.0/debian/control kildclient-3.1.0/debian/control
--- kildclient-3.1.0/debian/control	2016-12-04 20:46:22.0 -0200
+++ kildclient-3.1.0/debian/control	2018-01-20 10:50:25.0 -0200
@@ -10,7 +10,7 @@
 
 Package: kildclient
 Architecture: any
-Depends: ${shlibs:Depends}, ${misc:Depends}, libjson-perl
+Depends: ${shlibs:Depends}, ${misc:Depends}, libjson-perl, desktop-file-utils
 Suggests: kildclient-doc, libgtk3-perl
 Description: powerful MUD client with a built-in Perl interpreter
  KildClient is a MUD Client written with the GTK+ windowing toolkit.
diff -Nru kildclient-3.1.0/debian/NEWS.Debian kildclient-3.1.0/debian/NEWS.Debian
--- kildclient-3.1.0/debian/NEWS.Debian	2016-12-04 20:46:22.0 -0200
+++ kildclient-3.1.0/debian/NEWS.Debian	2018-01-20 10:50:25.0 -0200
@@ -1,3 +1,11 @@
+kildclient (3.1.0-1+deb9u1) stretch-security; urgency=high
+
+  * The option to define the command used to run a web browser has been
+removed; the default browser (as selected by MIME types database) is
+now used.
+
+ -- Eduardo M Kalinowski   Sat, 20 Jan 2018 10:50:25 -0200
+
 kildclient (2.8.1-1) experimental; urgency=low
 
   The HTML manual is now in the package kildclient-doc.
diff -Nru kildclient-3.1.0/debian/patches/cve-2017-17511.patch kildclient-3.1.0/debian/patches/cve-2017-17511.patch
--- kildclient-3.1.0/debian/patches/cve-2017-17511.patch	1969-12-31 21:00:00.0 -0300
+++ kildclient-3.1.0/debian/patches/cve-2017-17511.patch	2018-01-20 08:44:40.0 -0200
@@ -0,0 +1,183 @@
+Description: Fix for CVE-2017-17511
+ Uses a GTK+ function to open URLs, instead of using a command
+ supplied by the user or $BROWSER.
+Author: Eduardo M KALINOWSKI 
+Last-Update: 2017-12-17
+---
+This patch header follows DEP-3: http://dep.debian.net/deps/dep3/
+--- a/doc/C/kildclient.xml
 b/doc/C/kildclient.xml
+@@ -1233,20 +1233,16 @@
+   
+ 
+ 
+-In this section you can configure the command that will be run
+-when you right-click in a URL that appears in the MUD window and
+-select Open Link. The command will be executed,
+-with %s replaced with the URL's address. The
+-ampersand () in the end means that the command
+-is to be executed in the background, so that you can continue using
+-KildClient while browsing the URL.
+-
+-You can also set a command used to play audio files (see In this section you can set a command used to play audio files (see ). Enter the command, with %s
+ in the place of the file path. The default should work (it uses the
+ SOX program, which is usually installed), but you can use other
+ commands if you use ALSA, ARTS, ESD, JACK, etc.
+ 
++Previously it was also possible to define a command to run a web
++browser. This option has been removed, and the default browser is now
++used instead.
++
+ 
+ 
+ 
+--- a/src/dlgPreferences.ui
 b/src/dlgPreferences.ui
+@@ -521,61 +521,6 @@
+ vertical
+ 6
+ 
+-  
+-False
+-bWeb browser/b
+-True
+-0
+-0
+-  
+-  
+-False
+-True
+-0
+-  
+-
+-
+-  
+-False
+-16
+-vertical
+-6
+-
+-  
+-False
+-Enter the command to run a _web browser. %s will be substituted by the web page address:
+-True
+-True
+-txtBrowserCommand
+-0
+-  
+-  
+-False
+-True
+-0
+-  
+-
+-
+-  
+-True
+-Specify the

Bug#885086: Slightly improved version

2018-01-20 Thread Eduardo M KALINOWSKI 
I've made a small change to the package, changing the new dependency
from gvfs to desktop-file-utils, since that's what's really necessary
(as discovered in #885086).

The new debdiff is attached.

-- 
Eduardo M KALINOWSKI
edua...@kalinowski.com.br

diff -Nru kildclient-3.1.0/debian/changelog kildclient-3.1.0/debian/changelog
--- kildclient-3.1.0/debian/changelog	2016-12-04 20:46:22.0 -0200
+++ kildclient-3.1.0/debian/changelog	2018-01-20 10:50:25.0 -0200
@@ -1,3 +1,10 @@
+kildclient (3.1.0-1+deb9u1) stretch; urgency=low
+
+  * Fix for CVE-2017-17511. New dependency 'desktop-file-utils' required
+in order to use GTK+ function for opening URLs. Closes: #885007
+
+ -- Eduardo M Kalinowski   Sat, 20 Jan 2018 10:50:25 -0200
+
 kildclient (3.1.0-1) unstable; urgency=low
 
   * New upstream version: 3.1.0.
diff -Nru kildclient-3.1.0/debian/control kildclient-3.1.0/debian/control
--- kildclient-3.1.0/debian/control	2016-12-04 20:46:22.0 -0200
+++ kildclient-3.1.0/debian/control	2018-01-20 10:50:25.0 -0200
@@ -10,7 +10,7 @@
 
 Package: kildclient
 Architecture: any
-Depends: ${shlibs:Depends}, ${misc:Depends}, libjson-perl
+Depends: ${shlibs:Depends}, ${misc:Depends}, libjson-perl, desktop-file-utils
 Suggests: kildclient-doc, libgtk3-perl
 Description: powerful MUD client with a built-in Perl interpreter
  KildClient is a MUD Client written with the GTK+ windowing toolkit.
diff -Nru kildclient-3.1.0/debian/NEWS.Debian kildclient-3.1.0/debian/NEWS.Debian
--- kildclient-3.1.0/debian/NEWS.Debian	2016-12-04 20:46:22.0 -0200
+++ kildclient-3.1.0/debian/NEWS.Debian	2018-01-20 08:44:40.0 -0200
@@ -1,3 +1,10 @@
+kildclient (3.1.0-1+deb9u1) stretch-security; urgency=high
+
+  * The option to define the command used to run a web browser has been
+removed; the default browser (as selected by gvfs) is now used.
+
+ -- Eduardo M Kalinowski   Sun, 17 Dec 2017 09:42:23 -0200
+
 kildclient (2.8.1-1) experimental; urgency=low
 
   The HTML manual is now in the package kildclient-doc.
diff -Nru kildclient-3.1.0/debian/patches/cve-2017-17511.patch kildclient-3.1.0/debian/patches/cve-2017-17511.patch
--- kildclient-3.1.0/debian/patches/cve-2017-17511.patch	1969-12-31 21:00:00.0 -0300
+++ kildclient-3.1.0/debian/patches/cve-2017-17511.patch	2018-01-20 08:44:40.0 -0200
@@ -0,0 +1,183 @@
+Description: Fix for CVE-2017-17511
+ Uses a GTK+ function to open URLs, instead of using a command
+ supplied by the user or $BROWSER.
+Author: Eduardo M KALINOWSKI 
+Last-Update: 2017-12-17
+---
+This patch header follows DEP-3: http://dep.debian.net/deps/dep3/
+--- a/doc/C/kildclient.xml
 b/doc/C/kildclient.xml
+@@ -1233,20 +1233,16 @@
+   
+ 
+ 
+-In this section you can configure the command that will be run
+-when you right-click in a URL that appears in the MUD window and
+-select Open Link. The command will be executed,
+-with %s replaced with the URL's address. The
+-ampersand () in the end means that the command
+-is to be executed in the background, so that you can continue using
+-KildClient while browsing the URL.
+-
+-You can also set a command used to play audio files (see In this section you can set a command used to play audio files (see ). Enter the command, with %s
+ in the place of the file path. The default should work (it uses the
+ SOX program, which is usually installed), but you can use other
+ commands if you use ALSA, ARTS, ESD, JACK, etc.
+ 
++Previously it was also possible to define a command to run a web
++browser. This option has been removed, and the default browser is now
++used instead.
++
+ 
+ 
+ 
+--- a/src/dlgPreferences.ui
 b/src/dlgPreferences.ui
+@@ -521,61 +521,6 @@
+ vertical
+ 6
+ 
+-  
+-False
+-bWeb browser/b
+-True
+-0
+-0
+-  
+-  
+-False
+-True
+-0
+-  
+-
+-
+-  
+-False
+-16
+-vertical
+-6
+-
+-  
+-False
+-Enter the command to run a _web browser. %s will be substituted by the web page address:
+-True
+-True
+-txtBrowserCommand
+-0
+-  
+-  
+-False
+-True
+-0
+-  
+-
+-
+-  
+-True
+-Specify the command used to launch a web browser