Package: release.debian.org
Severity: normal
Tags: stretch
User: release.debian@packages.debian.org
Usertags: pu
Hi SRMs,
Would you approve an update for agenda.app to fix #884098?
Proposed change was tested on a stretch machine; debdiff attached.
(Note that jessie is not affected; it has the same agenda.app version
but an older gnustep-gui version that doesn't exhibit the bug.)
-- System Information:
Debian Release: 9.3
APT prefers stable-updates
APT policy: (500, 'stable-updates'), (500, 'stable-debug'), (500, 'stable')
Architecture: i386 (i686)
Kernel: Linux 4.9.0-4-686-pae (SMP w/1 CPU core)
Locale: LANG=bg_BG.UTF-8, LC_CTYPE=bg_BG.UTF-8 (charmap=UTF-8),
LANGUAGE=bg_BG.UTF-8 (charmap=UTF-8)
Shell: /bin/sh linked to /bin/dash
Init: systemd (via /run/systemd/system)
diff -Nru agenda.app-0.42.2/debian/changelog agenda.app-0.42.2/debian/changelog
--- agenda.app-0.42.2/debian/changelog 2012-05-29 18:00:21.0 +0300
+++ agenda.app-0.42.2/debian/changelog 2017-12-25 22:09:00.0 +0200
@@ -1,3 +1,11 @@
+agenda.app (0.42.2-1+deb9u1) stretch; urgency=medium
+
+ * debian/patches/fix-editors-exception.patch: New, fixes creation of
+tasks and appointments (Closes: #884098).
+ * debian/patches/series: New file.
+
+ -- Yavor Doganov Mon, 25 Dec 2017 22:09:00 +0200
+
agenda.app (0.42.2-1) unstable; urgency=low
* New upstream release:
diff -Nru agenda.app-0.42.2/debian/patches/fix-editors-exception.patch
agenda.app-0.42.2/debian/patches/fix-editors-exception.patch
--- agenda.app-0.42.2/debian/patches/fix-editors-exception.patch
1970-01-01 02:00:00.0 +0200
+++ agenda.app-0.42.2/debian/patches/fix-editors-exception.patch
2017-12-25 22:09:00.0 +0200
@@ -0,0 +1,40 @@
+Description: Fix NSException when creating a new task or appointment.
+ Upstream is uncertain that this is the right fix; I concur. It looks
+ like the problem stems from the fact that TaskEditor/AppointmentEditor
+ are window controllers but don't derive from NSWindowController and
+ thus do not inherit the -document method. Upstream doesn't remember
+ why he opted to subclass NSObject; it's not feasible to change the
+ superclass now.
+Origin: upstream, commit:fa5ccf2
+Bug-Debian: https://bugs.debian.org/884098
+Last-Update: 2017-12-25
+---
+
+--- agenda.app.orig/AppointmentEditor.m
agenda.app/AppointmentEditor.m
+@@ -38,6 +38,11 @@
+ return self;
+ }
+
++- (id)document
++{
++ return nil;
++}
++
+ - (id)initWithEvent:(Event *)event
+ {
+ StoreManager *sm = [StoreManager globalManager];
+--- agenda.app.orig/TaskEditor.m
agenda.app/TaskEditor.m
+@@ -33,6 +33,11 @@
+ return self;
+ }
+
++- (id)document
++{
++ return nil;
++}
++
+ - (id)initWithTask:(Task *)task
+ {
+ StoreManager *sm = [StoreManager globalManager];
diff -Nru agenda.app-0.42.2/debian/patches/series
agenda.app-0.42.2/debian/patches/series
--- agenda.app-0.42.2/debian/patches/series 1970-01-01 02:00:00.0
+0200
+++ agenda.app-0.42.2/debian/patches/series 2017-12-25 22:09:00.0
+0200
@@ -0,0 +1 @@
+fix-editors-exception.patch