Bug#888392: [debian-mysql] Bug#888392: Bug#888392: Bug#888392: mariadb-connector-c: FTBFS on non-Linux: version script unused
Hi, Otto! On Dec 11, Otto Kekäläinen wrote: > Hello Aaron! > > If the solution is evident to you, can you perhaps make a pull request > on Salsa (https://wiki.debian.org/Teams/MySQL/patches) or even > upstream? IF(Linux) was added six years ago in v2.2.1, before even version script was used. It was only around "-Wl,--no-undefined --Wl,--as-needed". Version script was added few months later. I am sure nobody cared about hurd at that early stage :) But now it looks like a good time to fix it and correct that IF(). Regards, Sergei Chief Architect MariaDB and secur...@mariadb.org
Bug#888392: [debian-mysql] Bug#888392: Bug#888392: Bug#888392: mariadb-connector-c: FTBFS on non-Linux: version script unused
Hello Aaron! If the solution is evident to you, can you perhaps make a pull request on Salsa (https://wiki.debian.org/Teams/MySQL/patches) or even upstream? Also note these issues where upstream has tweaked how symbols are published and versioned: * https://jira.mariadb.org/browse/MDEV-13619 * https://jira.mariadb.org/browse/MDEV-13589
Bug#888392: [debian-mysql] Bug#888392: Bug#888392: mariadb-connector-c: FTBFS on non-Linux: version script unused
Control: tags -1 moreinfo Hello Aaron! su 4. maalisk. 2018 klo 7.24 Otto Kekäläinen (o...@debian.org) kirjoitti: > > Current Debian packaging now has: > > mariadb-connector-c$ head debian/libmariadb3.symbols > libmariadb.so.3 libmariadb3 #MINVER# > libmariadb_3@libmariadb_3 3.0.0 > libmariadbclient_18@libmariadbclient_18 3.0.0 > libmysqlclient_18@libmysqlclient_18 3.0.0 > ma_pvio_register_callback@libmariadb_3 3.0.0 > mariadb_cancel@libmariadb_3 3.0.0 > mariadb_connection@libmariadb_3 3.0.0 > mariadb_convert_string@libmariadb_3 3.0.0 > mariadb_deinitialize_ssl@libmariadb_3 3.0.0 > mariadb_dyncol_check@libmariadb_3 3.0.0 > > Full source at: > https://salsa.debian.org/mariadb-team/mariadb-connector-c/blob/master/debian/libmariadb3.symbols Latest build of hurd still fails with make shlibs. Can you please advice what should be done next? Or maybe even make a merge request on Salsa to fix this? >From https://buildd.debian.org/status/package.php?p=mariadb-connector-c Tail of log for mariadb-connector-c on hurd-i386: + stmt_read_execute_response@Base 1:3.0.3-2 + stmt_set_error@Base 1:3.0.3-2 + store_param@Base 1:3.0.3-2 + str_to_TIME@Base 1:3.0.3-2 + tls_library_version@Base 1:3.0.3-2 + tls_protocol_version@Base 1:3.0.3-2 + unpack_fields@Base 1:3.0.3-2 dh_makeshlibs: failing due to earlier errors debian/rules:20: recipe for target 'override_dh_makeshlibs' failed make[1]: *** [override_dh_makeshlibs] Error 2 make[1]: Leaving directory '/<>' debian/rules:6: recipe for target 'binary-arch' failed make: *** [binary-arch] Error 2 /bin/fakeauth: Error 2 for child 6799 /bin/settrans: Error 2 for child 6798
Bug#888392: [debian-mysql] Bug#888392: mariadb-connector-c: FTBFS on non-Linux: version script unused
Current Debian packaging now has: mariadb-connector-c$ head debian/libmariadb3.symbols libmariadb.so.3 libmariadb3 #MINVER# libmariadb_3@libmariadb_3 3.0.0 libmariadbclient_18@libmariadbclient_18 3.0.0 libmysqlclient_18@libmysqlclient_18 3.0.0 ma_pvio_register_callback@libmariadb_3 3.0.0 mariadb_cancel@libmariadb_3 3.0.0 mariadb_connection@libmariadb_3 3.0.0 mariadb_convert_string@libmariadb_3 3.0.0 mariadb_deinitialize_ssl@libmariadb_3 3.0.0 mariadb_dyncol_check@libmariadb_3 3.0.0 Full source at: https://salsa.debian.org/mariadb-team/mariadb-connector-c/blob/master/debian/libmariadb3.symbols
Bug#888392: Fwd: [debian-mysql] Bug#888392: mariadb-connector-c: FTBFS on non-Linux: version script unused
Hello! Here is the reply from the upstream author, manually forwarded as it did not originally reach the issue address. -- Forwarded message -- From: Georg Richter <ge...@mariadb.com> Date: 2018-01-25 8:11 GMT+02:00 Subject: Re: [debian-mysql] Bug#888392: mariadb-connector-c: FTBFS on non-Linux: version script unused To: Otto Kekäläinen <o...@debian.org> Hi Otto, this is handled by Serg, so it would be easier to file a ticket in jira. That's what I've found in git log: commit f91561bf54f5e2f1f97f3fddcb866898730ae343 Author: Sergei Golubchik <s...@mariadb.org> Date: Sat Sep 9 16:03:08 2017 +0200 MDEV-13588 /usr/lib/x86_64-linux-gnu/libmariadbclient.so.18: version `libmariadbclient_18' not found MDEV-13593 dlopen failure loading after upgrade from 10.2.6 to 10.2.8 MDEV-13619 libmariadb missing version info for libmariadbclient_18 MDEV-13615 MariaDB 10.2 client library (Debian 9/Stretch) not compatible with Perl MySQL DBI module Debian 9, just for the fun of it, I presume, renamed version nodes in the libmysqlclient.so, introducing new incompatible with anything, version "libmariadbclient_18". This version will supposedly disappear in Debian 10 (breaking compatibility again). But libmariadb.so.3 needs to be compatible with Debian 8 (libmysqlclient_18), Debian 9 (libmariadbclient_18), and, in the future, Debian 10 (libmariadb_3?). At the same time! To achieve this remarkable feat we version old symbols with libmysqlclient_18, and (!) alias them into libmariadbclient_18. New symbols are versioned under libmariadb_3. /Georg
Bug#888392: mariadb-connector-c: FTBFS on non-Linux: version script unused
Source: mariadb-connector-c Version: 2.3.3-1 Severity: important Tags: upstream Justification: fails to build from source User: debian-h...@lists.debian.org Usertags: hurd Builds of mariadb-connector-c for (non-release) non-Linux architectures -- hurd-i386 so far [1] -- have been failing because the .symbols file expects versioned symbols, whereas the actual symbols remain unversioned. The issue appears to be that line 398 of [2] is specifically conditional on Linux. (Per [3], the less narrowly conditional reference to mariadbclient.def on line 378 is evidently pointless.) Could you please take a look? Thanks! [1] https://buildd.debian.org/status/fetch.php?pkg=mariadb-connector-c=hurd-i386=3.0.3-1=1516561406=0 [2] https://salsa.debian.org/mariadb-team/mariadb-connector-c/blob/master/libmariadb/CMakeLists.txt [3] https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=888228#12 -- Aaron M. Ucko, KB1CJC (amu at alum.mit.edu, ucko at debian.org) http://www.mit.edu/~amu/ | http://stuff.mit.edu/cgi/finger/?a...@monk.mit.edu
