Bug#889012: Daemon flags aren't supported in systemd service

[Vincent Blut]

Control: tags -1 pending

Hi,

On Thu, Feb 01, 2018 at 09:44:04AM +0100, Christian Ehrhardt wrote:

Package: chrony
Version: 3.2-2

Description:
We still ship /etc/default/chrony which contians DAEMON_OPTS.
But the systemd service does not include that configuration, so we
lack a way to control options and upgraders might even regress and not
immediately see why.

The scheme to make those vars available in systemd services is pretty
common now and the suggested fix implements it this way.


Well, I did that on purpose to discourage systemd users from using this 
file (not to annoy them, after all I’m part of them) as that service 
manager provides capabilities to pass custom options to daemons (e.g.  
using drop-in files). So I wanted to invite them to use those 
capabilities rather than using the “/etc/default/chrony” file which is, 
to me, a lousy convention.


However, I do agree that it might confused some users so I’m willing to 
accept your patch.



Ubuntu-Bug: https://bugs.launchpad.net/ubuntu/+source/chrony/+bug/1746081
Fix-in-Review: 
https://git.launchpad.net/~paelzer/ubuntu/+source/chrony/commit/?id=e36bec99099dfaf6be6fb1b885a09f11d6025844


[1]: 
https://code.launchpad.net/~paelzer/ubuntu/+source/chrony/+git/chrony/+merge/336844

--
Christian Ehrhardt
Software Engineer, Ubuntu Server
Canonical Ltd


Cheers,
Vincent


signature.asc
Description: PGP signature

Bug#889012: Daemon flags aren't supported in systemd service

[Christian Ehrhardt]

Package: chrony
Version: 3.2-2

Hi,
I recently took a spike of activity on Chrony in Ubuntu with some
testing and checking older bugs on it. There are Ubuntu only changes
(like custom time servers), but some might qualify to be considered
for Debian as well.
So I wanted to open bugs for each of them to be discussed.
We currently have a merge proposal up for Ubuntu at [1], and I'll link
the fixes that are currently in review for you directly per-topic.

In case we modify the fixes due tot he review I'll keep you updated.


Description:
We still ship /etc/default/chrony which contians DAEMON_OPTS.
But the systemd service does not include that configuration, so we
lack a way to control options and upgraders might even regress and not
immediately see why.

The scheme to make those vars available in systemd services is pretty
common now and the suggested fix implements it this way.

Ubuntu-Bug: https://bugs.launchpad.net/ubuntu/+source/chrony/+bug/1746081
Fix-in-Review: 
https://git.launchpad.net/~paelzer/ubuntu/+source/chrony/commit/?id=e36bec99099dfaf6be6fb1b885a09f11d6025844


[1]: 
https://code.launchpad.net/~paelzer/ubuntu/+source/chrony/+git/chrony/+merge/336844

-- 
Christian Ehrhardt
Software Engineer, Ubuntu Server
Canonical Ltd