Bug#889293: src:alot: Please drop "Use file-magic instead of python-magic" patch, alot will FTBFS soon

[Christoph Biedl]

Christoph Biedl wrote...

> Also, I've prepared a NMU as attached but found alot fails to build on
> some (non-release) archs and like to investigate first. Feel free to go
> ahead, though.

No worries, this turned out to be a schroot configuration issue.

So I uploaded the NMU to DELAYED/7, diff debdiff as in the previous
message. Please feel free to tell me if I should delay it longer.

Regards,

Christoph


signature.asc
Description: PGP signature

Bug#889293: src:alot: Please drop "Use file-magic instead of python-magic" patch, alot will FTBFS soon

[Christoph Biedl]

# FTBFS
severity 889293 serious
tags 889293 patch
thanks

Christoph Biedl wrote...

> The new python-magic implementation will hit unstable very soon,
> causing your package to FTBFS.

python-magic 2:0.4.15-1 is now in unstable, hence raising severity.

Also, I've prepared a NMU as attached but found alot fails to build on
some (non-release) archs and like to investigate first. Feel free to go
ahead, though.

Regards,

Christoph
diff -Nru alot-0.6/debian/changelog alot-0.6/debian/changelog
--- alot-0.6/debian/changelog   2017-09-07 02:41:22.0 +0200
+++ alot-0.6/debian/changelog   2018-02-04 18:24:59.0 +0100
@@ -1,3 +1,10 @@
+alot (0.6-2.1) unstable; urgency=high
+
+  * Non-maintainer upload
+  * Drop "Use file-magic instead of python-magic" patch. Closes: #889293
+
+ -- Christoph Biedl   Sun, 04 Feb 2018 
18:24:59 +0100
+
 alot (0.6-2) unstable; urgency=low
 
   * Depend on python-gpg rather than pygpgme for alot package
diff -Nru alot-0.6/debian/control alot-0.6/debian/control
--- alot-0.6/debian/control 2017-09-07 02:41:22.0 +0200
+++ alot-0.6/debian/control 2018-02-04 18:24:59.0 +0100
@@ -14,7 +14,7 @@
  python-configobj,
  python-doc,
  python-gpg,
- python-magic,
+ python-magic (>= 2:0.4.15),
  python-mock,
  python-notmuch,
  python-setuptools,
diff -Nru 
alot-0.6/debian/patches/0002-debian-Use-file-magic-instead-of-python-magic-in-set.patch
 
alot-0.6/debian/patches/0002-debian-Use-file-magic-instead-of-python-magic-in-set.patch
--- 
alot-0.6/debian/patches/0002-debian-Use-file-magic-instead-of-python-magic-in-set.patch
 2017-08-21 01:37:30.0 +0200
+++ 
alot-0.6/debian/patches/0002-debian-Use-file-magic-instead-of-python-magic-in-set.patch
 1970-01-01 01:00:00.0 +0100
@@ -1,26 +0,0 @@
-From c8e3b0d9fce9b95b52f5f9c42ba35a3a1c631d18 Mon Sep 17 00:00:00 2001
-From: Jordan Justen 
-Date: Thu, 16 Feb 2017 17:35:32 -0800
-Subject: [PATCH] debian: Use file-magic instead of python-magic in setup.py
-
-Signed-off-by: Jordan Justen 

- setup.py | 2 +-
- 1 file changed, 1 insertion(+), 1 deletion(-)
-
-diff --git a/setup.py b/setup.py
-index f20c5cba..03a1969e 100755
 a/setup.py
-+++ b/setup.py
-@@ -45,7 +45,7 @@ setup(
- 'urwid>=1.1.0',
- 'urwidtrees>=1.0',
- 'twisted>=10.2.0',
--'python-magic',
-+'file-magic',
- 'configobj>=4.7.0',
- 'gpg'
- ],
--- 
-2.14.0
-
diff -Nru alot-0.6/debian/patches/series alot-0.6/debian/patches/series
--- alot-0.6/debian/patches/series  2017-07-10 00:53:58.0 +0200
+++ alot-0.6/debian/patches/series  2018-02-04 18:24:59.0 +0100
@@ -1,2 +1 @@
 0001-Description-Use-local-intersphinx-inventories.patch
-0002-debian-Use-file-magic-instead-of-python-magic-in-set.patch


signature.asc
Description: PGP signature

Bug#889293: src:alot: Please drop "Use file-magic instead of python-magic" patch, alot will FTBFS soon

[Christoph Biedl]

Package: src:alot
Version: 0.6-2
Severity: important

python-magic maintainer here ...

Dear Maintainer,

as announced in debian-devel two weeks ago, the python-magic libary
will switch upstream, from the one provided by src:file to the one
found in PyPI, written by Adam Hupp.

A rebuild of the known rdeps showed src:alot will no longer build then.
Since however alot is currently patched to work with the file-based
implementation, this can easily be cured by just dropping that patch.

The new python-magic implementation will hit unstable very soon,
causing your package to FTBFS. So I'm asking you to prepare for this by

* droping 0002-debian-Use-file-magic-instead-of-python-magic-in-set.patch,
* adding a versioned build dependency on python-magic (>= 2:0.4.15) as
  a hint for backporters

Sorry if this is a bit on short notice.

Christoph



signature.asc
Description: PGP signature