Bug#891829: stretch-pu: package needrestart/2.11-3

2018-03-03 Thread Adam D. Barratt
Control: tags -1 + pending

On Fri, 2018-03-02 at 17:47 +, Adam D. Barratt wrote:
> Control: tags -1 + confirmed
> 
> On Thu, 2018-03-01 at 11:37 +0100, Dominik George wrote:
> > I would like to update needrestart in the upcoming point release to
> > fix the RC bug #876459 in stretch. It causes regular unintended
> > restarts of critical services.
> > 
> 
> +needrestart (2.11-3+deb9u0.1) stretch; urgency=medium
> 
> That version number makes no sense - the first upload to stretch is
> always deb9u1. There are no NMU-style versions for stable updates,
> but
> even if there were deb9u0.1 would have been an old-style NMU of a new
> upstream version, which is not the case here.
> 
> With the version number fixed, please feel free to go ahead with the
> upload.
> 

Uploaded and flagged for acceptance.

Regards,

Adam



Bug#891829: stretch-pu: package needrestart/2.11-3

2018-03-02 Thread Adam D. Barratt
Control: tags -1 + confirmed

On Thu, 2018-03-01 at 11:37 +0100, Dominik George wrote:
> I would like to update needrestart in the upcoming point release to
> fix the RC bug #876459 in stretch. It causes regular unintended
> restarts of critical services.
> 

+needrestart (2.11-3+deb9u0.1) stretch; urgency=medium

That version number makes no sense - the first upload to stretch is
always deb9u1. There are no NMU-style versions for stable updates, but
even if there were deb9u0.1 would have been an old-style NMU of a new
upstream version, which is not the case here.

With the version number fixed, please feel free to go ahead with the
upload.

Regards,

Adam



Bug#891829: stretch-pu: package needrestart/2.11-3

2018-03-01 Thread Dominik George
Package: release.debian.org
Severity: normal
Tags: stretch
User: release.debian@packages.debian.org
Usertags: pu

-BEGIN PGP SIGNED MESSAGE-
Hash: SHA256

Hi,

I would like to update needrestart in the upcoming point release to fix
the RC bug #876459 in stretch. It causes regular unintended restarts of
critical services.

The maintainer seems to lack time, so I have offered help to fix this in
stretch. I got it reviewed by Mike Gabriel, who also offers to sponsor
the upload.

Find attached the debdiff.
Thanks,
Nik

- -- System Information:
Debian Release: buster/sid
  APT prefers unstable-debug
  APT policy: (500, 'unstable-debug'), (500, 'unstable'), (1, 
'experimental-debug')
Architecture: amd64 (x86_64)
Foreign Architectures: i386

Kernel: Linux 4.15.0-1-amd64 (SMP w/4 CPU cores)
Locale: LANG=en_GB.UTF-8, LC_CTYPE=en_GB.UTF-8 (charmap=UTF-8), LANGUAGE=en 
(charmap=UTF-8)
Shell: /bin/sh linked to /usr/bin/dash
Init: systemd (via /run/systemd/system)
LSM: AppArmor: enabled

-BEGIN PGP SIGNATURE-

iQJ4BAEBCABiFiEEPJ1UpHV1wCb7F/0mt5o8FqDE8pYFAlqX1+4xGmh0dHBzOi8v
d3d3LmRvbWluaWstZ2VvcmdlLmRlL2dwZy1wb2xpY3kudHh0LmFzYxIcbmlrQG5h
dHVyYWxuZXQuZGUACgkQt5o8FqDE8pY7Cw/9ESJmQMvwveheqIoCzLB4GTOYW6yK
ADuq8nHfQNmvd1Xdn/ejDwTEuz0NH/trRfuxvZ2oyIKFHMmpCx1meI5wy/wXypE1
dAroycHl4IRI3vruM1d8eg7LIzziak8tXJgg1gQt3RF9UOtE0WDMT4zPmPF5CBPk
kx4b4jBKEsrLz6IyjpXL7z+v7BmJ4+Qb9rmWI9ewEiKionnqfgfwivhjZg52PX0P
3wHIhgHUwbyQtzonZJq19iXyEg48nhKSCVYs0J1zRxTk5FEMkdplAWZwPVjrpDOT
jLL0LpJncv+AV3fukXl+JmHaF3EfTfKyKjtHD1SD2L2cTRPg/5zP9XBUL59W11wH
HbjmoyfEqib99nSp0bySDQSBJdJbnJ0DluvekT2O1JmYNG8KaYdhs2z/9Zw/wQe3
u0Qmgqw34P/bP21yURutCEjQjBqWACkcnLq85Evmx597gr6ZrV2ObBO393mnimwB
OEsxOWw6wBAJzyqTeWD1cRCqp4gI/JqGfP5R5FsfkOkIjgRac05UIoVJSncAssl0
O+wmbFs99X8bgCSPzXB9M0ASJKxRMCPzBK/79QFWg8jUj/v8tkrCMHoBpViBu/Ut
dXPwTJEqIvK32tixDhqLzyAHZY0j6T1X8G1jJ+tYssQ+FXQZ9i50w1in1ZEF+mKi
+fzXy9IBnDs9xgY=
=QteC
-END PGP SIGNATURE-
diff -Nru needrestart-2.11/debian/changelog needrestart-2.11/debian/changelog
--- needrestart-2.11/debian/changelog   2017-05-26 15:45:04.0 +0200
+++ needrestart-2.11/debian/changelog   2018-02-28 22:48:43.0 +0100
@@ -1,3 +1,11 @@
+needrestart (2.11-3+deb9u0.1) stretch; urgency=medium
+
+  * Non-maintainer upload.
+  * Fix switching to list mode if debconf is run non-interactively.
+(Closes: #876459)
+
+ -- Dominik George   Wed, 28 Feb 2018 22:48:43 +0100
+
 needrestart (2.11-3) unstable; urgency=high
 
   * Add patch 03-perl-warning to fix a warning from Perl triggered in version
diff -Nru needrestart-2.11/debian/patches/05-fix-debconf-noninteractive.diff 
needrestart-2.11/debian/patches/05-fix-debconf-noninteractive.diff
--- needrestart-2.11/debian/patches/05-fix-debconf-noninteractive.diff  
1970-01-01 01:00:00.0 +0100
+++ needrestart-2.11/debian/patches/05-fix-debconf-noninteractive.diff  
2018-02-28 22:48:43.0 +0100
@@ -0,0 +1,16 @@
+From: Piotr PaƄczyk 
+Subject: Fix switcihng to list mode if debconf is run non-interactively
+Bug-Debian: https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=876459
+Origin: 
https://github.com/liske/needrestart/commit/6c83d643a21fe0da2c8ae5ece97a778b347a033c
+
+--- a/needrestart
 b/needrestart
+@@ -181,7 +181,7 @@ $nrconf{ui} = qq(NeedRestart::UI::stdio)
+ die "Hook directory '$nrconf{hook_d}' is invalid!\n" unless(-d 
$nrconf{hook_d} || $opt_b);
+ $opt_r = $nrconf{restart} unless(defined($opt_r));
+ die "ERROR: Unknown restart option '$opt_r'!\n" unless($opt_r =~ /^(l|i|a)$/);
+-$is_tty++ if($opt_r eq 'i' && exists($ENV{DEBIAN_FRONTEND}) && 
$ENV{DEBIAN_FRONTEND} eq 'noninteractive');
++$is_tty = 0 if($opt_r eq 'i' && exists($ENV{DEBIAN_FRONTEND}) && 
$ENV{DEBIAN_FRONTEND} eq 'noninteractive');
+ $opt_r = 'l' if(!$is_tty && $opt_r eq 'i');
+ 
+ $opt_m = $nrconf{ui_mode} unless(defined($opt_m));
diff -Nru needrestart-2.11/debian/patches/series 
needrestart-2.11/debian/patches/series
--- needrestart-2.11/debian/patches/series  2017-05-26 15:45:04.0 
+0200
+++ needrestart-2.11/debian/patches/series  2018-02-28 22:45:55.0 
+0100
@@ -2,3 +2,4 @@
 02-install-restart-d.diff
 03-perl-warning.diff
 04-ignore-systemd-services.diff
+05-fix-debconf-noninteractive.diff