Bug#892481: r-cran-testthat: autopkgtest failure

2018-03-10 Thread Graham Inggs
On 10 March 2018 at 16:00, Dylan Aïssi  wrote:
> I am not sure how to proceed here. Is there a simple way to skip this
> test except to patch the relevant file and to use the skip function?

There may be better ways, but that's how I have done it before.



Bug#892481: r-cran-testthat: autopkgtest failure

2018-03-10 Thread Dylan Aïssi
Hi Graham,

On Fri, 9 Mar 2018 15:24:45 +0200 Graham Inggs  wrote:
>
> By changing the locale from C to C.UTF-8, similar to what I did in
> r-cran-urltools [3], there is only one test failure remaining:

Thanks. Done.

>
>  > test_check("testthat")
> ── 1. Error: returns local path when called from
> tools::testInstalledPackages (@
> cannot change working directory
> 1: setwd("test-path-installed/testthat-tests/testthat") at
> testthat/test-test-path.R:11
>
> ══ testthat results
> ═══
> OK: 449 SKIPPED: 2 FAILED: 1
> 1. Error: returns local path when called from
> tools::testInstalledPackages (@test-test-path.R#11)
>
> It is a new test, not a regression, so skipping it may be a valid option.
>

I am not sure how to proceed here. Is there a simple way to skip this
test except to patch the relevant file and to use the skip function?

Best,
Dylan



Bug#892481: r-cran-testthat: autopkgtest failure

2018-03-09 Thread Graham Inggs

Source: r-cran-testthat
Version: 2.0.0-1
User: ubuntu-de...@lists.ubuntu.com
Usertags: origin-ubuntu bionic autopkgtest

Hi Dylan

Since the upload of 2.0.0-1, r-cran-testthat's autopkgtests have been 
failing [1].  I noticed you already added a missing test dependency [2] 
in Salsa.  This reduced the number of failing tests to 4.


By changing the locale from C to C.UTF-8, similar to what I did in 
r-cran-urltools [3], there is only one test failure remaining:


> test_check("testthat")
── 1. Error: returns local path when called from 
tools::testInstalledPackages (@

cannot change working directory
1: setwd("test-path-installed/testthat-tests/testthat") at 
testthat/test-test-path.R:11


══ testthat results 
═══

OK: 449 SKIPPED: 2 FAILED: 1
1. Error: returns local path when called from 
tools::testInstalledPackages (@test-test-path.R#11)


It is a new test, not a regression, so skipping it may be a valid option.

Regards
Graham


[1] https://ci.debian.net/packages/r/r-cran-testthat/unstable/amd64/
[2] 
https://salsa.debian.org/r-pkg-team/r-cran-testthat/commit/c5c04175436b406abe675080beca0b9672d9b412
[3] 
https://salsa.debian.org/r-pkg-team/r-cran-urltools/commit/8e5db0e366c651e31846afd49f4f981fa23bd4ac