Bug#892737: [Pkg-puppet-devel] Bug#892737: Bug#892737: puppet: /usr/lib/ruby/vendor_ruby/puppet/gettext/config.rb:156:in `copy_default_translations': undefined method `chain'

[Jan Huijsmans]

On Tue, 13 Mar 2018 13:25:25 +0100
Jan Huijsmans  wrote:
> On Tue, 13 Mar 2018 10:28:49 +0100 Georg Faerber 
> wrote:
> > On 18-03-13 10:36:34, Apollon Oikonomopoulos wrote:
> > Yeah.. Thanks for your work, too! I like teamwork a lot! :)
> Thanks, will test as soon as I get it, ruby-gettext-setup was pulled
> in with r10k, so I now also know how I got it. (and that it's a
> requirement for r10k package)

Can confirm the bug is fixed.
Thanks for the very quick fix.

---

Jan Huijsmans  b...@koffie.nu

... cannot activate /dev/brain, no response from main coffee server

Bug#892737: [Pkg-puppet-devel] Bug#892737: Bug#892737: puppet: /usr/lib/ruby/vendor_ruby/puppet/gettext/config.rb:156:in `copy_default_translations': undefined method `chain'

[Jan Huijsmans]

On Tue, 13 Mar 2018 10:28:49 +0100 Georg Faerber 
wrote:
> On 18-03-13 10:36:34, Apollon Oikonomopoulos wrote:
> Yeah.. Thanks for your work, too! I like teamwork a lot! :)

Thanks, will test as soon as I get it, ruby-gettext-setup was pulled in
with r10k, so I now also know how I got it. (and that it's a
requirement for r10k package)

---

Jan Huijsmans  b...@koffie.nu

... cannot activate /dev/brain, no response from main coffee server

Bug#892737: [Pkg-puppet-devel] Bug#892737: Bug#892737: puppet: /usr/lib/ruby/vendor_ruby/puppet/gettext/config.rb:156:in `copy_default_translations': undefined method `chain'

[Georg Faerber]

On 18-03-13 10:36:34, Apollon Oikonomopoulos wrote:
> Control: tags -1 pending
> On 02:30 Tue 13 Mar , Georg Faerber wrote:
> > On 18-03-13 00:19:06, Apollon Oikonomopoulos wrote:
> > > On 23:09 Mon 12 Mar , Georg Faerber wrote:
> > > > On 18-03-12 23:28:20, Apollon Oikonomopoulos wrote:
> > > > > So, the version of ruby-gettext-setup is pretty outdated and 
> > > > > predates
> > > > > Puppet's i18n system. When pulled in via i18n-enabled Puppet modules
> > > > > (e.g. ruby-puppet-forge), it will completely hijack Puppet's gettext
> > > > > default domain, causing breakage. This has been fixed upstream[1] in
> > > > > 0.17.
> > > > > 
> > > > > We should upgrade ruby-gettext-setup to the latest upstream version.
> > > > 
> > > > I could take care of this, tomorrow. Just need someone to sponsor the
> > > > upload.
> > > 
> > > Please do! I'd be glad to sponsor this, ping me when you're ready or
> > > if you need any help.
> > 
> > I've pushed in git to branch debian/0.30-1. Please especially review
> > eeff22b6, in particular the changes I've made to
> > spec/lib/tasks/gettext_rake_spec.rb. 
> > 
> > (This file loads an rake task contained in lib/. I'm not really sure if
> > I'm happy with my proposed change, however, I've tried various methods
> > and didn't found anything else working besides this. Reasoning for this
> > change: Upstreams code doesn't work if specs are run via autopkgtest, as
> > lib/ is moved away during autopkgtest runs. In case you would like to
> > change this: Please go ahead.)
> 
> Looks good to me! I've pushed an additional change (unexport LANGUAGE
> in d/rules) to fix a test failure occurring on my system. I'll upload
> the package shortly.
> 
> Thanks for your work!

Yeah.. Thanks for your work, too! I like teamwork a lot! :)

CHeers,
Georg


signature.asc
Description: Digital signature

Bug#892737: [Pkg-puppet-devel] Bug#892737: Bug#892737: puppet: /usr/lib/ruby/vendor_ruby/puppet/gettext/config.rb:156:in `copy_default_translations': undefined method `chain'

[Apollon Oikonomopoulos]

Control: tags -1 pending

Hi Georg,

On 02:30 Tue 13 Mar , Georg Faerber wrote:
> Hi Apollon,
> 
> On 18-03-13 00:19:06, Apollon Oikonomopoulos wrote:
> > On 23:09 Mon 12 Mar , Georg Faerber wrote:
> > > On 18-03-12 23:28:20, Apollon Oikonomopoulos wrote:
> > > > So, the version of ruby-gettext-setup is pretty outdated and 
> > > > predates
> > > > Puppet's i18n system. When pulled in via i18n-enabled Puppet modules
> > > > (e.g. ruby-puppet-forge), it will completely hijack Puppet's gettext
> > > > default domain, causing breakage. This has been fixed upstream[1] in
> > > > 0.17.
> > > > 
> > > > We should upgrade ruby-gettext-setup to the latest upstream version.
> > > 
> > > I could take care of this, tomorrow. Just need someone to sponsor the
> > > upload.
> > 
> > Please do! I'd be glad to sponsor this, ping me when you're ready or
> > if you need any help.
> 
> I've pushed in git to branch debian/0.30-1. Please especially review
> eeff22b6, in particular the changes I've made to
> spec/lib/tasks/gettext_rake_spec.rb. 
> 
> (This file loads an rake task contained in lib/. I'm not really sure if
> I'm happy with my proposed change, however, I've tried various methods
> and didn't found anything else working besides this. Reasoning for this
> change: Upstreams code doesn't work if specs are run via autopkgtest, as
> lib/ is moved away during autopkgtest runs. In case you would like to
> change this: Please go ahead.)

Looks good to me! I've pushed an additional change (unexport LANGUAGE in 
d/rules) to fix a test failure occurring on my system. I'll upload the 
package shortly.

Thanks for your work!
Apollon

Bug#892737: [Pkg-puppet-devel] Bug#892737: Bug#892737: puppet: /usr/lib/ruby/vendor_ruby/puppet/gettext/config.rb:156:in `copy_default_translations': undefined method `chain'

[Georg Faerber]

Hi Apollon,

On 18-03-13 00:19:06, Apollon Oikonomopoulos wrote:
> On 23:09 Mon 12 Mar , Georg Faerber wrote:
> > On 18-03-12 23:28:20, Apollon Oikonomopoulos wrote:
> > > So, the version of ruby-gettext-setup is pretty outdated and 
> > > predates
> > > Puppet's i18n system. When pulled in via i18n-enabled Puppet modules
> > > (e.g. ruby-puppet-forge), it will completely hijack Puppet's gettext
> > > default domain, causing breakage. This has been fixed upstream[1] in
> > > 0.17.
> > > 
> > > We should upgrade ruby-gettext-setup to the latest upstream version.
> > 
> > I could take care of this, tomorrow. Just need someone to sponsor the
> > upload.
> 
> Please do! I'd be glad to sponsor this, ping me when you're ready or
> if you need any help.

I've pushed in git to branch debian/0.30-1. Please especially review
eeff22b6, in particular the changes I've made to
spec/lib/tasks/gettext_rake_spec.rb. 

(This file loads an rake task contained in lib/. I'm not really sure if
I'm happy with my proposed change, however, I've tried various methods
and didn't found anything else working besides this. Reasoning for this
change: Upstreams code doesn't work if specs are run via autopkgtest, as
lib/ is moved away during autopkgtest runs. In case you would like to
change this: Please go ahead.)

Thanks for reviewing,
cheers,
Georg


signature.asc
Description: Digital signature

Bug#892737: [Pkg-puppet-devel] Bug#892737: Bug#892737: puppet: /usr/lib/ruby/vendor_ruby/puppet/gettext/config.rb:156:in `copy_default_translations': undefined method `chain'

[Georg Faerber]

Hi Apollon,

On 18-03-13 00:19:06, Apollon Oikonomopoulos wrote:
> On 23:09 Mon 12 Mar , Georg Faerber wrote:
> > On 18-03-12 23:28:20, Apollon Oikonomopoulos wrote:
> > > So, the version of ruby-gettext-setup is pretty outdated and 
> > > predates
> > > Puppet's i18n system. When pulled in via i18n-enabled Puppet modules
> > > (e.g. ruby-puppet-forge), it will completely hijack Puppet's gettext
> > > default domain, causing breakage. This has been fixed upstream[1] in
> > > 0.17.
> > > 
> > > We should upgrade ruby-gettext-setup to the latest upstream version.
> > 
> > I could take care of this, tomorrow. Just need someone to sponsor
> > the upload.
> 
> Please do! I'd be glad to sponsor this, ping me when you're ready or
> if you need any help.

Will do, thanks!

Cheers,
Georg


signature.asc
Description: Digital signature

Bug#892737: [Pkg-puppet-devel] Bug#892737: Bug#892737: puppet: /usr/lib/ruby/vendor_ruby/puppet/gettext/config.rb:156:in `copy_default_translations': undefined method `chain'

[Apollon Oikonomopoulos]

Hi Georg,

On 23:09 Mon 12 Mar , Georg Faerber wrote:
> On 18-03-12 23:28:20, Apollon Oikonomopoulos wrote:
> > So, the version of ruby-gettext-setup is pretty outdated and 
> > predates
> > Puppet's i18n system. When pulled in via i18n-enabled Puppet modules
> > (e.g. ruby-puppet-forge), it will completely hijack Puppet's gettext
> > default domain, causing breakage. This has been fixed upstream[1] in
> > 0.17.
> > 
> > We should upgrade ruby-gettext-setup to the latest upstream version.
> 
> I could take care of this, tomorrow. Just need someone to sponsor the
> upload.

Please do! I'd be glad to sponsor this, ping me when you're ready or if 
you need any help.

Cheers,
Apollon

Bug#892737: [Pkg-puppet-devel] Bug#892737: Bug#892737: puppet: /usr/lib/ruby/vendor_ruby/puppet/gettext/config.rb:156:in `copy_default_translations': undefined method `chain'

[Georg Faerber]

On 18-03-12 23:28:20, Apollon Oikonomopoulos wrote:
> On 21:04 Mon 12 Mar , Mykola Nikishov wrote:
> > Package: puppet
> > Version: 5.4.0-1
> > Followup-For: Bug #892737
> > 
> > I have librarian-puppet and found out that downgrading it to jessie
> > will fix the problem. Downgrade will remove ruby-puppet-forge and
> > ruby-gettext-setup.
> > 
> > Seems ruby-gettext-setup causes this problem.
> 
> So, the version of ruby-gettext-setup is pretty outdated and predates
> Puppet's i18n system. When pulled in via i18n-enabled Puppet modules
> (e.g. ruby-puppet-forge), it will completely hijack Puppet's gettext
> default domain, causing breakage. This has been fixed upstream[1] in
> 0.17.
> 
> We should upgrade ruby-gettext-setup to the latest upstream version.

I could take care of this, tomorrow. Just need someone to sponsor the
upload.

Cheers,
Georg


signature.asc
Description: Digital signature

Bug#892737: [Pkg-puppet-devel] Bug#892737: Bug#892737: puppet: /usr/lib/ruby/vendor_ruby/puppet/gettext/config.rb:156:in `copy_default_translations': undefined method `chain'

[Apollon Oikonomopoulos]

Control: tags -1 unreproducible moreinfo
Control: tags -1 severity important

Hi Jan,

[Downgrading severity as it does not seem to be affecting all systems 
ATM]

On 13:54 Mon 12 Mar , Jan Huijsmans wrote:
> Hi Apollon,
> 
> On Mon, 12 Mar 2018 13:57:03 +0200 Apollon Oikonomopoulos
>  wrote:
> > Hi,
> > 
> > Thanks for the report,
> > 
> > On 12:33 Mon 12 Mar , Jan Huijsmans wrote:
> > > Would love tips on how to get this setup working or downgrade back
> > > to 4.10.4.
> > 
> > I'll have a look at the issue as soon as possible. In the meantime,
> > you can obtain 4.10.4 from
> > http://snapshot.debian.org/package/puppet/4.10.4-2/
> 
> Thanks for the link, great to be able to get the packages. Reinstalled
> the old version and everything works again as expected.
> 
> I'll compare the debian (a few clients) and the raspbian
> (puppet-master) to see if I can find differences. Iy looks like
> gettext(-setup) is a dependency. (but have it installed and it gives
> the error)

It's not a strict dependency: puppet tries to load it, but it works fine 
without it. It's this line that worries me most to be honest:

> /usr/lib/ruby/vendor_ruby/puppet/gettext/config.rb:156:in 
> `copy_default_translations': undefined method `chain' for 
> # (NoMethodError)

It seems that somehow it has managed to get the internal state mixed up, as the
object should be a FastGettext::TranslationRepository::Chain, and not
FastGettext::TranslationRepository::Po. I have no idea how that 
happened, but you can help me find out. Can you please run the attached 
script (ruby puppet-locale-test.rb) on your master and reply with the 
output?

Regards,
Apollon


puppet-locale-test.rb
Description: application/ruby


signature.asc
Description: PGP signature