Bug#894967: mac-robber FTCBFS: uses the build architecture compiler

[Helmut Grohne]

Hi Raphaël,

On Fri, Apr 06, 2018 at 10:07:30AM +0200, Raphael Hertzog wrote:
> it's not the first time that you are submitting such fixes. Would you like
> to be added to the pkg-security team so that you can commit (and even upload
> if you feel like) your fixes directly ?

Thanks for your offer, but I think it doesn't scale. My fixes are in no
way specific to pkg-security. I'd love to fix things directly, but
that'd require more uniformity from the archive. Possibly dgit can
provide that one day.

At the moment, I even file patches for orphaned packages rather than
uploading them directly. I think this has two benefits:
 * I do not make such packages appear as maintained when they are not.
 * Someone else reviews my patch and catches the occasional error. The
   present feedback I get suggests that around 1% to 3% of my patches
   contain mistakes.

My present workflow with using bugs.d.o as a patch distribution system
scales somewhat. In parallel to submitting patches, I try to turn
generic fixes into lintian tags[1]. Do you have any suggestions to
improving that?

Helmut

[1] E.g.

https://lintian.debian.org/tags/autotools-pkg-config-macro-not-cross-compilation-safe.html

https://lintian.debian.org/tags/pkg-config-unavailable-for-cross-compilation.html
https://lintian.debian.org/tags/multiarch-foreign-pkgconfig.html
https://lintian.debian.org/tags/multiarch-foreign-shared-library.html
https://lintian.debian.org/tags/multiarch-foreign-static-library.html

Bug#894967: mac-robber FTCBFS: uses the build architecture compiler

[Raphael Hertzog]

Hello Helmut,

On Thu, 05 Apr 2018, Helmut Grohne wrote:
> mac-robber fails to cross build from source, because it uses the build
> architecture compiler. The easiest way of fixing that is letting
> dh_auto_build do it. After doing so, mac-robber cross builds
> successfully. Please consider applying the attached patch.

it's not the first time that you are submitting such fixes. Would you like
to be added to the pkg-security team so that you can commit (and even upload
if you feel like) your fixes directly ?

Cheers,
-- 
Raphaël Hertzog ◈ Debian Developer

Support Debian LTS: https://www.freexian.com/services/debian-lts.html
Learn to master Debian: https://debian-handbook.info/get/

Bug#894967: mac-robber FTCBFS: uses the build architecture compiler

[Helmut Grohne]

Source: mac-robber
Version: 1.02-5
Tags: patch
User: helm...@debian.org
Usertags: rebootstrap

mac-robber fails to cross build from source, because it uses the build
architecture compiler. The easiest way of fixing that is letting
dh_auto_build do it. After doing so, mac-robber cross builds
successfully. Please consider applying the attached patch.

Helmut
diff --minimal -Nru mac-robber-1.02/debian/changelog 
mac-robber-1.02/debian/changelog
--- mac-robber-1.02/debian/changelog2016-12-30 11:35:43.0 +0100
+++ mac-robber-1.02/debian/changelog2018-04-05 17:54:36.0 +0200
@@ -1,3 +1,10 @@
+mac-robber (1.02-5.1) UNRELEASED; urgency=medium
+
+  * Non-maintainer upload.
+  * Fix FTCBFS: Let dh_auto_build pass cross tools to make. (Closes: #-1)
+
+ -- Helmut Grohne   Thu, 05 Apr 2018 17:54:36 +0200
+
 mac-robber (1.02-5) unstable; urgency=medium
 
   * Bumped DH level to 10.
diff --minimal -Nru mac-robber-1.02/debian/rules mac-robber-1.02/debian/rules
--- mac-robber-1.02/debian/rules2016-12-30 11:35:43.0 +0100
+++ mac-robber-1.02/debian/rules2018-04-05 17:54:34.0 +0200
@@ -7,4 +7,4 @@
dh $@
 
 override_dh_auto_build:
-   make linux_notstatic
+   dh_auto_build -- linux_notstatic