Bug#896710: harfbuzz: autopkgtest to detect freetype regressions
On Wed, Nov 14, 2018 at 09:39:01AM +0100, أحمد المحمودي wrote: > On Tue, Nov 13, 2018 at 09:53:29AM -0800, Steve Langasek wrote: > > > Is that patch correct? It doesn't seem to be building anything? > > Because the test is 'Restrictions: build-needed', whenever the autopkgtest > > is run, the source package will automatically be rebuilt, and the test will > > fail if the rebuild fails. > ---end quoted text--- > I added this test, then later removed it, as lintian (or a DD, I don't > remember) complained that this is soke sort of a fake test. Sure. I don't agree that it's a fake test; you're running the test suite, which is only available in the harfbuzz build tree, and that is a useful thing which would have caught a real regression in a dependency (freetype) at test time. There are other ways that the autopkgtest could be constructed instead, perhaps to re-invoke the test suite from the build tree against the already-installed harfbuzz binary packages on the system. I have no particular opinion on this; I just think it's misguided to consider this a "fake" test when it is very much running the test suite. -- Steve Langasek Give me a lever long enough and a Free OS Debian Developer to set it on, and I can move the world. Ubuntu Developer https://www.debian.org/ slanga...@ubuntu.com vor...@debian.org signature.asc Description: PGP signature
Bug#896710: harfbuzz: autopkgtest to detect freetype regressions
On Tue, Nov 13, 2018 at 09:53:29AM -0800, Steve Langasek wrote: > > Is that patch correct? It doesn't seem to be building anything? > > Because the test is 'Restrictions: build-needed', whenever the autopkgtest > is run, the source package will automatically be rebuilt, and the test will > fail if the rebuild fails. ---end quoted text--- I added this test, then later removed it, as lintian (or a DD, I don't remember) complained that this is soke sort of a fake test. -- أحمد المحمودي (Ahmed El-Mahmoudy) Digital design engineer GPG KeyIDs: 4096R/A7EF5671 2048R/EDDDA1B7 GPG Fingerprints: 6E2E E4BB 72E2 F417 D066 6ABF 7B30 B496 A7EF 5761 8206 A196 2084 7E6D 0DF8 B176 BC19 6A94 EDDD A1B7 signature.asc Description: PGP signature
Bug#896710: harfbuzz: autopkgtest to detect freetype regressions
Hi Emilio, On Tue, Nov 13, 2018 at 05:05:22PM +0100, Emilio Pozuelo Monfort wrote: > On Mon, 23 Apr 2018 17:14:19 -0700 Steve Langasek > > wrote: > > Package: harfbuzz > > Version: 1.7.2-1 > > Severity: minor > > Tags: patch > > User: ubuntu-de...@lists.ubuntu.com > > Usertags: origin-ubuntu bionic ubuntu-patch > > > > Dear maintainers, > > > > In Ubuntu we found a regression in freetype 2.8.1 due to unaligned memory > > access on armhf (when running on certain chips in certain kernel > > configurations) that was only discovered because it caused harfbuzz to fail > > to build on this architecture. > > > > It would have been useful to catch this regression much earlier, if the > > harfbuzz build-time test suite were run at the time the new version of > > freetype was introduced, instead of later as part of an archive rebuild > > test. > > > > So I've added a simple build-only autopkgtest to harfbuzz in Ubuntu; please > > see the attached patch, and please consider whether you think this would > > also be useful to have in Debian. > Is that patch correct? It doesn't seem to be building anything? Because the test is 'Restrictions: build-needed', whenever the autopkgtest is run, the source package will automatically be rebuilt, and the test will fail if the rebuild fails. -- Steve Langasek Give me a lever long enough and a Free OS Debian Developer to set it on, and I can move the world. Ubuntu Developer https://www.debian.org/ slanga...@ubuntu.com vor...@debian.org signature.asc Description: PGP signature
Bug#896710: harfbuzz: autopkgtest to detect freetype regressions
Hi Steve, On Mon, 23 Apr 2018 17:14:19 -0700 Steve Langasek wrote: > Package: harfbuzz > Version: 1.7.2-1 > Severity: minor > Tags: patch > User: ubuntu-de...@lists.ubuntu.com > Usertags: origin-ubuntu bionic ubuntu-patch > > Dear maintainers, > > In Ubuntu we found a regression in freetype 2.8.1 due to unaligned memory > access on armhf (when running on certain chips in certain kernel > configurations) that was only discovered because it caused harfbuzz to fail > to build on this architecture. > > It would have been useful to catch this regression much earlier, if the > harfbuzz build-time test suite were run at the time the new version of > freetype was introduced, instead of later as part of an archive rebuild test. > > So I've added a simple build-only autopkgtest to harfbuzz in Ubuntu; please > see the attached patch, and please consider whether you think this would > also be useful to have in Debian. Is that patch correct? It doesn't seem to be building anything? Emilio
Bug#896710: harfbuzz: autopkgtest to detect freetype regressions
reopen 896710 quit On Mon, Apr 23, 2018 at 05:14:19PM -0700, Steve Langasek wrote: > So I've added a simple build-only autopkgtest to harfbuzz in Ubuntu; please > see the attached patch, and please consider whether you think this would > also be useful to have in Debian. ---end quoted text--- I removed this testsuite, since Debian prohibits adding no-op tests. -- أحمد المحمودي (Ahmed El-Mahmoudy) Digital design engineer GPG KeyIDs: 4096R/A7EF5671 2048R/EDDDA1B7 GPG Fingerprints: 6E2E E4BB 72E2 F417 D066 6ABF 7B30 B496 A7EF 5761 8206 A196 2084 7E6D 0DF8 B176 BC19 6A94 EDDD A1B7 signature.asc Description: PGP signature
Bug#896710: harfbuzz: autopkgtest to detect freetype regressions
Package: harfbuzz Version: 1.7.2-1 Severity: minor Tags: patch User: ubuntu-de...@lists.ubuntu.com Usertags: origin-ubuntu bionic ubuntu-patch Dear maintainers, In Ubuntu we found a regression in freetype 2.8.1 due to unaligned memory access on armhf (when running on certain chips in certain kernel configurations) that was only discovered because it caused harfbuzz to fail to build on this architecture. It would have been useful to catch this regression much earlier, if the harfbuzz build-time test suite were run at the time the new version of freetype was introduced, instead of later as part of an archive rebuild test. So I've added a simple build-only autopkgtest to harfbuzz in Ubuntu; please see the attached patch, and please consider whether you think this would also be useful to have in Debian. -- Steve Langasek Give me a lever long enough and a Free OS Debian Developer to set it on, and I can move the world. Ubuntu Developerhttp://www.debian.org/ slanga...@ubuntu.com vor...@debian.org diff -Nru harfbuzz-1.7.2/debian/tests/control harfbuzz-1.7.2/debian/tests/control --- harfbuzz-1.7.2/debian/tests/control 1969-12-31 16:00:00.0 -0800 +++ harfbuzz-1.7.2/debian/tests/control 2018-04-12 20:36:14.0 -0700 @@ -0,0 +1,3 @@ +Test-Command: true +Depends: @, @builddeps@ +Restrictions: build-needed
