Hi Stefan,
I went ahead and tagged the 1.6.2 upstream release and put the
pristine-tar deltas in the repo. Take a look when you get
the chance https://salsa.debian.org/snhardin-guest/mp3gain/ and please
feel free to nit-pick as you see fit.
Thanks,
Scott
On Sat, 25 Jul 2020 10:40:42 +0200
Stefan Fritsch wrote:
> Hi Scott,
>
> this took a lot longer than I intended, I am sorry for that.
>
> I have taken a look now and your work looks very good already. Some
> small things:
>
> In the past, the maintainers have use pristine-tar to store the orig
> tarball in the git repo, too. I think you should do this, too, as the
> downloadable file is zip and is then repacked.
>
> The 1.6.2 upstream commit should have a tag in the git repo.
>
> The debian/rules file could be made a lot simpler by using the dh
> debhelper command sequencer. You should probably convert it at some
> point in the future, but I think it can also be done in a later
> update.
>
>
> After you put the tarball into the git repo, I would be ok to upload
> the package to debian. But if you want to do the conversion to dh
> first, that's fine with me, too.
>
> In any case, thanks for your work.
>
> Cheers,
> Stefan
>
>
>
> Am 16.06.20 um 07:52 schrieb Scott Hardin:
> > Hey Stefan,
> >
> > Perfect. Within the last month (or three ), I got something
> > working, although I could use some experienced guidance. For
> > example, the linter recently started complaining about testing for
> > packages? I didn't even know that was a thing, and I'm pretty sure
> > it wasn't when I started this.
> >
> > To be frank, most of the patches that used to be a part of this
> > package were merged upstream. The fork of mpglib that used to be a
> > part of this project was also removed, so there really wasn't a
> > whole lot of obvious work to do besides moving to newer formats and
> > ditching those patches. I've been reading the documentation when I
> > have time. There's just quite a bit of it, so pointers are helpful.
> >
> > Take a look at what I've done here:
> > https://salsa.debian.org/snhardin-guest/mp3gain. It's not a lot,
> > but I think I'm almost there.
> >
> > Thanks,
> > Scott
> >
> > On 6/14/2020 5:40 AM, Stefan Fritsch wrote:
> >> Hi,
> >>
> >> I used to maintain mp3gain a long time ago. I have still use for
> >> it for the player in my car and would support you if you want to
> >> maintain it. I am still Debian developer and could sponsor your
> >> uploads.
> >>
> >> If you are no longer interested, it may make sense to rename the
> >> bug back to RFP.
> >>
> >> Cheers,
> >> Stefan
