Bug#898501: Bug#899124: fonts-font-awesome: completely breaks web applications, with no notice

2018-05-27 Thread Sean Whitton
control: tag 898501 +wontfix
control: notfixed 898501 fonts-font-awesome/5.0.10-3
control: affects 899124 mkdocs-bootstrap
control: affects 899124 cider

Hello Alexis,

On Sat, May 26, 2018 at 04:07:59PM +0200, Alexis Murzeau wrote:
> close 898501 5.0.10-3
> thanks
>
> Hi,
>
> I'm re-closing #898501: Broken symlinks as they are indeed fixed now and
> to keep only one bug open (#899124) about the incompatibilities caused
> by version 5.

The broken symlinks I originally reported in this bug are not fixed --
try building something depending on mkdocs-bootstrap, e.g. src:cider.

However, discussion in #899124 suggest that the links in question
/can't/ be fixed, because there no longer exists a single font-awesome,
instead three variants.  Hence the wontfix tag.

-- 
Sean Whitton


signature.asc
Description: PGP signature


Bug#899124: fonts-font-awesome: completely breaks web applications, with no notice

2018-05-27 Thread Antonio Terceiro
On Sat, May 26, 2018 at 02:29:56AM +0200, Pierre-Elliott Bécue wrote:
> Le mardi 22 mai 2018 à 21:16:14+0530, Vasudev Kamath a écrit :
> > Hi Antonio,
> > 
> > Antonio Terceiro  writes:
> > 
> > > Control: forwarded -1 
> > > https://salsa.debian.org/fonts-team/fonts-font-awesome/merge_requests/1
> > >
> > > On Sun, May 20, 2018 at 06:15:08PM -0300, Antonio Terceiro wrote:
> > >> Control: reopen -1
> > >> 
> > >> On Sun, May 20, 2018 at 10:32:38PM +0530, Vasudev Kamath wrote:
> > >> > Antonio Terceiro  writes:
> > >> > > 2) revert the changes in fonts-font-awesome in unstable, upload the
> > >> > > new release to experimental, and give people a few months to adapt.
> > >> > 
> > >> > I'm okay with this solution. I've currently fixed the broken links and
> > >> > uploaded the fixes. If you would like more time to adapt to the version
> > >> > 5 of font, I can request its removal from unstable and re-upload old
> > >> > version to unstable and then upload this new version to experimental.
> > >> 
> > >> There is no such thing as requesting removal. you need to upload it with
> > >> a higher version number, but with the old contents. Something like
> > >> 5.0.10+really4.7.0-1.
> > >> 
> > >> Or maybe not. I will try if I can work things out with the new version,
> > >> so expect a few patches.
> > >> 
> > >> For now I'm reopening this bug (which was not really fixed by your -3
> > >> upload), and let's see what I can get.
> > >
> > > So here it is:
> > > https://salsa.debian.org/fonts-team/fonts-font-awesome/merge_requests/1
> > >
> > > This merge request fixes usage of v5, and add a backwards compatibility
> > > layer for the v4 when used with CSS (which was the only option in v4
> > > AFAICT). It also adds autopkgtest to automatically test that the needed
> > > files are in the right places both for v5 and for v4.
> > 
> > Thanks for this!. I've merged this and pushed new version to unstable.
> > 
> > >
> > > LESS and SCSS are not handled.
> > 
> > Let's see if any one is really using them, if so we will get bug report.
> > 
> > Thanks and Warm Regards,
> 
> Hi,
> 
> I'm maintaining HyperKitty, and it relies on fontawesome-webfont.ttf and
> FontAwesome.otf from the v4 version. To avoid shipping the files with the
> package, I linked them from the debian's one in d/rules. (see [1])
> 
> Do we agree that there is no backward compability for such a case?

I'm afraid so. The font files themselves changed upstream, and there is
not a single font file that is equivalente to the old ones anymore.


signature.asc
Description: PGP signature


Bug#899124: fonts-font-awesome: completely breaks web applications, with no notice

2018-05-26 Thread Thomas Goirand
Alexis,

Thanks for your contribution to this bug report.

> [1] Here is an analysis of font-awesome usage across sid packages from
> [3]: Packages embedding a copy of font-awesome:
> [...]
> python-xstatic-font-awesome 4.7.0.0-4: embedded copy of 4.7

Nope, python-xstatic-font-awesome has the fonts in the source package,
but when building the binaries, they are removed and the package points
to /usr/share/fonts-font-awesome/fonts/ (through some Python Xstatic
mechanisms). And under the current situation, the package is currently
completely broken. Threfore, I'm also considering re-embedding the files
in, unless we find a solution.

I very much agree with you that adding a new fonts-font-awesome-v4
package would fix the situation, at least during the time of the
transition. I don't see any issue with doing this, as this really is 2
sets of very different fonts, and also, I don't see how having 2
versions of fonts is a problem (it's unlike shared libraries where
there's security issues when duplicating stuff).

If we can't do that, then I also believe that adding links to
fa-solid-900 as fontawesome-webfont would be helpful.

Anyways, I'll try to get upstream to upgrade to v5.

Cheers,

Thomas Goirand (zigo)



Bug#899124: fonts-font-awesome: completely breaks web applications, with no notice

2018-05-26 Thread Vasudev Kamath
Pierre-Elliott Bécue  writes:

>
> Hi,
>
> I'm maintaining HyperKitty, and it relies on fontawesome-webfont.ttf and
> FontAwesome.otf from the v4 version. To avoid shipping the files with the
> package, I linked them from the debian's one in d/rules. (see [1])
>
> Do we agree that there is no backward compability for such a case?

Upstream completely dropped ttf files. Now there are 3 variants of
opentype fonts, to provide backward compatibility some one should point
out which version suits best and we can create compatibility link. So as
to not break the package for now. But at some point of time reverse
dependencies need to adjust to new version of font.

Cheers,



Bug#898501: Bug#899124: fonts-font-awesome: completely breaks web applications, with no notice

2018-05-26 Thread Alexis Murzeau
close 898501 5.0.10-3
thanks

Hi,

I'm re-closing #898501: Broken symlinks as they are indeed fixed now and
to keep only one bug open (#899124) about the incompatibilities caused
by version 5.

-- 
Alexis Murzeau
PGP: B7E6 0EBB 9293 7B06 BDBC  2787 E7BD 1904 F480 937F





signature.asc
Description: OpenPGP digital signature


Bug#899124: fonts-font-awesome: completely breaks web applications, with no notice

2018-05-25 Thread Pierre-Elliott Bécue
Le mardi 22 mai 2018 à 21:16:14+0530, Vasudev Kamath a écrit :
> Hi Antonio,
> 
> Antonio Terceiro  writes:
> 
> > Control: forwarded -1 
> > https://salsa.debian.org/fonts-team/fonts-font-awesome/merge_requests/1
> >
> > On Sun, May 20, 2018 at 06:15:08PM -0300, Antonio Terceiro wrote:
> >> Control: reopen -1
> >> 
> >> On Sun, May 20, 2018 at 10:32:38PM +0530, Vasudev Kamath wrote:
> >> > Antonio Terceiro  writes:
> >> > > 2) revert the changes in fonts-font-awesome in unstable, upload the
> >> > > new release to experimental, and give people a few months to adapt.
> >> > 
> >> > I'm okay with this solution. I've currently fixed the broken links and
> >> > uploaded the fixes. If you would like more time to adapt to the version
> >> > 5 of font, I can request its removal from unstable and re-upload old
> >> > version to unstable and then upload this new version to experimental.
> >> 
> >> There is no such thing as requesting removal. you need to upload it with
> >> a higher version number, but with the old contents. Something like
> >> 5.0.10+really4.7.0-1.
> >> 
> >> Or maybe not. I will try if I can work things out with the new version,
> >> so expect a few patches.
> >> 
> >> For now I'm reopening this bug (which was not really fixed by your -3
> >> upload), and let's see what I can get.
> >
> > So here it is:
> > https://salsa.debian.org/fonts-team/fonts-font-awesome/merge_requests/1
> >
> > This merge request fixes usage of v5, and add a backwards compatibility
> > layer for the v4 when used with CSS (which was the only option in v4
> > AFAICT). It also adds autopkgtest to automatically test that the needed
> > files are in the right places both for v5 and for v4.
> 
> Thanks for this!. I've merged this and pushed new version to unstable.
> 
> >
> > LESS and SCSS are not handled.
> 
> Let's see if any one is really using them, if so we will get bug report.
> 
> Thanks and Warm Regards,

Hi,

I'm maintaining HyperKitty, and it relies on fontawesome-webfont.ttf and
FontAwesome.otf from the v4 version. To avoid shipping the files with the
package, I linked them from the debian's one in d/rules. (see [1])

Do we agree that there is no backward compability for such a case?

Cheers!

[1] 
https://salsa.debian.org/mailman-team/hyperkitty/blob/ad8b848059fcebe9392eeb79235297cf029051a9/debian/rules#L23

-- 
Pierre-Elliott Bécue
GPG: 9AE0 4D98 6400 E3B6 7528  F493 0D44 2664 1949 74E2
It's far easier to fight for one's principles than to live up to them.


signature.asc
Description: PGP signature


Bug#899124: fonts-font-awesome: completely breaks web applications, with no notice

2018-05-22 Thread Vasudev Kamath
Hi Antonio,

Antonio Terceiro  writes:

> Control: forwarded -1 
> https://salsa.debian.org/fonts-team/fonts-font-awesome/merge_requests/1
>
> On Sun, May 20, 2018 at 06:15:08PM -0300, Antonio Terceiro wrote:
>> Control: reopen -1
>> 
>> On Sun, May 20, 2018 at 10:32:38PM +0530, Vasudev Kamath wrote:
>> > Antonio Terceiro  writes:
>> > > 2) revert the changes in fonts-font-awesome in unstable, upload the
>> > > new release to experimental, and give people a few months to adapt.
>> > 
>> > I'm okay with this solution. I've currently fixed the broken links and
>> > uploaded the fixes. If you would like more time to adapt to the version
>> > 5 of font, I can request its removal from unstable and re-upload old
>> > version to unstable and then upload this new version to experimental.
>> 
>> There is no such thing as requesting removal. you need to upload it with
>> a higher version number, but with the old contents. Something like
>> 5.0.10+really4.7.0-1.
>> 
>> Or maybe not. I will try if I can work things out with the new version,
>> so expect a few patches.
>> 
>> For now I'm reopening this bug (which was not really fixed by your -3
>> upload), and let's see what I can get.
>
> So here it is:
> https://salsa.debian.org/fonts-team/fonts-font-awesome/merge_requests/1
>
> This merge request fixes usage of v5, and add a backwards compatibility
> layer for the v4 when used with CSS (which was the only option in v4
> AFAICT). It also adds autopkgtest to automatically test that the needed
> files are in the right places both for v5 and for v4.

Thanks for this!. I've merged this and pushed new version to unstable.

>
> LESS and SCSS are not handled.

Let's see if any one is really using them, if so we will get bug report.

Thanks and Warm Regards,

Vasudev

--



Bug#899124: fonts-font-awesome: completely breaks web applications, with no notice

2018-05-21 Thread Antonio Terceiro
Control: forwarded -1 
https://salsa.debian.org/fonts-team/fonts-font-awesome/merge_requests/1

On Sun, May 20, 2018 at 06:15:08PM -0300, Antonio Terceiro wrote:
> Control: reopen -1
> 
> On Sun, May 20, 2018 at 10:32:38PM +0530, Vasudev Kamath wrote:
> > Antonio Terceiro  writes:
> > > 2) revert the changes in fonts-font-awesome in unstable, upload the
> > > new release to experimental, and give people a few months to adapt.
> > 
> > I'm okay with this solution. I've currently fixed the broken links and
> > uploaded the fixes. If you would like more time to adapt to the version
> > 5 of font, I can request its removal from unstable and re-upload old
> > version to unstable and then upload this new version to experimental.
> 
> There is no such thing as requesting removal. you need to upload it with
> a higher version number, but with the old contents. Something like
> 5.0.10+really4.7.0-1.
> 
> Or maybe not. I will try if I can work things out with the new version,
> so expect a few patches.
> 
> For now I'm reopening this bug (which was not really fixed by your -3
> upload), and let's see what I can get.

So here it is:
https://salsa.debian.org/fonts-team/fonts-font-awesome/merge_requests/1

This merge request fixes usage of v5, and add a backwards compatibility
layer for the v4 when used with CSS (which was the only option in v4
AFAICT). It also adds autopkgtest to automatically test that the needed
files are in the right places both for v5 and for v4.

LESS and SCSS are not handled.


signature.asc
Description: PGP signature


Bug#899124: fonts-font-awesome: completely breaks web applications, with no notice

2018-05-20 Thread Alexis Murzeau
unmerge 899124
thanks

Hi,

I'm maintaining streamlink which use a custom rtd sphinx theme which use
fonts-font-awesome v4.

I'm unmerging this bug from xxx because there is a major incompatibility
changes in font-awesome 5.
The font file got split in solid, regular and brands fonts, and thus
there is no drop in replacement for the old fontawesome-webfont.xxx.

Many packages use hard-coded path to the old fonts
(fontawesome-webfont.xxx) because they reference them from their .css theme.

According to [1], there are 26 probably affected source packages.

Some packages embed font-awesome directly instead of symlinking to
fonts-font-awesome, which might be a solution for most affected
packages, albeit duplicating the font (which is a bit against the
purpose of this package).

Having a separate package for fonts-font-awesome could let maintainers
use font-awesome 4 until upstream changes for font-awesome 5.
This package would be probably have little change over time as upstream
does not intend to update the v4 branch anymore [4].

This would provide a solution avoiding simply duplicating old
fontawesome-webfont v4 files in packages that use them.

As a side note, depending on the font usage by packages, using
fa-solid-900 as fontawesome-webfont can fix most basic glyphs, but
that's not an ideal solution, mixing v4 css and js with v5 font.

[1] Here is an analysis of font-awesome usage across sid packages from [3]:
Packages embedding a copy of font-awesome:
- boinc 7.10.2+dfsg-1: embedded copy of 4.6.3
- cockpit 168-1: embedded copy of 4.2.0
- controlsfx 8.40.14-1: embedded copy of 4.7.0
- copyq 3.1.2-1: embedded copy of 4.7.0
- coz-profiler 0.1.0-2: embedded copy of 4.7
- crmsh 3.0.1-4: embedded copy of 4.0.3
- fontawesomefx 8.9-1: embedded copy of 4.4.1
- golang-github-smartystreets-goconvey 1.6.1-3: embedded copy of 4.5
- hugo 0.40.3-1: embedded copy of 4.4.1
- jekyll 3.1.6+dfsg-3: embedded copy of 4.4.0
- mitmproxy 3.0.3-1: embedded copy of 4.2.0 and 4.0.3 (first mitmproxy
itself and the later for onboardingapp plugin)
- mongodb 1:3.4.14-3: embedded copy in base64
- nghttp2 1.32.0-1: embedded copy of 4.2.0
- opennebula 4.12.3+dfsg-3.1: embedded copy of 4.3.0
- pgbadger 9.2-1: embedded copy of 3.2
- publican 4.3.2-2: embedded copy of 4.2.0
- python-mne 0.15.2+dfsg-2: embedded copy of 4.7.0
- python-openstackdocstheme 1.18.1-3: embedded copy of 4.7.0
- python-xstatic-font-awesome 4.7.0.0-4: embedded copy of 4.7
- rclone 1.41-1: embedded copy of 4.6.3
- spdylay 1.3.2-2.1: embedded copy of 4.0.2
- sympa 6.2.32~dfsg-1: embedded copy of 4.3.0
- wims 1:4.15b~dfsg1-11: embedded copy of 4.7.0
- zeal / 1:0.4.0-2: embedded copy

Packages symlinking to fonts-font-awesome files:
- cantata 2.3.0.ds1-1: symlink to fonts
- djangorestframework 3.8.2-1: symlink to fonts
- glewlwyd 1.3.1-1: embedded copy of 4.7 replaced with symlink to fonts
in override_dh_install-indep
- grafana 2.6.0+dfsg-3: symlink to fonts and css
- grr 3.1.0.2+dfsg-5: symlink to fonts
- hyperkitty 1.1.4-4: symlink to fonts
- julia 0.4.7-7: symlink to fonts
- lightbeam 1.3.1+dfsg-1: symlink to fonts and css
- mkdocs-bootstrap 0.1.1-3: symlink to fonts
- mkdocs-bootswatch 0.4.0-3: symlink to fonts
- netdata 1.10.0+dfsg-1: symlink to fonts and css
- ntopng 3.2+dfsg1-1: symlink to fonts, css, less, scss
- oca-core 11.0.20180420-1: symlink to fonts
- phabricator 0~git20180509-2: symlink to fonts
- plasma-applet-redshift-control 1.0.18-2: symlink to fonts
- prewikka 4.1.5-2: symlink to fonts and css
- python-qtawesome 0.4.4+ds1-1: symlink to fonts
- r-cran-rmarkdown 1.9+dfsg-2: symlink to fonts and css
- r-cran-shiny 1.0.5+dfsg-4: symlink to fonts and css
- ruby-font-awesome-rails 4.7.0.2-1: symlink to fonts
- rustc 1.25.0+dfsg1-2: symlink to fonts and css
- sphinx-rtd-theme 0.2.4-1: symlink to fonts
- streamlink 0.12.1+dfsg-1: symlink to fonts
- tulip 4.8.0dfsg-2: symlink to fonts
- ublock-origin 1.13.8+dfsg-1: symlink to fonts
- webdeveloper 1.2.13-1: symlink to fonts

[2] https://github.com/rtfd/sphinx_rtd_theme/issues/266
[3] https://codesearch.debian.net/search?q=fontawesome-webfont
[4]
https://github.com/FortAwesome/Font-Awesome#where-did-font-awesome-4-or-3-go
-- 
Alexis Murzeau
PGP: B7E6 0EBB 9293 7B06 BDBC  2787 E7BD 1904 F480 937F



signature.asc
Description: OpenPGP digital signature


Bug#899124: fonts-font-awesome: completely breaks web applications, with no notice

2018-05-20 Thread Antonio Terceiro
Control: reopen -1

On Sun, May 20, 2018 at 10:32:38PM +0530, Vasudev Kamath wrote:
> Antonio Terceiro  writes:
> > 2) revert the changes in fonts-font-awesome in unstable, upload the
> > new release to experimental, and give people a few months to adapt.
> 
> I'm okay with this solution. I've currently fixed the broken links and
> uploaded the fixes. If you would like more time to adapt to the version
> 5 of font, I can request its removal from unstable and re-upload old
> version to unstable and then upload this new version to experimental.

There is no such thing as requesting removal. you need to upload it with
a higher version number, but with the old contents. Something like
5.0.10+really4.7.0-1.

Or maybe not. I will try if I can work things out with the new version,
so expect a few patches.

For now I'm reopening this bug (which was not really fixed by your -3
upload), and let's see what I can get.


signature.asc
Description: PGP signature


Bug#899124: fonts-font-awesome: completely breaks web applications, with no notice

2018-05-20 Thread Vasudev Kamath

Hi Antonio,

Antonio Terceiro  writes:

> Package: fonts-font-awesome
> Version: 5.0.10-1
> Severity: grave
>
> Font-Awesome version completely changed everything, and any web
> applications that use it are now broken unless they go through some
> manual intervention.
>
> https://fontawesome.com/how-to-use/upgrading-from-4
>
> As a maintainer of multiple packages that use Font-Awesome, it would
> have been nice to receive a heads up and be given some time to adapt.
> But instead, now everything is broken and every single web appliction
> package that uses Font-Awesome needs to be changed to cope with the
> changes.

Apologies for the problems created by this upload. I was not aware of
technical efforts involved due to this upgrade as I myself do not use
this font and maintainer only because of some historical reasons.

>
> I'm not sure how to move forward now. IMO either
>
> 1) revert the changes in fonts-font-awesome, and package the new release
> under a new name (e.g.  fonts-font-awesome-5)

Though it might temporarily be a solution I think in long run it will be
burden as font-awesome till 4 will be not maintained.

>
> or
>
> 2) revert the changes in fonts-font-awesome in unstable, upload the
> new release to experimental, and give people a few months to adapt.

I'm okay with this solution. I've currently fixed the broken links and
uploaded the fixes. If you would like more time to adapt to the version
5 of font, I can request its removal from unstable and re-upload old
version to unstable and then upload this new version to experimental.

Let me know if this works for you.

Cheers,
Vasudev

--



Bug#899124: fonts-font-awesome: completely breaks web applications, with no notice

2018-05-19 Thread Antonio Terceiro
Package: fonts-font-awesome
Version: 5.0.10-1
Severity: grave

Font-Awesome version completely changed everything, and any web
applications that use it are now broken unless they go through some
manual intervention.

https://fontawesome.com/how-to-use/upgrading-from-4

As a maintainer of multiple packages that use Font-Awesome, it would
have been nice to receive a heads up and be given some time to adapt.
But instead, now everything is broken and every single web appliction
package that uses Font-Awesome needs to be changed to cope with the
changes.

I'm not sure how to move forward now. IMO either

1) revert the changes in fonts-font-awesome, and package the new release
under a new name (e.g.  fonts-font-awesome-5)

or

2) revert the changes in fonts-font-awesome in unstable, upload the
new release to experimental, and give people a few months to adapt.

-- System Information:
Debian Release: buster/sid
  APT prefers unstable-debug
  APT policy: (500, 'unstable-debug'), (500, 'testing-debug'), (500, 
'unstable'), (500, 'testing'), (1, 'experimental-debug'), (1, 'experimental')
Architecture: amd64 (x86_64)

Kernel: Linux 4.16.0-1-amd64 (SMP w/4 CPU cores)
Locale: LANG=pt_BR.UTF-8, LC_CTYPE=pt_BR.UTF-8 (charmap=UTF-8), 
LANGUAGE=pt_BR:pt:en (charmap=UTF-8)
Shell: /bin/sh linked to /bin/dash
Init: systemd (via /run/systemd/system)
LSM: AppArmor: enabled

-- no debconf information


signature.asc
Description: PGP signature