Bug#900777: fontmake: fails to rebuild fonts-firacode from its glyphs source
Hi, fontmake and the dependencies has been updated: * fontmake 1.8.0: https://salsa.debian.org/fonts-team/fontmake * glyphslib 3.1.4: https://salsa.debian.org/fonts-team/glyphslib * mutatormath 2.1.2: https://salsa.debian.org/fonts-team/mutatormath * fontmath 0.4.9: https://salsa.debian.org/fonts-team/fontmath On Fri, Dec 14, 2018 at 10:23:10AM +0800, Yao Wei wrote: > > fontmake 1.6.1 has been in Debian since September. Maybe you're > > thinking of fontmake 1.8 which isn't in Salsa yet. > > Ouch. I will update this soon. Yao Wei signature.asc Description: PGP signature
Bug#900777: fontmake: fails to rebuild fonts-firacode from its glyphs source
Hi, Replying inline: On Thu, Dec 13, 2018 at 10:00:46AM -0500, Jeremy Bicha wrote: > I think I've done all of these today (or earlier) except for: > > ufo2ft 2.5: the build requires skia-pathops. Did you want to work on > packaging that too? This is not an requirement as far as the source code suggests. It seems skia-pathops is optional, where booleanoperations is used by default for path operations. Also, skia has been in RFP for a while (#818180). I think we can package this but it is not a blocking issue for this package. > fontmake 1.6.1 has been in Debian since September. Maybe you're > thinking of fontmake 1.8 which isn't in Salsa yet. Ouch. I will update this soon. Yao Wei signature.asc Description: PGP signature
Bug#900777: fontmake: fails to rebuild fonts-firacode from its glyphs source
On Fri, Nov 30, 2018 at 3:24 AM Yao Wei wrote: > I would like to RFS the following packages to close this bug, as I am > non-uploading DD: > > * fontmake 1.6.1: https://salsa.debian.org/fonts-team/fontmake > * ufo2ft 2.5.0: https://salsa.debian.org/fonts-team/ufo2ft > * fonttools 3.32.0: https://salsa.debian.org/fonts-team/fonttools > * defcon 0.6.0: https://salsa.debian.org/fonts-team/defcon > * cu2qu 1.6.5: https://salsa.debian.org/fonts-team/cu2qu > * booleanoperations 0.8.1: > https://salsa.debian.org/fonts-team/booleanoperations > * ufolib2 (NEW) 0.2.1: https://salsa.debian.org/fonts-team/ufolib2 > > As well as following python module dependencies: > * python-fs (NEW for python3) 2.1.1: > https://salsa.debian.org/python-team/modules/python-fs > * python-backports.os (NEW) 0.1.1: > https://salsa.debian.org/python-team/modules/python-backports.os I think I've done all of these today (or earlier) except for: ufo2ft 2.5: the build requires skia-pathops. Did you want to work on packaging that too? fontmake 1.6.1 has been in Debian since September. Maybe you're thinking of fontmake 1.8 which isn't in Salsa yet. Thanks, Jeremy Bicha
Bug#900777: fontmake: fails to rebuild fonts-firacode from its glyphs source
On Fri, Nov 30, 2018 at 07:04:53AM -0500, Jeremy Bicha wrote: > Please check that you have git pushed the upstream and pristine-tar > branches for that list. Ouch. Uploaded, Please check. Yao Wei signature.asc Description: PGP signature
Bug#900777: fontmake: fails to rebuild fonts-firacode from its glyphs source
On Fri, Nov 30, 2018 at 3:24 AM Yao Wei wrote: > I would like to RFS the following packages to close this bug, as I am > non-uploading DD: > > * fontmake 1.6.1: https://salsa.debian.org/fonts-team/fontmake > * ufo2ft 2.5.0: https://salsa.debian.org/fonts-team/ufo2ft > * fonttools 3.32.0: https://salsa.debian.org/fonts-team/fonttools > * defcon 0.6.0: https://salsa.debian.org/fonts-team/defcon > * cu2qu 1.6.5: https://salsa.debian.org/fonts-team/cu2qu > * booleanoperations 0.8.1: > https://salsa.debian.org/fonts-team/booleanoperations > * ufolib2 (NEW) 0.2.1: https://salsa.debian.org/fonts-team/ufolib2 Please check that you have git pushed the upstream and pristine-tar branches for that list. Thanks, Jeremy Bicha
Bug#900777: fontmake: fails to rebuild fonts-firacode from its glyphs source
Hi, I would like to RFS the following packages to close this bug, as I am non-uploading DD: * fontmake 1.6.1: https://salsa.debian.org/fonts-team/fontmake * ufo2ft 2.5.0: https://salsa.debian.org/fonts-team/ufo2ft * fonttools 3.32.0: https://salsa.debian.org/fonts-team/fonttools * defcon 0.6.0: https://salsa.debian.org/fonts-team/defcon * cu2qu 1.6.5: https://salsa.debian.org/fonts-team/cu2qu * booleanoperations 0.8.1: https://salsa.debian.org/fonts-team/booleanoperations * ufolib2 (NEW) 0.2.1: https://salsa.debian.org/fonts-team/ufolib2 As well as following python module dependencies: * python-fs (NEW for python3) 2.1.1: https://salsa.debian.org/python-team/modules/python-fs * python-backports.os (NEW) 0.1.1: https://salsa.debian.org/python-team/modules/python-backports.os On Tue, Nov 27, 2018 at 12:37:45PM +0100, Fabian Greffrath wrote: > James Godfrey-Kittle wrote: > > Your error is the same as in the original email. The error "Glyph > > psili cannot be in both @MC_top and @MC_topleft" I believe was fixed > > by https://github.com/googlei18n/ufo2ft/pull/276, and should not occur > > with ufo2ft >= 2.3.0. > > Great, thank you! So, we have a chance to build this font from sources > once an updated ufo2ft package (and probably glyphslib) enters Debian. signature.asc Description: PGP signature
Bug#900777: fontmake: fails to rebuild fonts-firacode from its glyphs source
James Godfrey-Kittle wrote: > Your error is the same as in the original email. The error "Glyph > psili cannot be in both @MC_top and @MC_topleft" I believe was fixed > by https://github.com/googlei18n/ufo2ft/pull/276, and should not occur > with ufo2ft >= 2.3.0. Great, thank you! So, we have a chance to build this font from sources once an updated ufo2ft package (and probably glyphslib) enters Debian. Cheers, - Fabian
Bug#900777: fontmake: fails to rebuild fonts-firacode from its glyphs source
Aha! I didn't have the correct versions of the dependencies as packaged in sid. Your error is the same as in the original email. The error "Glyph psili cannot be in both @MC_top and @MC_topleft" I believe was fixed by https://github.com/googlei18n/ufo2ft/pull/276, and should not occur with ufo2ft >= 2.3.0.
Bug#900777: fontmake: fails to rebuild fonts-firacode from its glyphs source
Am Montag, den 26.11.2018, 09:19 -0800 schrieb James Godfrey-Kittle:
> > Yes, according to https://packages.debian.org/fontmake both Buster and
> Sid are packaging fontmake 1.6.1. I also tried with the latest version
> on Github (1.8.0) and got no error.
Well, then something is still odd on the Debian side. This is what I
get on an up-to-date sid system:
$ fontmake --version
1.6.1
$ fontmake -g FiraCode.glyphs
INFO:fontmake.font_project:Building master UFOs and designspace from
Glyphs source
INFO:glyphsLib.classes:Parsing "FiraCode.glyphs" file into
INFO:fontmake.font_project:Building OTF for FiraCode-Regular
INFO:ufo2ft:Pre-processing glyphs
INFO:ufo2ft.filters:Running DecomposeComponentsFilter on FiraCode-
Regular
INFO:ufo2ft.filters:Running RemoveOverlapsFilter on FiraCode-Regular
INFO:ufo2ft:Building OpenType tables
INFO:ufo2ft.outlineCompiler:The copyright was normalized for storage in
the CFF table and consequently some characters were dropped: 'Copyright
Copyright 2015 by Nikita Prokopov'
Traceback (most recent call last):
File "/usr/bin/fontmake", line 11, in
load_entry_point('fontmake==1.6.1', 'console_scripts',
'fontmake')()
File "/usr/lib/python3/dist-packages/fontmake/__main__.py", line 248,
in main
project.run_from_glyphs(glyphs_path, **args)
File "/usr/lib/python3/dist-packages/fontmake/font_project.py", line
548, in run_from_glyphs
self.run_from_designspace(designspace_path, **kwargs)
File "/usr/lib/python3/dist-packages/fontmake/font_project.py", line
623, in run_from_designspace
**kwargs)
File "/usr/lib/python3/dist-packages/fontmake/font_project.py", line
654, in run_from_ufos
self.build_otfs(ufos, **kwargs)
File "/usr/lib/python3/dist-packages/fontmake/font_project.py", line
232, in build_otfs
self.save_otfs(ufos, **kwargs)
File "/usr/lib/python3/dist-packages/fontTools/misc/loggingTools.py",
line 372, in wrapper
return func(*args, **kwds)
File "/usr/lib/python3/dist-packages/fontmake/font_project.py", line
395, in save_otfs
for font, ufo in zip(fonts, ufos):
File "/usr/lib/python3/dist-packages/fontmake/font_project.py", line
280, in _iter_compile
yield compile_func(ufo, **options)
File "/usr/lib/python3/dist-packages/ufo2ft/__init__.py", line 89, in
compileOTF
featureCompilerClass=featureCompilerClass,
File "/usr/lib/python3/dist-packages/ufo2ft/__init__.py", line 230,
in compileFeatures
return featureCompiler.compile()
File "/usr/lib/python3/dist-packages/ufo2ft/featureCompiler.py", line
125, in compile
self.setupFeatures()
File "/usr/lib/python3/dist-packages/ufo2ft/featureCompiler.py", line
225, in setupFeatures
writer.write(self.ufo, featureFile, compiler=self)
File "/usr/lib/python3/dist-
packages/ufo2ft/featureWriters/baseFeatureWriter.py", line 118, in
write
return self._write()
File "/usr/lib/python3/dist-
packages/ufo2ft/featureWriters/markFeatureWriter.py", line 691, in
_write
features = self._makeFeatures()
File "/usr/lib/python3/dist-
packages/ufo2ft/featureWriters/markFeatureWriter.py", line 640, in
_makeFeatures
indicGlyphs = self._getIndicGlyphs()
File "/usr/lib/python3/dist-
packages/ufo2ft/featureWriters/markFeatureWriter.py", line 677, in
_getIndicGlyphs
gsub = self.compileGSUB()
File "/usr/lib/python3/dist-
packages/ufo2ft/featureWriters/baseFeatureWriter.py", line 181, in
compileGSUB
gsub = compileGSUB(self.context.feaFile, glyphOrder)
File "/usr/lib/python3/dist-packages/ufo2ft/util.py", line 119, in
compileGSUB
addOpenTypeFeatures(font, featureFile, tables={"GSUB"})
File "/usr/lib/python3/dist-packages/fontTools/feaLib/builder.py",
line 22, in addOpenTypeFeatures
builder.build(tables=tables)
File "/usr/lib/python3/dist-packages/fontTools/feaLib/builder.py",
line 132, in build
table = self.makeTable(tag)
File "/usr/lib/python3/dist-packages/fontTools/feaLib/builder.py",
line 540, in makeTable
table.LookupList.Lookup = self.buildLookups_(tag)
File "/usr/lib/python3/dist-packages/fontTools/feaLib/builder.py",
line 530, in buildLookups_
return [l.build() for l in lookups]
File "/usr/lib/python3/dist-packages/fontTools/feaLib/builder.py",
line 530, in
return [l.build() for l in lookups]
File "/usr/lib/python3/dist-packages/fontTools/feaLib/builder.py",
line 1265, in build
self.setBacktrackCoverage_(prefix, st)
File "/usr/lib/python3/dist-packages/fontTools/feaLib/builder.py",
line 1185, in setBacktrackCoverage_
coverage = otl.buildCoverage(p, self.glyphMap)
File "/usr/lib/python3/dist-packages/fontTools/otlLib/builder.py",
line 11, in buildCoverage
self.glyphs = sorted(glyphs, key=glyphMap.__getitem__)
KeyError: ''
signature.asc
Description: This is a digitally signed message part
Bug#900777: fontmake: fails to rebuild fonts-firacode from its glyphs source
James Godfrey-Kittle wrote: > Hm, I'm unable to reproduce this error with fontmake 1.6.1 and the > latest version of FiraCode from https://github.com/tonsky/FiraCode. Is this with the fontmake version packaged in Debian? - Fabian
Bug#900777: fontmake: fails to rebuild fonts-firacode from its glyphs source
Hm, I'm unable to reproduce this error with fontmake 1.6.1 and the latest version of FiraCode from https://github.com/tonsky/FiraCode. My output: $ fontmake -g FiraCode.glyphs INFO:fontmake.font_project:Building master UFOs and designspace from Glyphs source INFO:glyphsLib.classes:Parsing "FiraCode.glyphs" file into INFO:fontmake.font_project:Building OTF for FiraCode-Bold INFO:ufo2ft:Pre-processing glyphs INFO:ufo2ft.filters:Running DecomposeComponentsFilter on FiraCode-Bold INFO:ufo2ft.filters:Running RemoveOverlapsFilter on FiraCode-Bold INFO:ufo2ft:Building OpenType tables INFO:ufo2ft.outlineCompiler:The copyright was normalized for storage in the CFF table and consequently some characters were dropped: 'Copyright Copyright 2015 by Nikita Prokopov' INFO:fontmake.font_project:Saving master_otf/FiraCode-Bold.otf INFO:fontmake.font_project:Building OTF for FiraCode-Regular INFO:ufo2ft:Pre-processing glyphs INFO:ufo2ft.filters:Running DecomposeComponentsFilter on FiraCode-Regular INFO:ufo2ft.filters:Running RemoveOverlapsFilter on FiraCode-Regular INFO:ufo2ft:Building OpenType tables INFO:ufo2ft.outlineCompiler:The copyright was normalized for storage in the CFF table and consequently some characters were dropped: 'Copyright Copyright 2015 by Nikita Prokopov' INFO:fontmake.font_project:Saving master_otf/FiraCode-Regular.otf INFO:fontmake.font_project:Building TTF for FiraCode-Bold INFO:ufo2ft:Pre-processing glyphs INFO:ufo2ft.filters:Running DecomposeComponentsFilter on FiraCode-Bold INFO:ufo2ft.filters:Running RemoveOverlapsFilter on FiraCode-Bold INFO:ufo2ft.filters:Running CubicToQuadraticFilter on FiraCode-Bold INFO:ufo2ft.filters.cubicToQuadratic:New spline lengths: 1: 266, 2: 2368, 3: 740, 4: 188, 5: 23 INFO:ufo2ft:Building OpenType tables INFO:fontmake.font_project:Saving master_ttf/FiraCode-Bold.ttf INFO:fontmake.font_project:Building TTF for FiraCode-Regular INFO:ufo2ft:Pre-processing glyphs INFO:ufo2ft.filters:Running DecomposeComponentsFilter on FiraCode-Regular INFO:ufo2ft.filters:Running RemoveOverlapsFilter on FiraCode-Regular INFO:ufo2ft.filters:Running CubicToQuadraticFilter on FiraCode-Regular INFO:ufo2ft.filters.cubicToQuadratic:New spline lengths: 1: 257, 2: 2313, 3: 783, 4: 208, 5: 25 INFO:ufo2ft:Building OpenType tables INFO:fontmake.font_project:Saving master_ttf/FiraCode-Regular.ttf Am I running fontmake with different arguments?
Bug#900777: fontmake: fails to rebuild fonts-firacode from its glyphs source
Hi James, Am Dienstag, den 20.11.2018, 09:22 -0800 schrieb James Godfrey-Kittle: > with some component of fontmake; it's worth posting an issue on Github > to have it triaged (I was planning to do this soon when I have time). yes, please! Thanks, - Fabian signature.asc Description: This is a digitally signed message part
Bug#900777: fontmake: fails to rebuild fonts-firacode from its glyphs source
On 2018-11-20 10:22 a.m., James Godfrey-Kittle wrote: > It's possible that this font actually contains illegal feature syntax, > which is still accepted by Glyphs. Or of course it could be an issue > with some component of fontmake; it's worth posting an issue on Github > to have it triaged (I was planning to do this soon when I have time). It is also possible that the font source worked at some point with the build tool chain, then the tool chain changed, breaking the build. I am not saying this is the case here, I have not looked into the details. Just to say I have seen similar issue with my team's own fonts where a font built with the toolchain, then the toolchain was updated (in one case to fix a bug), and the build broke. So in some sense, the source was not incorrect until the build system found it to be incorrect. Bobby -- Bobby de Vos /bobby_de...@sil.org/ signature.asc Description: OpenPGP digital signature
Bug#900777: fontmake: fails to rebuild fonts-firacode from its glyphs source
It's possible that this font actually contains illegal feature syntax, which is still accepted by Glyphs. Or of course it could be an issue with some component of fontmake; it's worth posting an issue on Github to have it triaged (I was planning to do this soon when I have time).
Bug#900777: fontmake: fails to rebuild fonts-firacode from its glyphs source
Hi, Yao Wei wrote: > Sorry for the late reply, here was me testing to build Fira Code after > bumping fontmake: *sigh* this doesn't look too promising. Do you have any idea which package is responsible for this error? Thanks, - Fabian
Bug#900777: fontmake: fails to rebuild fonts-firacode from its glyphs source
Hi,
Sorry for the late reply, here was me testing to build Fira Code after
bumping fontmake:
INFO:fontmake.font_project:Building master UFOs and designspace from Glyphs
source
INFO:glyphsLib.classes:Parsing "FiraCode.glyphs" file into
INFO:fontmake.font_project:Building OTF for FiraCode-Regular
INFO:ufo2ft:Pre-processing glyphs
INFO:ufo2ft.filters:Running DecomposeComponentsFilter on FiraCode-Regular
INFO:ufo2ft.filters:Running RemoveOverlapsFilter on FiraCode-Regular
INFO:ufo2ft:Building OpenType tables
INFO:ufo2ft.outlineCompiler:The copyright was normalized for storage in the
CFF table and consequently some characters were dropped: 'Copyright
Copyright 2015 by Nikita Prokopov'
ERROR:ufo2ft.featureCompiler:Compilation failed! Inspect temporary file:
'/tmp/tmpyyyj2ern'
Traceback (most recent call last):
File "/usr/bin/fontmake", line 11, in
load_entry_point('fontmake==1.6.1', 'console_scripts', 'fontmake')()
File "/usr/lib/python3/dist-packages/fontmake/__main__.py", line 248, in
main
project.run_from_glyphs(glyphs_path, **args)
File "/usr/lib/python3/dist-packages/fontmake/font_project.py", line 548,
in run_from_glyphs
self.run_from_designspace(designspace_path, **kwargs)
File "/usr/lib/python3/dist-packages/fontmake/font_project.py", line 623,
in run_from_designspace
**kwargs)
File "/usr/lib/python3/dist-packages/fontmake/font_project.py", line 654,
in run_from_ufos
self.build_otfs(ufos, **kwargs)
File "/usr/lib/python3/dist-packages/fontmake/font_project.py", line 232,
in build_otfs
self.save_otfs(ufos, **kwargs)
File "/usr/lib/python3/dist-packages/fontTools/misc/loggingTools.py",
line 372, in wrapper
return func(*args, **kwds)
File "/usr/lib/python3/dist-packages/fontmake/font_project.py", line 395,
in save_otfs
for font, ufo in zip(fonts, ufos):
File "/usr/lib/python3/dist-packages/fontmake/font_project.py", line 280,
in _iter_compile
yield compile_func(ufo, **options)
File "/usr/lib/python3/dist-packages/ufo2ft/__init__.py", line 89, in
compileOTF
featureCompilerClass=featureCompilerClass,
File "/usr/lib/python3/dist-packages/ufo2ft/__init__.py", line 230, in
compileFeatures
return featureCompiler.compile()
File "/usr/lib/python3/dist-packages/ufo2ft/featureCompiler.py", line
131, in compile
self.buildTables()
File "/usr/lib/python3/dist-packages/ufo2ft/featureCompiler.py", line
252, in buildTables
self.ttFont, self.features, filename=path
File "/usr/lib/python3/dist-packages/fontTools/feaLib/builder.py", line
31, in addOpenTypeFeaturesFromString
addOpenTypeFeatures(font, featurefile, tables=tables)
File "/usr/lib/python3/dist-packages/fontTools/feaLib/builder.py", line
22, in addOpenTypeFeatures
builder.build(tables=tables)
File "/usr/lib/python3/dist-packages/fontTools/feaLib/builder.py", line
109, in build
self.parseTree.build(self)
File "/usr/lib/python3/dist-packages/fontTools/feaLib/ast.py", line 260,
in build
s.build(builder)
File "/usr/lib/python3/dist-packages/fontTools/feaLib/ast.py", line 289,
in build
Block.build(self, builder)
File "/usr/lib/python3/dist-packages/fontTools/feaLib/ast.py", line 260,
in build
s.build(builder)
File "/usr/lib/python3/dist-packages/fontTools/feaLib/ast.py", line 328,
in build
Block.build(self, builder)
File "/usr/lib/python3/dist-packages/fontTools/feaLib/ast.py", line 260,
in build
s.build(builder)
File "/usr/lib/python3/dist-packages/fontTools/feaLib/ast.py", line 850,
in build
builder.add_mark_base_pos(self.location, self.base.glyphSet(),
self.marks)
File "/usr/lib/python3/dist-packages/fontTools/feaLib/builder.py", line
973, in add_mark_base_pos
self.add_marks_(location, builder, marks)
File "/usr/lib/python3/dist-packages/fontTools/feaLib/builder.py", line
969, in add_marks_
location)
fontTools.feaLib.error.FeatureLibError: :1578:9: Glyph psili
cannot be in both @MC_top and @MC_topleft
On Fri, Nov 9, 2018 at 6:41 PM Fabian Greffrath wrote:
> Hi,
>
> Yao Wei wrote:
> > While newer version is ready, I found that building Fira Code needs the
> > dependencies under fontmake to be bumped, hence this bug is kept
> > unresolved.
>
> could you please tell me what exactly needs to be updated in order to
> build fonts-firacode with fontmake?
>
> Thanks!
>
> - Fabian
>
>
>
Bug#900777: fontmake: fails to rebuild fonts-firacode from its glyphs source
Hi, Yao Wei wrote: > While newer version is ready, I found that building Fira Code needs the > dependencies under fontmake to be bumped, hence this bug is kept > unresolved. could you please tell me what exactly needs to be updated in order to build fonts-firacode with fontmake? Thanks! - Fabian
Bug#900777: fontmake: fails to rebuild fonts-firacode from its glyphs source
Hi Jeremy, Jeremy Bicha wrote: > 3.1 is not a trivial update since our glyphdata handling will need to > be redone (debian/rules, debian/copyright and we probably need a > glyphsinfo update). I have seen some progress in the salsa GIT repo recently. Is there anything still missing to have this package uploaded, anything that I could do to help? Cheers, - Fabian
Bug#900777: fontmake: fails to rebuild fonts-firacode from its glyphs source
Hi, While newer version is ready, I found that building Fira Code needs the dependencies under fontmake to be bumped, hence this bug is kept unresolved. Yao Wei On Tue, Oct 30, 2018 at 17:27 Fabian Greffrath wrote: > Hi Jeremy, > > Jeremy Bicha wrote: > > 3.1 is not a trivial update since our glyphdata handling will need to > > be redone (debian/rules, debian/copyright and we probably need a > > glyphsinfo update). > > I have seen some progress in the salsa GIT repo recently. Is there > anything still missing to have this package uploaded, anything that I > could do to help? > > Cheers, > > - Fabian > > >
Bug#900777: fontmake: fails to rebuild fonts-firacode from its glyphs source
Jeremy Bicha wrote: > 3.1 is not a trivial update since our glyphdata handling will need to > be redone (debian/rules, debian/copyright and we probably need a > glyphsinfo update). Okay, thanks! - Fabian
Bug#900777: fontmake: fails to rebuild fonts-firacode from its glyphs source
On Mon, Oct 15, 2018 at 11:09 AM Fabian Greffrath wrote: > > This has been fixed upstream in glyphslib: > > https://github.com/googlei18n/glyphsLib/pull/428 > > any chance to get glyphslib >= 3.1.1 into Debian in the near future? 3.1 is not a trivial update since our glyphdata handling will need to be redone (debian/rules, debian/copyright and we probably need a glyphsinfo update). Thanks, Jeremy Bicha
Bug#900777: fontmake: fails to rebuild fonts-firacode from its glyphs source
Hi there, > This has been fixed upstream in glyphslib: > https://github.com/googlei18n/glyphsLib/pull/428 any chance to get glyphslib >= 3.1.1 into Debian in the near future? - Fabian signature.asc Description: This is a digitally signed message part
Bug#900777: fontmake: fails to rebuild fonts-firacode from its glyphs source
Control: reassign -1 glyphslib Control: found -1 3.0.2-3 Control: tags -1 + fixed-upstream This has been fixed upstream in glyphslib: https://github.com/googlei18n/glyphsLib/pull/428 - Fabian signature.asc Description: This is a digitally signed message part
Bug#900777: fontmake: fails to rebuild fonts-firacode from its glyphs source
I filed this upstream here: https://github.com/googlei18n/fontmake/issues/445
Bug#900777: fontmake: fails to rebuild fonts-firacode from its glyphs source
Package: fontmake
Version: 1.4.0-2
Severity: normal
Hi fontmake mates,
the following happens when I try to rebuild fonts-firacode from its
glyphs source. I have absolutely no clue what that means. Could you
probably have a look, please?
$ fontmake -g FiraCode.glyphs
INFO:fontmake.font_project:Building master UFOs and designspace from Glyphs
source
INFO:glyphsLib.parser:Parsing .glyphs file
INFO:glyphsLib:Loading to UFOs
INFO:glyphsLib.util:Writing master_ufo/FiraCode-Regular.ufo
INFO:glyphsLib.util:Writing master_ufo/FiraCode-Bold.ufo
INFO:fontmake.font_project:Building OTFs
INFO:fontmake.font_project:Decomposing glyphs for FiraCode-Regular
INFO:fontmake.font_project:Decomposing glyphs for FiraCode-Bold
INFO:fontmake.font_project:Removing overlaps for FiraCode-Regular
INFO:fontmake.font_project:Removing overlaps for FiraCode-Bold
INFO:fontmake.font_project:Saving OTF for FiraCode-Regular
WARNING:ufo2ft.outlineCompiler:The copyright was normalized for storage in the
CFF table and consequently some characters were dropped: 'Copyright Copyright
2015 by Nikita Prokopov'
Traceback (most recent call last):
File "/usr/bin/fontmake", line 11, in
load_entry_point('fontmake==1.4.0', 'console_scripts', 'fontmake')()
File "/usr/lib/python3/dist-packages/fontmake/__main__.py", line 186, in main
project.run_from_glyphs(glyphs_path, **args)
File "/usr/lib/python3/dist-packages/fontmake/font_project.py", line 369, in
run_from_glyphs
designspace_path, instance_data=instance_data, **kwargs)
File "/usr/lib/python3/dist-packages/fontmake/font_project.py", line 437, in
run_from_designspace
interpolate_layout_from=interpolate_layout_from, **kwargs)
File "/usr/lib/python3/dist-packages/fontmake/font_project.py", line 476, in
run_from_ufos
ufos, remove_overlaps, **kwargs)
File "/usr/lib/python3/dist-packages/fontmake/font_project.py", line 169, in
build_otfs
self.save_otfs(ufos, **kwargs)
File "/usr/lib/python3/dist-packages/fontTools/misc/loggingTools.py", line
372, in wrapper
return func(*args, **kwds)
File "/usr/lib/python3/dist-packages/fontmake/font_project.py", line 286, in
save_otfs
font = compileOTF(ufo, optimizeCFF=subroutinize, **compiler_options)
File "/usr/lib/python3/dist-packages/ufo2ft/__init__.py", line 69, in
compileOTF
featureCompiler.compile()
File "/usr/lib/python3/dist-packages/ufo2ft/featureCompiler.py", line 56, in
compile
self.setupFile_featureTables()
File "/usr/lib/python3/dist-packages/ufo2ft/featureCompiler.py", line 143, in
setupFile_featureTables
filename=feapath)
File "/usr/lib/python3/dist-packages/fontTools/feaLib/builder.py", line 25,
in addOpenTypeFeaturesFromString
addOpenTypeFeatures(font, featurefile)
File "/usr/lib/python3/dist-packages/fontTools/feaLib/builder.py", line 16,
in addOpenTypeFeatures
builder.build()
File "/usr/lib/python3/dist-packages/fontTools/feaLib/builder.py", line 87,
in build
table = self.makeTable(tag)
File "/usr/lib/python3/dist-packages/fontTools/feaLib/builder.py", line 468,
in makeTable
table.LookupList.Lookup = self.buildLookups_(tag)
File "/usr/lib/python3/dist-packages/fontTools/feaLib/builder.py", line 458,
in buildLookups_
return [l.build() for l in lookups]
File "/usr/lib/python3/dist-packages/fontTools/feaLib/builder.py", line 458,
in
return [l.build() for l in lookups]
File "/usr/lib/python3/dist-packages/fontTools/feaLib/builder.py", line 1168,
in build
self.setBacktrackCoverage_(prefix, st)
File "/usr/lib/python3/dist-packages/fontTools/feaLib/builder.py", line 1088,
in setBacktrackCoverage_
coverage = otl.buildCoverage(p, self.glyphMap)
File "/usr/lib/python3/dist-packages/fontTools/otlLib/builder.py", line 11,
in buildCoverage
self.glyphs = sorted(glyphs, key=glyphMap.__getitem__)
KeyError: ''
Thanks!
Cheers,
- Fabian
-- System Information:
Debian Release: buster/sid
APT prefers testing
APT policy: (990, 'testing'), (500, 'unstable-debug'), (500, 'experimental'),
(500, 'unstable')
Architecture: amd64 (x86_64)
Foreign Architectures: i386
Kernel: Linux 4.15.0-3-amd64 (SMP w/4 CPU cores)
Locale: LANG=de_DE.UTF-8, LC_CTYPE=de_DE.UTF-8 (charmap=UTF-8),
LANGUAGE=de_DE.UTF-8 (charmap=UTF-8)
Shell: /bin/sh linked to /bin/dash
Init: systemd (via /run/systemd/system)
LSM: AppArmor: enabled
Versions of packages fontmake depends on:
ii python3 3.6.5-3
ii python3-fontmake 1.4.0-2
fontmake recommends no packages.
fontmake suggests no packages.
-- no debconf information
