Bug#901274: [lintian] warn about *.md,.eslintrc, .npmignore, LICENSE, CHANGES, PATENTS, *.woff, *.ttf, *.woff.? under /usr/lib/node (may be /usr/lib ?)
Bastien, > >> >> Did you prefer a reset or reset of master ? > >> > > >> > A reset or a reset? > >> > >> A reset or a revert... > > pushed Bug#901274 May I suggest making a merge requests so it's easier to comment on? Regards, -- ,''`. : :' : Chris Lamb `. `'` la...@debian.org / chris-lamb.co.uk `-
Bug#901274: [lintian] warn about *.md,.eslintrc, .npmignore, LICENSE, CHANGES, PATENTS, *.woff, *.ttf, *.woff.? under /usr/lib/node (may be /usr/lib ?)
pushed Bug#901274 On Mon, Jun 11, 2018 at 9:59 AM, Chris Lamb wrote: > Bastien, > >> >> > Could you move the other changes to this branch too (or a "901274" >> >> > branch/MR or something?) >> >> >> >> Did you prefer a reset or reset of master ? >> > >> > A reset or a reset? >> >> A reset or a revert... > > I have subsequently pushed other fixes so a [--hard] reset is not > possible and would also require an ugly force push. At this point > pleas please back out all of the commits in a single commit. > > > Regards, > > -- > ,''`. > : :' : Chris Lamb > `. `'` la...@debian.org / chris-lamb.co.uk >`-
Bug#901274: [lintian] warn about *.md,.eslintrc, .npmignore, LICENSE, CHANGES, PATENTS, *.woff, *.ttf, *.woff.? under /usr/lib/node (may be /usr/lib ?)
Bastien, > >> > Could you move the other changes to this branch too (or a "901274" > >> > branch/MR or something?) > >> > >> Did you prefer a reset or reset of master ? > > > > A reset or a reset? > > A reset or a revert... I have subsequently pushed other fixes so a [--hard] reset is not possible and would also require an ugly force push. At this point pleas please back out all of the commits in a single commit. Regards, -- ,''`. : :' : Chris Lamb `. `'` la...@debian.org / chris-lamb.co.uk `-
Bug#901274: [lintian] warn about *.md,.eslintrc, .npmignore, LICENSE, CHANGES, PATENTS, *.woff, *.ttf, *.woff.? under /usr/lib/node (may be /usr/lib ?)
On Mon, Jun 11, 2018 at 1:05 AM, Chris Lamb wrote: > > > Hi Bastien ROUCARIES, > >> On Mon, Jun 11, 2018 at 12:07 AM, Chris Lamb wrote: >> > Hi Bastien, >> > >> >> > Unfortunately, I don't think these commits reach the level of quality >> >> > that Debian Developers would expect from Lintian. >> >> >> >> Ok could you get a glimpse at README branch >> > >> > Could you move the other changes to this branch too (or a "901274" >> > branch/MR or something?) :) >> >> Did you prefer a reset or reset of master ? > > A reset or a reset? A reset or a revert... > >> Bastien >> > >> > >> > Best wishes, >> > >> > -- >> > ,''`. >> > : :' : Chris Lamb >> > `. `'` la...@debian.org / chris-lamb.co.uk >> >`- > > > Regards, > > -- > ,''`. > : :' : Chris Lamb > `. `'` la...@debian.org / chris-lamb.co.uk >`-
Bug#901274: [lintian] warn about *.md,.eslintrc, .npmignore, LICENSE, CHANGES, PATENTS, *.woff, *.ttf, *.woff.? under /usr/lib/node (may be /usr/lib ?)
Hi Bastien, > On Mon, Jun 11, 2018 at 12:07 AM, Chris Lamb wrote: > > Hi Bastien, > > > >> > Unfortunately, I don't think these commits reach the level of quality > >> > that Debian Developers would expect from Lintian. > >> > >> Ok could you get a glimpse at README branch > > > > Could you move the other changes to this branch too (or a "901274" > > branch/MR or something?) :) > > Did you prefer a reset or reset of master ? > > Bastien > > > > > > Best wishes, > > > > -- > > ,''`. > > : :' : Chris Lamb > > `. `'` la...@debian.org / chris-lamb.co.uk > >`- Regards, -- ,''`. : :' : Chris Lamb `. `'` la...@debian.org / chris-lamb.co.uk `-
Bug#901274: [lintian] warn about *.md,.eslintrc, .npmignore, LICENSE, CHANGES, PATENTS, *.woff, *.ttf, *.woff.? under /usr/lib/node (may be /usr/lib ?)
Hi Bastien ROUCARIES, > On Mon, Jun 11, 2018 at 12:07 AM, Chris Lamb wrote: > > Hi Bastien, > > > >> > Unfortunately, I don't think these commits reach the level of quality > >> > that Debian Developers would expect from Lintian. > >> > >> Ok could you get a glimpse at README branch > > > > Could you move the other changes to this branch too (or a "901274" > > branch/MR or something?) :) > > Did you prefer a reset or reset of master ? A reset or a reset? > Bastien > > > > > > Best wishes, > > > > -- > > ,''`. > > : :' : Chris Lamb > > `. `'` la...@debian.org / chris-lamb.co.uk > >`- Regards, -- ,''`. : :' : Chris Lamb `. `'` la...@debian.org / chris-lamb.co.uk `-
Bug#901274: [lintian] warn about *.md,.eslintrc, .npmignore, LICENSE, CHANGES, PATENTS, *.woff, *.ttf, *.woff.? under /usr/lib/node (may be /usr/lib ?)
On Mon, Jun 11, 2018 at 12:07 AM, Chris Lamb wrote: > Hi Bastien, > >> > Unfortunately, I don't think these commits reach the level of quality >> > that Debian Developers would expect from Lintian. >> >> Ok could you get a glimpse at README branch > > Could you move the other changes to this branch too (or a "901274" > branch/MR or something?) :) Did you prefer a reset or reset of master ? Bastien > > > Best wishes, > > -- > ,''`. > : :' : Chris Lamb > `. `'` la...@debian.org / chris-lamb.co.uk >`-
Bug#901274: [lintian] warn about *.md,.eslintrc, .npmignore, LICENSE, CHANGES, PATENTS, *.woff, *.ttf, *.woff.? under /usr/lib/node (may be /usr/lib ?)
Hi Bastien, > > Unfortunately, I don't think these commits reach the level of quality > > that Debian Developers would expect from Lintian. > > Ok could you get a glimpse at README branch Could you move the other changes to this branch too (or a "901274" branch/MR or something?) :) Best wishes, -- ,''`. : :' : Chris Lamb `. `'` la...@debian.org / chris-lamb.co.uk `-
Bug#901274: [lintian] warn about *.md,.eslintrc, .npmignore, LICENSE, CHANGES, PATENTS, *.woff, *.ttf, *.woff.? under /usr/lib/node (may be /usr/lib ?)
On Sun, Jun 10, 2018 at 11:09 PM, Chris Lamb wrote: > Hi Bastien > >> Just see it. Will corects thanks > > May I kindly suggest doing this work on a branch? > > I am happy to review your grammar and spelling but I would very much > like to keep the "master" branch releasable at any time. > > Unfortunately, I don't think these commits reach the level of quality > that Debian Developers would expect from Lintian. Ok could you get a glimpse at README branch Bastien > >> Sorry for the delay I was removing a scratch on my screen with >> toothpaste... > > Uhh. > > > Regards, > > -- > ,''`. > : :' : Chris Lamb > `. `'` la...@debian.org / chris-lamb.co.uk >`-
Bug#901274: [lintian] warn about *.md,.eslintrc, .npmignore, LICENSE, CHANGES, PATENTS, *.woff, *.ttf, *.woff.? under /usr/lib/node (may be /usr/lib ?)
Hi Bastien > Just see it. Will corects thanks May I kindly suggest doing this work on a branch? I am happy to review your grammar and spelling but I would very much like to keep the "master" branch releasable at any time. Unfortunately, I don't think these commits reach the level of quality that Debian Developers would expect from Lintian. > Sorry for the delay I was removing a scratch on my screen with > toothpaste... Uhh. Regards, -- ,''`. : :' : Chris Lamb `. `'` la...@debian.org / chris-lamb.co.uk `-
Bug#901274: [lintian] warn about *.md,.eslintrc, .npmignore, LICENSE, CHANGES, PATENTS, *.woff, *.ttf, *.woff.? under /usr/lib/node (may be /usr/lib ?)
On Sun, Jun 10, 2018 at 10:59 PM, Chris Lamb wrote: > Hi Bastien, > >> Will begin to wrok on this bug > > (I trust you are seeing my comments on salsa.) Just see it. Will corects thanks Sorry for the delay I was removing a scratch on my screen with toothpaste... Bastien > > Regards, > > -- > ,''`. > : :' : Chris Lamb > `. `'` la...@debian.org / chris-lamb.co.uk >`-
Bug#901274: [lintian] warn about *.md,.eslintrc, .npmignore, LICENSE, CHANGES, PATENTS, *.woff, *.ttf, *.woff.? under /usr/lib/node (may be /usr/lib ?)
Hi Bastien, > Will begin to wrok on this bug (I trust you are seeing my comments on salsa.) Regards, -- ,''`. : :' : Chris Lamb `. `'` la...@debian.org / chris-lamb.co.uk `-
Bug#901274: [lintian] warn about *.md,.eslintrc, .npmignore, LICENSE, CHANGES, PATENTS, *.woff, *.ttf, *.woff.? under /usr/lib/node (may be /usr/lib ?)
On Sun, Jun 10, 2018 at 9:33 PM, Bastien ROUCARIES wrote: > On Sun, Jun 10, 2018 at 9:31 PM, Chris Lamb wrote: >> Hi Bastien, >> >>> > (This seems like a candidate for data/files/fnames.) >>> >>> Will add the fonts name ASAP, thanks >> >> I don't understand this, sorry... My remark about data/files/fnames >> refers to this entire bug report, not to the fonts specifically. > > Ok, I had understood that your remark apply only to last paragraph. > Will begin to wrok on this bug Last but not least, the woff.* and eot file are serious (at least now). Tools to create does not yet exist (I am packaging it, Waiting in NEWS node-microbuffer and node-svgpath, will need svg2ttf, ttf2woff and ttf2eot) Bastien > >> >> Regards, >> >> -- >> ,''`. >> : :' : Chris Lamb >> `. `'` la...@debian.org / chris-lamb.co.uk >>`-
Bug#901274: [lintian] warn about *.md,.eslintrc, .npmignore, LICENSE, CHANGES, PATENTS, *.woff, *.ttf, *.woff.? under /usr/lib/node (may be /usr/lib ?)
On Sun, Jun 10, 2018 at 9:31 PM, Chris Lamb wrote: > Hi Bastien, > >> > (This seems like a candidate for data/files/fnames.) >> >> Will add the fonts name ASAP, thanks > > I don't understand this, sorry... My remark about data/files/fnames > refers to this entire bug report, not to the fonts specifically. Ok, I had understood that your remark apply only to last paragraph. Will begin to wrok on this bug > > Regards, > > -- > ,''`. > : :' : Chris Lamb > `. `'` la...@debian.org / chris-lamb.co.uk >`-
Bug#901274: [lintian] warn about *.md,.eslintrc, .npmignore, LICENSE, CHANGES, PATENTS, *.woff, *.ttf, *.woff.? under /usr/lib/node (may be /usr/lib ?)
Hi Bastien, > > (This seems like a candidate for data/files/fnames.) > > Will add the fonts name ASAP, thanks I don't understand this, sorry... My remark about data/files/fnames refers to this entire bug report, not to the fonts specifically. Regards, -- ,''`. : :' : Chris Lamb `. `'` la...@debian.org / chris-lamb.co.uk `-
Bug#901274: [lintian] warn about *.md,.eslintrc, .npmignore, LICENSE, CHANGES, PATENTS, *.woff, *.ttf, *.woff.? under /usr/lib/node (may be /usr/lib ?)
On Sun, Jun 10, 2018 at 9:25 PM, Chris Lamb wrote: > Bastien, > >> Documentation file (*.md, LICENSE, CHANGES, PATENTS) do not belong to this >> dir >> >> .eslintrc are jslint config file and should not be installed >> >> .npmignore is used in order to publish file under npm so do not install >> >> *.woff, *.ttf, *.woff. are fonts so go to fonts package > > (This seems like a candidate for data/files/fnames.) Will add the fonts name ASAP, thanks
Bug#901274: [lintian] warn about *.md,.eslintrc, .npmignore, LICENSE, CHANGES, PATENTS, *.woff, *.ttf, *.woff.? under /usr/lib/node (may be /usr/lib ?)
Bastien, > Documentation file (*.md, LICENSE, CHANGES, PATENTS) do not belong to this dir > > .eslintrc are jslint config file and should not be installed > > .npmignore is used in order to publish file under npm so do not install > > *.woff, *.ttf, *.woff. are fonts so go to fonts package (This seems like a candidate for data/files/fnames.) Regards, -- ,''`. : :' : Chris Lamb `. `'` la...@debian.org / chris-lamb.co.uk `-
Bug#901274: [lintian] warn about *.md,.eslintrc, .npmignore, LICENSE, CHANGES, PATENTS, *.woff, *.ttf, *.woff.? under /usr/lib/node (may be /usr/lib ?)
Package: lintian Version: 2.5.89 Severity: normal Hi, Documentation file (*.md, LICENSE, CHANGES, PATENTS) do not belong to this dir .eslintrc are jslint config file and should not be installed .npmignore is used in order to publish file under npm so do not install *.woff, *.ttf, *.woff. are fonts so go to fonts package signature.asc Description: This is a digitally signed message part.
