Bug#912219: lintian-brush: Missing dependency on python3-dulwich, and more

2018-10-31 Thread gregor herrmann
On Tue, 30 Oct 2018 22:11:50 +, Jelmer Vernooij wrote:

> > % lintian-brush
> > Traceback (most recent call last):
> >   File "/usr/bin/lintian-brush", line 11, in 
> > load_entry_point('lintian-brush==0.1', 'console_scripts', 
> > 'lintian-brush')()
> > TypeError: 'module' object is not callable
> Oops - this should be fixed in the 0.3 that was just uploaded.

Thanks.
0.3 looks good indeed.
 
> Note that you'll get some errors when running 'lintian-brush' on
> packages with control files that it can't preserve the formatting for.
> (i.e. the libdatetime-timezone-perl package that you mentioned that
> had a comment).

Ack; it's a bit noisy but doesn't fail which seems to be a good
compromise for the time being.
 

Cheers,
gregor

-- 
 .''`.  https://info.comodo.priv.at -- Debian Developer https://www.debian.org
 : :' : OpenPGP fingerprint D1E1 316E 93A7 60A8 104D  85FA BB3A 6801 8649 AA06
 `. `'  Member VIBE!AT & SPI Inc. -- Supporter Free Software Foundation Europe
   `-   NP: Various Artists: Fields of Athenry


signature.asc
Description: Digital Signature


Bug#912219: lintian-brush: Missing dependency on python3-dulwich, and more

2018-10-30 Thread Jelmer Vernooij
On Tue, Oct 30, 2018 at 02:56:38PM +0100, gregor herrmann wrote:
> On Tue, 30 Oct 2018 00:42:42 +, Jelmer Vernooij wrote:
> 
> > On Mon, Oct 29, 2018 at 01:34:23PM +0100, gregor herrmann wrote:
> > > Thanks for writing lintian-brush, this looks really helpful. But
> > > currently it has its quirks:
> > Thanks for the detailed bug report, much appreciated. I hope to fix
> > most of these issues in the upcoming upload.
> 
> Thanks for all the fixes and the new 0.2 release.
> 
> Unfortunately there's still a problem left:
> 
> % lintian-brush --list-fixers
> Traceback (most recent call last):   
>   File "/usr/bin/lintian-brush", line 11, in 
> load_entry_point('lintian-brush==0.1', 'console_scripts', 
> 'lintian-brush')()
> TypeError: 'module' object is not callable
> 
> 
> % lintian-brush
> Traceback (most recent call last):
>   File "/usr/bin/lintian-brush", line 11, in 
> load_entry_point('lintian-brush==0.1', 'console_scripts', 
> 'lintian-brush')()
> TypeError: 'module' object is not callable
Oops - this should be fixed in the 0.3 that was just uploaded.

Note that you'll get some errors when running 'lintian-brush' on
packages with control files that it can't preserve the formatting for.
(i.e. the libdatetime-timezone-perl package that you mentioned that
had a comment).

In the future I'm planning to:
 * make it report those errors in a nicer way
 * and eventually, improve support for preserving formatting in cases
   like this

Cheers,

Jelmer


signature.asc
Description: PGP signature


Bug#912219: lintian-brush: Missing dependency on python3-dulwich, and more

2018-10-30 Thread gregor herrmann
On Tue, 30 Oct 2018 00:42:42 +, Jelmer Vernooij wrote:

> On Mon, Oct 29, 2018 at 01:34:23PM +0100, gregor herrmann wrote:
> > Thanks for writing lintian-brush, this looks really helpful. But
> > currently it has its quirks:
> Thanks for the detailed bug report, much appreciated. I hope to fix
> most of these issues in the upcoming upload.

Thanks for all the fixes and the new 0.2 release.

Unfortunately there's still a problem left:

% lintian-brush --list-fixers
Traceback (most recent call last):   
  File "/usr/bin/lintian-brush", line 11, in 
load_entry_point('lintian-brush==0.1', 'console_scripts', 'lintian-brush')()
TypeError: 'module' object is not callable


% lintian-brush
Traceback (most recent call last):
  File "/usr/bin/lintian-brush", line 11, in 
load_entry_point('lintian-brush==0.1', 'console_scripts', 'lintian-brush')()
TypeError: 'module' object is not callable


Cheers,
gregor

-- 
 .''`.  https://info.comodo.priv.at -- Debian Developer https://www.debian.org
 : :' : OpenPGP fingerprint D1E1 316E 93A7 60A8 104D  85FA BB3A 6801 8649 AA06
 `. `'  Member VIBE!AT & SPI Inc. -- Supporter Free Software Foundation Europe
   `-   


signature.asc
Description: Digital Signature


Bug#912219: lintian-brush: Missing dependency on python3-dulwich, and more

2018-10-29 Thread Jelmer Vernooij
On Mon, Oct 29, 2018 at 01:34:23PM +0100, gregor herrmann wrote:
> Thanks for writing lintian-brush, this looks really helpful. But
> currently it has its quirks:
Thanks for the detailed bug report, much appreciated. I hope to fix
most of these issues in the upcoming upload.

Cheers,

Jelmer


signature.asc
Description: PGP signature


Bug#912219: lintian-brush: Missing dependency on python3-dulwich, and more

2018-10-29 Thread gregor herrmann
Package: lintian-brush
Version: 0.1
Severity: important

-BEGIN PGP SIGNED MESSAGE-
Hash: SHA512

Thanks for writing lintian-brush, this looks really helpful. But
currently it has its quirks:


% lintian-brush --list-tags
Traceback (most recent call last):
  File "/usr/lib/python3/dist-packages/breezy/git/__init__.py", line 66, in 
import_dulwich
from dulwich import __version__ as dulwich_version
ModuleNotFoundError: No module named 'dulwich'

During handling of the above exception, another exception occurred:

Traceback (most recent call last):
  File "/usr/bin/lintian-brush", line 11, in 
load_entry_point('lintian-brush==0.1', 'console_scripts', 'lintian-brush')()
  File "/usr/lib/python3/dist-packages/pkg_resources/__init__.py", line 484, in 
load_entry_point
return get_distribution(dist).load_entry_point(group, name)
  File "/usr/lib/python3/dist-packages/pkg_resources/__init__.py", line 2714, 
in load_entry_point
return ep.load()
  File "/usr/lib/python3/dist-packages/pkg_resources/__init__.py", line 2332, 
in load
return self.resolve()
  File "/usr/lib/python3/dist-packages/pkg_resources/__init__.py", line 2338, 
in resolve
module = __import__(self.module_name, fromlist=['__name__'], level=0)
  File "/usr/lib/python3/dist-packages/lintian_brush/__main__.py", line 63, in 

wt = WorkingTree.open('.')
  File "/usr/lib/python3/dist-packages/breezy/workingtree.py", line 205, in open
control = controldir.ControlDir.open(path, _unsupported=_unsupported)
  File "/usr/lib/python3/dist-packages/breezy/controldir.py", line 710, in open
_unsupported=_unsupported)
  File "/usr/lib/python3/dist-packages/breezy/controldir.py", line 739, in 
open_from_transport
find_format, transport, redirected)
  File "/usr/lib/python3/dist-packages/breezy/transport/__init__.py", line 
1638, in do_catching_redirections
return action(transport)
  File "/usr/lib/python3/dist-packages/breezy/controldir.py", line 727, in 
find_format
probers=probers)
  File "/usr/lib/python3/dist-packages/breezy/controldir.py", line 1163, in 
find_format
return prober.probe_transport(transport)
  File "/usr/lib/python3/dist-packages/breezy/git/__init__.py", line 119, in 
probe_transport
lazy_check_versions()
  File "/usr/lib/python3/dist-packages/breezy/git/__init__.py", line 82, in 
lazy_check_versions
import_dulwich()
  File "/usr/lib/python3/dist-packages/breezy/git/__init__.py", line 69, in 
import_dulwich
"bzr-git: Please install dulwich, https://www.dulwich.io/;)
breezy.errors.DependencyNotPresent: Unable to import library "dulwich": 
bzr-git: Please install dulwich, https://www.dulwich.io/



After installing python3-dulwich, it gets better but the end
indicates some other problem:


% lintian-brush --list-tags  
ancient-python-version-field
control-file-with-CRLF-EOLs
copyright-has-crs
debian-control-has-empty-field
debian-control-has-obsolete-dbg-package
debian-rules-should-not-use-pwd
debian-upstream-obsolete-path
debian-watch-uses-insecure-uri
dh-quilt-addon-but-quilt-source-format
dm-upload-allowed-is-obsolete
file-contains-trailing-whitespace
homepage-field-uses-insecure-uri
insecure-copyright-format-uri
malformed-dm-upload-allowed
missing-debian-source-format
missing-vcs-browser-field
out-of-date-copyright-format-uri
package-uses-deprecated-source-override-location
priority-extra-is-replaced-by-priority-optional
quilt-series-without-trailing-newline
transitional-package-should-be-oldlibs-optional
unnecessary-testsuite-autopkgtest-field
unversioned-copyright-format-uri
vcs-field-uses-insecure-uri
vcs-field-uses-not-recommended-uri-format
wrong-debian-qa-group-name
xc-package-type-in-debian-control
xs-testsuite-field-in-debian-control
xs-vcs-field-in-debian-control
Traceback (most recent call last):
  File "/usr/bin/lintian-brush", line 11, in 
load_entry_point('lintian-brush==0.1', 'console_scripts', 'lintian-brush')()
TypeError: 'module' object is not callable


Running it in a random source package git repo also throws some
tracebacks:


% lintian-brush
Running fixer  on 
/home/gregoa/src/git-pkg-perl/meta/packages/libdatetime-timezone-perl
Running fixer  on 
/home/gregoa/src/git-pkg-perl/meta/packages/libdatetime-timezone-perl
Running fixer  on 
/home/gregoa/src/git-pkg-perl/meta/packages/libdatetime-timezone-perl
Running fixer  on 
/home/gregoa/src/git-pkg-perl/meta/packages/libdatetime-timezone-perl
Committing to: 
/home/gregoa/src/git-pkg-perl/meta/packages/libdatetime-timezone-perl/  
  
modified debian/changelog
modified debian/control
Committed revision 475.
Running fixer  on 
/home/gregoa/src/git-pkg-perl/meta/packages/libdatetime-timezone-perl
Traceback (most recent call last):
  File 
"/usr/share/lintian-brush/fixers/debian-control-has-obsolete-dbg-package.py", 
line 54, in 
raise Exception("no debug packages found to remove")
Exception: no debug packages found to remove
No files deleted.