Bug#917717: [Python-modules-team] Bug#917717: pylint-django: FTBFS: dh_auto_test: pybuild --test --test-pytest -i python{version} -p 3.7 returned exit code 13
Hi Joseph! El mar., 1 de ene. de 2019 a la(s) 21:27, Joseph Herlant ( aerosti...@debian.org) escribió: > Control: tags -1 - fixed > Control: tags -1 + patch > Hi guys, > > Thanks Lucas for the report. Sorry for the late reply, I was out of > the country with very limited internet access. > > Thanks Emmanuel for the quick patch. > Notes for next time: > * Please use meaningful commit messages, especially when committing > to the master branch of a package you don't maintain. Using commit > messages like "fix issue 917717" makes the commit history harder to > read and the use of tools like gbp dch impossible as well as rendering > the gitlab hooks in place for tagging the bugs as pending unusable. > (If you're not sure about your patches, please just create a MR and > the maintainer can help getting the patch to a better standard) > Ok! I will do it!. What is the meaning of MR? * Please conform to the DEP-3 headers when you are writing a quilt > patch header. See https://dep-team.pages.debian.net/deps/dep3/ I used gbp-pq to create the patch. Maybe, I am using this tool from a wrong way? > * If you have a patch that you thing is good enough for Debian, it's > generally a good practice to propose it upstream as upstream is > generally aware of the potential negative impacts and this would avoid > having to maintain diverging patch hell, especially on packages you > don't maintain. > Ok. Thanks. > * Please don't tag bugs as "fixed" as long as there's no NMU uploaded > (as long as the package is not in the archive). In your case the tag > "patch" seems more appropriate. > Great. thanks > > There is an upstream upgrade I need to do so I'll clean the previous > points and do the upload today or tomorrow. > > Thanks, > Joseph > > ___ > Python-modules-team mailing list > python-modules-t...@alioth-lists.debian.net > > https://alioth-lists.debian.net/cgi-bin/mailman/listinfo/python-modules-team Thanks for your tips. I will keep them in mind :-) Cheers, -- Arias Emmanuel http://eamanu.com Github/Gitlab; @eamanu Debian: @eamanu-guest
Bug#917717: pylint-django: FTBFS: dh_auto_test: pybuild --test --test-pytest -i python{version} -p 3.7 returned exit code 13
Note that I'm having trouble with the latest release right now (see https://github.com/PyCQA/pylint-django/issues/215) so I won't upload it today. But I should be able to get that fixed shortly.
Bug#917717: pylint-django: FTBFS: dh_auto_test: pybuild --test --test-pytest -i python{version} -p 3.7 returned exit code 13
Control: tags -1 + fixed-upstream Reading through the changes of 2.0.1 to 2.0.5 of pylint-django, it seems that this change has already been dealt with in the latest version. See: https://github.com/PyCQA/pylint-django/commit/c0408d7b844f46cf675986576ea2acaf4fd234cc#diff-caeb1acca0adc7ada7d03b9e07452774 So please don't get mad if I drop your patch. ;) Thanks Joseph
Bug#917717: pylint-django: FTBFS: dh_auto_test: pybuild --test --test-pytest -i python{version} -p 3.7 returned exit code 13
Control: tags -1 - fixed Control: tags -1 + patch Hi guys, Thanks Lucas for the report. Sorry for the late reply, I was out of the country with very limited internet access. Thanks Emmanuel for the quick patch. Notes for next time: * Please use meaningful commit messages, especially when committing to the master branch of a package you don't maintain. Using commit messages like "fix issue 917717" makes the commit history harder to read and the use of tools like gbp dch impossible as well as rendering the gitlab hooks in place for tagging the bugs as pending unusable. (If you're not sure about your patches, please just create a MR and the maintainer can help getting the patch to a better standard) * Please conform to the DEP-3 headers when you are writing a quilt patch header. See https://dep-team.pages.debian.net/deps/dep3/ * If you have a patch that you thing is good enough for Debian, it's generally a good practice to propose it upstream as upstream is generally aware of the potential negative impacts and this would avoid having to maintain diverging patch hell, especially on packages you don't maintain. * Please don't tag bugs as "fixed" as long as there's no NMU uploaded (as long as the package is not in the archive). In your case the tag "patch" seems more appropriate. There is an upstream upgrade I need to do so I'll clean the previous points and do the upload today or tomorrow. Thanks, Joseph
Bug#917717: pylint-django: FTBFS: dh_auto_test: pybuild --test --test-pytest -i python{version} -p 3.7 returned exit code 13
Hi, This is because upstream deleted the "YES" alias from astroid on https://github.com/PyCQA/astroid/commit/36fa294e9b84885d95a03b1fbc07da63e6d6a79b This issue was opened on pylint-django ( https://github.com/PyCQA/pylint-django/issues/201) They resolve the issue adding on setup.py the requirement of astroid == 2.0.4. I've push to salsa a patch adding the 'YES' alias on pylint-django ( https://salsa.debian.org/python-team/modules/pylint-django/commit/c3f38068cda75d4125b4e6274598a8f4acd892bd#58ef006ab62b83b4bec5d81fe5b32c3b4c2d1cc2 ) Cheers -- Arias Emmanuel http://eamanu.com Github/Gitlab; @eamanu Debian: @eamanu-guest
Bug#917717: pylint-django: FTBFS: dh_auto_test: pybuild --test --test-pytest -i python{version} -p 3.7 returned exit code 13
Source: pylint-django Version: 2.0.1-1 Severity: serious Justification: FTBFS on amd64 Tags: buster sid Usertags: ftbfs-20181229 ftbfs-buster Hi, During a rebuild of all packages in sid, your package failed to build on amd64. Relevant part (hopefully): > make[1]: Entering directory '/<>' > PYBUILD_SYSTEM=custom PYBUILD_TEST_ARGS="PYTHONDONTWRITEBYTECODE=1 > PYTHONPATH=. {interpreter} pylint_django/tests/test_func.py" dh_auto_test > I: pybuild base:217: PYTHONDONTWRITEBYTECODE=1 PYTHONPATH=. python3.7 > pylint_django/tests/test_func.py > = test session starts > == > platform linux -- Python 3.7.2rc1, pytest-3.10.1, py-1.7.0, pluggy-0.8.0 > rootdir: /<>, inifile: > collected 0 items / 1 errors > > ERRORS > > __ ERROR collecting pylint_django/tests/test_func.py > ___ > ImportError while importing test module > '/<>/pylint_django/tests/test_func.py'. > Hint: make sure your test modules/packages have valid Python names. > Traceback: > pylint_django/__init__.py:6: in > from pylint_django import plugin > pylint_django/plugin.py:5: in > from pylint_django.checkers import register_checkers > pylint_django/checkers/__init__.py:3: in > from pylint_django.checkers.models import ModelChecker > pylint_django/checkers/models.py:11: in > from pylint_django.utils import node_is_subclass, PY3 > pylint_django/utils.py:4: in > from astroid.util import YES > E ImportError: cannot import name 'YES' from 'astroid.util' > (/usr/lib/python3/dist-packages/astroid/util.py) > !!! Interrupted: 1 errors during collection > > === 1 error in 0.07 seconds > > E: pybuild pybuild:338: test: plugin custom failed with: exit code=2: > PYTHONDONTWRITEBYTECODE=1 PYTHONPATH=. python3.7 > pylint_django/tests/test_func.py > dh_auto_test: pybuild --test --test-pytest -i python{version} -p 3.7 returned > exit code 13 The full build log is available from: http://aws-logs.debian.net/2018/12/29/pylint-django_2.0.1-1_unstable.log A list of current common problems and possible solutions is available at http://wiki.debian.org/qa.debian.org/FTBFS . You're welcome to contribute! About the archive rebuild: The rebuild was done on EC2 VM instances from Amazon Web Services, using a clean, minimal and up-to-date chroot. Every failed build was retried once to eliminate random failures.