Bug#921423: /var/log/letsencrypt gets wiped on transitional package purge
On Tue, Feb 5, 2019 at 10:57 PM Mattia Rizzolo wrote: > Sure, of course that's the cause, but your suggested fix would instead > introduce the other bug that "purge does not delete related logs", which > is what everybody is expecting "purge" to do. Hi Mattia, The bug here is that the transitional dummy package purges the directory that the main package which provides it uses. Both certbot and letsencrypt use `/var/log/letsencrypt` for their log storage, but the letsencrypt package has been hollowed out and made into a dummy. The directory will still be deleted if you purge certbot, which is the new and correct owner of that path. Sincerely, -- Harlan Lieberman-Berg ~hlieberman
Bug#921423: /var/log/letsencrypt gets wiped on transitional package purge
On Tue, Feb 05, 2019 at 10:42:25AM +, Robie Basak wrote: > Expected: logs still exist back to the beginning, or at least since step > 4. > > Actual: logs are gone. > > Real use case: users upgrading through the regular upgrade path will, > upon purging old transitional packages, lose their logs. Well, purging by definition would go about deleting such things. At most, you'd be expecting to see the stuff coming from after step 4, but everything before should be deleted by the definition of "purge". > Suspected cause: letsencrypt.postrm removes /var/log/letsencrypt. > > Suggested fix: drop the "rm -rf /var/log/letsencrypt" from > letsencrypt.postrm (which makes the postrm redundant so the entire file > can be removed). Sure, of course that's the cause, but your suggested fix would instead introduce the other bug that "purge does not delete related logs", which is what everybody is expecting "purge" to do. -- regards, Mattia Rizzolo GPG Key: 66AE 2B4A FCCF 3F52 DA18 4D18 4B04 3FCD B944 4540 .''`. more about me: https://mapreri.org : :' : Launchpad user: https://launchpad.net/~mapreri `. `'` Debian QA page: https://qa.debian.org/developer.php?login=mattia `- signature.asc Description: PGP signature
Bug#921423: /var/log/letsencrypt gets wiped on transitional package purge
Package: letsencrypt Version: 0.28.0-1 Severity: grave Justification: causes data loss User: ubuntu-de...@lists.ubuntu.com Usertags: origin-ubuntu disco Steps to reproduce: 1. Start on sid 2. apt install letsencrypt # using transitional package 3. Use letsencrypt or certbot 4. Later, note the project rename and start using the certbot name 5. Note the package description says that the letsencrypt binary package can be removed, and purge it. 6. Look for previous logs Expected: logs still exist back to the beginning, or at least since step 4. Actual: logs are gone. Real use case: users upgrading through the regular upgrade path will, upon purging old transitional packages, lose their logs. Suspected cause: letsencrypt.postrm removes /var/log/letsencrypt. Suggested fix: drop the "rm -rf /var/log/letsencrypt" from letsencrypt.postrm (which makes the postrm redundant so the entire file can be removed). signature.asc Description: PGP signature
