Bug#921558: lsb-base: killproc does not pass name parameter to start-stop-daemon

2019-03-13 Thread Didier 'OdyX' Raboud
Le mercredi, 13 mars 2019, 18.17:34 h CET Dmitry Bogatov a écrit : > [2019-03-11 21:51] Axel Beckert > > > I believe it would be reasonable to add '--name $base' into `else' > > > clause. Opinions? > > > > Sounds sane, I just checked that with #924311 (miredo, uses > > start-stop-daemon

Bug#921558: lsb-base: killproc does not pass name parameter to start-stop-daemon

2019-03-13 Thread Didier 'OdyX' Raboud
Hi there Andreas, Le mercredi, 6 février 2019, 20.20:54 h CET Andreas Metzler a écrit : > there is a logic error in /lib/lsb/init-functions's killproc: > > base=${1##*/} > if [ ! $pidfile ]; then > name_param="--name $base --pidfile /var/run/$base.pid" > else >

Bug#921558: lsb-base: killproc does not pass name parameter to start-stop-daemon

2019-03-13 Thread Dmitry Bogatov
[2019-03-11 21:51] Axel Beckert > > I believe it would be reasonable to add '--name $base' into `else' > > clause. Opinions? > > Sounds sane, I just checked that with #924311 (miredo, uses > start-stop-daemon directly, edited the init script) as well as #924312 > (stunnel4, by editing

Bug#921558: lsb-base: killproc does not pass name parameter to start-stop-daemon

2019-03-12 Thread Andreas Metzler
On 2019-03-11 Axel Beckert wrote: [...] > Here's the change I made to /lib/lsb/init-functions (as Dmitry already > suggested): > --- /lib/lsb/init-functions~2018-11-28 20:21:37.0 +0100 > +++ /lib/lsb/init-functions 2019-03-11 21:46:41.673767215 +0100 > @@ -141,7 +141,7 @@ >

Bug#921558: lsb-base: killproc does not pass name parameter to start-stop-daemon

2019-03-11 Thread Axel Beckert
Control: tag -1 + patch Hi Dmitry, Dmitry Bogatov wrote: > > base=${1##*/} > > if [ ! $pidfile ]; then > > name_param="--name $base --pidfile /var/run/$base.pid" > > else > > name_param="--pidfile $pidfile" > > fi > > > > The if clause checks for nonempty $pidfile

Bug#921558: lsb-base: killproc does not pass name parameter to start-stop-daemon

2019-03-10 Thread Dmitry Bogatov
control: tags -1 +moreinfo [2019-02-06 20:20] Andreas Metzler > Package: lsb-base > Version: 10.2018112800 > Severity: serious > > Hello, > > there is a logic error in /lib/lsb/init-functions's killproc: > > base=${1##*/} > if [ ! $pidfile ]; then > name_param="--name $base

Bug#921558: lsb-base: killproc does not pass name parameter to start-stop-daemon

2019-03-06 Thread Laurent Bigonville
On Wed, 6 Feb 2019 20:20:54 +0100 Andreas Metzler wrote:> Hello, Hello, > there is a logic error in /lib/lsb/init-functions's killproc: > > base=${1##*/} > if [ ! $pidfile ]; then > name_param="--name $base --pidfile /var/run/$base.pid" > else > name_param="--pidfile $pidfile" > fi > > The if

Bug#921558: lsb-base: killproc does not pass name parameter to start-stop-daemon

2019-02-06 Thread Andreas Metzler
Package: lsb-base Version: 10.2018112800 Severity: serious Hello, there is a logic error in /lib/lsb/init-functions's killproc: base=${1##*/} if [ ! $pidfile ]; then name_param="--name $base --pidfile /var/run/$base.pid" else name_param="--pidfile $pidfile" fi The