Bug#939998: systemd-logind: Assert due to insufficient function return checks

2019-09-11 Thread Michael Biebl
Am 11.09.19 um 00:12 schrieb Guillem Jover:
> We hit an assert in logind from the latest systemd package in buster:
> 
>   systemd-logind coredumped: in log_assert_failed_realm  ... at 
> ../src/basic/log.c:795
> 
> Investiaging from the following stack trace:

[...]

Hi Guillem, thanks for the excellent bug report!

I marked the bug as fixed in 242-1 and user-tagged it so it shows up at [1].
Those are currently the bugs I intend to fix in 10.2 via a stable upload.

Regards,
Michael

[1]
https://bugs.debian.org/cgi-bin/pkgreport.cgi?users=pkg-systemd-maintain...@lists.alioth.debian.org;tag=buster-backport;dist=stable

-- 
Why is it that all of the instruments seeking intelligent life in the
universe are pointed away from Earth?



signature.asc
Description: OpenPGP digital signature


Bug#939998: systemd-logind: Assert due to insufficient function return checks

2019-09-10 Thread Guillem Jover
Source: systemd
Source-Version: 241-7~deb10u1
Severity: important
Tags: upstream patch buster

Hi!

We hit an assert in logind from the latest systemd package in buster:

  systemd-logind coredumped: in log_assert_failed_realm  ... at 
../src/basic/log.c:795

Investiaging from the following stack trace:

,---
# gdb -c 
core.systemd-logind.0.4c92c46cf794487eb1df36acdfa8d37e.363.156802452000 
/lib/systemd/systemd-logind
[…]
Reading symbols from /lib/systemd/systemd-logind...Reading symbols from 
/usr/lib/debug/.build-id/67/1f5fd985d111ef7cca8db8d01c5175738b0ec6.debug...done.
done.
[New LWP 363]
[Thread debugging using libthread_db enabled]
Using host libthread_db library "/lib/x86_64-linux-gnu/libthread_db.so.1".
Core was generated by `/lib/systemd/systemd-logind'.
Program terminated with signal SIGABRT, Aborted.
#0  __GI_raise (sig=sig@entry=6) at ../sysdeps/unix/sysv/linux/raise.c:50
50  ../sysdeps/unix/sysv/linux/raise.c: No such file or directory.
(gdb) bt full
#0  __GI_raise (sig=sig@entry=6) at ../sysdeps/unix/sysv/linux/raise.c:50
set = {__val = {8589950979, 0, 17179869308, 0, 0, 0, 4096, 255, 
18446744073709551615, 0, 1024, 140109258535907, 4294967295, 4096, 
94012397244720, 140109259796384}}
pid = 
tid = 
ret = 
#1  0x7f6dba8f9535 in __GI_abort () at abort.c:79
save_stage = 1
act = {__sigaction_handler = {sa_handler = 0x5580f5dcb87e, sa_sigaction 
= 0x5580f5dcb87e}, sa_mask = {__val = {17, 94012397097648, 
13205360909752802304, 206158430240, 94012369043465, 2943, 94012369067104, 2, 
94012369067104, 
  94012397040272, 140109256346163, 0, 0, 0, 140109257989088, 
94012369057967}}, sa_flags = 0, sa_restorer = 0x5580f5dcb8af}
sigs = {__val = {32, 0 }}
#2  0x7f6dba69508a in log_assert_failed_realm (realm=, 
text=0x5580f5dcb8af "pid > 1", file=0x5580f5dc8009 
"../src/login/logind-dbus.c", line=2943, func=0x5580f5dcdc60 
<__PRETTY_FUNCTION__.15284> "manager_start_scope")
at ../src/basic/log.c:795
No locals.
#3  0x5580f5dbc282 in manager_start_scope (job=0x5580f7889330, 
error=0x7ffe8737fb60, more_properties=0x5580f78c1820, 
requires_mounts_for=0x5580f787ceb0 "/root", after=0x7ffe8737f970, 
wants=0x7ffe8737f950, 
description=0x7ffe8737f8d0 "Session 342 of user root", slice=0x5580f787b290 
"user-0.slice", pid=0, scope=0x5580f78ad360 "session-342.scope", 
manager=0x5580f7865c50) at ../src/login/logind-session.c:638
m = 0x0
reply = 0x0
i = 
r = 
m = 
reply = 
i = 
r = 
__PRETTY_FUNCTION__ = 
#4  session_start_scope (s=s@entry=0x5580f78892b0, 
properties=properties@entry=0x5580f78c1820, error=error@entry=0x7ffe8737fb60) 
at ../src/login/logind-session.c:640
scope = 
description = 0x7ffe8737f8d0 "Session 342 of user root"
_ptr_ = 
r = 
__PRETTY_FUNCTION__ = "session_start_scope"
__func__ = "session_start_scope"
_ptr_ = 
#5  0x5580f5dc2a6d in session_start (s=, 
properties=, error=, s=, 
properties=, error=) at 
../src/login/logind-session.c:682
r = 
r = 
__func__ = "session_start"
__PRETTY_FUNCTION__ = "session_start"
#6  0x5580f5db4f1a in method_create_session (message=0x5580f78c1820, 
userdata=, error=0x7ffe8737fb60) at 
../src/login/logind-dbus.c:860
service = 0x5580f787e9d4 "sshd"
type = 0x5580f787e9e0 "tty"
class = 0x5580f787e9e8 "user"
cseat = 0x5580f787e9fc ""
tty = 0x5580f787ea08 ""
display = 0x5580f787ea10 ""
remote_user = 0x5580f787ea1c ""
remote_host = 0x5580f787ea24 "<…REDACTED…>"
desktop = 0x0
id = 0x5580f78b82b0 "342"
session = 0x5580f78892b0
audit_id = 342
m = 
user = 0x5580f78a2490
seat = 
leader = 2973
uid = 0
remote = 1
vtnr = 0
t = 
c = SESSION_USER
r = 1
__PRETTY_FUNCTION__ = "method_create_session"
__func__ = "method_create_session"
#7  0x7f6dba708767 in method_callbacks_run (found_object=0x7ffe8737fc17, 
require_fallback=, c=, m=0x5580f78c1820, 
bus=0x5580f7868c00) at ../src/libsystemd/sd-bus/bus-objects.c:403
slot = 0x5580f786abf0
error = {name = 0x0, message = 0x0, _need_free = 0}
signature = 
u = 0x5580f7865c50
r = 
error = 
signature = 
u = 
r = 
__PRETTY_FUNCTION__ = 
slot = 
__unique_prefix_A8 = 
#8  object_find_and_run (bus=0x5580f7868c00, m=0x5580f78c1820, p=, require_fallback=false, found_object=0x7ffe8737fc17) at 
../src/libsystemd/sd-bus/bus-objects.c:1266
n = 0x5580f786aba0
vtable_key = {path = 0x5580f787e928 "/org/freedesktop/login1", 
interface = 0x5580f787e960 "org.freedesktop.login1.Manager", member = 
0x5580f787e948 "CreateSession", parent = 0x5580f7868c88, last_iteration = 
4152790016, 
  vtable =