Bug#949196: libzypp: diff for NMU version 17.7.0-1.1

2020-06-22 Thread Mike Gabriel
Hi,

Am Montag, 22. Juni 2020 schrieb Giovanni Mascellani:
> Hi,
> 
> Il 20/06/20 19:01, Mike Gabriel ha scritto:
> > Thanks for patching libzypp. Your NMU is ok, I will include your
> > .debdiff on its VCS. In fact, I am considering orphaning libzypp and
> > zypper in Debian. Do you have interest in taking over?
> 
> Ugh, I just realized I stupidly embedded the amd64 architecture in my
> patch, leading to obvious FTBFS on the other archs. It is ok for you if
> I directly NMU libzypp replacing x86_64-linux-gnu with
> $(DEB_HOST_MULTIARCH)?

yes, please.

Mike

-- 
Gesendet von meinem Fairphone (powered by SailfishOS)

Bug#949196: libzypp: diff for NMU version 17.7.0-1.1

2020-06-22 Thread Giovanni Mascellani
Hi,

Il 20/06/20 19:01, Mike Gabriel ha scritto:
> Thanks for patching libzypp. Your NMU is ok, I will include your
> .debdiff on its VCS. In fact, I am considering orphaning libzypp and
> zypper in Debian. Do you have interest in taking over?

Ugh, I just realized I stupidly embedded the amd64 architecture in my
patch, leading to obvious FTBFS on the other archs. It is ok for you if
I directly NMU libzypp replacing x86_64-linux-gnu with
$(DEB_HOST_MULTIARCH)?

Thanks, Giovanni.
-- 
Giovanni Mascellani 
Postdoc researcher - Université Libre de Bruxelles



signature.asc
Description: OpenPGP digital signature


Bug#949196: libzypp: diff for NMU version 17.7.0-1.1

2020-06-20 Thread Mike Gabriel
Hi,

Am Samstag, 20. Juni 2020 schrieb Giovanni Mascellani:
> Control: tags 949196 + patch
> Control: tags 949196 + pending
> 
> Dear maintainer,
> 
> I've prepared an NMU for libzypp (versioned as 17.7.0-1.1) and
> uploaded it to DELAYED/02. Please feel free to tell me if I
> should delay it longer.
> 
> Regards.

Thanks for patching libzypp. Your NMU is ok, I will include your .debdiff on 
its VCS. In fact, I am considering orphaning libzypp and zypper in Debian. Do 
you have interest in taking over?

Greets,
Mike
-- 
Gesendet von meinem Fairphone (powered by SailfishOS)

Bug#949196: libzypp: diff for NMU version 17.7.0-1.1

2020-06-20 Thread Giovanni Mascellani
Hi,

Il 20/06/20 19:01, Mike Gabriel ha scritto:
> Thanks for patching libzypp. Your NMU is ok, I will include your
> .debdiff on its VCS. In fact, I am considering orphaning libzypp and
> zypper in Debian. Do you have interest in taking over?

No, I have no interest. Actually, I barely know what they do: I am just
doing some RC sniping.

Giovanni.
-- 
Giovanni Mascellani 
Postdoc researcher - Université Libre de Bruxelles



signature.asc
Description: OpenPGP digital signature


Bug#949196: libzypp: diff for NMU version 17.7.0-1.1

2020-06-20 Thread Giovanni Mascellani
Control: tags 949196 + patch
Control: tags 949196 + pending

Dear maintainer,

I've prepared an NMU for libzypp (versioned as 17.7.0-1.1) and
uploaded it to DELAYED/02. Please feel free to tell me if I
should delay it longer.

Regards.


-- 
Giovanni Mascellani 
Postdoc researcher - Université Libre de Bruxelles
diff -Nru libzypp-17.7.0/debian/changelog libzypp-17.7.0/debian/changelog
--- libzypp-17.7.0/debian/changelog	2018-09-17 13:31:02.0 +0200
+++ libzypp-17.7.0/debian/changelog	2020-06-20 16:35:50.0 +0200
@@ -1,3 +1,12 @@
+libzypp (17.7.0-1.1) unstable; urgency=medium
+
+  * Non-maintainer upload.
+  * Work around broken libsolv detection (closes: #949196).
+  * Fix build with Boost 1.71.
+  * Treat libxml as a C++ library.
+
+ -- Giovanni Mascellani   Sat, 20 Jun 2020 16:35:50 +0200
+
 libzypp (17.7.0-1) unstable; urgency=medium
 
   * New upstream release.
diff -Nru libzypp-17.7.0/debian/patches/40e772a952ed8b0525430bca6a226e054826c662.patch libzypp-17.7.0/debian/patches/40e772a952ed8b0525430bca6a226e054826c662.patch
--- libzypp-17.7.0/debian/patches/40e772a952ed8b0525430bca6a226e054826c662.patch	1970-01-01 01:00:00.0 +0100
+++ libzypp-17.7.0/debian/patches/40e772a952ed8b0525430bca6a226e054826c662.patch	2020-06-20 16:35:50.0 +0200
@@ -0,0 +1,69 @@
+From 40e772a952ed8b0525430bca6a226e054826c662 Mon Sep 17 00:00:00 2001
+From: Adam Majer 
+Date: Wed, 28 Nov 2018 16:56:15 +0100
+Subject: [PATCH] Need to explitily cast of Tribool to boolean
+
+Only explicit casts are allowed as of Boost 1.69
+---
+ zypp/RepoInfo.cc   | 8 
+ zypp/RepoManager.cc| 2 +-
+ zypp/repo/Applydeltarpm.cc | 2 +-
+ 3 files changed, 6 insertions(+), 6 deletions(-)
+
+diff --git a/zypp/RepoInfo.cc b/zypp/RepoInfo.cc
+index 0a3575bc8..db230c727 100644
+--- a/zypp/RepoInfo.cc
 b/zypp/RepoInfo.cc
+@@ -387,11 +387,11 @@ namespace zypp
+ 
+ 
+   bool RepoInfo::repoGpgCheck() const
+-  { return gpgCheck() || _pimpl->cfgRepoGpgCheck(); }
++  { return gpgCheck() || bool(_pimpl->cfgRepoGpgCheck()); }
+ 
+   bool RepoInfo::repoGpgCheckIsMandatory() const
+   {
+-bool ret = ( gpgCheck() && indeterminate(_pimpl->cfgRepoGpgCheck()) ) || _pimpl->cfgRepoGpgCheck();
++bool ret = ( gpgCheck() && indeterminate(_pimpl->cfgRepoGpgCheck()) ) || bool(_pimpl->cfgRepoGpgCheck());
+ if ( ret && _pimpl->internalUnsignedConfirmed() )	// relax if unsigned repo was confirmed in the past
+   ret = false;
+ return ret;
+@@ -402,10 +402,10 @@ namespace zypp
+ 
+ 
+   bool RepoInfo::pkgGpgCheck() const
+-  { return _pimpl->cfgPkgGpgCheck() || ( gpgCheck() && !bool(validRepoSignature())/*enforced*/ ) ; }
++  { return bool(_pimpl->cfgPkgGpgCheck()) || ( gpgCheck() && !bool(validRepoSignature())/*enforced*/ ) ; }
+ 
+   bool RepoInfo::pkgGpgCheckIsMandatory() const
+-  { return _pimpl->cfgPkgGpgCheck() || ( gpgCheck() && indeterminate(_pimpl->cfgPkgGpgCheck()) && !bool(validRepoSignature())/*enforced*/ ); }
++  { return bool(_pimpl->cfgPkgGpgCheck()) || ( gpgCheck() && indeterminate(_pimpl->cfgPkgGpgCheck()) && !bool(validRepoSignature())/*enforced*/ ); }
+ 
+   void RepoInfo::setPkgGpgCheck( TriBool value_r )
+   { _pimpl->rawPkgGpgCheck( value_r ); }
+diff --git a/zypp/RepoManager.cc b/zypp/RepoManager.cc
+index dbcf7a1b5..ad53013fe 100644
+--- a/zypp/RepoManager.cc
 b/zypp/RepoManager.cc
+@@ -2243,7 +2243,7 @@ namespace zypp
+ 
+ 	// Make sure the service repo is created with the appropriate enablement
+ 	if ( ! indeterminate(toBeEnabled) )
+-	  it->setEnabled( toBeEnabled );
++	  it->setEnabled( ( bool ) toBeEnabled );
+ 
+ DBG << "Service adds repo " << it->alias() << " " << (it->enabled()?"enabled":"disabled") << endl;
+ addRepository( *it );
+diff --git a/zypp/repo/Applydeltarpm.cc b/zypp/repo/Applydeltarpm.cc
+index 7b382be9b..0a1b8ad7e 100644
+--- a/zypp/repo/Applydeltarpm.cc
 b/zypp/repo/Applydeltarpm.cc
+@@ -82,7 +82,7 @@ namespace zypp
+   else
+ WAR << "No executable " << prog << endl;
+ }
+-  return _last;
++  return ( bool ) _last;
+ }
+ 
+ /**
diff -Nru libzypp-17.7.0/debian/patches/867c6b3190dafcd07f0ac5d8eef39268cc925141.patch libzypp-17.7.0/debian/patches/867c6b3190dafcd07f0ac5d8eef39268cc925141.patch
--- libzypp-17.7.0/debian/patches/867c6b3190dafcd07f0ac5d8eef39268cc925141.patch	1970-01-01 01:00:00.0 +0100
+++ libzypp-17.7.0/debian/patches/867c6b3190dafcd07f0ac5d8eef39268cc925141.patch	2020-06-20 16:35:50.0 +0200
@@ -0,0 +1,24 @@
+From 867c6b3190dafcd07f0ac5d8eef39268cc925141 Mon Sep 17 00:00:00 2001
+From: Adam Majer 
+Date: Tue, 27 Nov 2018 15:45:43 +0100
+Subject: [PATCH] Boost.Tribool requires an explicit cast to bool
+
+operator== between boost::logic::tribool returns a tribool, which
+requires an explicit cast to bool
+---
+ zypp/TriBool.h | 2 +-
+ 1 file changed, 1 insertion(+), 1 deletion(-)
+
+diff --git