Bug#951251: RFS: ledmon/0.94-1 -- Enclosure LED Utilities
On Fri, Feb 14, 2020 at 12:52:55AM +0800, Woodrow Shen wrote: > I don't why this bug needs to close, but anyway I will file a new bug after > I fix all issues you mentioned. It shouldn't have been closed, but apparently bartm's bot got confused. Meow! -- ⢀⣴⠾⠻⢶⣦⠀ ⣾⠁⢰⠒⠀⣿⡁ Imagine there are bandits in your house, your kid is bleeding out, ⢿⡄⠘⠷⠚⠋⠀ the house is on fire, and seven giant trumpets are playing in the ⠈⠳⣄ sky. Your cat demands food. The priority should be obvious...
Bug#951251: RFS: ledmon/0.94-1 -- Enclosure LED Utilities
Hi Adam, Thanks for the help! Very appreciated. On Thu, Feb 13, 2020 at 9:17 PM Adam Borowski wrote: > On Thu, Feb 13, 2020 at 09:01:38AM +, Hsieh-Tseng Shen wrote: > > * Package name: ledmon > >Version : 0.94-1 > > > Changes since the last upload: > > > >* New upstream release 0.94. > > - Support for AMD IPMI enclosure management. > > - Support for NPEM. > >* debian/control: add pkg-config and libpci-dev as build dependency. > >* debian/control: update Standards-Version to 4.5.0. > >* Remove obsolete patch. > > Hi! > Besides things mentioned above, you also add installation of systemd > .service file. And, I see some problems there. > > + dh $@ --wth systemd > would look a bit nicer when spelt "--with". I didn't think I made ridiculous mistake here... oops > It would also make this section done automatically: > +override_dh_auto_install: > + dh_auto_install > + mkdir -p debian/ledmon/lib/systemd/system > + install -c -m 644 systemd/ledmon.service > debian/ledmon/lib/systemd/system > + dh_systemd_enable || true > + dh_systemd_start || true > > > Another problem is that you enable the daemon only for systemd. For any > other init/rc combination there's a need for an init script (and, it would > be enough for systemd too). Here's one: > > .--==[ debian/ledmon.init ] > #!/usr/bin/env /lib/init/init-d-script > ### BEGIN INIT INFO > # Provides: ledmon > # Required-Start: $syslog $time > # Required-Stop:$syslog $time > # Default-Start:2 3 4 5 > # Default-Stop: 0 1 6 > # Short-Description: enclosure LED monitor > # Description: monitoring of storage enclosure LEDs > ### END INIT INFO > DAEMON=/usr/sbin/ledmon > ` > I will refer some examples (e.g. network-manager) to finish init script, thanks. I don't why this bug needs to close, but anyway I will file a new bug after I fix all issues you mentioned. Woodrow > > > Meow! > -- > ⢀⣴⠾⠻⢶⣦⠀ > ⣾⠁⢠⠒⠀⣿⡁ > ⢿⡄⠘⠷⠚⠋⠀ A white dwarf seeks a red giant for a binary relationship. > ⠈⠳⣄ >
Bug#951251: RFS: ledmon/0.94-1 -- Enclosure LED Utilities
On Thu, Feb 13, 2020 at 09:01:38AM +, Hsieh-Tseng Shen wrote: > * Package name: ledmon >Version : 0.94-1 > Changes since the last upload: > >* New upstream release 0.94. > - Support for AMD IPMI enclosure management. > - Support for NPEM. >* debian/control: add pkg-config and libpci-dev as build dependency. >* debian/control: update Standards-Version to 4.5.0. >* Remove obsolete patch. Hi! Besides things mentioned above, you also add installation of systemd .service file. And, I see some problems there. + dh $@ --wth systemd would look a bit nicer when spelt "--with". It would also make this section done automatically: +override_dh_auto_install: + dh_auto_install + mkdir -p debian/ledmon/lib/systemd/system + install -c -m 644 systemd/ledmon.service debian/ledmon/lib/systemd/system + dh_systemd_enable || true + dh_systemd_start || true Another problem is that you enable the daemon only for systemd. For any other init/rc combination there's a need for an init script (and, it would be enough for systemd too). Here's one: .--==[ debian/ledmon.init ] #!/usr/bin/env /lib/init/init-d-script ### BEGIN INIT INFO # Provides: ledmon # Required-Start: $syslog $time # Required-Stop:$syslog $time # Default-Start:2 3 4 5 # Default-Stop: 0 1 6 # Short-Description: enclosure LED monitor # Description: monitoring of storage enclosure LEDs ### END INIT INFO DAEMON=/usr/sbin/ledmon ` Meow! -- ⢀⣴⠾⠻⢶⣦⠀ ⣾⠁⢠⠒⠀⣿⡁ ⢿⡄⠘⠷⠚⠋⠀ A white dwarf seeks a red giant for a binary relationship. ⠈⠳⣄
Bug#951251: RFS: ledmon/0.94-1 -- Enclosure LED Utilities
Package: sponsorship-requests Followup-For: Bug #951251 I've resubmited package again for revise, and the change is to fix changelog as below: The point here is to give what's new features for this release, especially AMD platform support. Changes since the last upload: * New upstream release 0.94. - Support for AMD IPMI enclosure management. - Support for NPEM. * debian/control: add pkg-config and libpci-dev as build dependency. * debian/control: update Standards-Version to 4.5.0. * Remove obsolete patch. -- Woodrow Shen (Hsieh-Tseng Shen) 4FA0 D159 803F F8B6 34E9 5A38 3970 FE24 7CB6 9685 woodrow.s...@gmail.com signature.asc Description: PGP signature
Bug#951251: RFS: ledmon/0.94-1 -- Enclosure LED Utilities
Package: sponsorship-requests Severity: normal Tags: upstream Dear mentors, I am looking for a sponsor for my package "ledmon" * Package name: ledmon Version : 0.94-1 Upstream Author : [fill in name and email of upstream] * URL : https://github.com/intel/ledmon * License : GPL-2.0+ * Vcs : https://salsa.debian.org/debian/ledmon Section : admin It builds those binary packages: ledmon - Enclosure LED Utilities To access further information about this package, please visit the following URL: https://mentors.debian.net/package/ledmon Alternatively, one can download the package with dget using this command: dget -x https://mentors.debian.net/debian/pool/main/l/ledmon/ledmon_0.94-1.dsc Changes since the last upload: * New upstream release 0.94. * debian/control: add pkg-config and libpci-dev as build dependency. * debian/control: update Standards-Version to 4.5.0. * Remove obsolete patch. Regards, -- Woodrow Shen (Hsieh-Tseng Shen) 4FA0 D159 803F F8B6 34E9 5A38 3970 FE24 7CB6 9685 woodrow.s...@gmail.com signature.asc Description: PGP signature
