Bug#951262: Please set CGO_XFLAGS with dpkg-buildflags

[Shengjing Zhu]

On Wed, Feb 19, 2020 at 9:44 PM Tong Sun  wrote:
> If no objection to Shengjing's proposal, I'll take a look and try to fix it...
>

It has been fixed, thanks though.

-- 
Shengjing Zhu

Bug#951262: Please set CGO_XFLAGS with dpkg-buildflags

[Tong Sun]

Hi,


On Thu, Feb 13, 2020 at 9:00 AM Shengjing Zhu  wrote:
>
> Package: dh-golang
> Version: 1.45
> Severity: wishlist
>
> Hi,
>
> Currently the CGO_XFLAGS is set with:
>
> $ go env|grep CGO_
> CGO_ENABLED="1"
> CGO_CFLAGS="-g -O2"
> CGO_CPPFLAGS=""
> CGO_CXXFLAGS="-g -O2"
> CGO_FFLAGS="-g -O2"
> CGO_LDFLAGS="-g -O2"
>
> I think the values should be same as dpkg-buildflags
>
> $ dpkg-buildflags
> CFLAGS=-g -O2 -fdebug-prefix-map=/tmp=. -fstack-protector-strong -Wformat 
> -Werror=format-security
> CPPFLAGS=-Wdate-time -D_FORTIFY_SOURCE=2
> CXXFLAGS=-g -O2 -fdebug-prefix-map=/tmp=. -fstack-protector-strong -Wformat 
> -Werror=format-security
> FCFLAGS=-g -O2 -fdebug-prefix-map=/tmp=. -fstack-protector-strong
> FFLAGS=-g -O2 -fdebug-prefix-map=/tmp=. -fstack-protector-strong
> GCJFLAGS=-g -O2 -fdebug-prefix-map=/tmp=. -fstack-protector-strong
> LDFLAGS=-Wl,-z,relro
> OBJCFLAGS=-g -O2 -fdebug-prefix-map=/tmp=. -fstack-protector-strong -Wformat 
> -Werror=format-security
> OBJCXXFLAGS=-g -O2 -fdebug-prefix-map=/tmp=. -fstack-protector-strong 
> -Wformat -Werror=format-security
>
> I'm not familiar with Perl. I hope someone can help with the patch.

If no objection to Shengjing's proposal, I'll take a look and try to fix it...

> Shengjing Zhu
>

Bug#951262: Please set CGO_XFLAGS with dpkg-buildflags

[Shengjing Zhu]

Package: dh-golang
Version: 1.45
Severity: wishlist

Hi,

Currently the CGO_XFLAGS is set with:

$ go env|grep CGO_
CGO_ENABLED="1"
CGO_CFLAGS="-g -O2"
CGO_CPPFLAGS=""
CGO_CXXFLAGS="-g -O2"
CGO_FFLAGS="-g -O2"
CGO_LDFLAGS="-g -O2"

I think the values should be same as dpkg-buildflags

$ dpkg-buildflags
CFLAGS=-g -O2 -fdebug-prefix-map=/tmp=. -fstack-protector-strong -Wformat 
-Werror=format-security
CPPFLAGS=-Wdate-time -D_FORTIFY_SOURCE=2
CXXFLAGS=-g -O2 -fdebug-prefix-map=/tmp=. -fstack-protector-strong -Wformat 
-Werror=format-security
FCFLAGS=-g -O2 -fdebug-prefix-map=/tmp=. -fstack-protector-strong
FFLAGS=-g -O2 -fdebug-prefix-map=/tmp=. -fstack-protector-strong
GCJFLAGS=-g -O2 -fdebug-prefix-map=/tmp=. -fstack-protector-strong
LDFLAGS=-Wl,-z,relro
OBJCFLAGS=-g -O2 -fdebug-prefix-map=/tmp=. -fstack-protector-strong -Wformat 
-Werror=format-security
OBJCXXFLAGS=-g -O2 -fdebug-prefix-map=/tmp=. -fstack-protector-strong -Wformat 
-Werror=format-security

I'm not familiar with Perl. I hope someone can help with the patch.

Shengjing Zhu