Bug#965327: Lower severity of bash-completion-with-hashbang
❦ 20 juillet 2020 15:00 +00, Chris Lamb: >> Lintian is a very useful tool, but too many stuff is a warning while >> this is a matter of opinion. I have given up on the "info" level >> since a long time for similar reasons. I would like not to give up on >> the "warning" level. > > (It is a shame to read you have given up on "I:" and it would be nice > if Lintian earned back your trust. Now that it has a slightly simpler > system of classification, could you file a wishlist bugs against what > you feel are, or felt were, the worst offenders?) Thanks! I'll reuse -I and will open bugs if needed. -- Don't just echo the code with comments - make every comment count. - The Elements of Programming Style (Kernighan & Plauger) signature.asc Description: PGP signature
Bug#965327: Lower severity of bash-completion-with-hashbang
Hi Vincent, > >> the shebang is harmless and I won't > >> patch or other upstream about a harmless shebang. > > > > As explained in this MR [2], we consider the hashbang an error. The > > snippets are not meant to be executed. The upstream for > > 'bash-completion' also does not use them. > > > > [2] https://salsa.debian.org/lintian/lintian/-/merge_requests/292 > > Again, I won't maintain a patch for such an "error". Hmm, I would agree this should not be a "W:" level tag, and could easily be convinced it should not even be "I:" either given that I wouldn't patch it out either or bother upstream with it. This might be another one of my controversial opinions too, but I find modelines as a solution beyond ugly. :) > Lintian is a very useful tool, but too many stuff is a warning while > this is a matter of opinion. I have given up on the "info" level > since a long time for similar reasons. I would like not to give up on > the "warning" level. (It is a shame to read you have given up on "I:" and it would be nice if Lintian earned back your trust. Now that it has a slightly simpler system of classification, could you file a wishlist bugs against what you feel are, or felt were, the worst offenders?) Best wishes, -- ,''`. : :' : Chris Lamb `. `'` la...@debian.org chris-lamb.co.uk `-
Bug#965327: Lower severity of bash-completion-with-hashbang
Hello Felix, Thanks for your quick reply. ❦ 19 juillet 2020 09:33 -07, Felix Lechner: >> the shebang is harmless and I won't >> patch or other upstream about a harmless shebang. > > As explained in this MR [2], we consider the hashbang an error. The > snippets are not meant to be executed. The upstream for > 'bash-completion' also does not use them. > > [2] https://salsa.debian.org/lintian/lintian/-/merge_requests/292 Again, I won't maintain a patch for such an "error". And I won't bother upstream with this. This kind of warnings just deter me of using Lintian. Lintian is a very useful tool, but too many stuff is a warning while this is a matter of opinion. I have given up on the "info" level since a long time for similar reasons. I would like not to give up on the "warning" level. >> Also, this helps editors turning on the right "mode" to edit the >> file. > > This is an unrelated function that you may be able to resolve by using > [3] or [4]. > > [3] > https://www.gnu.org/software/emacs/manual/html_node/emacs/Choosing-Modes.html > [4] http://vimdoc.sourceforge.net/htmldoc/syntax.html I am not even sure upstream puts a shebang for this reason. It was pure speculation on my side. But as I won't bother upstream about adding special markups for each known editor to replace the shebang, I would like to not bother them about an harmless error. Debian is not the special snowflake every upstream try to take care of anymore. I would like to not be more an annoyance that I strictly need to. -- Use variable names that mean something. - The Elements of Programming Style (Kernighan & Plauger) signature.asc Description: PGP signature
Bug#965327: Lower severity of bash-completion-with-hashbang
Hi Vincent, On Sun, Jul 19, 2020 at 9:03 AM Vincent Bernat wrote: > > bash-completion-with-hashbang got bump from > minor to certain, after commit 70eaca50411. I think that's a misunderstanding. We changed the scale back to the simple EWI system after having classed tags by levels from the BTS for some time. Due to Certainty: certain, this tag was always issued as a warning. [1] [1] https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=935706#40 That being said, the tag was introduced just three weeks earlier (in commit 6fbc952b) and may carry a severity higher than intended. (A warning does not sound like minor, does it?) I will think about the level. > the shebang is harmless and I won't > patch or other upstream about a harmless shebang. As explained in this MR [2], we consider the hashbang an error. The snippets are not meant to be executed. The upstream for 'bash-completion' also does not use them. [2] https://salsa.debian.org/lintian/lintian/-/merge_requests/292 > Also, this helps > editors turning on the right "mode" to edit the file. This is an unrelated function that you may be able to resolve by using [3] or [4]. [3] https://www.gnu.org/software/emacs/manual/html_node/emacs/Choosing-Modes.html [4] http://vimdoc.sourceforge.net/htmldoc/syntax.html You can see examples for both, at the top and the bottom of the file respectively, here: https://salsa.debian.org/lintian/lintian/-/blob/master/checks/continuous-integration/salsa.pm Kind regards Felix Lechner
Bug#965327: Lower severity of bash-completion-with-hashbang
Package: lintian Version: 2.84.0 Severity: normal -BEGIN PGP SIGNED MESSAGE- Hash: SHA256 Hey! I have just noticed that bash-completion-with-hashbang got bump from minor to certain, after commit 70eaca50411. I don't understand the rationale behind this commit, but in case of bash-completion-with-hashbang, the shebang is harmless and I won't patch or other upstream about a harmless shebang. Also, this helps editors turning on the right "mode" to edit the file. - -- System Information: Debian Release: bullseye/sid APT prefers unstable-debug APT policy: (500, 'unstable-debug'), (500, 'unstable'), (500, 'testing'), (101, 'experimental-debug'), (101, 'experimental') Architecture: amd64 (x86_64) Kernel: Linux 5.7.0-1-amd64 (SMP w/4 CPU threads) Kernel taint flags: TAINT_WARN Locale: LANG=fr_FR.utf8, LC_CTYPE=fr_FR.utf8 (charmap=UTF-8), LANGUAGE not set Shell: /bin/sh linked to /usr/bin/dash Init: systemd (via /run/systemd/system) LSM: AppArmor: enabled Versions of packages lintian depends on: ii binutils 2.34.90.20200706-1 ii bzip2 1.0.8-3 ii diffstat 1.63-1 ii dpkg 1.20.5 ii dpkg-dev 1.20.5 ii file 1:5.38-5 ii gettext 0.19.8.1-10 ii gpg 2.2.20-1 ii intltool-debian 0.35.0+20060710.5 ii libapt-pkg-perl 0.1.36+b3 ii libarchive-zip-perl 1.68-1 ii libcapture-tiny-perl 0.48-1 ii libclass-xsaccessor-perl 1.19-3+b5 ii libclone-perl 0.45-1 ii libconfig-tiny-perl 2.24-1 ii libcpanel-json-xs-perl4.19-1 ii libdata-validate-domain-perl 0.10-1 ii libdevel-size-perl0.83-1+b1 ii libdpkg-perl 1.20.5 ii libemail-address-xs-perl 1.04-1+b2 ii libfile-basedir-perl 0.08-1 ii libfile-find-rule-perl0.34-1 ii libfont-ttf-perl 1.06-1 ii libhtml-parser-perl 3.72-5 ii libio-async-loop-epoll-perl 0.21-1 ii libio-async-perl 0.77-3 ii libjson-maybexs-perl 1.004002-1 ii liblist-compare-perl 0.53-1 ii liblist-moreutils-perl0.416-1+b5 ii liblist-utilsby-perl 0.11-1 ii libmoo-perl 2.004000-1 ii libmoox-aliases-perl 0.001006-1 ii libnamespace-clean-perl 0.27-1 ii libpath-tiny-perl 0.114-1 ii libsereal-decoder-perl4.017+ds-1 ii libsereal-encoder-perl4.017+ds-1 ii libtext-levenshteinxs-perl0.03-4+b7 ii libtext-xslate-perl 3.5.8-1 ii libtime-duration-perl 1.21-1 ii libtime-moment-perl 0.44-1+b2 ii libtimedate-perl 2.3300-1 ii libtry-tiny-perl 0.30-1 ii libtype-tiny-perl 1.010002-1 ii libunicode-utf8-perl 0.62-1+b1 ii liburi-perl 1.76-2 ii libxml-libxml-perl2.0134+dfsg-2 ii libxml-writer-perl0.625-1 ii libyaml-libyaml-perl 0.82+repack-1 ii man-db2.9.3-2 ii patchutils0.3.4-3 ii perl [libdigest-sha-perl] 5.30.3-4 ii t1utils 1.41-4 ii xz-utils 5.2.4-1+b1 Versions of packages lintian recommends: ii libperlio-gzip-perl 0.19-1+b6 Versions of packages lintian suggests: ii binutils-multiarch 2.34.90.20200706-1 ii libtext-template-perl 1.59-1 - -- no debconf information -BEGIN PGP SIGNATURE- iQJGBAEBCAAwFiEErvI0h2bzccaJpzYAlaQv6DU1JfkFAl8Ubg4SHGJlcm5hdEBk ZWJpYW4ub3JnAAoJEJWkL+g1NSX5UowQAJ9rPWWt9SGEZ/LA3kFxKGsketLFxELj KSO1SQSz+14XEp7T1wPBmq6BsoRH6nYQvxC47yfQR6jyrMNddOEt4LaxVG7B0QM7 BwfnyIT+SxjT4G+boahcwlOsKey0AbeHCp74ujpr21ret9uLutDMagvNsaKRRenJ rk4yc9T/aGDB+jV8OIhbfHL2YhEVJYp/4kCZpPP0AYuKgH/m5UpTZMzTRLAX8R7m qtPooGrndhks77po5T4P4j1rWuRssNw9w20Aj8T39A69RTXsgGNYN1Yf2MhOnWKP 0MgsWiRE/Z2eZrjsMv3tgLrwyLExehPwsqYZye8Ejj0dzbGUGw12CL83Dp1R+vaq a2V8T3fwIaFTeCprnz0JrUhR48ZWy9r9GK+6nHdgeOCmQXPM97lPmIuA1Paa5foc 0c4F870+WyFACVefKpDGNq5SmJIgQjq1tqvzeZN9sYcL2rKyBGiiKSw9uws7CPN+ lAKQ2Ci1ZXrzPNkEhDtZToxchcSd5EOrmvse6P6oymjDXqk2AGLrrsykkSUnjPGF wBmZDHEj6K6XYQ4pDbDZ1vcu90W5LhFhYvxNf9NgLZmdWg5+OVGfwias7ATc5MZE PgElBoGUsw8U8qzlDIjqLPGB1WFpvv8frNnCVFaOY6waSI5MN2bI3GJQbODhIl3+ UXSVKJOizPS/ =HzFs -END PGP SIGNATURE-
