Bug#968714: extractpdfmark FTBFS with poppler 0.85
It seems the recent upload of poppler 20 introduced further breakage. Poppler changed the return type of Catalog::getDestNameTreeDest and Catalog::getDestsDest from LinkDest * to std::unique_ptr If I am following the code correctly, it seems that extractpdfmark had a memory leak, previously, getDestNameTreeDest and getDestsDest returned an owning pointer, but add_destname does not take ownership of the pointer passed in. I therefore belive it is ok to just add .get() to the calls, this should fix both the build failure and the memory leak. A debdiff should appear soon at http://debdiffs.raspbian.org/main/e/extractpdfmark/extractpdfmark_1.1.0-1+rpi2.debdiff
Bug#968714: extractpdfmark FTBFS with poppler 0.85
Package: extractpdfmark Version: 1.1.0-1 Severity: serious Tags: patch extractpdfmark FTBFS with poppler 0.85 destname.cc:85:62: error: no matching function for call to ‘PDFDoc::findPage(int&, int&)’ 85 | pagenum = doc->findPage (page_ref.num, page_ref.gen); Doing a bit of poking around in poppler's git repository I deduced that the call should be changed to pagenum = doc->findPage(page_ref); I have whipped up a patch and uploaded it to raspbian, a debdiff should appear soon at https://debdiffs.raspbian.org/main/e/extractpdfmark I may or may not NMU this in Debian later.
