Bug#988197: [Pkg-samba-maint] Bug#988197: patch for samba which fixes legacy printing support
OK. Then I'll try to add this fix in bullseye. Le lun. 10 mai 2021 à 12:40, Mateusz Mikołajczyk a écrit : > > not sure how to check this. I googled for "debian source code" and that's the > source for samba version in bullseye (I think): > > https://sources.debian.org/src/samba/2:4.13.5+dfsg-1/source3/smbd/reply.c/#L7094 > > I marked the line that has the patch on samba's gitlab > > the patch was made in upstream literally days ago so I don't think it made to > bullseye yet. especially given the fact that upstream samba is at 4.14.x and > this is 4.13.x > > pon., 10 maj 2021 o 12:14 Mathieu Parent napisał(a): >> >> I think the bug is not present in bullseye. >> >> Le lun. 10 mai 2021 à 12:09, Mateusz Mikołajczyk >> a écrit : >> > >> > sorry, I'm a bit confused. did you mean bullseye is frozen? Does it mean >> > that this patch won't make it to bullseye either and I'd have to switch to >> > sid instead? the patch is definetely not a feature implementation, it >> > simply makes samba conform with the SMB protocol. this particular function >> > was bugged for quite a while now, but on the other hand I totally >> > understand that only a minority of a percentage of users will benefit from >> > this. >> > >> > if it would make it to bullseye, how would I know this? >> > >> > pon., 10 maj 2021 o 11:48 Mathieu Parent >> > napisał(a): >> >> >> >> Le lun. 10 mai 2021 à 11:29, Mateusz Mikołajczyk >> >> a écrit : >> >> > >> >> > actually, I thought that I couldn't do this but on a second thought as >> >> > I understand I'd simply have to change all my entries in sources.list >> >> > from buster to bullseye ? I'm using armbian if that's relevant to the >> >> > story :) >> >> > >> >> >> >> I don't know for Raspian, but upgrades notes are here: >> >> >> >> https://www.debian.org/releases/bullseye/armhf/release-notes/ch-upgrading.en.html >> >> >> >> Please note that Debian buster is the future Debian stable, and is >> >> currently "frozen" (i.e only stabibilty fixes are allowed). >> >> >> >> Regards >> >> -- >> >> Mathieu Parent >> > >> > >> > >> > -- >> > pozdrawiam serdecznie, >> > Mateusz Mikołajczyk, a.k.a. toudi >> >> >> >> -- >> Mathieu > > > > -- > pozdrawiam serdecznie, > Mateusz Mikołajczyk, a.k.a. toudi -- Mathieu
Bug#988197: [Pkg-samba-maint] Bug#988197: patch for samba which fixes legacy printing support
not sure how to check this. I googled for "debian source code" and that's the source for samba version in bullseye (I think): https://sources.debian.org/src/samba/2:4.13.5+dfsg-1/source3/smbd/reply.c/#L7094 I marked the line that has the patch on samba's gitlab the patch was made in upstream literally days ago so I don't think it made to bullseye yet. especially given the fact that upstream samba is at 4.14.x and this is 4.13.x pon., 10 maj 2021 o 12:14 Mathieu Parent napisał(a): > I think the bug is not present in bullseye. > > Le lun. 10 mai 2021 à 12:09, Mateusz Mikołajczyk > a écrit : > > > > sorry, I'm a bit confused. did you mean bullseye is frozen? Does it mean > that this patch won't make it to bullseye either and I'd have to switch to > sid instead? the patch is definetely not a feature implementation, it > simply makes samba conform with the SMB protocol. this particular function > was bugged for quite a while now, but on the other hand I totally > understand that only a minority of a percentage of users will benefit from > this. > > > > if it would make it to bullseye, how would I know this? > > > > pon., 10 maj 2021 o 11:48 Mathieu Parent > napisał(a): > >> > >> Le lun. 10 mai 2021 à 11:29, Mateusz Mikołajczyk > >> a écrit : > >> > > >> > actually, I thought that I couldn't do this but on a second thought > as I understand I'd simply have to change all my entries in sources.list > from buster to bullseye ? I'm using armbian if that's relevant to the story > :) > >> > > >> > >> I don't know for Raspian, but upgrades notes are here: > >> > >> > https://www.debian.org/releases/bullseye/armhf/release-notes/ch-upgrading.en.html > >> > >> Please note that Debian buster is the future Debian stable, and is > >> currently "frozen" (i.e only stabibilty fixes are allowed). > >> > >> Regards > >> -- > >> Mathieu Parent > > > > > > > > -- > > pozdrawiam serdecznie, > > Mateusz Mikołajczyk, a.k.a. toudi > > > > -- > Mathieu > -- pozdrawiam serdecznie, Mateusz Mikołajczyk, a.k.a. toudi
Bug#988197: [Pkg-samba-maint] Bug#988197: patch for samba which fixes legacy printing support
I think the bug is not present in bullseye. Le lun. 10 mai 2021 à 12:09, Mateusz Mikołajczyk a écrit : > > sorry, I'm a bit confused. did you mean bullseye is frozen? Does it mean that > this patch won't make it to bullseye either and I'd have to switch to sid > instead? the patch is definetely not a feature implementation, it simply > makes samba conform with the SMB protocol. this particular function was > bugged for quite a while now, but on the other hand I totally understand that > only a minority of a percentage of users will benefit from this. > > if it would make it to bullseye, how would I know this? > > pon., 10 maj 2021 o 11:48 Mathieu Parent napisał(a): >> >> Le lun. 10 mai 2021 à 11:29, Mateusz Mikołajczyk >> a écrit : >> > >> > actually, I thought that I couldn't do this but on a second thought as I >> > understand I'd simply have to change all my entries in sources.list from >> > buster to bullseye ? I'm using armbian if that's relevant to the story :) >> > >> >> I don't know for Raspian, but upgrades notes are here: >> >> https://www.debian.org/releases/bullseye/armhf/release-notes/ch-upgrading.en.html >> >> Please note that Debian buster is the future Debian stable, and is >> currently "frozen" (i.e only stabibilty fixes are allowed). >> >> Regards >> -- >> Mathieu Parent > > > > -- > pozdrawiam serdecznie, > Mateusz Mikołajczyk, a.k.a. toudi -- Mathieu
Bug#988197: [Pkg-samba-maint] Bug#988197: patch for samba which fixes legacy printing support
sorry, I'm a bit confused. did you mean bullseye is frozen? Does it mean that this patch won't make it to bullseye either and I'd have to switch to sid instead? the patch is definetely not a feature implementation, it simply makes samba conform with the SMB protocol. this particular function was bugged for quite a while now, but on the other hand I totally understand that only a minority of a percentage of users will benefit from this. if it would make it to bullseye, how would I know this? pon., 10 maj 2021 o 11:48 Mathieu Parent napisał(a): > Le lun. 10 mai 2021 à 11:29, Mateusz Mikołajczyk > a écrit : > > > > actually, I thought that I couldn't do this but on a second thought as I > understand I'd simply have to change all my entries in sources.list from > buster to bullseye ? I'm using armbian if that's relevant to the story :) > > > > I don't know for Raspian, but upgrades notes are here: > > > https://www.debian.org/releases/bullseye/armhf/release-notes/ch-upgrading.en.html > > Please note that Debian buster is the future Debian stable, and is > currently "frozen" (i.e only stabibilty fixes are allowed). > > Regards > -- > Mathieu Parent > -- pozdrawiam serdecznie, Mateusz Mikołajczyk, a.k.a. toudi
Bug#988197: [Pkg-samba-maint] Bug#988197: patch for samba which fixes legacy printing support
Le lun. 10 mai 2021 à 11:29, Mateusz Mikołajczyk a écrit : > > actually, I thought that I couldn't do this but on a second thought as I > understand I'd simply have to change all my entries in sources.list from > buster to bullseye ? I'm using armbian if that's relevant to the story :) > I don't know for Raspian, but upgrades notes are here: https://www.debian.org/releases/bullseye/armhf/release-notes/ch-upgrading.en.html Please note that Debian buster is the future Debian stable, and is currently "frozen" (i.e only stabibilty fixes are allowed). Regards -- Mathieu Parent
Bug#988197: [Pkg-samba-maint] Bug#988197: patch for samba which fixes legacy printing support
actually, I thought that I couldn't do this but on a second thought as I understand I'd simply have to change all my entries in sources.list from buster to bullseye ? I'm using armbian if that's relevant to the story :) pon., 10 maj 2021 o 10:44 Mathieu Parent napisał(a): > Le ven. 7 mai 2021 à 15:24, Mateusz Mikołajczyk > a écrit : > > > > Package: samba > > Version: 4.9.5+dfsg-5+deb10u1 > > > > I was testing samba with an really old DOS client. it turns out that > ever since samba 3.2.0 there was an upstream change that broke this legacy > printing support. It was already merged upstream but the patch is super > tiny - a one liner: > > > > > https://gitlab.com/samba-team/samba/-/commit/47d79d7e7e406f7dd204ded7c72cfed3e0761ad5 > > > > I was wondering, would it be possible to add it as a patch to debian > buster? Currently I figured out a way to apply it - I simply build samba > .deb package from source (i.e. deb-src), manually apply the patch and then > install local version of the package. That's all great until I'm testing > this on x86 architecture (because the compilation is relatively quick), > however I intend to put everything to sbc board as a headless print server. > In order to avoid compilation on the sbc, I could create a virtual machine > and do a cross-compilation but it seems like a massive overkill just to > introduce a one-liner patch, plus it wouldn't survive any of the potential > upgrades > > Hi, > > I'm sorry, but I won't apply this patch to buster. You can use bullseye > instead. > > Regards > -- > Mathieu Parent > -- pozdrawiam serdecznie, Mateusz Mikołajczyk, a.k.a. toudi
Bug#988197: [Pkg-samba-maint] Bug#988197: patch for samba which fixes legacy printing support
Le ven. 7 mai 2021 à 15:24, Mateusz Mikołajczyk a écrit : > > Package: samba > Version: 4.9.5+dfsg-5+deb10u1 > > I was testing samba with an really old DOS client. it turns out that ever > since samba 3.2.0 there was an upstream change that broke this legacy > printing support. It was already merged upstream but the patch is super tiny > - a one liner: > > https://gitlab.com/samba-team/samba/-/commit/47d79d7e7e406f7dd204ded7c72cfed3e0761ad5 > > I was wondering, would it be possible to add it as a patch to debian buster? > Currently I figured out a way to apply it - I simply build samba .deb package > from source (i.e. deb-src), manually apply the patch and then install local > version of the package. That's all great until I'm testing this on x86 > architecture (because the compilation is relatively quick), however I intend > to put everything to sbc board as a headless print server. In order to avoid > compilation on the sbc, I could create a virtual machine and do a > cross-compilation but it seems like a massive overkill just to introduce a > one-liner patch, plus it wouldn't survive any of the potential upgrades Hi, I'm sorry, but I won't apply this patch to buster. You can use bullseye instead. Regards -- Mathieu Parent
