Source: kdump-tools Version: 1:1.8 Severity: serious Justification: FTBFS Tags: bookworm sid ftbfs User: lu...@debian.org Usertags: ftbfs-20230101 ftbfs-bookworm
Hi, During a rebuild of all packages in sid, your package failed to build on amd64. Relevant part (hopefully): > make[1]: Entering directory '/<<PKGBUILDDIR>>' > shellcheck -e SC1090,SC1091,SC3043 debian/kdump-config.in > debian/kernel-postrm-delete-initrd debian/kdump-tools.postinst > debian/kdump-tools.preinst debian/kdump-tools.postrm > debian/kdump-tools.config debian/kernel-postinst-generate-initrd > debian/initramfs.local-bottom debian/kdump-tools.init debian/initramfs.hook > > In debian/kdump-config.in line 62: > [ -d $KDUMP_COREDIR ] || mkdir -p $KDUMP_COREDIR ; > ^------------^ SC2086 (info): Double quote to prevent globbing and word > splitting. > ^------------^ SC2086 (info): Double quote > to prevent globbing and word splitting. > > Did you mean: > [ -d "$KDUMP_COREDIR" ] || mkdir -p "$KDUMP_COREDIR" ; > > > In debian/kdump-config.in line 178: > if [ -e $kexec_cmd_file ] ; then > ^-------------^ SC2086 (info): Double quote to prevent > globbing and word splitting. > > Did you mean: > if [ -e "$kexec_cmd_file" ] ; then > > > In debian/kdump-config.in line 179: > cat $kexec_cmd_file ; > ^-------------^ SC2086 (info): Double quote to prevent > globbing and word splitting. > > Did you mean: > cat "$kexec_cmd_file" ; > > > In debian/kdump-config.in line 266: > create_symlink $symlink "$KVER" > ^------^ SC2086 > (info): Double quote to prevent globbing and word splitting. > > Did you mean: > create_symlink "$symlink" "$KVER" > > > In debian/kdump-config.in line 457: > logger -t $NAME "fadump registering failed" > ^---^ SC2086 (info): Double quote to prevent > globbing and word splitting. > > Did you mean: > logger -t "$NAME" "fadump registering failed" > > > In debian/kdump-config.in line 462: > logger -t $NAME "fadump registered successfully" > ^---^ SC2086 (info): Double quote to prevent globbing and > word splitting. > > Did you mean: > logger -t "$NAME" "fadump registered successfully" > > > In debian/kdump-config.in line 478: > logger -t $NAME "fadump un-registering failed" > ^---^ SC2086 (info): Double quote to prevent > globbing and word splitting. > > Did you mean: > logger -t "$NAME" "fadump un-registering failed" > > > In debian/kdump-config.in line 483: > logger -t $NAME "fadump un-registered successfully" > ^---^ SC2086 (info): Double quote to prevent globbing and > word splitting. > > Did you mean: > logger -t "$NAME" "fadump un-registered successfully" > > > In debian/kdump-config.in line 594: > logger -t $NAME "unloaded kdump kernel" > ^---^ SC2086 (info): Double quote to prevent > globbing and word splitting. > > Did you mean: > logger -t "$NAME" "unloaded kdump kernel" > > > In debian/kdump-config.in line 597: > logger -t $NAME "failed to unload kdump kernel" > ^---^ SC2086 (info): Double quote to prevent > globbing and word splitting. > > Did you mean: > logger -t "$NAME" "failed to unload kdump kernel" > > > In debian/kdump-config.in line 727: > logger -t $NAME "makedumpfile --dump-dmesg failed. dmesg content will > be unavailable" > ^---^ SC2086 (info): Double quote to prevent globbing and > word splitting. > > Did you mean: > logger -t "$NAME" "makedumpfile --dump-dmesg failed. dmesg content will > be unavailable" > > > In debian/kdump-config.in line 755: > while [ $CNT -ne 0 ];do > ^--^ SC2086 (info): Double quote to prevent globbing > and word splitting. > > Did you mean: > while [ "$CNT" -ne 0 ];do > > > In debian/kdump-config.in line 768: > if [ $ERROR -ne 0 ];then > ^----^ SC2086 (info): Double quote to prevent globbing > and word splitting. > > Did you mean: > if [ "$ERROR" -ne 0 ];then > > > In debian/kdump-config.in line 770: > logger -t $NAME "Unable to mount remote NFS directory > $NFS. Cannot save core" > ^---^ SC2086 (info): Double quote to > prevent globbing and word splitting. > > Did you mean: > logger -t "$NAME" "Unable to mount remote NFS directory > $NFS. Cannot save core" > > > In debian/kdump-config.in line 781: > logger -t $NAME "Unable to write to the remote NFS > directory $NFS. Cannot save core" > ^---^ SC2086 (info): Double quote to > prevent globbing and word splitting. > > Did you mean: > logger -t "$NAME" "Unable to write to the remote NFS > directory $NFS. Cannot save core" > > > In debian/kdump-config.in line 782: > umount $KDUMP_COREDIR > ^------------^ SC2086 (info): Double quote to > prevent globbing and word splitting. > > Did you mean: > umount "$KDUMP_COREDIR" > > > In debian/kdump-config.in line 786: > logger -t $NAME "Unable to cleanly unmount the > NFS file system" > ^---^ SC2086 (info): Double quote > to prevent globbing and word splitting. > > Did you mean: > logger -t "$NAME" "Unable to cleanly unmount > the NFS file system" > > > In debian/kdump-config.in line 790: > logger -t $NAME "Dumping to NFS mountpoint > $NFS/$KDUMP_STAMP" > ^---^ SC2086 (info): Double quote to > prevent globbing and word splitting. > > Did you mean: > logger -t "$NAME" "Dumping to NFS mountpoint > $NFS/$KDUMP_STAMP" > > > In debian/kdump-config.in line 804: > logger -t $NAME "saved dmesg content in $KDUMP_STAMPDIR" > ^---^ SC2086 (info): Double quote to > prevent globbing and word splitting. > > Did you mean: > logger -t "$NAME" "saved dmesg content in > $KDUMP_STAMPDIR" > > > In debian/kdump-config.in line 808: > logger -t $NAME "failed to save dmesg content in > $KDUMP_STAMPDIR" > ^---^ SC2086 (info): Double quote to > prevent globbing and word splitting. > > Did you mean: > logger -t "$NAME" "failed to save dmesg content in > $KDUMP_STAMPDIR" > > > In debian/kdump-config.in line 818: > logger -t $NAME "makedumpfile failed, falling back to 'cp'" > ^---^ SC2086 (info): Double quote to prevent > globbing and word splitting. > > Did you mean: > logger -t "$NAME" "makedumpfile failed, falling back to 'cp'" > > > In debian/kdump-config.in line 829: > logger -t $NAME "saved vmcore in $KDUMP_STAMPDIR" > ^---^ SC2086 (info): Double quote to prevent > globbing and word splitting. > > Did you mean: > logger -t "$NAME" "saved vmcore in $KDUMP_STAMPDIR" > > > In debian/kdump-config.in line 833: > logger -t $NAME "failed to save vmcore in $KDUMP_STAMPDIR" > ^---^ SC2086 (info): Double quote to prevent > globbing and word splitting. > > Did you mean: > logger -t "$NAME" "failed to save vmcore in $KDUMP_STAMPDIR" > > > In debian/kdump-config.in line 837: > if [ -z "${NFS}" ] && [ $ERROR -eq 0 ] && [ $KDUMP_NUM_DUMPS -gt 0 ] ; > then > ^--------------^ SC2086 > (info): Double quote to prevent globbing and word splitting. > > Did you mean: > if [ -z "${NFS}" ] && [ $ERROR -eq 0 ] && [ "$KDUMP_NUM_DUMPS" -gt 0 ] > ; then > > > In debian/kdump-config.in line 838: > num_dumps=$(find $KDUMP_COREDIR -mindepth 1 -maxdepth 1 -name > '2*' | wc -l) > ^------------^ SC2086 (info): Double quote > to prevent globbing and word splitting. > > Did you mean: > num_dumps=$(find "$KDUMP_COREDIR" -mindepth 1 -maxdepth 1 -name > '2*' | wc -l) > > > In debian/kdump-config.in line 839: > if [ "$num_dumps" -gt $KDUMP_NUM_DUMPS ] ; then > ^--------------^ SC2086 (info): Double > quote to prevent globbing and word splitting. > > Did you mean: > if [ "$num_dumps" -gt "$KDUMP_NUM_DUMPS" ] ; then > > > In debian/kdump-config.in line 841: > purge_dir=$(find $KDUMP_COREDIR -mindepth 1 -maxdepth 1 > -name '2*' -print0 | sort -Vz | head -z -n $purge_num | tr "\\0" " ") > ^------------^ SC2086 (info): Double > quote to prevent globbing and word splitting. > > Did you mean: > purge_dir=$(find "$KDUMP_COREDIR" -mindepth 1 -maxdepth > 1 -name '2*' -print0 | sort -Vz | head -z -n $purge_num | tr "\\0" " ") > > > In debian/kdump-config.in line 843: > logger -t $NAME "Too many dumps, purging: $purge_dir" > ^---^ SC2086 (info): Double quote to > prevent globbing and word splitting. > > Did you mean: > logger -t "$NAME" "Too many dumps, purging: $purge_dir" > > > In debian/kdump-config.in line 844: > find $KDUMP_COREDIR -mindepth 1 -maxdepth 1 -name '2*' > -print0 | sort -Vz | head -z -n $purge_num | xargs -0 rm -rf > ^------------^ SC2086 (info): Double quote to > prevent globbing and word splitting. > > Did you mean: > find "$KDUMP_COREDIR" -mindepth 1 -maxdepth 1 -name > '2*' -print0 | sort -Vz | head -z -n $purge_num | xargs -0 rm -rf > > > In debian/kdump-config.in line 851: > umount $KDUMP_COREDIR > ^------------^ SC2086 (info): Double quote to prevent > globbing and word splitting. > > Did you mean: > umount "$KDUMP_COREDIR" > > > In debian/kdump-config.in line 855: > logger -t $NAME "Unable to cleanly unmount the NFS file > system" > ^---^ SC2086 (info): Double quote to > prevent globbing and word splitting. > > Did you mean: > logger -t "$NAME" "Unable to cleanly unmount the NFS > file system" > > > In debian/kdump-config.in line 903: > logger -t $NAME "saved dmesg content via FTP in > $FTP_REMOTE_HOST:$FTP_DMESGFILE" > ^---^ SC2086 (info): Double quote to > prevent globbing and word splitting. > > Did you mean: > logger -t "$NAME" "saved dmesg content via FTP in > $FTP_REMOTE_HOST:$FTP_DMESGFILE" > > > In debian/kdump-config.in line 906: > logger -t $NAME "failed to save dmesg content via FTP > in $FTP_REMOTE_HOST:$FTP_DMESGFILE" > ^---^ SC2086 (info): Double quote to > prevent globbing and word splitting. > > Did you mean: > logger -t "$NAME" "failed to save dmesg content via FTP > in $FTP_REMOTE_HOST:$FTP_DMESGFILE" > > > In debian/kdump-config.in line 918: > logger -t $NAME "failed to save vmcore via FTP in > $FTP_REMOTE_HOST:$FTP_COREFILE" > ^---^ SC2086 (info): Double quote to prevent > globbing and word splitting. > > Did you mean: > logger -t "$NAME" "failed to save vmcore via FTP in > $FTP_REMOTE_HOST:$FTP_COREFILE" > > > In debian/kdump-config.in line 921: > logger -t $NAME "saved vmcore via FTP in > $FTP_REMOTE_HOST:$FTP_COREFILE" > ^---^ SC2086 (info): Double quote to prevent > globbing and word splitting. > > Did you mean: > logger -t "$NAME" "saved vmcore via FTP in > $FTP_REMOTE_HOST:$FTP_COREFILE" > > > In debian/kdump-config.in line 941: > while [ $CNT -ne 0 ];do > ^--^ SC2086 (info): Double quote to prevent globbing and word > splitting. > > Did you mean: > while [ "$CNT" -ne 0 ];do > > > In debian/kdump-config.in line 942: > ssh -i $SSH_KEY "$SSH_REMOTE_HOST" mkdir -p "$SSH_STAMPDIR" > ^------^ SC2086 (info): Double quote to prevent > globbing and word splitting. > > Did you mean: > ssh -i "$SSH_KEY" "$SSH_REMOTE_HOST" mkdir -p "$SSH_STAMPDIR" > > > In debian/kdump-config.in line 953: > if [ $ERROR -ne 0 ]; then > ^----^ SC2086 (info): Double quote to prevent globbing and word > splitting. > > Did you mean: > if [ "$ERROR" -ne 0 ]; then > > > In debian/kdump-config.in line 955: > logger -t $NAME "Unable to reach remote server > $SSH_REMOTE_HOST; can't continue" > ^---^ SC2086 (info): Double quote to prevent > globbing and word splitting. > > Did you mean: > logger -t "$NAME" "Unable to reach remote server > $SSH_REMOTE_HOST; can't continue" > > > In debian/kdump-config.in line 964: > scp -i $SSH_KEY "$SSH_TMPDMESG" > "$SSH_REMOTE_HOST:$SSH_DMESGFILE" > ^------^ SC2086 (info): Double quote to > prevent globbing and word splitting. > > Did you mean: > scp -i "$SSH_KEY" "$SSH_TMPDMESG" > "$SSH_REMOTE_HOST:$SSH_DMESGFILE" > > > In debian/kdump-config.in line 971: > logger -t $NAME "saved dmesg content in > $SSH_REMOTE_HOST:$SSH_STAMPDIR" > ^---^ SC2086 (info): Double quote to > prevent globbing and word splitting. > > Did you mean: > logger -t "$NAME" "saved dmesg content in > $SSH_REMOTE_HOST:$SSH_STAMPDIR" > > > In debian/kdump-config.in line 974: > logger -t $NAME "failed to save dmesg content in > $SSH_REMOTE_HOST:$SSH_STAMPDIR" > ^---^ SC2086 (info): Double quote to > prevent globbing and word splitting. > > Did you mean: > logger -t "$NAME" "failed to save dmesg content in > $SSH_REMOTE_HOST:$SSH_STAMPDIR" > > > In debian/kdump-config.in line 984: > logger -t $NAME "makedumpfile failed, falling back to 'scp'" > ^---^ SC2086 (info): Double quote to prevent > globbing and word splitting. > > Did you mean: > logger -t "$NAME" "makedumpfile failed, falling back to 'scp'" > > > In debian/kdump-config.in line 988: > if ! scp -i $SSH_KEY $vmcore_file > "$SSH_REMOTE_HOST:$SSH_CORETEMP"; then > ^------^ SC2086 (info): Double quote to prevent > globbing and word splitting. > > Did you mean: > if ! scp -i "$SSH_KEY" $vmcore_file > "$SSH_REMOTE_HOST:$SSH_CORETEMP"; then > > > In debian/kdump-config.in line 990: > logger -t $NAME "makedumpfile scp failed. The vmcore > file will not be available" > ^---^ SC2086 (info): Double quote to > prevent globbing and word splitting. > > Did you mean: > logger -t "$NAME" "makedumpfile scp failed. The vmcore > file will not be available" > > > In debian/kdump-config.in line 1001: > logger -t $NAME "failed to save vmcore in > $SSH_REMOTE_HOST:$SSH_STAMPDIR" > ^---^ SC2086 (info): Double quote to prevent > globbing and word splitting. > > Did you mean: > logger -t "$NAME" "failed to save vmcore in > $SSH_REMOTE_HOST:$SSH_STAMPDIR" > > > In debian/kdump-config.in line 1003: > ssh -i $SSH_KEY "$SSH_REMOTE_HOST" mv "$SSH_CORETEMP" > "$SSH_COREFILE" > ^------^ SC2086 (info): Double quote to prevent > globbing and word splitting. > > Did you mean: > ssh -i "$SSH_KEY" "$SSH_REMOTE_HOST" mv "$SSH_CORETEMP" > "$SSH_COREFILE" > > > In debian/kdump-config.in line 1005: > logger -t $NAME "saved vmcore in $SSH_REMOTE_HOST:$SSH_STAMPDIR" > ^---^ SC2086 (info): Double quote to prevent > globbing and word splitting. > > Did you mean: > logger -t "$NAME" "saved vmcore in > $SSH_REMOTE_HOST:$SSH_STAMPDIR" > > > In debian/kdump-config.in line 1020: > logger -t $NAME "Remote ssh dump is not configured. No reason > to propagate" > ^---^ SC2086 (info): Double quote to prevent > globbing and word splitting. > > Did you mean: > logger -t "$NAME" "Remote ssh dump is not configured. No reason > to propagate" > > > In debian/kdump-config.in line 1029: > /usr/bin/ssh-keygen -t rsa -f $KDUMP_SSH_KEY -N "" >/dev/null > 2>&1 > ^------------^ SC2086 (info): > Double quote to prevent globbing and word splitting. > > Did you mean: > /usr/bin/ssh-keygen -t rsa -f "$KDUMP_SSH_KEY" -N "" >/dev/null > 2>&1 > > > In debian/kdump-config.in line 1035: > ssh-copy-id -i $KDUMP_SSH_KEY "$KDUMP_SSH_USER@$KDUMP_SSH_TARGET" > >/dev/null 2>&1 > ^------------^ SC2086 (info): Double quote to prevent > globbing and word splitting. > > Did you mean: > ssh-copy-id -i "$KDUMP_SSH_KEY" "$KDUMP_SSH_USER@$KDUMP_SSH_TARGET" > >/dev/null 2>&1 > > > In debian/kdump-config.in line 1040: > logger -t $NAME "$KDUMP_SSH_KEY failed to be sent to > $KDUMP_REMOTE_HOST" > ^---^ SC2086 (info): Double quote to prevent > globbing and word splitting. > > Did you mean: > logger -t "$NAME" "$KDUMP_SSH_KEY failed to be sent to > $KDUMP_REMOTE_HOST" > > > In debian/kdump-config.in line 1043: > logger -t $NAME "propagated ssh key $KDUMP_SSH_KEY to server > $KDUMP_REMOTE_HOST" > ^---^ SC2086 (info): Double quote to prevent > globbing and word splitting. > > Did you mean: > logger -t "$NAME" "propagated ssh key $KDUMP_SSH_KEY to server > $KDUMP_REMOTE_HOST" > > > In debian/kdump-config.in line 1138: > condreload 9>$lock_file > ^--------^ SC2086 (info): Double quote to prevent > globbing and word splitting. > > Did you mean: > condreload 9>"$lock_file" > > For more information: > https://www.shellcheck.net/wiki/SC2086 -- Double quote to prevent globbing > ... > make[1]: *** [debian/rules:64: override_dh_auto_test] Error 1 The full build log is available from: http://qa-logs.debian.net/2023/01/01/kdump-tools_1.8_unstable.log All bugs filed during this archive rebuild are listed at: https://bugs.debian.org/cgi-bin/pkgreport.cgi?tag=ftbfs-20230101;users=lu...@debian.org or: https://udd.debian.org/bugs/?release=na&merged=ign&fnewerval=7&flastmodval=7&fusertag=only&fusertagtag=ftbfs-20230101&fusertaguser=lu...@debian.org&allbugs=1&cseverity=1&ctags=1&caffected=1#results A list of current common problems and possible solutions is available at http://wiki.debian.org/qa.debian.org/FTBFS . You're welcome to contribute! If you reassign this bug to another package, please mark it as 'affects'-ing this package. See https://www.debian.org/Bugs/server-control#affects If you fail to reproduce this, please provide a build log and diff it with mine so that we can identify if something relevant changed in the meantime.