Bug#1033913: partman-auto-lvm: Broken "Guided - use entire disk and set up LVM" in UEFI mode

2023-04-10 Thread Steve McIntyre
I've just pushed an update to the code here... On Mon, Apr 10, 2023 at 05:45:15PM +0200, Pascal Hambourg wrote: >On 10/04/2023 at 15:13, Steve McIntyre wrote: >> >> Overall comment: I'm not trying to make the heuristics 100% reliable >> here, as I don't think that's actually possible. Instead,

Bug#1033913: partman-auto-lvm: Broken "Guided - use entire disk and set up LVM" in UEFI mode

2023-04-10 Thread Pascal Hambourg
On 10/04/2023 at 15:13, Steve McIntyre wrote: Overall comment: I'm not trying to make the heuristics 100% reliable here, as I don't think that's actually possible. Instead, I'm trying to tread the fine line of: * minimising false negatives - let's try to pick up on the most common cases

Bug#1033913: partman-auto-lvm: Broken "Guided - use entire disk and set up LVM" in UEFI mode

2023-04-10 Thread Steve McIntyre
Hey Pascal, and thanks for the review! Overall comment: I'm not trying to make the heuristics 100% reliable here, as I don't think that's actually possible. Instead, I'm trying to tread the fine line of: * minimising false negatives - let's try to pick up on the most common cases where

Bug#1033913: partman-auto-lvm: Broken "Guided - use entire disk and set up LVM" in UEFI mode

2023-04-10 Thread Pascal Hambourg
partman-efi "Fix detection of BIOS-bootable systems" provides a significant improvement over previous behaviour. However I have a few comments. 1a) The patch assumes that a GPT disk may be BIOS-bootable only if it has a BIOS boot partition. But a GPT disk can be BIOS-bootable even without a

Bug#1033913: partman-auto-lvm: Broken "Guided - use entire disk and set up LVM" in UEFI mode

2023-04-03 Thread Pascal Hambourg
Hello, On 03/04/2023 at 21:50, Cyril Brulebois wrote: - It very much looks like the intermediary states are slightly different when setting up LVM and when setting up encrypted LVM, and the LVM case case leads to some confusion in partman-efi's /lib/partman/init.d/50efi (which

Bug#1033913: partman-auto-lvm: Broken "Guided - use entire disk and set up LVM" in UEFI mode

2023-04-03 Thread Cyril Brulebois
Package: partman-auto-lvm Version: 87 Severity: serious Justification: Maintainer says so TL;DR: Answering “Yes” to the “Force UEFI installation?” makes sure the installer pulls the right bootloader packages, despite misreading the situation. I've discovered this while testing D-I Bookworm RC 1