Your message dated Sun, 07 Apr 2024 19:51:52 +0000
with message-id <e1rtyys-008qyv...@fasolo.debian.org>
and subject line Bug#1041519: fixed in transmission 4.0.5-2
has caused the Debian Bug report #1041519,
regarding transmission: contains prebuilt javascript without source
to be marked as done.

This means that you claim that the problem has been dealt with.
If this is not the case it is now your responsibility to reopen the
Bug report if necessary, and/or fix the problem forthwith.

(NB: If you are a system administrator and have no idea what this
message is talking about, this may indicate a serious mail system
misconfiguration somewhere. Please contact ow...@bugs.debian.org
immediately.)


-- 
1041519: https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=1041519
Debian Bug Tracking System
Contact ow...@bugs.debian.org with problems
--- Begin Message ---
Source: transmission
Version: 4.0.1-1
Severity: serious
Justification: Policy 2.2.1

Hi,

The source package contains:

web/public_html/index.html
web/public_html/transmission-app.js

These files are copied into the binary package as:

/usr/share/transmission/public_html/index.html
/usr/share/transmission/public_html/transmission-app.js

Those files should be built from source with no network connection.

The corresponding lintian overrides are wrong: the files are not generated
during build.

    # these are generated from web/src/*
    transmission source: source-is-missing [web/public_html/index.html]
    transmission source: source-is-missing [web/public_html/transmission-app.js]

The sad way to solve this would be to remove the webui (and I'm a user!).

The better way to solve this would be to build and would begin like the 
following
but requires packaging some of the below npm deps. I can help and would 
appreciate
some guidance or pointers to good examples of source packages that have solved
this problem.

--- a/debian/control
+++ b/debian/control
@@ -21,7 +21,9 @@ Build-Depends: cmake,
                qttools5-dev-tools,
                qttools5-dev,
                libqt5svg5-dev,
-               zlib1g-dev
+               zlib1g-dev,
+               node-webpack,
+               node-mini-css-extract-plugin
 Standards-Version: 4.6.2
 Rules-Requires-Root: no
 Vcs-Browser: https://salsa.debian.org/debian/transmission
diff --git a/debian/rules b/debian/rules
index 09fe4f7d..bfed98c1 100755
--- a/debian/rules
+++ b/debian/rules
@@ -2,12 +2,13 @@

 #export DH_VERBOSE=1
 export DEB_BUILD_MAINT_OPTIONS = hardening=+all
+export NPM_CONFIG_OFFLINE=true

 %:
        dh $@

 override_dh_auto_configure:
-       dh_auto_configure -- -DENABLE_GTK=ON -DENABLE_QT=ON -DENABLE_CLI=ON 
-DINSTALL_LIB=OFF -DCMAKE_BUILD_TYPE=RelWithDebInfo
+       dh_auto_configure -- -DENABLE_GTK=ON -DENABLE_QT=ON -DENABLE_CLI=ON 
-DINSTALL_LIB=OFF -DREBUILD_WEB=ON -DCMAKE_BUILD_TYPE=RelWithDebInfo

 override_dh_auto_test:
        @echo "skipping auto test"

Thanks,

Alex

--
transmission.git/web$ npm2deb depends package.json

Dependencies:                                                                   
               NPM                                               Debian
transmission-web (FIX_ME version)                 None
└─ lodash.isequal (^4.5.0)                        node-lodash 
(4.17.21+dfsg+~cs8.31.198.20210220-9)

Build dependencies:
NPM                                               Debian
@babel/core (^7.20.12)                            node-babel 
(6.26.0+repack-3~bpo10+1)         @babel/eslint-parser (^7.19.1)                
    None
@babel/plugin-proposal-class-properties (^7.18.6) None
@primer/stylelint-config (^12.7.0)                None
css-loader (^6.7.3)                               node-css-loader 
(6.7.2+~cs14.0.11-1)         css-minimizer-webpack-plugin (^4.2.2)             
None
eslint (^8.32.0)                                  None
eslint-plugin-sonarjs (^0.18.0)                   None
eslint-plugin-unicorn (^45.0.2)                   None
file-loader (^6.2.0)                              node-file-loader (6.2.0-3)    
               mini-css-extract-plugin (^2.7.2)                  
node-mini-css-extract-plugin (2.4.6+~2.4.0-4)npm-run-all (^4.1.5)               
               None
prettier (^2.8.3)                                 None                          
               sass (^1.57.1)                                    None
sass-loader (^13.2.0)                             None
style-loader (^3.3.1)                             node-style-loader (3.3.1-2)   
               stylelint (^14.16.1)                              None
stylelint-config-prettier (^9.0.4)                None
stylelint-config-sass-guidelines (^9.0.1)         None
stylelint-config-standard (^29.0.0)               None
terser-webpack-plugin (^5.3.6)                    None
webpack (^5.76.0)                                 node-webpack 
(5.76.1+dfsg1+~cs17.16.16-1)    webpack-bundle-analyzer (^4.7.0)                
  None
webpack-cli (^4.10.0)                             None
webpack-dev-server (^4.11.1)                      None

Warnings occurred:
 [warning] prettier: Useless in Debian compilation, see node-jest for an example


-- System Information:
Debian Release: trixie/sid
  APT prefers unstable
  APT policy: (500, 'unstable')
Architecture: amd64 (x86_64)

Kernel: Linux 6.1.0-10-amd64 (SMP w/4 CPU threads; PREEMPT)
Locale: LANG=fr_FR.utf8, LC_CTYPE=fr_FR.utf8 (charmap=UTF-8), LANGUAGE not set
Shell: /bin/sh linked to /usr/bin/dash
Init: systemd (via /run/systemd/system)

--- End Message ---
--- Begin Message ---
Source: transmission
Source-Version: 4.0.5-2
Done: Alexandre Rossi <n...@zincube.net>

We believe that the bug you reported is fixed in the latest version of
transmission, which is due to be installed in the Debian FTP archive.

A summary of the changes between this version and the previous one is
attached.

Thank you for reporting the bug, which will now be closed.  If you
have further comments please address them to 1041...@bugs.debian.org,
and the maintainer will reopen the bug report if appropriate.

Debian distribution maintenance software
pp.
Alexandre Rossi <n...@zincube.net> (supplier of updated transmission package)

(This message was generated automatically at their request; if you
believe that there is a problem with it please contact the archive
administrators by mailing ftpmas...@ftp-master.debian.org)


-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA512

Format: 1.8
Date: Sun, 07 Apr 2024 11:05:16 +0200
Source: transmission
Architecture: source
Version: 4.0.5-2
Distribution: unstable
Urgency: medium
Maintainer: Leo Antunes <cost...@debian.org>
Changed-By: Alexandre Rossi <n...@zincube.net>
Closes: 1041519 1067625
Changes:
 transmission (4.0.5-2) unstable; urgency=medium
 .
   [ Sandro Tosi ]
   * remove myself from this package maintainership
 .
   [ Barak A. Pearlmutter ]
   * Revert to installing man pages using using dh_installmanpages
   * Lintian overrides for Folx
   * Quilt patch for systemd unit file documentation key
   * Quilt patch: disable build-time install of indentation git commit hook
   * Add debian/rules stanza for arch-dependent -latomic (closes: #1067625)
   * Add suggestion pointers to various GUI remotes for controlling the daemon
 .
   [ Alexandre Rossi ]
   * build webapp from source (Closes: #1041519)
   * fix build on bookworm
   * declare compliance to standards 4.7.0 (no change)
   * add some help to the maintenance team
   * fix d/control syntax
Checksums-Sha1:
 035bbd0bb4315d1d2d1fbfa0e817f21bc04bcb5c 2689 transmission_4.0.5-2.dsc
 020e1908f6ece4c0138ecf52da086b6e30e62711 20804 
transmission_4.0.5-2.debian.tar.xz
Checksums-Sha256:
 94a9531cc2664462df52340a7b67c2cce9c4f1f6006156623becdf02fedfc560 2689 
transmission_4.0.5-2.dsc
 f04cc00ec39fd4e31008e134907061b1527a38eebaf65c8a702618c68413b5be 20804 
transmission_4.0.5-2.debian.tar.xz
Files:
 3db9d9b1b74d50d0add393c3380699e3 2689 net optional transmission_4.0.5-2.dsc
 732b916c1e16c69dcd50f7231e9884e1 20804 net optional 
transmission_4.0.5-2.debian.tar.xz

-----BEGIN PGP SIGNATURE-----

iQJDBAEBCgAtFiEEZaEt9P4xrWusTXauM1X01jtYIcwFAmYS5EUPHGJhcnRtQGtu
YXJzLmJlAAoJEDNV9NY7WCHM11QP/iY7NBkL8S7WGrqv1mjgX4267hS8dy6bsFIw
Z5I3zT/LVKE05TS7/U4+up3VrMwqBb+Qw0gKruizdalhf9lWvtBpMUFQH/g6uc1g
cf4wbFStH1I3jprSaT3hkXRrhM6aEGgGBaIng5iz5eTG9uI6YczuOBHSbz4uhlk0
/vSDXMu6cKsHdy+r1wQr++LtVSjNTlxCODjsa3NTyelhZfTTy7LjRlvFs25ybqhh
dzATEHm1hdUWFFPouzKQsMUPL+uY3ZKdH7IItvjkg0ncpx0fPe3GxWsg4fj3ElH5
zrhVkQ2JeOVmo7r3t0607/bo5QV/M9PuBD9Yi8l8y/K9HZCCZiX+YayEnLbUnIIO
G3SnPBlWvysoslJRqxyGmrJStqmmq0ijtUROGiMBhBeLK8aC2DSXSnWjVYCKlQCm
E1reJ6svMQ4MjizlCU/tf/QfgCqf/j7lgrHADf6B8lVHtBOxwxjHJ2SoY4nJMNsd
MJh5mLA4nFMeixRra1TQTdgjhV1lP/vE+m+bSKgIN6BW5i2+WM/2QrIgCO1KT4KQ
pk6DNbe0cgv22pYKzJEcG6857KpKnWz22v5Zfam/by+6Z992/gKdia0KxxFHcFed
b0pevRjvRdJ6uTSiiNVvouhOLWpz/YjnLwrXhqSIyIPhGNNhmv2UXMyLwNwPJBGJ
TVq/QwrN
=suNl
-----END PGP SIGNATURE-----

Attachment: pgp6o2o5iXrRv.pgp
Description: PGP signature


--- End Message ---

Reply via email to