Package: lastfmsubmitd
Version: 0.35-3
Severity: grave
Tags: patch

Hello... again. O:-)

The sync() method of Spool does not honour the configured spool_path.
This causes data loss when the daemon exits but there are pending
submissions on the queue. Please find a (tested) trivial patch below,
though I'd recommend doing something involving a try block, possibly
calling lastfm.submit() *before* calling unlink().

Cheers,

--- lastfmsubmitd~
+++ lastfmsubmitd
@@ -111,7 +111,7 @@
         for f in self.files:
             os.unlink(f)
         if self.subs:
-            newfile = lastfm.submit(self.subs)
+            newfile = lastfm.submit(self.subs, self.spool_path)
             self.files = [newfile]
         else:
             self.files = []

-- 
Adeodato Simó                                     dato at net.com.org.es
Debian Developer                                  adeodato at debian.org
 
If there is a sin against life, it consists perhaps not so much in
despairing of life as in hoping for another life and in eluding the
implacable grandeur of this life.
                -- Albert Camus


Reply via email to