Package: afbinit
Severity: serious
Tags: patch

Hello,

Afbinit installation fails when installing for the first time. The main problem is that firmware miss is fatal, but I guess we should be able to install the package first, then read README.Debian to figure out how to get the firmware. Here is a small patch against current sid package that do not fail if the firmware is not present, check if it's the right one (md5) and a minor README.Debian with more informations about how to grab the microcode.

Thanks in advance,

Best regards, Adam.



--- System information. ---
Architecture: amd64
Kernel: Linux 2.6.22-2-amd64

Debian Release: lenny/sid
900 testing debmirror
500 ubuntu-doko people.ubuntu.com
500 testing www.debian-multimedia.org
400 unstable debmirror

--- Package information. ---
Depends (Version) | Installed
=======================-+-===========
|

diff -Nur afbinit-1.0/debian/afbinit.init afbinit-1.0.new/debian/afbinit.init
--- afbinit-1.0/debian/afbinit.init	2008-02-16 16:52:01.000000000 +0100
+++ afbinit-1.0.new/debian/afbinit.init	2008-02-16 16:49:05.043692598 +0100
@@ -32,7 +32,12 @@
 fi
 if [ ! -f /usr/lib/afb.ucode ];then
     log_failure_msg "Cannot find AFB microcode (/usr/lib/afb.ucode)"
-    exit 1
+    log_failure_msg "Please read /usr/share/doc/afbinit/README.Debian to see how to obtain it"
+    exit 0
+elif [ `md5sum /usr/lib/afb.ucode | cut -f1 -d' '` != '7cb8dda314278b3cae28da150a53973b' ]; then
+    log_failure_msg "AFB microcode (/usr/lib/afb.ucode) seems to be corrupted"
+    log_failure_msg "Its md5 should be 7cb8dda314278b3cae28da150a53973b"
+    exit 0
 fi
 
 case "$1" in
diff -Nur afbinit-1.0/debian/changelog afbinit-1.0.new/debian/changelog
--- afbinit-1.0/debian/changelog	2008-02-16 16:52:01.000000000 +0100
+++ afbinit-1.0.new/debian/changelog	2008-02-16 16:51:41.172589881 +0100
@@ -1,3 +1,12 @@
+afbinit (1.0-4) unstable; urgency=low
+
+  * Improve README.Debian with the right way to get microcode.
+  * Check md5sum of the microcode before trying to load it.
+  * Do not fail if microcode is corrupted or unavailable.
+  * Thanks to Adam Cécile for his suggestions.
+
+ -- Emanuele Rocca <[EMAIL PROTECTED]>  Sat, 16 Feb 2008 16:49:12 +0100
+
 afbinit (1.0-3) unstable; urgency=low
 
   * Add missing includes (Closes: #451635)
diff -Nur afbinit-1.0/debian/README.Debian afbinit-1.0.new/debian/README.Debian
--- afbinit-1.0/debian/README.Debian	2008-02-16 16:52:01.000000000 +0100
+++ afbinit-1.0.new/debian/README.Debian	2008-02-16 16:13:40.010593866 +0100
@@ -2,8 +2,11 @@
 ------------------
 
 This package requires the AFB microcode, which can be obtained from
-several places. One way is via a Solaris package. You may also find it on
-Sun's website (I found it by doing a search on Google).
+several places. The easiest way to have it is to grab a Solaris patch from
+Sun's website:
+
+Go to http://sunsolve.sun.com/ and search for patch number #108604.
+Download it. Once it's done, unzip the file.
 
 NOTE: The microcode is proprietary and NOT FREE. As in not free speech.
 

Reply via email to